FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

check for unused variables

This commit is contained in:
Matthew Kennedy 2023-11-03 15:00:44 -07:00
parent 3ef4d7c40e
commit 61900c0f18
6 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/config/engines/honda_k_dbc.cpp
View File

@ -66,9 +66,6 @@ void setProteusHondaElement2003() {
strcpy(engineConfiguration->vehicleName, "test");
gppwm_channel *vtsControl = &engineConfiguration->gppwm[0];
#if HW_PROTEUS & EFI_PROD_CODE
// engineConfiguration->triggerInputPins[0] = PROTEUS_DIGITAL_2; // crank
// engineConfiguration->camInputs[0] = PROTEUS_DIGITAL_4; // intake
@ -85,6 +82,7 @@ void setProteusHondaElement2003() {
engineConfiguration->injectionPins[2] = PROTEUS_LS_6;
engineConfiguration->injectionPins[3] = PROTEUS_LS_5;
gppwm_channel *vtsControl = &engineConfiguration->gppwm[0];
vtsControl->pin = PROTEUS_HS_1;
engineConfiguration->vvtPins[0] = PROTEUS_HS_2;

2
firmware/controllers/actuators/idle_thread.cpp
View File

@ -316,8 +316,6 @@ float IdleController::getIdlePosition(float rpm) {
auto phase = determinePhase(rpm, targetRpm, tps, vehicleSpeed, crankingTaper);
m_lastPhase = phase;
bool isAutomaticIdle = tps.Valid && engineConfiguration->idleMode == IM_AUTO;
finishIdleTestIfNeeded();
undoIdleBlipIfNeeded();

2
firmware/controllers/sensors/hella_oil_level.cpp
View File

@ -88,7 +88,7 @@ void HellaOilLevelSensor::onEdge(efitick_t nowNt, bool value) {
// Defective
// invalidate(UnexpectedCode::High);
} else {
float tempC = interpolateClamped(23, -40, 87, 160, lastPulseMs);
// float tempC = interpolateClamped(23, -40, 87, 160, lastPulseMs);
// setValidValue(tempC, nowNt);
}
} else if (m_nextPulse == NextPulse::Level) {

5
firmware/controllers/tcu/tc_4l6x.cpp
View File

@ -153,11 +153,12 @@ void Gm4l6xTransmissionController::set32State(gear_e gear) {
if (!vss.Valid) {
return;
}
uint8_t (*pcts)[sizeof(config->tcu_32SpeedBins)/sizeof(config->tcu_32SpeedBins[0])];
// TODO: looks unfinished?
// uint8_t (*pcts)[sizeof(config->tcu_32SpeedBins)/sizeof(config->tcu_32SpeedBins[0])];
int pct = interpolate2d(vss.Value, config->tcu_32SpeedBins, config->tcu_32Vals);
shift32Pwm.setSimplePwmDutyCycle(pct*0.01);
} else {
shift32Pwm.setSimplePwmDutyCycle(0);
shift32Pwm.setSimplePwmDutyCycle(0);
}
}

1
firmware/hw_layer/microsecond_timer/microsecond_timer.cpp
View File

@ -137,7 +137,6 @@ static void watchDogBuddyCallback(void*) {
static volatile bool testSchedulingHappened = false;
static Timer testScheduling;
static efitimems_t testSchedulingStart;
static void timerValidationCallback(void*) {
testSchedulingHappened = true;

1
firmware/rusefi_rules.mk
View File

@ -4,7 +4,6 @@ RUSEFI_CPPOPT = -Werror=shadow
# ...except these few
RUSEFI_OPT += -Wno-error=unused-function
RUSEFI_OPT += -Wno-error=unused-variable
RUSEFI_OPT += -Wno-error=sign-compare
RUSEFI_OPT += -Wno-error=unused-parameter
RUSEFI_OPT += -Wno-error=undef