From 7bc59adb839022ecf6cc58661ed34727386dcd2b Mon Sep 17 00:00:00 2001 From: rusefillc <48498823+rusefillc@users.noreply.github.com> Date: Mon, 25 Dec 2023 20:50:47 -0500 Subject: [PATCH] ETB calibration compatibility notes from 2022 (#320) Co-authored-by: rusefillc --- .../controllers/actuators/electronic_throttle.cpp | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index 37d50de95e..ddfacf4f5f 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -323,21 +323,11 @@ expected EtbController::getSetpointEtb() { } float minPosition = engineConfiguration->etbMinimumPosition; - if (minPosition < 0.01) { - // compatibility with legacy tunes, todo: remove in Nov of 2022 - minPosition = 1; - } // Keep the throttle just barely off the lower stop, and less than the user-configured maximum float maxPosition = engineConfiguration->etbMaximumPosition; - - if (maxPosition < 70) { - // compatibility with legacy tunes, todo: remove in Aug of 2022 - maxPosition = 100; - } else { - // Don't allow max position over 100 - maxPosition = minF(maxPosition, 100); - } + // Don't allow max position over 100 + maxPosition = minF(maxPosition, 100); targetPosition = clampF(minPosition, targetPosition, maxPosition); etbCurrentAdjustedTarget = targetPosition;