FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use onConfigurationChange instead of version holder

This commit is contained in:
Matthew Kennedy 2023-09-26 17:49:33 -07:00
parent effc8caa0b
commit a0d64ea0ad
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
firmware/controllers/actuators/vvt.cpp
View File

@ -38,11 +38,13 @@ void VvtController::onFastCallback() {
return;
}
if (engine->auxParametersVersion.isOld(engine->getGlobalConfigurationVersion())) {
update();
}
void VvtController::onConfigurationChange(engine_configuration_s const * previousConfig) {
if (!m_pid.isSame(&previousConfig->auxPid[index])) {
m_pid.reset();
}
update();
}
expected<angle_t> VvtController::observePlant() const {

1
firmware/controllers/actuators/vvt.h
View File

@ -27,6 +27,7 @@ public:
// EngineModule implementation
void onFastCallback() override;
void onConfigurationChange(engine_configuration_s const * previousConfig) override;
// ClosedLoopController implementation
expected<angle_t> observePlant() const override;

1
firmware/controllers/algo/engine.h
View File

@ -209,7 +209,6 @@ public:
void setConfig();
LocalVersionHolder versionForConfigurationListeners;
LocalVersionHolder auxParametersVersion;
AuxActor auxValves[AUX_DIGITAL_VALVE_COUNT][2];