From bb5500dbb3d5c17a5271aa4a1e29440006e3c828 Mon Sep 17 00:00:00 2001 From: Andrey Date: Fri, 25 Jun 2021 13:19:16 -0400 Subject: [PATCH] Trigger: warning code on normal engine start up #669 better TDC unit test approach? --- firmware/controllers/trigger/trigger_simulator.cpp | 2 -- firmware/controllers/trigger/trigger_simulator.h | 2 ++ unit_tests/tests/trigger/test_miata_na_tdc.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/firmware/controllers/trigger/trigger_simulator.cpp b/firmware/controllers/trigger/trigger_simulator.cpp index d35058c9f7..f6342990ad 100644 --- a/firmware/controllers/trigger/trigger_simulator.cpp +++ b/firmware/controllers/trigger/trigger_simulator.cpp @@ -10,8 +10,6 @@ #include "trigger_simulator.h" #include "trigger_emulator_algo.h" -#define SIMULATION_CYCLE_PERIOD 720000 - EXTERN_ENGINE; #if EFI_UNIT_TEST diff --git a/firmware/controllers/trigger/trigger_simulator.h b/firmware/controllers/trigger/trigger_simulator.h index 6833d123d8..14db33cdcf 100644 --- a/firmware/controllers/trigger/trigger_simulator.h +++ b/firmware/controllers/trigger/trigger_simulator.h @@ -8,6 +8,8 @@ #pragma once +#define SIMULATION_CYCLE_PERIOD 720000 + #include "trigger_decoder.h" int getSimulatedEventTime(const TriggerWaveform& shape, int i); diff --git a/unit_tests/tests/trigger/test_miata_na_tdc.cpp b/unit_tests/tests/trigger/test_miata_na_tdc.cpp index 1ec96e6826..19b5287e85 100644 --- a/unit_tests/tests/trigger/test_miata_na_tdc.cpp +++ b/unit_tests/tests/trigger/test_miata_na_tdc.cpp @@ -26,6 +26,6 @@ TEST(miata, miata_na_tdc) { } ASSERT_EQ(167, GET_RPM()) << "miata_na_tdc RPM"; - ASSERT_EQ(3894000, engine->tdcScheduler[0].momentX); // let's assert TDC position and sync point - ASSERT_EQ(4614000, engine->tdcScheduler[1].momentX); // let's assert TDC position and sync point + ASSERT_EQ(294000, engine->tdcScheduler[0].momentX % SIMULATION_CYCLE_PERIOD); // let's assert TDC position and sync point + ASSERT_EQ(294000, engine->tdcScheduler[1].momentX % SIMULATION_CYCLE_PERIOD); // let's assert TDC position and sync point }