diff --git a/firmware/controllers/actuators/gppwm/gppwm_channel.h b/firmware/controllers/actuators/gppwm/gppwm_channel.h index 19ee7a62be..597015dd61 100644 --- a/firmware/controllers/actuators/gppwm/gppwm_channel.h +++ b/firmware/controllers/actuators/gppwm/gppwm_channel.h @@ -12,11 +12,11 @@ public: void init(bool usePwm, SimplePwm* pwm, OutputPin* outputPin, const ValueProvider3D* table, const gppwm_channel* config); void update(); - -private: float getOutput() const; void setOutput(float result); +private: + // Store the current state so we can apply hysteresis bool m_state = false; diff --git a/firmware/controllers/sensors/converters/thermistor_func.h b/firmware/controllers/sensors/converters/thermistor_func.h index 416ae9c751..5e1a62972f 100644 --- a/firmware/controllers/sensors/converters/thermistor_func.h +++ b/firmware/controllers/sensors/converters/thermistor_func.h @@ -18,7 +18,6 @@ public: void showInfo(Logging* logger, float testRawValue) const override; -private: // Steinhart-Hart coefficients float m_a = 0; float m_b = 0; diff --git a/unit_tests/unit_test_framework.h b/unit_tests/unit_test_framework.h index fea8f1ce38..fbf6d5b7c4 100644 --- a/unit_tests/unit_test_framework.h +++ b/unit_tests/unit_test_framework.h @@ -13,7 +13,8 @@ using ::testing::Return; // This lets us inspect private state from unit tests -#define private public +// cool hack but probably should not be used, even conditional private/public compilation is more obvious +//#define private public /** * These are usually used with ASSETR_NEAR(val1, val2, abs_error)