From c433c20a3601bcf4840b0289f7ae0bdcab3d9a5c Mon Sep 17 00:00:00 2001 From: Andrey Date: Wed, 21 Jul 2021 17:45:35 -0400 Subject: [PATCH] simplify quad vvt test #3018 better parameter name and explicit constraint clarification --- firmware/controllers/trigger/trigger_decoder.cpp | 5 +++-- firmware/controllers/trigger/trigger_decoder.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/firmware/controllers/trigger/trigger_decoder.cpp b/firmware/controllers/trigger/trigger_decoder.cpp index db81ecf7c0..f628e1a6a3 100644 --- a/firmware/controllers/trigger/trigger_decoder.cpp +++ b/firmware/controllers/trigger/trigger_decoder.cpp @@ -376,9 +376,10 @@ void TriggerCentral::validateCamVvtCounters() { } } -bool TriggerState::syncSymmetricalCrank(int mod, int remainder) { +bool TriggerState::syncSymmetricalCrank(int divider, int remainder) { + efiAssert(OBD_PCM_Processor_Fault, remainder < divider, "syncSymmetricalCrank", false); bool isSync = false; - while (getTotalRevolutionCounter() % mod != remainder) { + while (getTotalRevolutionCounter() % divider != remainder) { /** * we are here if we've detected the cam sensor within the wrong crank phase * let's increase the trigger event counter, that would adjust the state of diff --git a/firmware/controllers/trigger/trigger_decoder.h b/firmware/controllers/trigger/trigger_decoder.h index 7019caa185..a05feccaa7 100644 --- a/firmware/controllers/trigger/trigger_decoder.h +++ b/firmware/controllers/trigger/trigger_decoder.h @@ -90,7 +90,7 @@ public: * this is important for crank-based virtual trigger and VVT magic */ void incrementTotalEventCounter(); - bool syncSymmetricalCrank(int mod, int remainder); + bool syncSymmetricalCrank(int divider, int remainder); efitime_t getTotalEventCounter() const;