From c53433801cfc2d3c629e8ea98bce5f669f906f53 Mon Sep 17 00:00:00 2001
From: rusefi <rusefillc@gmail.com>
Date: Sat, 13 Apr 2019 10:59:29 -0400
Subject: [PATCH] 'pins' fix

---
 firmware/hw_layer/pin_repository.cpp | 12 +++++-------
 firmware/util/loggingcentral.cpp     |  4 ++++
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/firmware/hw_layer/pin_repository.cpp b/firmware/hw_layer/pin_repository.cpp
index e4a41a8d5b..3f37582328 100644
--- a/firmware/hw_layer/pin_repository.cpp
+++ b/firmware/hw_layer/pin_repository.cpp
@@ -112,9 +112,7 @@ static int getPortIndex(ioportid_t port) {
 }
 
 static void reportPins(void) {
-	unsigned int i;
-
-	for (i = 0; i < PIN_REPO_SIZE; i++) {
+	for (unsigned int i = 0; i < PIN_REPO_SIZE; i++) {
 		const char *pin_user = PIN_USED[i];
 
 		/* show used pins */
@@ -123,12 +121,12 @@ static void reportPins(void) {
 			int pin = i % PORT_SIZE;
 			ioportid_t port = ports[portIndex];
 
-			scheduleMsg(&logger, "pin %s%d: %s\n", portname(port), pin, pin_user);
+			scheduleMsg(&logger, "pin %s%d: %s", portname(port), pin, pin_user);
 		}
 	}
 
 	#if (BOARD_EXT_GPIOCHIPS > 0)
-		for (i = PIN_REPO_SIZE ; i < PIN_REPO_SIZE + BOARD_EXT_PINREPOPINS /* gpiochips_get_total_pins()*/ ; i++) {
+		for (unsigned int i = PIN_REPO_SIZE ; i < PIN_REPO_SIZE + BOARD_EXT_PINREPOPINS /* gpiochips_get_total_pins()*/ ; i++) {
 			const char *pin_name;
 			const char *pin_user;
 			brain_pin_e brainPin = index_to_brainPin(i);
@@ -138,10 +136,10 @@ static void reportPins(void) {
 
 			/* here show all pins, unused too */
 			if (pin_name != NULL) {
-				scheduleMsg(&logger, "ext %s: %s\n",
+				scheduleMsg(&logger, "ext %s: %s",
 					pin_name, pin_user ? pin_user : "free");
 			} else {
-				scheduleMsg(&logger, "ext %s.%d: %s\n",
+				scheduleMsg(&logger, "ext %s.%d: %s",
 					gpiochips_getChipName(brainPin), gpiochips_getPinOffset(brainPin), pin_user ? pin_user : "free");
 			}
 		}
diff --git a/firmware/util/loggingcentral.cpp b/firmware/util/loggingcentral.cpp
index 38de539e81..76284a8077 100644
--- a/firmware/util/loggingcentral.cpp
+++ b/firmware/util/loggingcentral.cpp
@@ -121,6 +121,10 @@ void initLoggingCentral(void) {
  * in order to reduce memory usage
  */
 void scheduleMsg(Logging *logging, const char *fmt, ...) {
+	for (unsigned int i = 0;i<strlen(fmt);i++) {
+		// todo: open question which layer would not handle CR/LF propertly?
+		efiAssertVoid(OBD_PCM_Processor_Fault, fmt[i] != '\n', "No CRLF please");
+	}
 #if EFI_TEXT_LOGGING
 	if (logging == NULL) {
 		warning(CUSTOM_ERR_LOGGING_NULL, "logging NULL");