From c78ea7da6ca08d51cfdb71ad2b87c31e7b7a46d1 Mon Sep 17 00:00:00 2001 From: rusefi Date: Wed, 12 Feb 2020 17:19:58 -0500 Subject: [PATCH] tle8888 refactoring already - extracting method --- firmware/hw_layer/drivers/gpio/tle8888.h | 2 ++ firmware/hw_layer/pin_repository.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/firmware/hw_layer/drivers/gpio/tle8888.h b/firmware/hw_layer/drivers/gpio/tle8888.h index 4c06013b54..5595f5a3dd 100644 --- a/firmware/hw_layer/drivers/gpio/tle8888.h +++ b/firmware/hw_layer/drivers/gpio/tle8888.h @@ -25,6 +25,8 @@ // we can change this value on TLE8888QK but we probably do not have a reason to change #define Window_watchdog_close_window_time_ms 100.8 +#define getRegisterFromResponse(x) (x >> 1) & 0x7f + // unchangeable value for TLE8888QK // unused for now //#define Window_watchdog_open_window_time_ms 12.8 diff --git a/firmware/hw_layer/pin_repository.cpp b/firmware/hw_layer/pin_repository.cpp index 52fb026ebd..cf295f9fd7 100644 --- a/firmware/hw_layer/pin_repository.cpp +++ b/firmware/hw_layer/pin_repository.cpp @@ -66,7 +66,7 @@ void tle8888_dump_regs(void) for (int request = 0; request < 0x7e + 1; request++) { uint16_t tmp; tle8888_read_reg(request, &tmp); - uint8_t response = (tmp >> 1) & 0x7f; + uint8_t response = getRegisterFromResponse(tmp); uint8_t data = (tmp >> 8) & 0xff; scheduleMsg(&logger, "%02x: %02x", response, data);