From cd6b770945aa56ae52e188476034a862cba47bb0 Mon Sep 17 00:00:00 2001
From: Matthew Kennedy <matthewkennedy@outlook.com>
Date: Fri, 3 Mar 2023 02:05:50 -0800
Subject: [PATCH] is this just dead?

---
 firmware/console/status_loop.cpp                  | 8 +-------
 firmware/controllers/engine_cycle/spark_logic.cpp | 6 ------
 firmware/controllers/engine_cycle/spark_logic.h   | 2 --
 3 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/firmware/console/status_loop.cpp b/firmware/console/status_loop.cpp
index 8e89eb2474..742c0e6db6 100644
--- a/firmware/console/status_loop.cpp
+++ b/firmware/console/status_loop.cpp
@@ -220,12 +220,6 @@ static Logging logicAnalyzerLogger("logic analyzer", logicAnalyzerBuffer, sizeof
  * todo: is this mostly dead code?
  */
 void updateDevConsoleState(void) {
-	// todo: make SWO work
-//	char *msg = "hello\r\n";
-//	for(int i=0;i<strlen(msg);i++) {
-//		ITM_SendChar(msg[i]);
-//	}
-
 #if EFI_PROD_CODE
 	// todo: unify with simulator!
 	if (hasFirmwareError()) {
@@ -342,7 +336,7 @@ class CommunicationBlinkingTask : public PeriodicTimerController {
 			enginePins.communicationLedPin.setValue(1);
 
 	#if EFI_ENGINE_CONTROL
-			if (lowVBatt || isTriggerErrorNow() || isIgnitionTimingError()) {
+			if (lowVBatt || isTriggerErrorNow()) {
 				// todo: at the moment warning codes do not affect warning LED?!
 				enginePins.warningLedPin.setValue(1);
 			}
diff --git a/firmware/controllers/engine_cycle/spark_logic.cpp b/firmware/controllers/engine_cycle/spark_logic.cpp
index 66cc864600..aab690163a 100644
--- a/firmware/controllers/engine_cycle/spark_logic.cpp
+++ b/firmware/controllers/engine_cycle/spark_logic.cpp
@@ -30,14 +30,8 @@ extern bool verboseMode;
 	extern bool printFuelDebug;
 #endif // EFI_PRINTF_FUEL_DETAILS
 
-static cyclic_buffer<int> ignitionErrorDetection;
-
 static const char *prevSparkName = nullptr;
 
-int isIgnitionTimingError(void) {
-	return ignitionErrorDetection.sum(6) > 4;
-}
-
 static void fireSparkBySettingPinLow(IgnitionEvent *event, IgnitionOutputPin *output) {
 #if SPARK_EXTREME_LOGGING
 	efiPrintf("spark goes low  %d %s %d current=%d cnt=%d id=%d", getRevolutionCounter(), output->name, (int)getTimeNowUs(),
diff --git a/firmware/controllers/engine_cycle/spark_logic.h b/firmware/controllers/engine_cycle/spark_logic.h
index b82f0093fc..e8735d105c 100644
--- a/firmware/controllers/engine_cycle/spark_logic.h
+++ b/firmware/controllers/engine_cycle/spark_logic.h
@@ -13,5 +13,3 @@ void fireSparkAndPrepareNextSchedule(IgnitionEvent *event);
 int getNumberOfSparks(ignition_mode_e mode);
 percent_t getCoilDutyCycle(int rpm);
 void initializeIgnitionActions();
-
-int isIgnitionTimingError(void);