refactoring: reducing magic constant

This commit is contained in:
rusefillc 2022-06-02 12:41:49 -04:00
parent aeb02003ac
commit d44068746a
2 changed files with 3 additions and 2 deletions

View File

@ -16,7 +16,7 @@ public class PinoutLogic {
private static final String CONFIG_BOARDS = "config/boards/"; private static final String CONFIG_BOARDS = "config/boards/";
private static final String CONNECTORS = "/connectors"; private static final String CONNECTORS = "/connectors";
private static final String QUOTED_NONE = quote("NONE"); private static final String QUOTED_NONE = quote("NONE");
public static final String QUOTED_INVALID = quote("INVALID"); public static final String QUOTED_INVALID = quote(VariableRegistry.INVALID);
private final File[] boardYamlFiles; private final File[] boardYamlFiles;
private final String boardName; private final String boardName;

View File

@ -21,6 +21,7 @@ import static com.devexperts.logging.Logging.getLogging;
*/ */
public class VariableRegistry { public class VariableRegistry {
public static final String AUTO_ENUM_SUFFIX = "_auto_enum"; public static final String AUTO_ENUM_SUFFIX = "_auto_enum";
public static final String INVALID = "INVALID";
private static final Logging log = getLogging(VariableRegistry.class); private static final Logging log = getLogging(VariableRegistry.class);
public static final String _16_HEX_SUFFIX = "_16_hex"; public static final String _16_HEX_SUFFIX = "_16_hex";
@ -124,7 +125,7 @@ public class VariableRegistry {
if (sb.length() > 0) if (sb.length() > 0)
sb.append(", "); sb.append(", ");
String value = valueNameById.getOrDefault(i, "INVALID"); String value = valueNameById.getOrDefault(i, INVALID);
sb.append("\"" + value + "\""); sb.append("\"" + value + "\"");
} }
return sb.toString(); return sb.toString();