#656 global is not great

This commit is contained in:
rusefi 2019-01-28 02:29:13 -05:00
parent f1485cf8b4
commit db9a99b0c5
2 changed files with 5 additions and 7 deletions

View File

@ -496,6 +496,9 @@ public:
*/
int ignitionPin[IGNITION_PIN_COUNT];
// Store current ignition mode for prepareIgnitionPinIndices()
ignition_mode_e ignitionModeForPinIndices = Force_4_bytes_size_ignition_mode;
/**
* this is invoked each time we register a trigger tooth signal
*/

View File

@ -32,11 +32,6 @@
EXTERN_ENGINE
;
extern EnginePins enginePins;
// Store current ignition mode for prepareIgnitionPinIndices()
static ignition_mode_e ignitionModeForPinIndices;
floatms_t getEngineCycleDuration(int rpm DECLARE_ENGINE_PARAMETER_SUFFIX) {
return getCrankshaftRevolutionTimeMs(rpm) * (engineConfiguration->operationMode == TWO_STROKE ? 1 : 2);
}
@ -441,13 +436,13 @@ static int getIgnitionPinForIndex(int i DECLARE_ENGINE_PARAMETER_SUFFIX) {
}
void prepareIgnitionPinIndices(ignition_mode_e ignitionMode DECLARE_ENGINE_PARAMETER_SUFFIX) {
if (ignitionMode != ignitionModeForPinIndices) {
if (ignitionMode != engine->ignitionModeForPinIndices) {
#if EFI_ENGINE_CONTROL || defined(__DOXYGEN__)
for (int i = 0; i < CONFIG(specs.cylindersCount); i++) {
ENGINE(ignitionPin[i]) = getIgnitionPinForIndex(i PASS_ENGINE_PARAMETER_SUFFIX);
}
#endif /* EFI_ENGINE_CONTROL */
ignitionModeForPinIndices = ignitionMode;
engine->ignitionModeForPinIndices = ignitionMode;
}
}