Commit Graph

320 Commits

Author SHA1 Message Date
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
rusefillc e19b61aa5b [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
rusefillc a8e86b9b81 typos 2022-07-20 18:45:35 -04:00
Andrey G 2eeb1ad84e TunerStudio reconnect speedup (#4358)
* TunerStudio: do not emit tons of errors if we are not in sync

Track state of sync with ither side. Emit only ONE error when sync
is lost.
Also no need to wait 1sec for second byte in binary mode. 10mS is
enought.

* TunerStudio: remove duplicated debug print

* TunerStudio: comment about in_sync

* TunerStudio: clear comments
2022-07-20 17:54:10 -04:00
rusefillc ca25530445 picking atomic piece of #4358 2022-07-20 17:06:34 -04:00
rusefillc 5fafaa571d refactoring: reducing warnings 2022-07-20 17:03:15 -04:00
Matthew Kennedy cd98ad35c2 use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
Matthew Kennedy ab24c5eb35 Rewrite tooth logger buffer management (#4317)
* s

* make it work

* put back enough maybe

* fix console composite log

* unit tests can just use a vector, why not

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
rusefillc e8777995be visiting "live data" tab causes fatal error on ECU fix #4271 2022-06-25 19:48:48 -04:00
rusefillc 19abcab3d1 docs 2022-04-25 00:36:12 -04:00
Andrey 220dea05a8 shameless reminder about time-sensitive Proteus fabrication issue which worries me 2022-04-17 16:00:31 -04:00
rusefillc 2b0b9313d1 logging of live data structs was: data points #3614
exciting
2022-04-17 13:28:43 -04:00
rusefillc f9d222bce1 random progress & method rename 2022-04-16 17:35:59 -04:00
Matthew Kennedy 75c7fb3b18 fragment refactoring (#4072)
* fragment refactoring

* jar

* jar?
2022-04-16 09:24:45 -04:00
rusefillc b718d059ac logging of live data structs was: data points #3614
getting closer...
2022-04-14 22:40:35 -04:00
rusefillc 28b0b8d460 logging of live data structs was: data points #3614
ETB
2022-04-14 15:25:01 -04:00
rusefi b6483c2d8b steps towards better commands encapsulation 2022-04-14 01:44:35 -04:00
rusefi f5b1834b92 steps towards better commands encapsulation 2022-04-14 01:06:44 -04:00
rusefi 296985767b encapsulation 2022-04-14 00:35:33 -04:00
rusefillc 725e5467bd logging of live data structs was: data points #3614 2022-04-13 22:27:44 -04:00
Andrey 7cbe075bab logging of live data structs was: data points #3614
progress
2022-04-13 21:52:05 -04:00
rusefillc bc9d6089ec logging of live data structs was: data points #3614
hmm
2022-04-13 21:37:49 -04:00
rusefillc 0b3101d690 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 21:20:37 -04:00
rusefillc 57be5a2147 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 5c5d258b5f typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc 23bffc3973 JNI for test coverage #3965 2022-03-15 10:47:02 -04:00
rusefillc 0b1c1f73a0 JNI for test coverage #3965 and code style 2022-03-15 10:32:32 -04:00
rusefillc 3a2156090b Firmware support or user instructions for jdy-33 #3944 2022-03-10 13:35:37 -05:00
rusefillc 86560ca27c Firmware support or user instructions for jdy-33 #3944 2022-03-10 12:49:04 -05:00
Matthew Kennedy 53ae63df09 move allowLongResponse option to ECU side (#3917)
* executeCommand knows about opcodes

* kick

* remove allowLongResponse

* add api in firmware instead

* test size

* bad merge

* firmware missed a spot

* fix logic

* haha we have to disable it
2022-02-11 16:03:20 -05:00
Matthew Kennedy 47b4ace4cb less dependence on that logger (#3884)
* less dependence on that logger

* comma

* refactor a bit, make it clear what this thing actually *does*

* static

* shrink the buffer a bit and make names useful

* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
rusefillc ed584dd904 GDI Epic #1448 2022-01-18 16:16:17 -05:00
rusefillc 7ac8d9d83d GDI Epic #1448 2022-01-18 12:31:12 -05:00
rusefillc 9d3d7b046a 't' in terminal does not print seconds properly fix #3780 2022-01-12 16:03:40 -05:00
rusefillc f9054b0cde 't' to print current date 2022-01-11 22:47:46 -05:00
rusefillc 6fd0ae24d9 RE usability: live data for idle controller 2022-01-10 19:48:58 -05:00
rusefi 553d63b620 disablePrimaryUart for MRE for GDI 2022-01-08 19:38:02 -05:00
rusefillc ca6b7bba23 Live Data progress 2022-01-06 17:58:59 -05:00
rusefillc 4554a94794 docs 2021-12-08 11:55:34 -05:00
Andrey d2c46b3310 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
rusefillc a268c670bf rusEFI console ISO-TP via PCAN #3667
better logging
2021-12-07 15:15:06 -05:00
rusefillc f7f86e978d tune via CAN #3361
a couple of flush() were missing, also improving readability
2021-12-06 22:19:30 -05:00
Matthew Kennedy 565a94ea34 Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
Matthew Kennedy 6e4759389a AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
rusefillc 28c9d7555b live data for wastegate #3588 2021-11-24 12:59:57 -05:00
Matthew Kennedy 5274cffff3 main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
Matthew Kennedy e7956a53f6 fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy c1941f3a49 (void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 26749e0384 test TS writes (#3515)
* test TS writes

* s

* this must be a gcc extension
2021-11-10 07:29:40 -05:00
Andrey ef413188ee Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:21:36 -04:00
rusefillc 8b0299dead respond to 'Q follow-up #3383 2021-10-20 20:51:10 -04:00
Matthew Kennedy 0eb190cf85 respond to 'Q' (#3382) 2021-10-20 15:40:37 -04:00
rusefillc d4dd74c731 Whatever we call it, whatever we implement it - we need live data / remote view into rusEFI actual state #3353
progress
2021-10-14 18:50:03 -04:00
rusefillc f588b92a65 fixing build 2021-10-14 16:49:15 -04:00
rusefillc 998b474e2d Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
progress
2021-10-14 15:17:30 -04:00
rusefillc ba40de44b3 TS channel names for nicer console messages 2021-09-18 18:03:31 -04:00
rusefillc 75bd49ccbd TS channel names for nicer console messages 2021-09-18 16:58:35 -04:00
rusefillc 2944a89e4e TS channel names for nicer console messages 2021-09-18 15:33:14 -04:00
rusefillc 6247a50662 Revert "Revert "memory savings (#3195)""
This reverts commit 86cf9cf7
2021-08-27 06:18:05 -04:00
rusefillc 86cf9cf7c9 Revert "memory savings (#3195)"
This reverts commit 1b485ca2
2021-08-27 02:32:31 -04:00
Matthew Kennedy 1b485ca2d8 memory savings (#3195)
* d

* dead code

* all your ram are belong to me

* turn off gpiochips we don't need

* save

* save by using the same file handle

* smaller stack ok

* these can be on the stack

* this is closer

* what about ccm?

* probing available

* now probe ccm

* ccm

* put stuff in ccm

* fsio

* memory usage

* memory
2021-08-26 23:05:31 +03:00
Matthew Kennedy 39388c75d8 even more pch (#3112)
* s

* more

* s

* f7
2021-08-04 19:30:52 -04:00
Matthew Kennedy 4e6b61234f yet more pch (#3068)
* big pch energy

* put back ramdisk stub

* tests are happy

* h743 nucleo

* kinetis

* I love deleting code!

* make stepper happy

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy 0fde085a44 remove TS file read (#3004)
* remove

* more defines

* test

* lots of java

* s
2021-07-21 14:24:53 -04:00
Matthew Kennedy e3849b95d5 don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
rusefi 723b347e4d longer error message in 't' response 2021-07-14 12:42:35 -04:00
rusefi 1b2be671dd 't' comammand to return fatal error text 2021-07-13 22:53:11 -04:00
Andrey G fdfec5ea3c Fix swap macro (#2904)
* convert swap macroses to inline functions

* clean-up workarounds
2021-07-04 18:03:17 -04:00
Andrey G 5c552e196a TS communication minor fixes (#2847)
* console: noone use this

* console: do not stop blinking if TS command executes too long

Set and clear flag from the same place

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-06-23 04:36:55 -04:00
Andrey 270905fa8b removing dead code 2021-06-23 04:26:32 -04:00
Andrey 25168809f3 performance optimization by dron0gus 2021-06-21 09:27:09 -04:00
Andrey aa9f609df5 random trick 2021-06-12 13:48:37 -04:00
Matthew Kennedy 177f3afd05 ts logger (#2566)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 19:13:48 -04:00
Matthew Kennedy 72dac58f9b fix multi-serial-port insanity (#2476)
* carve out UART specific

* implement channel

* config cleanup

* use new config

* bootloader

* dead code

* s

* h7 inherits f7

* oops

* ok now it's right

* tests

* cleanup

* call setup

* put that in its own file

* cleanup

* format

* guard

* not needed

* improve guarding

* portable

* allow override of uart mode

* fixes for bootloader

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
Matthew Kennedy ce142907a0 replace print/printMsg with scheduleMsg (#2497)
* start cleaning

* disabled feature means don't print that it's disabled

* cli

* usages

* printMsg -> scheduleMsg

* this is alllll dead now

* no crlf please

* all hope is lost if you manage to hit this line

* tests

* tests

* ok we did actually need that part

* sim

* d

* kinetis

* it did ifdef, not if

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
Matthew Kennedy 368415972e read configuration from flash exactly once (#2481)
* early hw init

* s

* read configuration exactly once

* cleanup

* housekeeping

* test friendly

* ugh bad merge

* that is a noop

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 18:16:26 -04:00
Matthew Kennedy cb33bb77ae Dedicated code path for USB console/TS (#2465)
* new apis

* dedicated USB path

* move decl

* init

* don't init usb twice

* guard

* check that we're initialized before using TS

* comment

* guard

* guard USB

* brain doesn't go good

* make tests happy

* dead define

* cypress

* ifdef != if

* s

* include priority

* don't start a thread we know we don't need

* bad-ish merge

* const

* why did this code exist...?

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-18 14:07:22 -04:00
Matthew Kennedy a26002bc02 type signature, guards 2021-03-15 17:11:11 -04:00
rusefillc 212b9d6684 fix error/warning buffer overflow #2456 2021-03-14 09:52:27 -04:00
Matthew Kennedy 962e0b32e7 fix error/warning buffer overflow (#2456)
* fix error printing overflow

* make the worst offender shorter

* error as warning

* these don't need that flag set
2021-03-14 09:31:11 -04:00
Matthew Kennedy 943e6078c8 logging cleanup before refactor (#2438)
* minor cleanup

* more cleaning

* signature

* spelling

* doy
2021-03-09 08:43:29 -05:00
Matthew Kennedy f8747a35bf set all thread priorities in the same place (#2412)
* unify thread priority

* header

* mmc
2021-02-28 07:30:45 -05:00
Matthew Kennedy 726be2232e yet more TS sanity (#2382)
* ts cleanup part 1

* move more stuff in to the class

* extract base class

* switch to TsChannelBase where we can

* dfu

* more to TsChannelBase

* bad merge

* another bad merge

* bootloader

* bluetooth

* format

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-20 02:11:39 -05:00
Matthew Kennedy 12a31e5132 start making tunerstudio more sane: part 2 (#2381)
* ts cleanup part 1

* move more stuff in to the class

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
Matthew Kennedy 43f39fa616 start making tunerstudio more sane: part 1 (#2378)
* ts cleanup part 1

* unused unused

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 07:40:59 -05:00
Matthew Kennedy a576c2e109 USB mass storage tweaking (#2352)
* disable TS in case of USB MSD

* housekeeping while we're here

* enable on MRE

* changelog
2021-02-14 15:03:07 -05:00
Matthew Kennedy e38a160644 start peeling out ts commands (#2045)
* start peeling out commands

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 02:23:02 -05:00
Matthew Kennedy 2e1dad3650 start making TS protocol testable (#2043)
* start pulling out a class

* pull function out of loop

* there we go

* ok there we go for real

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 03:05:43 -05:00
rusefi 412e2b1d40 Revert "Revert "Split ETB in to interface + implementation headers (#2040)""
This reverts commit dae0b606
2020-12-07 01:27:27 -05:00
rusefi dae0b606cb Revert "Split ETB in to interface + implementation headers (#2040)"
This reverts commit 53cbeedb
2020-12-07 01:11:19 -05:00
Matthew Kennedy 53cbeedb99 Split ETB in to interface + implementation headers (#2040)
* split etb interface

* mocks

* fix master while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
rusefillc 9fb7540ece sporadic crc error #1943
un-removing, one step forward
2020-11-17 15:24:00 -05:00
rusefi 70a94ee1f7 occasional tunerstudio CRC errors #1943
second step back
2020-11-15 22:41:04 -05:00
Matthew Kennedy 80edfe64ce Fix crc again, for real this time (#1948)
* re enable

* changelog

* fix

* fix test

* put some tests back
2020-11-15 16:59:02 -05:00
Matthew Kennedy 3a052682dd fix large response packets (#1947)
* fix console text mode

* oops I should actually write the crc
2020-11-15 07:14:50 -05:00
Matthew Kennedy ebcd4f73af fix CRC errors (#1944)
* fix crc mismatch

* cleanup

* use size_t, add null check

* bounds check for good measure

* rename to scratchBuffer

* comment
2020-11-14 19:21:29 -05:00
Matthew Kennedy 5f11390f58 fatal error + inhibit read on TS preset (#1922)
* fatal error + inhibit read on preset

* inhibit more stuff when flag is set

* don't need that message

* extract function, improve msg

* changelog entry
2020-11-03 19:03:46 -05:00
rusefi 63b1a6652b Merge remote-tracking branch 'origin/Hellen_fork_point' into master
# Conflicts:
#	firmware/console/binary/tunerstudio_io.cpp
#	firmware/console/console_io.cpp
2020-09-11 05:54:21 -04:00