FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,987 Commits 35 Branches 20 Tags 554 MiB
Commit Graph

581 Commits

Author SHA1 Message Date
rusefillc 2d96fb3ef6 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc ce55171d8d minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 45deb75979 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
Andrey 72ed388948 minor trigger refactoring 2022-11-05 21:43:12 -04:00
Andrey G cc9b1517ac compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 07c5c2a91e progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc 8b1a1a984c refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
Matthew Kennedy 14b92612e2 fix 36-2-1 trigger (#4645) 
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
 2022-10-09 21:22:05 -04:00
rusefillc a9cf096272 // todo: what is broken _exactly_? (#4531) 
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-10-08 23:13:14 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628) 
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
 2022-10-04 20:36:03 -04:00
rusefillc 93b5758736 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622) 
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
 2022-09-25 18:49:54 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 5935c18beb K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey 4653cde601 K progress 2022-09-24 23:18:57 -04:00
Matthew Kennedy 2410b11a66 log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607) 
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
 2022-09-23 20:39:41 -04:00
rusefillc d423c077a0 moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 1c9cb5b6ba just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc cf53f8b65c tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc 6e3bbd2ca2 dead idea 2022-09-15 14:55:32 -04:00
Andrey dc9504f33c deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 02:45:31 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 02:35:55 -04:00
Andrey d9accf1772 deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 02:24:41 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 02:17:04 -04:00
Andrey aa0cffcfdb deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 02:06:52 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc 4836c78644 send more of Engine Sniffer data #4560 
hello Kinetis it has been a while!
 2022-09-11 00:18:08 -04:00
rusefillc b2ad515b0f vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547) 
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
 2022-09-08 16:15:36 -04:00
Andrey 3c1cc0b857 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey fdee7db991 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
Andrey 5cb41535d5 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 89b32418a1 Revert "smaller step forward" 
This reverts commit 3e105b1599.
 2022-09-01 09:10:11 -04:00
Andrey 22f31397b0 Revert "smaller step forward" 
This reverts commit deff630653.
 2022-09-01 09:10:07 -04:00
Andrey deff630653 smaller step forward 2022-09-01 08:51:13 -04:00
Andrey 3e105b1599 smaller step forward 2022-09-01 08:44:46 -04:00
Andrey 7b50f32b3d smaller step forward 2022-09-01 01:08:51 -04:00
Andrey bc407d7749 54ac7279b1 partial rollback 2022-09-01 00:46:54 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey 54ac7279b1 refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 9d497846d3 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
Andrey 0a9c1d7581 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Andrey 9042cd80db TT_VVT_MAZDA_MYSTERY 2022-08-28 23:01:38 -04:00
Matthew Kennedy fcb9897443 resolve VVT phase using every tooth, not just sync point (#4434) 
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
 2022-08-12 08:08:23 -04:00
Matthew Kennedy 6267b8621a big delete ICU (#4270) 
* big delete

* icu vestiges

* changelog
 2022-07-07 15:27:59 -04:00
Matthew Kennedy 88ff234c91 Injector scheduled by angle, not tooth index (#4208) 
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
 2022-06-24 17:43:23 -04:00
Matthew Kennedy d5f1235a43 trigger tweaks cleanup (#4278) 
* simplify some math

* we say yes to the todo

* and put back that test

* test
 2022-06-23 23:11:29 -04:00
rusefi dcde5cea9e verbose trigger sync should reuse engineSnifferRpmThreshold #4259 
docs
 2022-06-18 14:44:21 -04:00
rusefi 514531bc5c verbose trigger sync should reuse engineSnifferRpmThreshold #4259 
reducing complexity
 2022-06-18 14:17:36 -04:00
rusefillc f3a5b027d9 more into "triggerinfo" 2022-06-17 22:10:48 -04:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226) 
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
 2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222) 
* extra parameter

* name decoders in constructor

* s
 2022-06-01 00:55:34 -04:00
Matthew Kennedy 54c339c0a4 remove trigger duty cycle calculation (#4213) 
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
 2022-05-30 22:39:57 -04:00
Matthew Kennedy b5d212dcd8 remove dead useOnlyFirstChannel (#4211) 
* This field was ignored.

* move pad out

* gone
 2022-05-30 07:03:40 -04:00
Matthew Kennedy cf51533f45 More trigger encapsulation (#4207) 
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
 2022-05-29 13:49:00 -04:00
Matthew Kennedy 6ea78efbe7 bail from trigger_central (#4210) 2022-05-29 10:42:08 -04:00
Matthew Kennedy d85ed5f3c0 trigger decoder returns a result (#4206) 2022-05-28 09:01:45 -04:00
Matthew Kennedy eb257b2335 12 tooth crank mode (#4179) 
* 12 tooth crank

* comment

* s

* rusefi config
 2022-05-17 21:38:24 -04:00
Matthew Kennedy cf89b42716 move logic in to trigger decoder (#4162) 
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
 2022-05-10 23:55:28 +03:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy dede3f8215 phase resolution rpm limit (#4156) 2022-05-10 07:22:50 +03:00
Matthew Kennedy 55fdd3f3c7 encapsulate stuff properly (#4154) 2022-05-09 15:46:36 -04:00
rusefillc 394d1fe961 refactoring: bringing method names up to date 2022-05-08 09:04:27 -04:00
rusefillc b2771f9b44 Remove value copy from controller into outputChannels #4095 2022-05-08 08:50:27 -04:00
Matthew Kennedy 83caf1ea1b Brain pin is enum class (#4108) 
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
 2022-04-28 17:32:39 -04:00
rusefillc d1173219b6 Remove value copy from controller into outputChannels #4095 2022-04-23 19:53:05 -04:00
rusefillc 1ce5be5629 m_hasSynchronizedSymmetrical handling improvements #4099 (#4101) 2022-04-23 19:45:29 -04:00
rusefillc 8f1fb5dc0f i will confess: i need to fit a debug build into discovery 2022-04-16 17:24:31 -04:00
Andrey 20dbc1ff82 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 
WOW it works?!
 2022-04-03 02:30:43 -04:00
Andrey 6c69e55ea0 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:11:53 -04:00
rusefillc 9ae96ea7e5 refactoring: method rename 2022-04-02 21:01:29 -04:00
rusefillc b555d9e82b toothed previous time #4019 2022-03-21 20:41:09 -04:00
Andrey fe790bee93 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:24:50 -04:00
Andrey 8b5fdfa852 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:11:51 -04:00
rusefillc 9d8c316aff Remove Miata MX5 NB1 trigger fix #3488 2022-01-31 18:20:43 -05:00
rusefillc 22f679870a Bosch Quick Start on B6 Passat is confused about phase #3812 
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
 2022-01-19 01:30:16 -05:00
rusefillc a4479259cf Bosch Quick Start on B6 Passat is confused about phase #3812 
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
 2022-01-19 00:48:39 -05:00
rusefillc a2c71f07c6 refactoring: reusing existing flag instead of switch which refers to same thing 2022-01-19 00:48:39 -05:00
rusefillc 107eae67e0 docs 2021-12-29 16:18:21 -05:00
Matthew Kennedy 513187decc remove vvtSyncTimeNt (#3722) 
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* check synchronized bit

* now we don't need it at all?!

* and *NOT* synced

* start VVT sync earlier
 2021-12-28 00:00:26 -05:00
Matthew Kennedy b392a7120e improved noFiringUntilVvtSync logic (#3696) 
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* nissan MR too
 2021-12-27 12:09:38 -05:00
Andrey f5ead049c3 MAP phase sensing #3544 
limiting to below cranking RPM limit
 2021-12-11 02:56:19 -05:00
Matthew Kennedy d6a0154f79 maybe more working MAP sampling (#3689) 
* what if we do this

* cleanup

* s

* test
 2021-12-11 03:01:28 -04:00
rusefillc e7dec2a4b9 MAP phase sensing #3544 2021-12-09 22:16:42 -05:00
rusefillc 80c62ce888 MAP phase sensing #3544 
gauge name fix
 2021-12-08 12:44:43 -05:00
Andrey b8a197d0f0 MAP phase sensing #3544 
new implementation seems complete? 360 fix
 2021-12-07 21:37:33 -05:00
Andrey d3afd617d2 MAP phase sensing #3544 
new implementation seems complete?
 2021-12-07 21:08:25 -05:00
Andrey d2c46b3310 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
Andrey 0f6c9e15c3 MAP phase sensing #3544 
new implementation
 2021-12-07 20:00:04 -05:00
rusefillc ddbe875d98 MAP phase sensing #3544 
trigger sync better gauges/logging
 2021-12-06 17:04:05 -05:00
Matthew Kennedy 99367c8348 log actual tooth angle (#3646) 2021-12-02 19:22:33 -05:00
rusefillc 9ce37314c0 Engine phase wrap around in log #3645 
refactoring & docs
 2021-12-02 17:06:20 -05:00
rusefillc 2476fae92a Engine phase wrap around in log #3645 
refactoring & docs
 2021-12-02 17:06:20 -05:00