FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
25,036 Commits 35 Branches 20 Tags 554 MiB
Commit Graph

87 Commits

Author SHA1 Message Date
Matthew Kennedy d610bd40f0 remove idle deadzone because it only causes problems 2025-05-19 11:53:15 -07:00
Matthew Kennedy 877b2da1bd
idle entry target ramp (#570) 
* ramp target as you enter idle

* add idle threshold hysteresis

* make it optional

* test hysteresis behavior

* UI & changelog
 2025-03-11 18:26:01 -07:00
Matthew Kennedy dd67fa58e7 move idle "capture" RPM math to getTargetRpm 2025-03-09 00:52:33 -08:00
Matthew Kennedy 4c770b3431 unnecessary includes 2024-12-24 02:15:40 -08:00
Matthew Kennedy 84abe3692f fix tests 2024-12-23 13:38:19 -08:00
Matthew Kennedy 1d9efc95f2 int rpm -> float rpm 2024-09-24 23:40:49 -07:00
Matthew Kennedy 80358ad54e setTimeNowUs(): replace global fiddling with a functino call 2024-04-27 01:59:38 -07:00
Stefan de Kraker 4c65992017
Add cranking taper duration multiplier based on CLT (#370) 
* Add Cranking taper duration multiplier based on CLT

* Fixed same merge error in TS config

* Fixed existing unit test for getCrankingTaperFraction, and added a new one to test multiplier table for cranking taper duration.

* Fixed existing header file for unit test getCrankingTaperFraction

* Changed naming

* changed logic

* Forgot to update name here too

* Forgot to update name here too, second time
 2024-02-25 17:36:30 -08:00
Matthew Kennedy 06b39dbb07
trigger and engine types -> enum class (#113) 
* trigger type is enum class

* java tooling

* enum class engine_type_e

* enum class engine_type_e
 2023-06-01 13:47:49 -07:00
Matthew Kennedy acfde29c60 remove idle timing deadzone (#4731) 
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-11-04 15:02:20 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499) 
* idle always uses instant rpm

* configs

* fully inject rpm
 2022-08-29 22:18:06 -04:00
Matthew Kennedy 2926570747 idle coasting table is RPM, not clt (#4487) 
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
 2022-08-29 08:15:04 -04:00
Andreika fda9448798 [DRAFT] Air by rpm taper (#4486) 
* add rpm to getOpenLoop() and getRunningOpenLoop()

* implement airByRpmTaper

* unit-test for airByRpmTaper
 2022-08-25 21:23:23 -04:00
Matthew Kennedy 1fd637d27e remove idle offset (#4355) 
* remove offset

* remove more completely

* changelog
 2022-07-18 15:49:43 -04:00
rusefillc 178721c809 Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
Andrey 03662e48c4 Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
Andrey b7cd7dbdb9 Extra Idle Air if Throttle is Pressed behavior #3940 
only live data
 2022-04-03 20:30:09 -04:00
Matthew Kennedy 28b6cce9d9 Remove fsio part 1 (#3871) 
* dead includes

* move last logic out of fsio

* dead functions
 2022-02-01 15:42:04 -05:00
rusefillc 5c16186919 safer file name (#3861) 
* safer file name

* safer file name

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-01-31 21:51:32 -05:00
Andrey 37e700f8bd migrating to SensorType::Rpm API 2022-01-20 22:51:20 -05:00
rusefillc 5c68f86a0d RE usability: live data for idle controller 2022-01-10 21:55:52 -05:00
rusefillc 5eaabf5eb6 RE usability: live data for idle controller 
static bad, class fields better
 2022-01-10 20:12:11 -05:00
rusefillc 7760ddd8b6 live data for wastegate #3588 
i want to persist state so no 'const' sorry
 2021-11-23 15:52:43 -05:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565) 
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
 2021-11-17 03:54:21 -05:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560) 
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
 2021-11-16 16:52:11 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556) 
* some

* more

* more

* the last?!
 2021-11-16 04:15:29 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549) 
* less macro

* s
 2021-11-15 12:44:40 +01:00
Andreika 99fb5e4204 [DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables (#3168) 
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper

* Change isIdling() to isIdlingOrTaper()

* test_idle_controller.cpp

* useSeparateIdleTablesForCrankingTaper setting

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
 2021-10-06 12:05:20 -04:00
Matthew Kennedy e056369f05 actually remove FSIO idle stuff (#3150) 
* debug mode

* pid cleanup

* more dead

* more dead

* wow more dead

* much dead many death wow
 2021-08-14 09:48:45 +03:00
rusefillc d16cb0e153 dead idle FSIO 2021-08-12 18:28:55 -04:00
alxrMironov 9d1ce540c4 Begin "vehicleSpeed" refactoring. Module switched to "FunctionalPointerSensor" class. #3106 #3107 #3108. (#3132) 
* Add new sensor type "VehicleSpeed"

* Add "Vehicle speed" sensor to name list

* Add Vehicle speed sensor initialization with function pointer sensor.

* Add init_vehicle_speed_sensor.cpp to Makefile

* Replace dependencies from "getVehicleSpeed" to OOP-like "Sensor::get()"

* Add warning and TODO to "mock vehicle speed" call

* Replace get & mock "VehicleSpeed" methods in tests

* Remove #warning directive (cause error by current settings)

* Remove stray tab

* Remove explicitly type casting.

* Add "InitVehicleSpeedSensor" function declaration to init.h

* Add "VehicleSpeedSensor" initialization call into "InitNewSensors"

Co-authored-by: alxrMironov <330OMcorporative>
 2021-08-12 22:16:51 +03:00
Andrey e62244a623 unit test for vehicle_speed.cpp #3081 2021-08-03 19:48:24 -04:00
Matthew Kennedy d3ec2b21d1 Use pch in lots of files (#3066) 
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
 2021-07-26 01:05:17 -04:00
Matthew Kennedy d3d2762847 adjust taper behavior (#3051) 
* adjust taper behavior

* check that taper works in running state too
 2021-07-24 16:12:07 -04:00
Matthew Kennedy 16dac2e47c Disable closed loop idle during cranking->running taper (#2900) 
* implement

* dead file?

* implement tests

* new phase
 2021-07-06 08:47:06 -04:00
Matthew Kennedy d69fc86f26 explicitly set mock vss to test (#2905) 2021-07-04 17:52:45 -04:00
Matthew Kennedy 3247d4de00 Gate closed loop idle on road speed (#2901) 
* implement

* test

* b

* config
 2021-07-04 09:35:12 -04:00
Matthew Kennedy 63524c3f34 fan/AC idle improvements (#2818) 
* fan 2 open loop bump

* we had an AC target bump all this time?!

* format

* enable test

* I can't type
 2021-06-15 17:30:35 -04:00
Matthew Kennedy 0c0957f52a apply open loop idle when in automatic mode (#2745) 
* always apply open loop in closed loop

* simplify flags

* comment

* move

* comment

* missed one

* config for fan bump

* adjust miata defaults

* test fan/ac open loop

* idle CL tests

* test coasting

* test integration case

* fix merge

* put back reset logic for now

* s

* don't need that part

* I guess use OL as baseIdlePosition

* reset condition
 2021-06-12 14:21:11 -04:00
Matthew Kennedy f21fa3e652 idle fan/AC open loop bump (#2785) 
* idle open loop ui section

* idle bump logic

* test fan/ac bump
 2021-06-01 00:45:04 +03:00
Matthew Kennedy 1f3cbd67ad iac coast table (#2784) 2021-06-01 00:43:58 +03:00
Matthew Kennedy 6fbdb3c2d0 make the implementation match what the UI claims (#2779) 2021-05-31 07:37:02 -04:00
Matthew Kennedy 1b607faeba Idle test that fails (#2781) 
* make member func

* failing test
 2021-05-31 06:18:15 -04:00
Matthew Kennedy 86d3746453 Idle timing uses phase logic, remove falloff (#2169) 
* use phase computation

* move & simplify implementation

* test

* bad merge

* initialize

* wonderful changelog

* now unused parameter

* put back deadzone

* ui

* test deadzone

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2021-01-07 08:06:36 -05:00
rusefillc 7c38714129 Revert "Idle timing PID uses phase logic (#2156)" 
This reverts commit f1ee8b43
 2020-12-31 12:22:54 -05:00
Matthew Kennedy f1ee8b431e Idle timing PID uses phase logic (#2156) 
* use phase computation

* move & simplify implementation

* test

* bad merge

* initialize

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-12-29 23:50:56 -05:00
Matthew Kennedy 560061e251 Idle refactor open loop (#2146) 
* impl

* typo

* tests
 2020-12-26 19:34:42 -05:00
Matthew Kennedy 93cc1e84c3 more testable idle logic (#2140) 
* header

* test

* impl
 2020-12-26 08:32:01 -05:00
Matthew Kennedy d3cbed60af move target computation (#2091) 2020-12-17 17:46:51 -05:00
rusefillc 2d3ddcde9d Starter seems to be engaged forever #1965 2020-11-18 22:47:40 -05:00