Commit Graph

129 Commits

Author SHA1 Message Date
Matthew Kennedy 40a7fd732b deprecating EFI_ERROR_CODE 2024-12-28 14:49:27 -08:00
Matthew Kennedy f086b94c81 cisnan -> std::isnan 2024-07-22 16:00:59 -07:00
Matthew Kennedy 82b1c525e1 avoid float -> double 2024-05-11 13:24:38 -07:00
Matthew Kennedy 3f8931f341 we often mean inline when we say static 2024-03-28 18:20:40 -07:00
Matthew Kennedy baebd29adb shadowing in trigger land 2023-11-01 15:54:03 -07:00
Matthew Kennedy 0db4586c56 default params for happy test 2023-10-24 01:25:38 -07:00
Matthew Kennedy 987aa618dc make wrapAngle a function not macro 2023-10-19 15:21:44 -07:00
Matthew Kennedy f835025a2f remove wrapAngle2, wrapAngle does fine 2023-10-19 14:46:55 -07:00
Matthew Kennedy 6207d38b98 goodbye TriggerValue #55 2023-05-31 10:08:03 -07:00
Matthew Kennedy daaf50c2e4 looks like initialState was dead #55 2023-05-30 23:05:26 -07:00
Matthew Kennedy 03d43126de now dead overloads 2023-05-30 23:03:07 -07:00
Matthew Kennedy ef10a91c59 start switching TriggerValue to bool #55 2023-05-30 22:55:03 -07:00
Matthew Kennedy 2ed148fa9b need this one for now 2023-05-30 22:51:31 -07:00
Matthew Kennedy ce1dad1100 trigger structure api accepts bool #55 2023-05-30 22:48:07 -07:00
Matthew Kennedy d5f9479f28
ObdCode is enum class (#77)
* change ObdCode to enum class builds firmware

* test builds

* don't need this line at all

* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy e95197cda6 doesn't need to be generated 2023-02-28 03:42:44 -08:00
Matthew Kennedy b6e3f105df state sequence api doesn't use triggervalue #55 2023-02-28 02:25:38 -08:00
rusefi 18d93bf30f Revert "making enum less public API"
This reverts commit 46807bc8a4.
2023-02-15 09:08:52 -05:00
rusefillc 46807bc8a4 making enum less public API 2023-02-15 08:43:15 -05:00
Andrey 8d28853f48 docs 2022-11-16 15:23:42 -05:00
Andrey 7afc95a241 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
rusefi 4bc9b25214 reducing ugly 2022-11-06 20:47:57 -05:00
rusefillc d5c2c0294b minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc 4c3c34518a minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc 6402e61484 minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey b0acc6d141 A gem of dead code 2022-11-05 21:53:38 -04:00
Matthew Kennedy 1cc46a1b83 simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
Matthew Kennedy f2c8a0192c fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 1c9b07e355 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc e582a83ecb tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
rusefillc 0780a3f719 human brain does need sleep 2022-09-11 12:40:24 -04:00
rusefillc 2e85a7a09d refactoring: type safety 2022-09-11 05:41:01 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
rusefillc db0ff659c7 docs 2022-08-22 18:44:44 -04:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 54c339c0a4 remove trigger duty cycle calculation (#4213)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy 5f1801f9d6 trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy cf51533f45 More trigger encapsulation (#4207)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
rusefillc bc08418280 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
Andrey 49fab25b14 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
rusefillc 3dbee88f53 Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 19:08:22 -04:00
rusefillc 6dd790d7ac Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 18:32:40 -04:00
rusefillc 310a2044bd Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-01 21:11:32 -04:00