Matthew Kennedy
5f110d6c14
Toyota cam 4-1 can be a plain skipped tooth decoder ( #4863 )
...
* this should be RiseOnly
* use 4-1 skipped tooth for toyota
2022-12-02 07:37:18 -05:00
Andrey
9a3dfd7465
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 15:45:32 -05:00
Andrey
8d28853f48
docs
2022-11-16 15:23:42 -05:00
Andrey
7afc95a241
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
Andrey
01fd7f6831
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 12:18:46 -05:00
Andrey
c530523a7e
docs
2022-11-16 12:18:34 -05:00
rusefillc
5e9ff35ef9
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 11:35:00 -05:00
Matthew Kennedy
7b47e77e58
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
rusefi
4bc9b25214
reducing ugly
2022-11-06 20:47:57 -05:00
rusefillc
d5c2c0294b
minor trigger refactoring
2022-11-06 01:11:33 -04:00
rusefillc
4c3c34518a
minor trigger refactoring
2022-11-05 22:42:33 -04:00
rusefillc
6402e61484
minor trigger refactoring
2022-11-05 22:30:08 -04:00
Andrey
b0acc6d141
A gem of dead code
2022-11-05 21:53:38 -04:00
Andrey G
cc9b1517ac
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
1cc46a1b83
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
rusefillc
7a3cedfa22
triggerImage: todo: support symmetrical crank
2022-10-16 12:10:58 -04:00
Matthew Kennedy
14b92612e2
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy
a65190b008
remove 2jz trigger that's really 12 tooth crank ( #4637 )
...
* remove 2jz trigger that's really 12 tooth crank
* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy
33c8e937e6
change triggers that need RiseOnly ( #4636 )
...
* triggers that need RiseOnly
* skipped tooth
* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy
f2c8a0192c
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Andrey
1c9b07e355
nicer fatal message if that ever happens
2022-09-28 19:47:14 -04:00
GitHub gen-configs Action
915ce72a17
Auto-generated configs and docs
2022-09-25 22:54:41 +00:00
Matthew Kennedy
9cd5553617
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
6f5bed28d9
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
02aad24c59
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
c6a2f2657b
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
e582a83ecb
tear down Engine god object #4511
2022-09-15 21:28:27 -04:00
rusefillc
0780a3f719
human brain does need sleep
2022-09-11 12:40:24 -04:00
rusefillc
787dc0700e
Revert "refactoring: type safety"
...
This reverts commit 0ff7af9db5
.
2022-09-11 11:14:20 -04:00
rusefillc
0ff7af9db5
refactoring: type safety
2022-09-11 11:00:12 -04:00
rusefillc
2e85a7a09d
refactoring: type safety
2022-09-11 05:41:01 -04:00
rusefillc
921b97431f
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00
rusefillc
f9b849dd8f
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
rusefillc
efcd8ea084
refactoring - reducing API between FW and Java
2022-09-11 01:59:44 -04:00
Andrey
25b6d39802
os_access.h dead?
2022-09-07 15:56:45 -04:00
Andrey
82fa9b191a
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Matthew Kennedy
0863ac1a11
rename and fix skyactiv cam mode ( #4505 )
2022-08-31 22:12:45 -04:00
rusefillc
4c8e28dfab
docs
2022-08-29 10:51:32 -04:00
Andrey
691306f12a
TT_VVT_MAZDA_MYSTERY
2022-08-28 22:43:03 -04:00
rusefillc
35f17f38b3
TT_VVT_MAZDA_MYSTERY
2022-08-28 21:54:24 -04:00
Matthew Kennedy
234909a91f
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
rusefillc
f5576b05d9
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
Matthew Kennedy
e959f7e71e
hard code vq cam gaps ( #4471 )
2022-08-22 19:40:24 -04:00
rusefillc
db0ff659c7
docs
2022-08-22 18:44:44 -04:00
rusefillc
64c76bf59c
fix Subaru EZ30 trigger gaps fix #4344
2022-07-31 10:15:16 -04:00
rusefillc
cfd6828d42
Extra gap ratios for custom trigger wheels fix #4375
...
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
Andrey
43bc08bc24
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
rusefillc
250d8c4213
RoverK - wow that's odd, but whatever
2022-07-12 02:42:41 -04:00
rusefillc
b2cbd889f9
looks dead
2022-07-12 01:38:25 -04:00
rusefillc
60b8aa71de
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 11:41:33 -04:00
rusefillc
22e3ab8220
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 07:43:23 -04:00
Matthew Kennedy
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit 5454b8f509
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
c2f61dc95f
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy
54c339c0a4
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
5f1801f9d6
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
cf51533f45
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy
4a0c7cb8d5
honda trigger sync ratio ( #4194 )
2022-05-24 17:12:36 -04:00
rusefillc
7a52251375
Pavel says 120
2022-05-24 14:40:54 -04:00
Matthew Kennedy
eb257b2335
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy
fa835950a0
remove 360 trigger ( #4165 )
...
* remove 360
* s
* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy
b243d3fca0
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
Matthew Kennedy
997565ac22
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy
72e5604f9b
fix 36-2 trigger params ( #4138 )
...
* fix gap params
* changelog was wrong too
* typo
* binary log knock count and retard
* Revert "binary log knock count and retard"
This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
rusefillc
fdeeaac1c8
Corolla 1ZZ 2003 trigger improvements fix #4132
2022-05-04 02:45:44 -04:00
Matthew Kennedy
a2e1a079b8
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
rusefillc
f836dedef7
docs
2022-04-24 16:17:42 -04:00
rusefillc
bc08418280
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
Andrey
49fab25b14
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:38:52 -04:00
Andrey
6c69e55ea0
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
rusefillc
2f66b6fe04
huh?
2022-04-02 21:01:29 -04:00
rusefillc
3dbee88f53
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
rusefillc
6dd790d7ac
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 18:32:40 -04:00
rusefillc
310a2044bd
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 21:11:32 -04:00
Andrey
d97b2646ed
new VVT trigger shape? 4-1 Toyota #1847
2022-03-23 19:25:13 -04:00
Matthew Kennedy
5cf2b1bba5
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
Andrey
63adb09089
new VVT trigger shape? #1847
2022-03-22 06:34:22 -04:00
Matthew Kennedy
f67f65d31d
tweak sync parameters for mitsubishi ( #4017 )
2022-03-21 19:23:48 -04:00
Andrey
ce45951f7a
Mitsubishi 4B11 support #4013
2022-03-20 11:24:08 -04:00
Andrey
ef3248c245
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:06:19 -04:00
Andrey
394deca94a
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 21:34:25 -04:00
Andrey
65fe21cf84
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 20:34:51 -04:00
Andrey
d8ac904a28
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 17:57:35 -04:00
rusefillc
416f9a974d
Mitsubishi 6G75 Support #4014
2022-03-19 16:34:40 -04:00
rusefillc
faf84286f5
Mitsubishi 6G75 Support #4014
2022-03-19 16:28:06 -04:00
rusefillc
7548fe13f2
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 15:54:43 -04:00
rusefillc
c7cc88ccd0
Mitsubishi 4B11 support #4013
2022-03-19 15:52:42 -04:00
rusefillc
d6b1c9faf2
Mitsubishi 3A92 Support (Issue #4011 )
2022-03-19 12:01:57 -04:00
rusefillc
9d8c316aff
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
rusefillc
7b9816d137
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 20:55:50 -05:00
rusefillc
b40c898097
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
rusefillc
accc0542b8
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
Matthew Kennedy
4627bace31
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
Matthew Kennedy
c058698859
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
Matthew Kennedy
b392a7120e
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc
b0c1a8fb2e
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
Matthew Kennedy
8afee6c233
Honda K 12+1 decoder adjustment ( #3694 )
...
* adjust trigger
* real cranking
* mk
2021-12-14 21:10:01 -05:00
Matthew Kennedy
71514cb633
adjust mr18 vvt trigger ( #3691 )
...
* adjust mr18 trigger
* second gap, why not
2021-12-13 16:33:34 -04:00
rusefillc
9ce37314c0
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00