Commit Graph

158 Commits

Author SHA1 Message Date
Andrey 77caa77b4b trigger refactoring: instance RPM fix #4740 2022-11-06 12:03:55 -05:00
Andrey 65f5c00616 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 25d292c462 trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc 4c3c34518a minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc 6402e61484 minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey 72ed388948 minor trigger refactoring 2022-11-05 21:43:12 -04:00
Matthew Kennedy 2410b11a66 log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
rusefillc 1c9cb5b6ba just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc 03d176ca61 tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
Andrey dc9504f33c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey d9accf1772 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey aa0cffcfdb deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
Matthew Kennedy fcb9897443 resolve VVT phase using every tooth, not just sync point (#4434)
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
2022-08-12 08:08:23 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy d85ed5f3c0 trigger decoder returns a result (#4206) 2022-05-28 09:01:45 -04:00
Matthew Kennedy eb257b2335 12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
rusefillc 30e619fe95 random progress & method rename 2022-04-16 17:40:05 -04:00
rusefillc 8f1fb5dc0f i will confess: i need to fit a debug build into discovery 2022-04-16 17:24:31 -04:00
rusefillc a80b2dabd7 sporadic HighRevTest testV12 #3806
let's attempt to guess his intentions
2022-01-25 17:24:38 -05:00
rusefillc 22332a4dad sporadic HighRevTest testV12 #3806
is this bug here?
2022-01-25 10:28:35 -05:00
Matthew Kennedy 0dc5ff1941 fix (#3833) 2022-01-24 18:15:18 -05:00
Andrey 385f0cc991 Better handling of RPM during stop of cranking #3803 2022-01-17 21:27:10 -05:00
Andrey 19ff671aaf Better handling of RPM during stop of cranking #3803
reuse existing magic constant
2022-01-17 21:18:43 -05:00
rusefillc 2da6593305 Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
Matthew Kennedy c058698859 Nb2 crank sync special case (#3727)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
Matthew Kennedy 513187decc remove vvtSyncTimeNt (#3722)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* check synchronized bit

* now we don't need it at all?!

* and *NOT* synced

* start VVT sync earlier
2021-12-28 00:00:26 -05:00
rusefillc b0c1a8fb2e MAP phase sensing fix #3544
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc 02e31e1555 MAP phase sensing #3544
removing dead implementation
2021-12-16 21:13:55 -05:00
rusefillc e7dec2a4b9 MAP phase sensing #3544 2021-12-09 22:16:42 -05:00
Andrey d3afd617d2 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey 0f6c9e15c3 MAP phase sensing #3544
new implementation
2021-12-07 20:00:04 -05:00
Andrey c793b19538 MAP phase sensing #3544
look new unit test!
2021-12-07 16:58:10 -05:00
rusefillc 2b465be253 MAP phase sensing #3544
option to look for high and low peaks
2021-12-05 14:25:26 -05:00
rusefillc 52d770c2bf MAP phase sensing #3544 2021-12-04 18:47:14 -05:00
rusefillc e0559a8548 MAP phase sensing #3544
taking a step back to happy place
2021-12-04 18:21:10 -05:00
rusefillc f3a3d96fa9 MAP phase sensing #3544
trying longer average
2021-12-04 17:06:59 -05:00
rusefillc 2476fae92a Engine phase wrap around in log #3645
refactoring & docs
2021-12-02 17:06:20 -05:00
Andrey 7fa2fa5707 MAP phase sensing #3544 2021-11-24 23:06:52 -05:00
Andrey 695557f709 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Andrey 7b790d36f6 random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
rusefi 291f815b2d Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
Matthew Kennedy cadaf2a801 extract engine phase function (#3456)
* extract getCurrentEnginePhase

* inject engine ref

* never invalid RPM, use 0 instead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00