Commit Graph

112 Commits

Author SHA1 Message Date
Matthew Kennedy 3418356b6b ETB: inject pedal map (#1334)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

* inject pedal map

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
Matthew Kennedy d17afd3a63 ETB testing: output, position clamping (#1333)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
Matthew Kennedy 830f03c003 Closed loop controller base & ETB testing (#1322)
* closed loop controller base

* etb tps test

* closed loop controller tests

* test support

* update gtest

* fix for change

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
Matthew Kennedy d666743ab5 filter ETB autotune results (#1281)
* Astrom-Hagglund

* enums

* comments

* dead

* fix

* changed enum

* ts guard

* safety

* etb autotune debug channels

* filter results

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-11 22:28:50 -04:00
Matthew Kennedy 9bbb7bc497 etb autotune (#1274)
* Astrom-Hagglund

* enums

* comments

* dead

* fix

* changed enum

* ts guard

* safety

* etb autotune debug channels

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-11 22:15:49 -04:00
Matthew Kennedy 1a59950240 support ETB disable pin (#1273)
* config & hand gen

* board configs

* add dc motor support

* initialization

* also set duty to zero

* use disable in etb

* fix proteus default

* add TS fields

* I guess we needed 8 bytes

* :D

* comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-10 17:27:13 -04:00
Matthew Kennedy b934cb666b simplify (#1275) 2020-04-10 08:12:16 -04:00
Matthew Kennedy 44bb09d1a4 yet more tps consumers (#1258)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

* old tests

* kill dead stuff

* cleanup

* more

* fix

* test

* s

* fix signature

* fix test

* comment

* priming pulse

* remove mock tps

* remove more dead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
Matthew Kennedy cd3dc7f91b fix (#1251) 2020-04-03 07:48:12 -04:00
Matthew Kennedy d16ff88e30 run ETB on new TPS (#1248)
* run ETB on new TPS

* why did we include all those...?

* init tps for etb test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
Matthew Kennedy 7e4f4ca97e Replace hasPedalPositionSensor (#1245)
* remove

* add Sensor::hasSensor

* consume in etb

* remove unused state

* don't use it there either

* format

* fix up tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
rusefi 48baff1789 partial revert 2020-04-02 00:37:02 -04:00
rusefi be5b4fb3c6 less ETB in case of critical 2020-04-02 00:32:03 -04:00
Matthew Kennedy 8235d8d765 Fully switch acc pedal to new sensors (#1212)
* proxy sensor

* header

* idle

* can

* settings

* remove old mocking

* remove old impl

* etb

* oops, gotta actually register it

* fix test

* structured bindings ftw!

* driver intent for stepper

* tear out old

* oops too much
2020-04-01 20:21:03 -04:00
rusefi c6ac5ed888 progress 2020-03-28 20:56:58 -04:00
Matthew Kennedy 6d8eedf9ca Split out EtbHardware (#1168)
* start tear out motor

* fix

* nuke reconfig

* guard for test

* test fixing

* format, condense headers

* fix todos

* undo todo

* format
2020-03-03 17:56:50 -05:00
rusefi 923daaa3a1 ETB: expand automated testing #115 2020-02-22 23:18:02 -05:00
rusefi a222ecdfe1 happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 20a6cf130f better method name 2020-01-10 02:02:22 -05:00
rusefi afa5de2655 ETB documentation improvement? 2019-12-30 10:25:52 -05:00
rusefi 7577d81689 typo 2019-12-14 18:33:08 -05:00
rusefi 27f617686b progress towards ETB controller mocking 2019-12-13 13:52:34 -05:00
rusefi 2c296c0f18 etbActualCount logic to handle the scenario where only one ETB is present 2019-12-13 12:50:34 -05:00
rusefi f47a1a16d1 getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
Matthew Kennedy 87ec74119d ETB Encapsulation & C++ Conventions (#1049)
* encapsulate etb stuff, c++ conventions

* remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE

* reduce include dependencies

* Revert "reduce include dependencies"

This reverts commit c529bbbf757cd9070f6e00616f84b1229eeb768e.

* Revert "remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE"

This reverts commit ca98b18cd4dae24b993d1263a18daf509dcd54b9.
2019-12-10 19:37:04 -05:00
rusefi 07b7b62bca refactoring 2019-12-02 23:08:18 -05:00
rusefi ed9bae63af dual throttle re-init bugfix thank you andreika! 2019-12-01 09:39:34 -05:00
rusefi 34f53bd102 making things nicer with dual ETB settings 2019-11-30 17:38:33 -05:00
rusefi fd5c45ba46 all ETBs to run in same HW mode 2019-11-30 01:00:54 -05:00
rusefi 75b1a9e52c all ETBs to run in same HW mode
taking a step back and going to bed :(
2019-11-30 00:39:00 -05:00
rusefi 02f4e847f4 all ETBs to run in same HW mode 2019-11-30 00:25:33 -05:00
rusefi 349eac34de better state validation, better error codes 2019-11-29 23:41:26 -05:00
rusefi 4d6052c9f3 dual ETB seems to work! 2019-11-29 20:15:29 -05:00
rusEfi 13d4ae2169 dual ETB seems to work! 2019-11-29 19:06:50 -05:00
rusefi 73b3150d0f all ETBs to run in same HW mode 2019-11-29 19:02:12 -05:00
rusEfi 980a3d7086 all ETBs to run in same HW mode 2019-11-29 16:51:51 -05:00
rusefi 002a08316c steps towards dual ETB 2019-11-28 15:24:30 -05:00
rusefi 265727b7db steps towards dual ETB 2019-11-27 22:07:36 -05:00
Matthew Kennedy 0a7535fb1f Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusEfi c141d42a87 v12 and minor ETB 2019-11-22 23:27:03 -05:00
Matthew Kennedy 783ed572a9 inject interfaces to ETB, renaming (#1026)
* inject interfaces, renaming

* format

* null check

* that was a dumb typo

* fix indent
2019-11-22 20:53:54 -05:00
Matthew Kennedy 10a6f652d3 DC motor improvements (#1025)
* extract interface, comments, conform names

* fwd declare
2019-11-22 16:30:44 -05:00
rusefi 96443d079d following the pattern 2019-11-21 13:35:57 -05:00
rusEfi 7e78f077bc steps towards dual ETB 2019-11-21 00:49:38 -05:00
rusefi fb66dd1e7d making more code testable 2019-11-20 08:46:54 -05:00
rusefi 76a4e37c66 making more code testable 2019-11-20 02:18:17 -05:00
rusEfi 71511441c9 ETB docs 2019-11-18 22:25:07 -05:00
rusefi 30cfb96619 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 20:07:55 -05:00
rusefi eff84bcfeb steps towards #975 2019-10-18 18:54:32 -04:00
Matthew Kennedy 821ca6156f move tsOutputChannels to header (#970) 2019-10-08 21:02:51 -04:00