Commit Graph

568 Commits

Author SHA1 Message Date
Matthew Kennedy eea3f2cf36 fix tests 2020-07-28 14:27:34 -07:00
rusefi dfd646cbf5 Weird VAG: DC motor idle valve not ETB #1637
ok, that's the current reality
2020-07-26 12:30:50 -04:00
rusefi 07df0c78a8 Weird VAG: DC motor idle valve not ETB
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
rusefi 0302be40ed Weird VAG: DC motor idle valve not ETB #1637 2020-07-26 10:54:51 -04:00
Matthew Kennedy 7bf98384bf add tests for VW mode 2020-07-26 03:11:56 -07:00
Matthew Kennedy 0828146ccc tests & cleanup 2020-07-25 02:00:24 -07:00
rusefillc 07ce0ae1b2 Merge pull request #1634 from mck1117/refactor-inj
move injector logic in to its own file
2020-07-24 22:47:39 -04:00
Matthew Kennedy d19e2b2499 refacto 2020-07-24 18:26:24 -07:00
Matthew Kennedy aeb5c8e8d6 improve test 2020-07-23 01:24:02 -07:00
Matthew Kennedy 7940b84778 start refactor 2020-07-22 13:11:07 -07:00
rusefillc 2e58d92fdb Merge pull request #1606 from mck1117/reset-overlap
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
Matthew Kennedy c0ea3f19b7 make private 2020-07-20 18:50:48 -07:00
Matthew Kennedy faf9279402 Merge remote-tracking branch 'upstream/master' into export-all-logicdata 2020-07-20 18:48:54 -07:00
Matthew Kennedy b40114f34f test with fix 2020-07-20 18:47:08 -07:00
Matthew Kennedy 572c347ad7 compensate for bug 2020-07-20 13:21:15 -07:00
Matthew Kennedy 5c4e22fd16 auto export all logicdata 2020-07-20 13:12:21 -07:00
Matthew Kennedy 57de48ad59 impruv 2020-07-20 12:40:23 -07:00
rusefi c1a1f384bb Merge remote-tracking branch 'origin/master' 2020-07-20 14:25:47 -04:00
rusefi a6706b7d26 unit test framework improvements for smoother event execution 2020-07-20 14:25:32 -04:00
rusefillc 7d3876148b Merge pull request #1622 from mck1117/encapsulate-wwae
put wall wetting inside InjectionEvent
2020-07-20 14:19:57 -04:00
Matthew Kennedy bac27ea8ea Merge remote-tracking branch 'upstream/master' into test-1592 2020-07-20 10:54:18 -07:00
rusefi 117e98b753 unit test framework improvements for smoother event execution 2020-07-20 12:45:26 -04:00
rusefi c4885dcc0e unit test framework improvements for smoother event execution 2020-07-20 11:16:51 -04:00
Matthew Kennedy 8282bb127d test 2020-07-20 03:29:43 -07:00
Matthew Kennedy b38c2e3863 put wall wetting inside 2020-07-20 00:04:05 -07:00
rusefi e2c8e97aa0 logicdata into unit tests 2020-07-20 00:36:10 -04:00
Matthew Kennedy e0bf2eb909 fix (#1620) 2020-07-19 18:05:31 -04:00
rusefi 5245cb1978 unit tests: order of tests multispark/sensor tests should not matter #1616
TODO
2020-07-19 14:10:55 -04:00
rusefi 09684963a1 would this work? 2020-07-19 13:59:55 -04:00
rusefi 9c22ca7202 Injectors #1 and #5 stick open #1592
two bytes of progress
2020-07-19 13:54:47 -04:00
rusefi e9c5d5be7e would this work? 2020-07-19 13:50:43 -04:00
rusefi 8c520758d6 would this work? 2020-07-19 13:45:42 -04:00
rusefi 934300465a would this work? 2020-07-19 13:33:02 -04:00
rusefi eaff13ea1f Injectors #1 and #5 stick open #1592
two bytes of progress
2020-07-19 13:32:17 -04:00
rusefi 18efd1609b one step backwards to help build? 2020-07-19 13:26:46 -04:00
rusefi 5406a60e49 Injectors #1 and #5 stick open #1592
starting somewhere
2020-07-19 13:13:25 -04:00
rusefi ec29fd9ca0 better folder structure 2020-07-19 12:57:05 -04:00
Matthew Kennedy a79153bbea correct batch fuel cylinder pairing (#1595)
* correct batch fuel cylinder pairing

* param

* only change behavior on two wire batch

* Add tests for two wire batch & sequential

* improve testing a little bit

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
rusefi 93f85b0b93 EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 18:25:48 -04:00
rusefi 2b32bc8c16 PidIndustrial does not limit iTerm fix #1599 2020-07-11 15:30:40 -04:00
rusefi 2a45055289 PidIndustrial does not limit iTerm #1599
confirming issue with a unit test
2020-07-11 15:19:27 -04:00
rusefi 8bcd46291f migrate amazing idle from FSIO to less opaque TS #1581 2020-07-08 01:12:08 -04:00
rusefi bd39351055 idle_min through FSIO not working as intended #1553 2020-07-04 22:01:12 -04:00
andreika-git 8b84243dae Gen config refactor 2 (#1560)
* gen_config refactor, part II

* short board defines

* oops

* comment & undef

* define QUOTE

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
rusefi 21c35874a5 idle_min through FSIO not working as intended #1553 2020-07-01 20:45:37 -04:00
rusefi 7f3ce36065 1 byte issue in TuneReadWriteTest #1512 2020-06-18 22:51:07 -04:00
Matthew Kennedy aba153b814 simplify cranking corrections (#1510) 2020-06-18 08:54:02 -04:00
Matthew Kennedy 531f1c63c7 fuel math simplifications (#1485)
* simplify

* fix

* tweak

* cleaning

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-17 17:15:04 -04:00
rusefi 546344c78a nope, unit tests did not just fix themselves 2020-06-17 08:42:37 -04:00
Matthew Kennedy c46a6e5c0e only setup etb if primary sensor configured instead of proxy (#1489)
* only setup etb if primary sensor configured instead of proxy

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
rusefi 160d8d7462 Trigger decoding issues (60-2) #1488
unit test refactoring
2020-06-15 00:11:02 -04:00
Matthew Kennedy db29a3523a Fix gppwm properly (#1487)
* directly control output in onoff mode

* test fixing
2020-06-11 20:43:26 -04:00
Matthew Kennedy 2525a9a22c Factor out airmass logic (#1483)
* refactor

* extract more airmass

* rename, fix tests
2020-06-06 07:25:19 -04:00
Matthew Kennedy 9ecb0a4e55 refactor (#1481) 2020-06-03 21:12:12 -04:00
Matthew Kennedy c95ed26d89 Remove old thermistor implementation (#1458)
* remove test clt/iat

* remove warning since this code is nearly dead

* remove old therm impl

* tests & live doc

* not quite right
2020-05-28 17:51:33 -04:00
Matthew Kennedy 38cb254de3 remove maf2map mode (#1474)
* remove

* remove fully

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
Matthew Kennedy 45e03262d0 Redundant accelerator pedal (#1470)
* add second boudns

* init logic

* test changes

* reconfigure correctly

* rams
2020-05-23 19:48:32 -04:00
Matthew Kennedy a2313a853c switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi f47f5089ba Clean-up analog channels in "unit" tests #1456 2020-05-20 03:49:56 -04:00
rusefi 93a3379fce Clean-up analog channels in "unit" tests #1456 2020-05-20 03:42:09 -04:00
rusefi 60bfb2d789 Clean-up analog channels in "unit" tests #1456 2020-05-20 03:38:55 -04:00
Matthew Kennedy ce2beafb5f Redundant tps (#1427)
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* partial hookup

* fix

* fix

* bad makefile merge

* use second TPS config

* update test

* update test

* sensor names

* set second pin by default

* fix auto cal

* auto cal both sensors

* add reconfigure of secondary sensors

* gobblin' up your ram

* slow down write a little bit

* put split in debug gauge

* s

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
Matthew Kennedy e6e48ce66c binary logging (#1443)
* field support

* tests

* makefiles

* test data too

* missing include dir

* write correct thing

* fix one test

* fix test

* omnomnomnom ram

* format

* use defined names

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-17 15:56:37 -04:00
rusefi 8253f5b931 better VVT progress 2020-05-15 21:33:25 -04:00
rusefi 2878461d25 VVT_INACTIVE 2020-05-14 23:31:01 -04:00
Matthew Kennedy 7a41df6153 Fix 100% duty injection (#1431)
* skip turn-off for high duty

* mock executor injection

* test

* switch to hard cut

* test no longer relevant
2020-05-14 07:44:32 -04:00
rusefi 2db29c7824 34-2 3 cam Toyota wheel progress 2020-05-10 18:03:11 -04:00
rusefi b6f6d28ed4 removing some unneeded flexibility 2020-05-10 02:06:15 -04:00
rusefi bfe3b2c5fb 34-2 3 cam Toyota wheel progress 2020-05-10 01:21:54 -04:00
rusefi e4cfc39b68 docs & clean-up 2020-05-10 00:59:32 -04:00
Matthew Kennedy 424a86be7b short term fuel trim: part 2 (#1405)
* add tooltip

* add other direction to deadband

* add impl

* test partitioning

* makefile

* wrong comment

* fix include
2020-05-07 08:52:32 -04:00
Matthew Kennedy 55159cae44 short term fuel trim: part 1 (#1402)
* add cell

* add stft cell tests

* add bit

* minimally generate

* config defaults
2020-05-06 21:00:40 -04:00
Matthew Kennedy 6f3736f246 Rewrite boost control in new closed loop framework (#1342)
* rewrite boost

* test

* fix build

* tests

* open loop test

* test closed loop

* fix names

* typo

* tests

* mock boost setOutput

* needs more virtual

* fix boost logic

* switch to TPS based open loop

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
Matthew Kennedy 573d6d2d55 pull out std air charge math (#1397) 2020-05-05 08:01:40 -04:00
rusefi 9353ef7d51 better state messages 2020-05-01 18:52:06 -04:00
Matthew Kennedy dee2568fd5 Minor ETB improvements (#1381)
* fix pid reset and pedal failure

* pause control later

* test pauseEtbControl

* update tooltip + field name

* update test
2020-04-28 16:52:40 -04:00
Matthew Kennedy 7e067eb0b5 Move ETB control to a thread (#1374)
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* fix dt

* re-resize ram
2020-04-28 07:22:31 -04:00
rusefi d84f194ab7 fixing build 2020-04-26 20:40:06 -04:00
Matthew Kennedy 738e53442d General purpose PWM: implementation & tests (#1366)
* config

* significant digits

* renumber enum, no need for a "none"

* ui

* impl base

* error handle MAP

* init & update

* don't need arg

* don't lie about sensor

* fix test build

* test stub

* initialize

* null check

* fix clamping

* test output

* types & enums

* don't need param

* test getOutput

* fix

* output pin instead of brain pin

* default config
2020-04-26 14:06:28 -04:00
Matthew Kennedy c9ca028c9c etb CL test (#1361) 2020-04-24 17:54:03 -04:00
Matthew Kennedy b1741bdd6e Improve ETB idle control (#1319)
* compress idle pos

* fix tests for new behavior
2020-04-20 17:29:03 -04:00
Matthew Kennedy ce08650f65 Inject idle to ETB (#1335)
* inject idle position

* pointer

* etb idle tests

* extract mocks

* ops

* test negative case too

* don't convert for etb

* guard
2020-04-20 16:26:35 -04:00
Matthew Kennedy 3418356b6b ETB: inject pedal map (#1334)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

* inject pedal map

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
Matthew Kennedy d17afd3a63 ETB testing: output, position clamping (#1333)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
Matthew Kennedy bb24782bc2 rewrite etb tests with gmock (#1330) 2020-04-19 20:32:41 -04:00
Matthew Kennedy 830f03c003 Closed loop controller base & ETB testing (#1322)
* closed loop controller base

* etb tps test

* closed loop controller tests

* test support

* update gtest

* fix for change

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
Matthew Kennedy f54db83d67 Improve unexpected (#1323)
* use type instead of value

* fix remaining initializer-list users

* impruv

* last consumer?

* consumer

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 08:37:43 -04:00
Matthew Kennedy 363f6d5110 add expected helper class (#1321)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 01:53:04 -04:00
rusefi 192a96838f consistency 2020-04-18 22:46:22 -04:00
Matthew Kennedy 942403cec2 Fuel/ign correctino on new temp sensors (#1318)
* corrections

* test

* adv map

* tests

* cleanup

* lcd

* fsio

* unneeded

* more math

* last consumer

* cleanup

* fix kinetis
2020-04-18 18:45:30 -04:00
Matthew Kennedy 2535d123b8 CLT consumer: fsio (#1302)
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup

* fsio test help
2020-04-15 16:20:45 -04:00
Matthew Kennedy 83592f0dff New clt consumers part 1 (#1301)
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup
2020-04-15 09:48:17 -04:00
rusefi 3f4518c324 fixing master 2020-04-14 12:55:39 -04:00
Matthew Kennedy afc5f6c99b fix maf (#1287) 2020-04-12 15:52:29 -04:00
Matthew Kennedy 3abd181f6f CLT/IAT/Aux in the new sensor world (#1269)
* hook up clt

* init test

* probably fix test

* aux temp

* relax checking

* more significant figures

* remove old aux temp

* hand generate

* claim RAM

* move to ccm

* subscribe

* info printing

* warnings

* raise high voltage failure threshold

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-07 16:07:09 -04:00
Matthew Kennedy 01c87a87ee Deadband helper & tests (#1267)
* deadband

* header

* comment
2020-04-06 09:16:26 -04:00
Matthew Kennedy f161a6990a fix (#1268) 2020-04-06 09:00:26 -04:00
Matthew Kennedy 95ef31da67 Goodbye, old TPS (#1266)
* clear out tps

* boost control

* aux valves

* launch, aux valves

* unused field
2020-04-05 19:33:33 -04:00
Matthew Kennedy 44bb09d1a4 yet more tps consumers (#1258)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

* old tests

* kill dead stuff

* cleanup

* more

* fix

* test

* s

* fix signature

* fix test

* comment

* priming pulse

* remove mock tps

* remove more dead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
Matthew Kennedy 43d38a6691 TPS Initialization Testing (#1264)
* test support

* stub for tests

* plumbing so we can test this

* add test

* comments
2020-04-05 09:10:08 -04:00
Matthew Kennedy 606a7fff0d More TPS consumers: VE lookup (#1256)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
Matthew Kennedy 9a21262cf8 TPS consumers: idle and ignition and obd2 and lcd (#1254)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
Matthew Kennedy d16ff88e30 run ETB on new TPS (#1248)
* run ETB on new TPS

* why did we include all those...?

* init tps for etb test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
shadowm60 baa2547da1 E30 M3 Tach output solution #907 (#1203)
* Update tachometer.cpp

Initial implementation of E30 M3 Tach output solution #907, unit_test plus debugging next

* tacho unit tests

First successfull unit test for tachometer

* RAM adjustment so it would link

* refactoring tacho, broken!

* starting to make some progress...still fails after a few seconds

* Rework with SW PWM

* Update after code review

* unit_test update

* First working unit_test

* Update .gitignore

* Update engine_controller.cpp

* Update engine_controller.cpp

* Update tachometer.h

* Update test_tacho.cpp

Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-04-02 15:20:04 -04:00
Matthew Kennedy cee565f2b1 Add redundant sensor (#1249)
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* casing

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:55:21 -04:00
Matthew Kennedy 7e4f4ca97e Replace hasPedalPositionSensor (#1245)
* remove

* add Sensor::hasSensor

* consume in etb

* remove unused state

* don't use it there either

* format

* fix up tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
rusefi b40d4d588d code style 2020-04-01 21:32:21 -04:00
Matthew Kennedy 8235d8d765 Fully switch acc pedal to new sensors (#1212)
* proxy sensor

* header

* idle

* can

* settings

* remove old mocking

* remove old impl

* etb

* oops, gotta actually register it

* fix test

* structured bindings ftw!

* driver intent for stepper

* tear out old

* oops too much
2020-04-01 20:21:03 -04:00
Matthew Kennedy cd41449459 Debuggability in the new sensor world (#1238)
* rename to avoid conflict

* fix efilib

* add sensor printing

* makefile

* that check was already there

* const

* const

* fix tests

* formatting

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-30 18:29:42 -04:00
Matthew Kennedy b7033bbde9 Finally rename injector_central to bench_test (#1229)
* bench test rename

* rename consumers

* good lord what are all of these externs doing

* fix tests
2020-03-26 08:03:55 -04:00
Matthew Kennedy b7b67a2a7f Multispark implementation (#1192)
* multispark prototype

* only multispark if not cut

* typo

* do some reasonableish math

* consume cfg

* todo

* bad merge

* move math out of engine2.cpp

* engine state config

* consume generated

* use new

* hand generate

* doc, debugging

* debug channel names

* don't depend on rpmcalc

* safer, fix math

* tests

* default multispark config

* remove todo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
rusefi aa28127211 random code inspired by Ola 2020-03-24 19:50:04 -04:00
Matthew Kennedy fa8036e4b6 fix (#1202)
* fix test

* shrink memory
2020-03-19 20:02:49 -04:00
rusefi 0e8acf6514 CLT stops working when using 2-0 custom trigger wheel #1171 2020-03-06 01:31:04 -05:00
Matthew Kennedy 6d8eedf9ca Split out EtbHardware (#1168)
* start tear out motor

* fix

* nuke reconfig

* guard for test

* test fixing

* format, condense headers

* fix todos

* undo todo

* format
2020-03-03 17:56:50 -05:00
rusefi 923daaa3a1 ETB: expand automated testing #115 2020-02-22 23:18:02 -05:00
rusefi 2eec300251 miata vvt trigger decoding is broken #1145 2020-02-14 13:02:27 -05:00
rusefi 67e6812dbb Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:51:26 -05:00
rusefi f69bbba6a4 Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:50:50 -05:00
rusefi eaf28b161b miata vvt trigger decoding is broken #1145 2020-02-14 10:49:22 -05:00
rusefi b4d2ce0ecd miata vvt trigger decoding is broken #1145 2020-02-14 09:33:29 -05:00
rusefi fc33789da7 miata vvt trigger decoding is broken #1145 2020-02-14 00:37:36 -05:00
rusefi 7e86765370 cam/vvt decoder test progress 2020-02-05 01:08:39 -05:00
Matthew Kennedy 734963343d Rescale TPS (#1112)
* fake adc ticks

* consumers

* fix test 1

* fix tests
2020-02-01 16:41:07 -05:00
rusefi 3f08833de2 this test is even better now! 2020-01-31 13:45:15 -05:00
rusefi f4d36f32fa VVT refactoring & assertions for VVT test 2020-01-31 01:49:10 -05:00
rusefi a124e0b934 date & VVT test progress 2020-01-31 01:23:01 -05:00
rusefi 5bb778381a lovely tiny bug which mostly affects NB2 with an impossible one tooth crank trigger wheel 2020-01-30 01:47:34 -05:00
rusefi 9bd819a18d extracting class & codes clean-up 2020-01-28 00:16:33 -05:00
rusefi ae228dff0e trigger refactoring 2020-01-26 14:20:55 -05:00
rusefi 98c6198f1d reducing code duplication 2020-01-26 06:28:33 -05:00
rusefi dfa8d9ccc9 refactoring trigger 2020-01-26 03:33:45 -05:00
rusefi a89e20a647 refactoring 2020-01-22 00:40:26 -05:00
rusefi a222ecdfe1 happy new year unification 2020-01-13 21:57:43 -05:00
rusefi abe1b8c1f3 refactoring: no need to specify parameter manually 2020-01-12 10:43:02 -05:00
Matthew Kennedy 0256b0358e Add timeout + raw value access for sensors (#1098)
* timeout

* inject stamp

* allow getting raw value

* plumb timeout

* fix tests
2020-01-12 03:25:23 -05:00
rusefi 67a3796086 better method names 2020-01-10 23:17:58 -05:00
Matthew Kennedy cb1039fe23 Inject timestamps in to hwHandleShaftSignal (#1090)
* injection

* injectors
2020-01-09 21:19:11 +03:00
rusefi 63e3e84e08 happy new year 2020-01-08 00:02:40 -05:00
Matthew Kennedy 3d8c4f4179 Strongly typed action constructor (#1087)
* strong typing

* maybe we needed that one
2020-01-07 18:10:31 -05:00
Matthew Kennedy 6703705a33 Pass action_s instead of callback/param (#1084)
* change action

* consumers

* fix test

* didn't mean to add those

* simplify

* fix simulator

* fix sim for real

* oy

* maybe this time the simulator will actually be fixed, for real

* don't rely on undefined behavior
2020-01-07 00:41:18 -05:00
rusefi 4605c64a07 that's not a worth a file 2019-12-24 00:03:53 -05:00
Matthew Kennedy 2b4b119962 Add new sensor function types (#1065)
* add functions

* add tests

* add chain tests

* float suffix
2019-12-17 09:06:29 -05:00
rusefi 95d2875672 this stuff is pretty dead 2019-12-15 21:59:25 -05:00
rusefi 19ce8b7044 and finally a unit test, like it shoud be! 2019-12-13 14:55:20 -05:00
rusefi 27f617686b progress towards ETB controller mocking 2019-12-13 13:52:34 -05:00
rusefi f47a1a16d1 getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi 9f5535721e clean-up 2019-12-10 01:03:02 -05:00
rusEfi 52c15a7d9b dual-ETB progress 2019-12-10 00:07:46 -05:00
rusefi bcec694eb1 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi a5ee6b13d5 Refactor Trigger System #635
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
rusefi edabed50f5 Refactor Trigger System #635
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
rusefi 561986d3e4 The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
rusefi 5c40bb4628 #490 2019-12-03 00:29:12 -05:00
rusefi bce4ce71fd misc clean-up 2019-12-02 13:53:31 -05:00
rusefi d8a10139c2 misc clean-up 2019-12-02 10:18:13 -05:00
rusefi f9c387b42e cj125 unit test progress! 2019-12-02 01:52:54 -05:00
andreika-git 7220735530 Starter relay + Hardcoded 'FSIO' + simulator fix (#1032)
* Starter Relay: gui + built-in FSIO impl.

* Hardcoded 'FSIO' replacement for RAM-limited boards

* fix simulator
2019-11-25 20:08:01 -05:00
rusefi e8051c1807 more correct variable names 2019-11-23 23:49:39 -05:00
rusefi 18bb121cbe aux valves unit test 2019-11-23 22:55:21 -05:00
rusefi 07c7219f51 header cleanup 2019-11-23 21:41:17 -05:00
rusefi af3118fd42 making progres on angle-based scheduling 2019-11-23 20:36:40 -05:00
rusefi f15986b9aa refactoring 2019-11-23 18:38:16 -05:00
rusefi 79ada84b56 'triggerEventAngle' not really needed 2019-11-23 17:44:44 -05:00
rusefi a31057ec17 explicit list field to simplify code navigation 2019-11-23 17:04:51 -05:00
Matthew Kennedy 0a7535fb1f Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusefi f3c4c8d822 v12 2019-11-18 23:54:08 -05:00
rusefi e4d31bafb7 v12 done right 2019-11-17 09:32:12 -05:00
rusefi e783f71d53 code formatting 2019-11-17 09:03:20 -05:00
rusefi 9f6549b719 32 bit vs 64 bit compiler challenge for floats in unit tests 2019-11-10 13:57:27 -05:00
andreika-git add26866f5 Industrial PID Controller (#1002)
* Implement Industrial PID controller

* Test-Use PidIndustrial in alternator

* Meaningful unit-tests for PidIndustrial
2019-11-10 13:04:27 -05:00
rusefi c734cb0fa4 Missing dwell altogether in some corner cases fix #796 2019-11-06 00:31:24 -05:00
rusefi 4910d37387 Missing dwell altogether in some corner cases #796
getting closer!
2019-11-06 00:01:08 -05:00
Matthew Kennedy 6f3bfcb099 fix wwae (#980) 2019-10-17 00:06:54 -04:00
rusefi cf20fe4b47 I guess we can simply change the magic number 2019-10-16 23:02:37 -04:00
rusefi a7ea155633 preparing for #973 2019-10-16 22:10:38 -04:00
rusefi 2c24b1b7f7 preparing for #973
wall wetting was not covered by any unit test?!
2019-10-16 16:46:34 -04:00
rusefi 5513e0174b Coil duty cycle ignores dwell #977 2019-10-15 05:30:38 -04:00
rusefi 6b2451873a Coil duty cycle ignores dwell #977
test-driven is the way to go
2019-10-15 05:16:30 -04:00
rusefi 41919a4fbd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
rusefi c938b0d374 preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
rusefi f776513a5a preparation for #961
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
rusefi c5f12fbcd9 I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 5d6a329c80 wow, dead field 2019-10-08 02:17:32 -04:00
rusefi 54fe92e534 really not clear what is the best place for these classes 2019-10-08 02:13:52 -04:00
rusefi 7e1e7629ee refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi 46e1ff671a refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi c9821588e9 One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
just a unit test for now
2019-10-07 23:12:29 -04:00
rusefi 95d3368b0f refactoring: all events are now validated in relation to current timestamp 2019-10-07 23:02:47 -04:00
rusefi 63375dc24c refactoring 2019-10-07 21:54:03 -04:00
Matthew Kennedy 40853e1a3f fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
Matthew Kennedy 9b1dc07ae1 Simplify thermistor config (#962)
* simplify thermistor config

* fix test
2019-10-02 21:00:10 -04:00
rusefi 52e95a5d68 pid limits / etb limits 2019-09-29 14:56:18 -04:00
rusefi eb59a41724 extracting pid test to separate file 2019-09-29 14:36:41 -04:00
Matthew Kennedy b68ed85491 Fix sensor mock spill, again (#957)
* actually reset

* add test

* doh
2019-09-27 21:40:36 -04:00
rusEfi 9193e73090 Revert "Fix sensor mocking bug (#956)"
This reverts commit 7989d593
2019-09-27 20:33:45 -04:00
Matthew Kennedy 7989d59311 Fix sensor mocking bug (#956)
* actually reset

* add test
2019-09-27 20:21:50 -04:00
rusefi 2b26fcc6c9 reducing copy/paste in unit tests 2019-09-25 09:09:32 -04:00
rusefi 9827177afe reducing copy/paste in unit tests 2019-09-25 08:55:18 -04:00
rusefi 1ebbfa7ebb Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-25 08:40:56 -04:00
rusefi 0d35b1ebba reducing hell in unit tests 2019-09-25 08:40:33 -04:00
Matthew Kennedy 325a9e3fd1 Hmm, that didn't quite work right (#955)
* maybe that wasn't a good idea

* we don't need a copy because you can't clear the func after setting it

* no longer a template - move logic to cpp

* fix tests

* rename to avoid object collision
2019-09-25 07:26:56 -04:00
Matthew Kennedy ccb4c51e50 Sensors: composition >> inheritance (#953)
* functional sensors

* format

* tests

* sim makefile

* eol

* format tests
2019-09-24 21:11:41 -04:00
rusefi 80f8facd8a absolute fuel pressure flow calculation #954 2019-09-24 18:39:26 -04:00
rusefi df64289fd5 ETB target is using integer values fix #945 2019-09-22 18:15:00 -04:00
rusefi 42f085a4a0 ETB target is using integer values #945
now we have a unit test! now we can fix the issue :)
2019-09-22 17:58:27 -04:00
rusefi 658dac889c ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
rusEfi b46c5b4960 ETB target is using integer values #945
first we will write a unit test
2019-09-22 07:58:03 -04:00
Matthew Kennedy dfcc9dba04 add sensor framework, tests (#929)
* add framework, tests

* move oil pressure to new way

* add init logic

* brackets on the same line

* spaces -> tabs

* spaces -> tabs for tests

* bracket on same line

* hook up sensor mocking

* add nan check

* fix nan check

* I wrote an essay

* casing

* only init if we have a sensor to init

* style, actually call init

* format

* fix casing

* typo

* implement linear sensor

* wire up producer

* smarter limiting

* setup comments

* add reporting

* doxyfile

* oops

* add adc subscription

* clarity

* fix logic

* multiply voltage

* test styling

* test guards

* remove dependencies

* linear sensor test

* remove unused

* fix merge

* format, implicit convert op

* explicit

* format tests

* fix merge
2019-09-21 14:33:38 -04:00
rusefi 13b74d3d4d unit tests progress 2019-09-20 00:46:35 -04:00
rusefi cac91ceac8 unit tests progress 2019-09-20 00:34:42 -04:00
rusefi d83ed085e8 unit tests progress 2019-09-19 22:56:54 -04:00
rusefi 0952b84aad unit tests progress 2019-09-19 21:41:52 -04:00
rusefi 317ec8d752 unit tests progress 2019-09-19 08:05:23 -04:00
rusefi 8ef1fcd344 unit tests progress 2019-09-18 21:48:46 -04:00
rusefi d576f3ba1f Delayed A/C compressor switch #922
unit tests skeleton
2019-09-12 07:31:13 -04:00
rusefi 5ac8545060 Delayed A/C compressor switch #922 2019-09-11 19:30:36 -04:00
rusefi a8f7a8965b cranking fuel live data #911 2019-08-26 23:41:04 -04:00
rusefi f816e92671 unit_tests are failing under 32 bit mingw-w64 fix #905 2019-08-25 17:38:08 -04:00
rusefi 3ae955b3e5 reducing unit test noise 2019-08-25 02:01:09 -04:00
rusefi 104cb1dc1a reducing unit test noise 2019-08-25 01:19:23 -04:00
rusefi d6f7e778ac code style/type safety/docs/typos 2019-08-10 11:13:41 -04:00
rusefi 946374184e WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898 2019-08-08 23:11:56 -04:00
rusefi 9112b7f797 WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
fatal error is the best I can come up with quickly
2019-08-08 22:57:22 -04:00
rusefi dfeac28299 current toolchain does not work great with current rusEfi code, two methods with same name are hard for full text search :( 2019-08-08 22:33:52 -04:00
rusefi eef4fbde9b fixing build & taking a safer route 2019-08-08 22:12:51 -04:00
rusefi 6043c93372 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
fancy smansy unit test with some C++11
2019-08-08 21:27:57 -04:00
rusefi 334f021137 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:32:31 -04:00
rusefi b34f232777 migrating to google test 2019-07-25 00:28:04 -04:00
rusefi 830d52d8ca removing least useful engine configurations 2019-07-25 00:18:39 -04:00
rusefi d4c28ecc69 setDefaultBoardConfiguration shouldn't have Frankenso pinout #852 2019-07-24 22:33:30 -04:00
rusefi 7cacc37fcc FIRMWARE_ID 2019-07-13 14:08:08 -04:00
rusefi 705df36b0e better variable names & fixing build 2019-07-13 08:19:00 -04:00
rusefi 756dec106a support multiple VVT sensors #885
new fields & packing configuration. bumping configuration version
2019-07-12 14:24:45 -04:00
Matthew Kennedy e4a0a0ae91 Fix some maf logic (#880)
* fix maf

* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
rusefi d2ba2c72f5 Missing dwell altogether in some corner cases #796
skeleton
2019-07-01 15:04:39 -04:00
rusefi f2a034b5aa Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-19 22:34:11 -04:00
rusefi 7d65295c6a I like static_cast 2019-06-17 10:22:43 -04:00
rusefi 7ea74f404a Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-15 17:32:11 -04:00
rusefi 9a33c3488a MK clean-up 2019-06-15 16:43:30 -04:00
Matthew Kennedy 89f59db75f Fix tunerstudio ratio vs. percent (#838)
* fix ratio vs pct

* fix idle cranking clt position

* fix defaults

* fix typo

* fix baro corr gauge

* baro default

* fix degree symbols

* fix testFuelMap

* fix testPlainCrankingWithoutAdvancedFeatures

* test testFasterEngineSpinningUp
2019-06-13 09:05:22 -04:00
rusefi 9179d3bf99 progress & fixinig unit tests 2019-06-01 09:11:01 -04:00
rusefi 19a6a27342 fix #799 2019-05-27 16:12:59 -04:00
rusefi 998345ef9e unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi ca3fe686a3 #799 unit test first 2019-05-27 14:55:35 -04:00
rusefi e557a30193 messing with TPS mocking 2019-05-27 14:21:12 -04:00
rusefi 53f5229423 Multiple sync pattern for faster cranking #679 2019-05-14 19:24:18 -04:00
rusefi bbcc555ac1 progress 2019-05-12 20:45:02 -04:00
rusefi cbc1aef722 more PROD code into unit test 2019-05-12 20:31:28 -04:00
rusefi 74bbda8f9e Multiple sync pattern for faster cranking #679
unit test for current status
2019-05-12 19:58:15 -04:00