Matthew Kennedy
17cb1444c7
add option to temperature compensate alpha-n
2023-09-16 23:21:03 -07:00
Matthew Kennedy
b1b1ec7fdf
add postState flag to airmass model calls #107
2023-05-15 17:18:35 -07:00
Matthew Kennedy
f30e2ce0f2
selectable idle Y axis override ( #94 )
...
* selectable idle Y axis override
* changelog
2023-05-02 15:04:15 -07:00
Matthew Kennedy
d5f9479f28
ObdCode is enum class ( #77 )
...
* change ObdCode to enum class builds firmware
* test builds
* don't need this line at all
* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy
2f85cd60d4
use ECU-calculated blend table axis values
2023-04-02 13:56:42 -07:00
Matthew Kennedy
f090a97b0b
remove specs_s struct, flatten config
2023-03-27 00:58:18 -07:00
Matthew Kennedy
bdeeb82f93
better idle VE table transition
2023-03-27 00:42:56 -07:00
Matthew Kennedy
e5d28022ad
spammy prints cleanup
2023-03-16 01:27:03 -07:00
Matthew Kennedy
6a05413e52
throttle model gets real max engine flow
2023-03-16 01:11:19 -07:00
Matthew Kennedy
4cd08fbc4b
table-only map fallback ( #46 )
...
* table-only map fallback
* InSequence
2023-02-23 15:05:56 -08:00
Andrey
fe780d477e
kinetis asking for guard, also I've must have messed up something
2022-12-17 18:04:54 -05:00
Matthew Kennedy
32b170810e
duplicate log field names ( #4730 )
...
* remove duplicate target lambda/afr
* names on fuel computer
* remove more copies
* sensor.java
* everybody loves hard dependencies on generated fields
* target afr gauge fix
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy
ede3df75f5
dual MAF sensors ( #4697 )
...
* add second MAF
* output channesl
* move them around
* ok let's try at the very end
* is the logic wrong, or something else?
* ooh it's the sensor order
2022-10-24 12:41:05 -04:00
Matthew Kennedy
acec8f2da3
VE blend tables ( #4640 )
...
* blendy ve too
* ui
* small optimizations
* save kinetis memory
* changelog
2022-10-19 06:42:22 -04:00
Andrey
73423a612a
tear down Engine god object #4511
...
just trying different things
2022-09-03 11:05:27 -04:00
Matthew Kennedy
2d033df11b
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
rusefillc
0b1c1f73a0
JNI for test coverage #3965 and code style
2022-03-15 10:32:32 -04:00
Matthew Kennedy
6fc4503ee2
XY Idle VE Table ( #3781 )
...
* config & ui
* implement
* test idle VE switching behavior
* use the interface where we can
* s
* re-bump flash version
2022-01-20 14:08:54 -05:00
rusefillc
917c13ef50
docs
2021-12-26 13:41:10 -05:00
rusefillc
c647dde007
docs & refactoring
2021-12-26 12:35:41 -05:00
Andrey
d2c46b3310
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
rusefillc
3cf4be3aa9
why so many channels are hidden in debug ? #3614
2021-11-29 14:11:19 -05:00
Scott Smith
b3e0b28c75
Make the module API more concise. ( #3571 )
...
engineModules.get<FOO>(). becomes modules<FOO>()->
I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith
f9f13f0bad
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy
bd04dc8352
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
Matthew Kennedy
a2766e5d9b
support autoscale on table axes ( #3452 )
...
* scale map Y axis
* allow different row/col types
* scaled channel detector
* interpolation
* looks like this actually works
* tests, no manual scaling
* comment
2021-11-03 19:53:26 -04:00
rusefillc
a16819ae10
refactoring
2021-10-16 23:18:09 -04:00
rusefillc
1fe037192e
refactoring
2021-10-16 22:08:47 -04:00
rusefillc
0518617689
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:49:38 -04:00
rusefillc
504bd78814
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:24:05 -04:00
Andreika
99fb5e4204
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
Matthew Kennedy
dab377d15d
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
Matthew Kennedy
4e6b61234f
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Matthew Kennedy
e3849b95d5
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Matthew Kennedy
b68469822e
lua hooks for custom airmass model ( #2697 )
...
* lua airmass
* not const any more
* bad merge
* don't change the position of others
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 00:49:14 -04:00
Matthew Kennedy
77f9c68733
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
Matthew Kennedy
0c03a1cb4a
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
Matthew Kennedy
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
Matthew Kennedy
dbebc353a2
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
Matthew Kennedy
ace0f4e78c
Add fallback map table ( #2248 )
...
* table
* sd math
* config
* debug channel name
* ptr vs not ptr
* actually use return value
* memory
* less magic
2021-01-31 17:19:06 -05:00
Matthew Kennedy
654bf0d698
Map fallback logic, TS cleanup ( #2247 )
...
* add new field
* UI
* set default
* consume new parameter
* some cleanup while we're at it
2021-01-27 20:31:29 -05:00
Matthew Kennedy
d4965d16f3
Enable idle timing/ve tables based on idle phase logic ( #2213 )
...
* add helper
* advance
* ve
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 00:54:37 -05:00
Matthew Kennedy
add0dcd390
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
Matthew Kennedy
83266c904b
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
rusefillc
a1fe39b89d
unit tests in clang #2012
2020-12-04 23:59:21 -05:00
rusefillc
5118a67f89
better error handling
2020-11-17 22:45:43 -05:00