Commit Graph

947 Commits

Author SHA1 Message Date
rusefi cf20fe4b47 I guess we can simply change the magic number 2019-10-16 23:02:37 -04:00
rusefi a7ea155633 preparing for #973 2019-10-16 22:10:38 -04:00
rusefi 2c24b1b7f7 preparing for #973
wall wetting was not covered by any unit test?!
2019-10-16 16:46:34 -04:00
rusefi 5513e0174b Coil duty cycle ignores dwell #977 2019-10-15 05:30:38 -04:00
rusefi 6b2451873a Coil duty cycle ignores dwell #977
test-driven is the way to go
2019-10-15 05:16:30 -04:00
rusefi 6f8b82e8ed preparing for #974
code comments & refactoring
2019-10-14 18:32:16 -04:00
rusefi 730aaca3ea preparing for #974
code comments & refactoring
2019-10-14 16:04:28 -04:00
rusefi 791c1423b0 preparing for #974
code comments & refactoring
2019-10-14 09:09:08 -04:00
rusefi 41919a4fbd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
rusefi 584398d593 sweet unit test hack 2019-10-13 09:59:43 -04:00
rusefi c938b0d374 preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
rusefi f776513a5a preparation for #961
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
rusefi c5f12fbcd9 I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 875fb3d1bc something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi 415de92543 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi 5d6a329c80 wow, dead field 2019-10-08 02:17:32 -04:00
rusefi 54fe92e534 really not clear what is the best place for these classes 2019-10-08 02:13:52 -04:00
rusefi 15ae9b1580 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 7e1e7629ee refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi 46e1ff671a refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi c9821588e9 One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
just a unit test for now
2019-10-07 23:12:29 -04:00
rusefi 95d3368b0f refactoring: all events are now validated in relation to current timestamp 2019-10-07 23:02:47 -04:00
rusefi 63375dc24c refactoring 2019-10-07 21:54:03 -04:00
rusefi b68ed9f8cb docs & refactoring 2019-10-07 21:23:38 -04:00
Matthew Kennedy 40853e1a3f fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
Matthew Kennedy 9b1dc07ae1 Simplify thermistor config (#962)
* simplify thermistor config

* fix test
2019-10-02 21:00:10 -04:00
rusefi 52e95a5d68 pid limits / etb limits 2019-09-29 14:56:18 -04:00
rusefi eb59a41724 extracting pid test to separate file 2019-09-29 14:36:41 -04:00
Matthew Kennedy b68ed85491 Fix sensor mock spill, again (#957)
* actually reset

* add test

* doh
2019-09-27 21:40:36 -04:00
rusEfi 9193e73090 Revert "Fix sensor mocking bug (#956)"
This reverts commit 7989d593
2019-09-27 20:33:45 -04:00
Matthew Kennedy 7989d59311 Fix sensor mocking bug (#956)
* actually reset

* add test
2019-09-27 20:21:50 -04:00
rusefi 2b26fcc6c9 reducing copy/paste in unit tests 2019-09-25 09:09:32 -04:00
rusefi 9827177afe reducing copy/paste in unit tests 2019-09-25 08:55:18 -04:00
rusefi 1ebbfa7ebb Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-25 08:40:56 -04:00
rusefi 0d35b1ebba reducing hell in unit tests 2019-09-25 08:40:33 -04:00
Matthew Kennedy 325a9e3fd1 Hmm, that didn't quite work right (#955)
* maybe that wasn't a good idea

* we don't need a copy because you can't clear the func after setting it

* no longer a template - move logic to cpp

* fix tests

* rename to avoid object collision
2019-09-25 07:26:56 -04:00
Matthew Kennedy ccb4c51e50 Sensors: composition >> inheritance (#953)
* functional sensors

* format

* tests

* sim makefile

* eol

* format tests
2019-09-24 21:11:41 -04:00
rusefi 80f8facd8a absolute fuel pressure flow calculation #954 2019-09-24 18:39:26 -04:00
rusefi df64289fd5 ETB target is using integer values fix #945 2019-09-22 18:15:00 -04:00
rusefi 42f085a4a0 ETB target is using integer values #945
now we have a unit test! now we can fix the issue :)
2019-09-22 17:58:27 -04:00
rusefi f65fc4fec1 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 17:39:13 -04:00
rusefi e4878734a1 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 17:19:08 -04:00
rusefi 1ff2a320ab ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 16:52:22 -04:00
rusefi c6bca8e77a ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 10:02:07 -04:00
rusefi 658dac889c ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
rusEfi b46c5b4960 ETB target is using integer values #945
first we will write a unit test
2019-09-22 07:58:03 -04:00
Matthew Kennedy dfcc9dba04 add sensor framework, tests (#929)
* add framework, tests

* move oil pressure to new way

* add init logic

* brackets on the same line

* spaces -> tabs

* spaces -> tabs for tests

* bracket on same line

* hook up sensor mocking

* add nan check

* fix nan check

* I wrote an essay

* casing

* only init if we have a sensor to init

* style, actually call init

* format

* fix casing

* typo

* implement linear sensor

* wire up producer

* smarter limiting

* setup comments

* add reporting

* doxyfile

* oops

* add adc subscription

* clarity

* fix logic

* multiply voltage

* test styling

* test guards

* remove dependencies

* linear sensor test

* remove unused

* fix merge

* format, implicit convert op

* explicit

* format tests

* fix merge
2019-09-21 14:33:38 -04:00
rusefi 03d71bedeb reducing complexity 2019-09-20 01:06:15 -04:00
rusefi 13b74d3d4d unit tests progress 2019-09-20 00:46:35 -04:00
rusefi cac91ceac8 unit tests progress 2019-09-20 00:34:42 -04:00
rusefi d83ed085e8 unit tests progress 2019-09-19 22:56:54 -04:00
rusefi ee2b14bdc6 unit tests progress 2019-09-19 21:55:27 -04:00
rusefi 0952b84aad unit tests progress 2019-09-19 21:41:52 -04:00
rusefi 317ec8d752 unit tests progress 2019-09-19 08:05:23 -04:00
rusefi 8ef1fcd344 unit tests progress 2019-09-18 21:48:46 -04:00
rusefi d576f3ba1f Delayed A/C compressor switch #922
unit tests skeleton
2019-09-12 07:31:13 -04:00
rusefi 5ac8545060 Delayed A/C compressor switch #922 2019-09-11 19:30:36 -04:00
rusefi afdeecb87e progress towards idle unit test 2019-08-29 23:50:20 -04:00
rusefi a8f7a8965b cranking fuel live data #911 2019-08-26 23:41:04 -04:00
rusefi 2ca4fb81ed unit tests code coverage #653 2019-08-26 10:45:34 -04:00
rusefi 5f5dfbfa61 unit tests code coverage #653 2019-08-25 23:31:39 -04:00
rusefi 62edeba408 unit tests code coverage #653 2019-08-25 21:53:37 -04:00
osboxes.org 0c298a8311 gcov 2019-08-25 21:51:22 -04:00
rusefi f5643e29b8 gcov progress 2019-08-25 21:34:04 -04:00
osboxes.org 7867eb9897 mint
lease enter the commit message for your changes. Lines starting
2019-08-25 21:18:06 -04:00
rusefi c0fd6fe69d unit tests code coverage #653 2019-08-25 21:10:39 -04:00
rusefi 5a567efda6 unit_tests to init git modules 2019-08-25 20:15:14 -04:00
rusefi f816e92671 unit_tests are failing under 32 bit mingw-w64 fix #905 2019-08-25 17:38:08 -04:00
rusefi c3562bde51 unit_tests are failing under 32 bit mingw-w64 #905 2019-08-25 17:23:53 -04:00
rusefi 55fec0066d Gcov (#906)
* trying to get gcov working

* unit tests code coverage #653

* unit tests code coverage #653
progress :(

* unit tests code coverage #653
2019-08-25 16:53:13 -04:00
rusefi 1b44e664cb unit tests code coverage #653
See https://stackoverflow.com/questions/57643813/cannot-get-gcov-to-produce-any-coverage-data
2019-08-25 10:21:36 -04:00
rusefi 3bf5bb5a2b readme 2019-08-25 02:49:11 -04:00
rusefi 3ae955b3e5 reducing unit test noise 2019-08-25 02:01:09 -04:00
rusefi 104cb1dc1a reducing unit test noise 2019-08-25 01:19:23 -04:00
rusefi 91bcd035af reducing unit test noise 2019-08-25 01:15:18 -04:00
rusefi 80658efa77 questionable readablity improvement 2019-08-25 00:37:05 -04:00
rusefi d6f7e778ac code style/type safety/docs/typos 2019-08-10 11:13:41 -04:00
rusefi 946374184e WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898 2019-08-08 23:11:56 -04:00
rusefi 9112b7f797 WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
fatal error is the best I can come up with quickly
2019-08-08 22:57:22 -04:00
rusefi dfeac28299 current toolchain does not work great with current rusEfi code, two methods with same name are hard for full text search :( 2019-08-08 22:33:52 -04:00
rusefi eef4fbde9b fixing build & taking a safer route 2019-08-08 22:12:51 -04:00
rusefi 6043c93372 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
fancy smansy unit test with some C++11
2019-08-08 21:27:57 -04:00
rusefi 334f021137 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:32:31 -04:00
rusefi b34f232777 migrating to google test 2019-07-25 00:28:04 -04:00
rusefi 830d52d8ca removing least useful engine configurations 2019-07-25 00:18:39 -04:00
rusefi d4c28ecc69 setDefaultBoardConfiguration shouldn't have Frankenso pinout #852 2019-07-24 22:33:30 -04:00
rusefi 8f6ef7976c CBR600 trigger progress 2019-07-23 19:22:40 -04:00
rusefi 7cacc37fcc FIRMWARE_ID 2019-07-13 14:08:08 -04:00
rusefi 705df36b0e better variable names & fixing build 2019-07-13 08:19:00 -04:00
rusefi 756dec106a support multiple VVT sensors #885
new fields & packing configuration. bumping configuration version
2019-07-12 14:24:45 -04:00
Matthew Kennedy e4a0a0ae91 Fix some maf logic (#880)
* fix maf

* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
Matthew Kennedy 0b52f5b542 Template-ize bin/value length for interpolation (#878)
* update consumers

* tests

* whitespace

* format
2019-07-09 21:16:36 +03:00
rusefi abc7040511 reviving unit tests 2019-07-06 21:00:34 -04:00
rusefi 777eb532dc Refactoring: OS access should be explicit #867 2019-07-03 21:48:04 -04:00
rusefi d2ba2c72f5 Missing dwell altogether in some corner cases #796
skeleton
2019-07-01 15:04:39 -04:00
rusefi f2a034b5aa Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-19 22:34:11 -04:00
rusefi 7d65295c6a I like static_cast 2019-06-17 10:22:43 -04:00
rusefi 7ea74f404a Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-15 17:32:11 -04:00
rusefi 9a33c3488a MK clean-up 2019-06-15 16:43:30 -04:00
Matthew Kennedy 89f59db75f Fix tunerstudio ratio vs. percent (#838)
* fix ratio vs pct

* fix idle cranking clt position

* fix defaults

* fix typo

* fix baro corr gauge

* baro default

* fix degree symbols

* fix testFuelMap

* fix testPlainCrankingWithoutAdvancedFeatures

* test testFasterEngineSpinningUp
2019-06-13 09:05:22 -04:00
rusefi 5eec063b7f fresh googletest 2019-06-02 14:56:32 -04:00
rusefi 9179d3bf99 progress & fixinig unit tests 2019-06-01 09:11:01 -04:00
rusefi 19a6a27342 fix #799 2019-05-27 16:12:59 -04:00
rusefi 998345ef9e unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi ca3fe686a3 #799 unit test first 2019-05-27 14:55:35 -04:00
rusefi e557a30193 messing with TPS mocking 2019-05-27 14:21:12 -04:00
rusefi 53f5229423 Multiple sync pattern for faster cranking #679 2019-05-14 19:24:18 -04:00
rusefi bbcc555ac1 progress 2019-05-12 20:45:02 -04:00
rusefi cbc1aef722 more PROD code into unit test 2019-05-12 20:31:28 -04:00
rusefi deead8f8ff reducing code duplication with unit tests 2019-05-12 20:24:35 -04:00
rusefi 74bbda8f9e Multiple sync pattern for faster cranking #679
unit test for current status
2019-05-12 19:58:15 -04:00
rusefi 8b74476c1b BUG: phase sensor validation attending - detect missing CAM signal fix #659 2019-05-11 00:21:37 -04:00
rusefi 35964c064c BUG: phase sensor validation attending - detect missing CAM signal #659
preparation
2019-05-10 23:52:55 -04:00
rusefi 499fb22a31 BUG: phase sensor validation attending - detect missing CAM signal #659 2019-05-10 23:20:42 -04:00
rusefi a696b5d5c5 Trigger: warning code on normal engine start up #669 2019-05-10 23:12:36 -04:00
rusefi 6f3bc5f150 Trigger: warning code on normal engine start up #669
avoiding CUSTOM_OBD_SKIPPED_FUEL fot triggers without synchronizaiton
2019-05-10 22:55:08 -04:00
rusefi b00af69c81 BUG: phase sensor validation attending - detect missing CAM signal #659
refactoring and unit test first phase
2019-05-10 21:56:33 -04:00
rusefi 767418b93b refactoring unit test 2019-05-10 21:29:17 -04:00
rusefi af7b39154a Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
only renaming methods
2019-05-07 17:10:47 -04:00
rusefi a6fc10910a Saab CDM knock signal integration #647 2019-05-05 18:53:34 -04:00
rusefi 48aefe67d9 adjusting test due to 8c1c892907 2019-05-04 23:24:19 -04:00
rusefi 85b790edcf The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
maybe probably pointless refactoring? reducing parameters visibility
2019-05-03 18:41:43 -04:00
rusefi 4627cc9c8f Try ccache #769 2019-04-20 21:44:00 -04:00
rusefi 3306f58ed2 minor fix - same -Wextra twice 2019-04-20 20:32:20 -04:00
rusefi 9f64e1c73e TPS/TPS logging delta TPS not consistent with actual logic fix #768 2019-04-20 17:34:23 -04:00
rusefi d4dcfac535 random cleanup 2019-04-15 19:24:46 -04:00
rusefi 37c2fbf1da cj125 and hip125 and else SPI broken with chibi18 migration fix #757 2019-04-14 18:35:39 -04:00
rusefi c7be178b58 random cleanup 2019-04-14 15:16:44 -04:00
rusefi 24733f586c smarter PWM API - need to pass arbitrary pointer 2019-04-12 20:35:02 -04:00
dron0gus 055b82ea07 unit test compilation fix under linux (#747) 2019-04-12 22:08:52 +02:00
rusefi f554572c54 The Big Refactoring of 2019: folder structure #723 2019-04-09 23:01:45 -04:00
rusefi df62ae6a4b The Big Refactoring of 2019: folder structure #723 2019-04-05 01:41:24 -04:00
rusefi 6531c0c6de reviving unit tests. too bad unit tests are coupled with cranking base fuel values :( 2019-04-04 09:17:12 -04:00
rusefi 59d33c4cdc The Big Refactoring of 2019: folder structure #723 2019-03-31 17:44:34 -04:00
rusefi 581d3d0c1b The Big Refactoring of 2019: folder structure #723 2019-03-31 17:14:53 -04:00
rusefi 583d189e3b The Big Refactoring of 2019: folder structure #723 2019-03-31 16:33:16 -04:00
andreika-git a79175f6ef More portability & small fixes (#719)
* Use hw_stm32.mk

* Fix bootloader

* Use more common hw_ports.mk filename instead of hw_stm32.mk

* More CPU compatibility for Makefile

* TS_UART_MODE & rename TS_SERIAL_UART_DEVICE->TS_SERIAL_DEVICE

* Move lockAnyContext()/unlockAnyContext() to rfiutil.c

* USE_FATFS

* EFI_LCD

* Less compilation errors

* STATUS_LOGGING_BUFFER_SIZE & SETTINGS_LOGGING_BUFFER_SIZE

* EFI_ALTERNATOR_CONTROL, EFI_SERVO, EFI_DISABLE_CONSOLE_ACTIONS

* #ifndef PWM_PHASE_MAX_COUNT & more flexible GPIO inside portname()

* merge

* EFI_ALTERNATOR_CONTROL, EFI_ELECTRONIC_THROTTLE_BODY
2019-03-29 15:29:01 +01:00
rusefi e28ce71bb8 unifying_file_naming 2019-03-29 09:11:13 -04:00
andreika-git 887580f7e2 Tps-accel. fractional mode (#715)
* Add new config settings for tps_accel_fractional_mode

* Add new variables for the fractional algo

* Add resetFractionValues() method

* Call onEngineCycleTps() and fix onEngineCycle()

* Implement the fractional algo

* More debug outputs for tps-enrich

* Nice & juicy unit-test!
2019-03-28 22:47:20 -04:00
andreika-git a3f33f3f0d More compatibility for ADC_inputs, etc. (#716)
* Move STM32-specific ADC pinouts to ports/stm32/stm32_common.cpp

* Move STM32-specific files to ports/*

* setAdcChannelOverrides()

* Add #ifdefs for adc_inputs (PWM_FREQ_*, PWM_PERIOD_*, ADC_*_DEVICE)

* addChannel(), removeChannel()

* fix tle6240 compilation

* Add stm32_common.cpp to Makefile

* More ports/stm32/* paths

* More ports/stm32/* paths

* More flexible GPIO ports

* Add #ifdef for GPTDEVICE

* EFI_BOARD_TEST and EFI_JOYSTICK

* EFI_TLE8888

* Fix HIP9011_logic compilation

* ADC_CHANNEL_SENSOR

* Move ioportid_t PORTS[] to ports/*

* Fix simulator
2019-03-28 22:46:10 -04:00
andreika-git b7a9cc13bb Idle timing PID control & TPS-based VE table (#713)
* Add new config settings for idleTimingPidControl & TPSBasedVeTable

* Add dialogs for idleTimingPidControl settings

* Add dialogs for TPSBasedVeTable settings

* Share the code for getTargetRpmForIdleCorrection() and move it from idle_thread.cpp

* Implement TPSBasedVeTable

* Add PID to advance_map.cpp

* Implement idleTimingPidControl

* Make getAdvanceCorrections() visible to unit-tests

* Unit-tests! Yeah!
2019-03-22 22:55:51 -04:00
rusefi 8303dc7595 refactoring: no logic changes, just nicer variable and method names 2019-03-12 18:54:46 -04:00
dron0gus 68884cc4ae gpiochips API, core and unit test (#703)
* Add external gpiochips driver API and core

* gpiochips: add unit test
2019-03-12 10:12:37 -04:00
rusefi 80fbca6f30 docs 2019-03-04 00:14:55 -05:00
rusefi 0fbc8c7adc #699 2019-02-28 21:17:35 -05:00
rusefi 7796c4e72c #699 2019-02-28 21:09:31 -05:00
rusefi 870c4e9d15 #699
more googletest to unit tests
2019-02-28 20:31:48 -05:00
rusefi 1f2ac36ca4 #699 2019-02-28 19:48:38 -05:00
rusefi 1d9720e5e5 #699 2019-02-28 19:42:15 -05:00
rusEfi 0244ccb010 fix #698 2019-02-27 17:12:52 -05:00