FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
12,026 Commits 30 Branches 13 Tags 619 MiB
Commit Graph

665 Commits

Author SHA1 Message Date
rusEfi fbbac83010 v12 progress 2020-03-20 00:36:22 -04:00
Matthew Kennedy fa8036e4b6 fix (#1202) 
* fix test

* shrink memory
 2020-03-19 20:02:49 -04:00
rusEfi 5a21db41a4 v12 & ETB progress 2020-03-18 00:12:31 -04:00
rusEfi cb37a6f51d v12 2020-03-11 20:48:09 -04:00
rusefi bd34f5479a In case of incompatible firmware and console we have a vague error message fix #1180 2020-03-10 19:12:37 -04:00
rusefi 2ae15b5bab hard-coding miata Nb2 VVT Ratio magic 2020-03-09 16:59:19 -04:00
rusefi 7bbe4f791a date 2020-03-08 09:17:43 -04:00
rusEfi a0e838467a date 2020-03-07 15:55:08 -05:00
rusefi 0865b7be2e better invalid configuration handling 2020-03-05 21:16:45 -05:00
Matthew Kennedy a2a5b40ced Support disabling most/all features (#1162) 
* this flag did nothing

* guard features properly
 2020-02-26 18:16:35 -05:00
rusEfi c2ab5f4871 more mc33816 2020-02-25 22:38:08 -05:00
rusefi e2704a4525 minor progress 2020-02-22 13:04:19 -05:00
rusEfi e9ac797ac9 reviving FRANKENSO_QA_ENGINE 2020-02-18 17:53:56 -05:00
rusefi 2eec300251 miata vvt trigger decoding is broken #1145 2020-02-14 13:02:27 -05:00
rusEfi 21853eb500 FATAL error running MRE blinking test #1137 
still not the fix?
 2020-02-11 17:49:39 -05:00
rusEfi 3c874398ff tle8888 start-up clean-up 2020-02-09 20:41:25 -05:00
Matthew Kennedy a08946c2f5 Fix master (#1134) 
* Revert "something went very wrong."

This reverts commit e0fb325d5a.

* Revert "trying to fix build broken by "Sensor reconfiguration while running (#1131)""

This reverts commit 55e8ee5052.

* Revert "partial Revert of "Stricter compile options (#1132)""

This reverts commit b0d7cc9a22.

* temp prometheus fix

* fix bootloader

* fix batch files
 2020-02-08 16:34:29 -05:00
rusefi e0fb325d5a something went very wrong. 
first we have functional defects
that we do not write test to cover newly intdroduced defects
then attempts to fix defects do not compile
 2020-02-08 08:15:46 -05:00
960 580e725d11 Boost pr (#1114) 
* boost control

* cleanup

* Delete rusefi_config.txt

* Add files via upload

* Delete rusefi_config.txt

* Add files via upload

* Update rusefi.input

* Update boost_control.cpp
 2020-02-02 03:56:21 -05:00
rusefi a124e0b934 date & VVT test progress 2020-01-31 01:23:01 -05:00
rusefi d1a4b39a5a refactoring: de-coupling trigger decoder and engine 2020-01-26 03:48:25 -05:00
rusefi 59c293b548 trigger refactoring 2020-01-25 11:22:25 -05:00
rusefi f6ce9397db refactoring 2020-01-22 01:22:44 -05:00
rusefi 5529e7cebf date 2020-01-19 03:49:06 -05:00
rusefi 12600a3b06 date 2020-01-13 02:03:42 -05:00
rusefi 63e3e84e08 happy new year 2020-01-08 00:02:40 -05:00
rusefi 50d78f648b de-coupling things a bit 2019-12-24 00:26:23 -05:00
rusefi 4605c64a07 that's not a worth a file 2019-12-24 00:03:53 -05:00
rusefi ae615376ea refactoring 2019-12-23 23:32:43 -05:00
rusefi c629b21ab4 adding simplicity 2019-12-23 23:25:08 -05:00
rusefi 67e1f06d36 simplicity? 2019-12-23 22:50:04 -05:00
rusefi 0cede6673f adding simplicity 2019-12-23 22:40:23 -05:00
rusefi de480fe05e adding simplicity 2019-12-23 22:30:58 -05:00
rusefi 34e1d4c3c1 date & fresh integration 2019-12-22 08:24:47 -05:00
Matthew Kennedy df57b24e3f Shrink output channels, now with passing CI (#1077) 
* reorder fields

* temporary tle8888 fix

* comment, simplify

* hand tweak generated

* oops, those are reciprocal

* fix engineLoadAccelExtra

* aggressive priority order

* fix output size

* comments

* reorder fields, no sizes yet

* should've been signed

* simplify constructor mess, hook up scaling

* notes

* typo

* if -> switch

* rev signature

* correct map offset

* handle unsigned properly

* RPM is unsigned

* vss isn't scaled

* extract magic

* required generated for build

* de-scale rpm

* field type cases
 2019-12-22 08:12:45 -05:00
rusefi 5c679034a7 Revert "fresh integration & changing protocol versions & versions" 
This reverts commit 8a8ea6c0
 2019-12-21 15:02:37 -05:00
rusefi 8a8ea6c096 fresh integration & changing protocol versions & versions 2019-12-21 12:35:47 -05:00
Matthew Kennedy 4866a78e63 Re-shrink stacks (#1060) 
* small stacks

* giant servo stack

* reclaim ram
 2019-12-14 09:31:13 -05:00
rusefi 9bd5721033 great news about #1055 2019-12-13 23:07:56 -05:00
rusefi eafefe5b24 great news about #1055 2019-12-13 21:50:14 -05:00
rusefi 2c296c0f18 etbActualCount logic to handle the scenario where only one ETB is present 2019-12-13 12:50:34 -05:00
rusefi f47a1a16d1 getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi 34b32db032 straightening enum reuse 2019-12-10 21:18:35 -05:00
rusEfi 52c15a7d9b dual-ETB progress 2019-12-10 00:07:46 -05:00
rusefi a40477e598 Making UART/TTL pins configurable 2019-12-07 21:22:09 -05:00
rusefi 561986d3e4 The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
rusefi d5bfd76922 "sensor chart" for aux fast analog input 2019-12-02 20:31:49 -05:00
rusefi 34f53bd102 making things nicer with dual ETB settings 2019-11-30 17:38:33 -05:00
rusEfi 13d4ae2169 dual ETB seems to work! 2019-11-29 19:06:50 -05:00
rusefi 002a08316c steps towards dual ETB 2019-11-28 15:24:30 -05:00
rusefi 265727b7db steps towards dual ETB 2019-11-27 22:07:36 -05:00
rusefi 155ff25c22 MapAveragingCallback schedules all cylinders at once #974 2019-11-24 23:20:24 -05:00
rusefi 6efab3683c bug: aux valve actions can overlap 2019-11-23 10:34:43 -05:00
rusefi 8dddc62979 aux overlap debugging 2019-11-22 18:50:46 -05:00
rusEfi 7e78f077bc steps towards dual ETB 2019-11-21 00:49:38 -05:00
rusefi 95e8f4227b making F4 and else happier with perf_trace, also maybe missing 'break'? 2019-11-19 20:36:47 -05:00
Matthew Kennedy 8fd603dca9 Merge remote-tracking branch 'origin/master' into perf-tracing 2019-11-19 16:28:58 -08:00
rusefi 7dade5a878 v12 2019-11-17 22:32:27 -05:00
rusefi 1624346c97 v12 2019-11-16 16:00:50 -05:00
rusefi ef9ad935e0 poke 2019-11-14 10:23:11 -05:00
rusefi c3aa47195d todo 2019-11-13 22:02:13 -05:00
rusefi a23f6bb23e time to panic and revert more 2019-11-12 21:42:44 -05:00
rusefi 1ad591742b refactoring: time to unify digital pin API 
trying to fix build
 2019-11-12 19:04:33 -05:00
rusefi 7c453fb199 Strange INJ1 signal behavior (when the frequency of scheduler's timer is less than 1MHz) fix #996 2019-11-10 23:54:08 -05:00
andreika-git add26866f5 Industrial PID Controller (#1002) 
* Implement Industrial PID controller

* Test-Use PidIndustrial in alternator

* Meaningful unit-tests for PidIndustrial
 2019-11-10 13:04:27 -05:00
rusefi ca0984007d Strange INJ1 signal behavior (when the frequency of scheduler's timer is less than 1MHz) #996 
new advanced debugging: hardware pins
 2019-11-10 12:39:47 -05:00
rusefi 3b2d5c8c7f Missing dwell altogether in some corner cases #796 
only additional live data here
 2019-11-05 23:36:33 -05:00
rusefi 3357e41614 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 22:40:33 -05:00
rusefi e5bebe0f72 happy November 2019-11-03 23:38:00 -05:00
rusefi db24091933 60/2 VW trigger has running issue on 19/10/19 snapshot fix #986 2019-10-30 20:51:20 -04:00
rusefi 7dec2d3ad8 bugfix around verboseTriggerSynchDetails - 64 bits on stack was causing broken messages 2019-10-29 18:20:55 -04:00
rusefi 8155cf6234 reducing code duplication with prod code & fixing simulator 2019-10-29 16:57:55 -04:00
rusefi 1602bdbebc steps towards #975 2019-10-18 19:45:32 -04:00
rusefi b31d729ce3 date 2019-10-17 00:09:13 -04:00
Matthew Kennedy 6f3bfcb099 fix wwae (#980) 2019-10-17 00:06:54 -04:00
Matthew Kennedy 89ca9a0406 Merge remote-tracking branch 'upstream/master' into perf-tracing 2019-10-14 23:45:39 -07:00
rusefi 0535ac8e01 preparing for #974 
code comments & refactoring
 2019-10-15 01:27:19 -04:00
rusefi 6f8b82e8ed preparing for #974 
code comments & refactoring
 2019-10-14 18:32:16 -04:00
rusefi 791c1423b0 preparing for #974 
code comments & refactoring
 2019-10-14 09:09:08 -04:00
Matthew Kennedy 97d848bb3e profile all the things 2019-10-13 13:14:08 -07:00
Matthew Kennedy 076b10fcb6 experiment 2019-10-11 17:43:21 -07:00
rusEfi 4c95fbd43d pin conflict in MRE test config 2019-10-10 13:32:07 -04:00
rusefi c5f12fbcd9 I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 415de92543 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi 0aa7088f99 date 2019-10-06 00:39:50 -04:00
rusefi 9a961fd0c2 do not let "Use fixed baro corr from MAP" kill VE fix #960 2019-09-29 09:58:29 -04:00
rusefi 7d68b3d829 firing order 1-2-7-8-4-5-6-3 2019-09-28 10:25:57 -04:00
rusEfi d73d668a9e new command 'etb_freq X' 2019-09-27 23:37:40 -04:00
rusefi df64289fd5 ETB target is using integer values fix #945 2019-09-22 18:15:00 -04:00
rusefi e4878734a1 ETB target is using integer values #945 
refactoring - ADC mocking is a mess
 2019-09-22 17:19:08 -04:00
rusefi c6bca8e77a ETB target is using integer values #945 
refactoring - ADC mocking is a mess
 2019-09-22 10:02:07 -04:00
rusEfi b46c5b4960 ETB target is using integer values #945 
first we will write a unit test
 2019-09-22 07:58:03 -04:00
rusefi 2e492d22bf fixing build 2019-09-21 15:43:18 -04:00
rusefi ee074b9fe7 fixing build 2019-09-21 15:33:13 -04:00
Matthew Kennedy dfcc9dba04 add sensor framework, tests (#929) 
* add framework, tests

* move oil pressure to new way

* add init logic

* brackets on the same line

* spaces -> tabs

* spaces -> tabs for tests

* bracket on same line

* hook up sensor mocking

* add nan check

* fix nan check

* I wrote an essay

* casing

* only init if we have a sensor to init

* style, actually call init

* format

* fix casing

* typo

* implement linear sensor

* wire up producer

* smarter limiting

* setup comments

* add reporting

* doxyfile

* oops

* add adc subscription

* clarity

* fix logic

* multiply voltage

* test styling

* test guards

* remove dependencies

* linear sensor test

* remove unused

* fix merge

* format, implicit convert op

* explicit

* format tests

* fix merge
 2019-09-21 14:33:38 -04:00
rusefi aa8d0eb640 configurable SD card logging speed 2019-09-20 20:18:22 -04:00
rusefi 6457c05da5 thank you @andreika! 2019-09-20 08:44:20 -04:00
rusefi 13b74d3d4d unit tests progress 2019-09-20 00:46:35 -04:00
rusefi cac91ceac8 unit tests progress 2019-09-20 00:34:42 -04:00
rusEfi 4030b69594 NA8 2019-09-15 10:04:24 -04:00
rusefi f2a76ef0e2 pedal ADC should be faster #931 2019-09-13 19:55:20 -04:00
rusefi f0427360bf Delayed A/C compressor switch #922 2019-09-11 20:46:50 -04:00
rusefi 3389caa1e4 one step back :) instant RPM does not look right 2019-09-10 21:35:10 -04:00
rusefi 34fb2c21e1 simulator crashes on any TS setting change fix #924 2019-09-09 20:49:16 -04:00
rusefi 280271ab1e TLE8888: NB2 solution + reset counter 2019-09-05 10:01:59 -04:00
rusefi fe6b5d8c56 Live Data: trigger current gap 2019-09-03 19:30:51 -04:00
rusefi 7c0688969f make iTerm limits visible for idle RPM pid #913 2019-09-02 00:19:06 -04:00
rusEfi 8f10e85d03 mock PPS voltage command in addition to mock PPS position 
ETB pane progress
 2019-09-01 17:35:43 -04:00
rusefi 6318f2ac38 Live Data: more Idle & ETB data points! 2019-09-01 15:46:40 -04:00
rusEfi 3970881a09 ETB progress 2019-08-31 20:17:17 -04:00
rusefi 4a1b78f9a4 PID errorAmplificationCoef to LiveData 2019-08-30 17:11:12 -04:00
rusefi 02610104d5 progress towards idle unit test 2019-08-29 00:10:47 -04:00
rusefi 6df2afface cranking fuel live data fix #911 2019-08-28 00:29:55 -04:00
rusefi a8f7a8965b cranking fuel live data #911 2019-08-26 23:41:04 -04:00
rusEfi 92f371c121 new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
rusEfi a8d872800c MRE & Miata 2019-08-17 22:42:22 -04:00
rusefi 613e9b39e8 poke 2019-08-16 23:37:16 -04:00
rusefi fe43256c91 ETB live docs 2019-08-15 21:01:04 -04:00
rusefi 8bdf4f30ae refactoring: ChibiOS now offers native 'lockAnyContext' pattern 2019-08-11 15:23:15 -04:00
rusefi 67fd81b3df poke 2019-08-10 00:54:26 -04:00
rusefi 946374184e WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898 2019-08-08 23:11:56 -04:00
rusEfi 9ddc9233ee NA6 & trigger 2019-08-06 22:17:18 -04:00
rusEfi 1e64c5a67f MRE test setup 2019-08-05 23:00:35 -04:00
rusefi ba52eba47a software jump to DFU #809 
very very dark magic it is
 2019-08-04 00:21:44 -04:00
rusEfi 475377dcfc DFU command & refactoring 2019-08-03 19:58:38 -04:00
rusefi d57779b686 F7 nucleo does not work? 
funny, it was about some very unused feature
 2019-08-02 01:36:02 -04:00
rusefi bf6bbdc190 software jump to DFU #809 2019-07-28 12:33:47 -04:00
rusefi 8f6ef7976c CBR600 trigger progress 2019-07-23 19:22:40 -04:00
rusefi 733478bd8a live docs for idle state 2019-07-21 18:34:37 -04:00
rusefi cc6257bf5c trigger counters to formula, docs & improvements 2019-07-20 14:56:56 -04:00
Matthew Kennedy a2f2a677b4 Remove warmup afr pid (#879) 
* config changes

* actually remove from config

* rip out implementation
 2019-07-18 18:26:18 -04:00
rusefi f48a24e71f having fun with async - reducing threads 2019-07-13 11:08:17 -04:00
rusefi e05952fa4f having fun with async - reducing threads 2019-07-13 11:06:03 -04:00
rusefi dcf0b3c867 removing a pointless thread 2019-07-13 10:36:31 -04:00
rusefi b0a531b4ec having fun with async - reducing threads 2019-07-13 10:24:23 -04:00
rusefi c8e3378ff7 Annotations in C++ code to produce formulas in rusEfi console #807 
typo & refactoring: splitting class
 2019-07-12 23:15:52 -04:00
rusefi e202ceaa1e Annotations in C++ code to produce formulas in rusEfi console #807 … 
refactoring wall wetting
 2019-07-12 22:36:54 -04:00
rusefi 756dec106a support multiple VVT sensors #885 
new fields & packing configuration. bumping configuration version
 2019-07-12 14:24:45 -04:00
rusefi 6c7870d1b5 we have some space! 2019-07-10 02:21:47 -04:00
rusefi f8bc3baa91 refactoring: wider usage of new periodic task 2019-07-09 16:08:49 -04:00
rusefi c15df2f16c Periodic timer controller (#875) 
* More than one aux pid #866

* More than one aux pid #866

* More than one aux pid #866

* More than one aux pid #866

* More than one aux pid #866
 2019-07-09 08:33:40 -04:00
rusefi e2a5e11616 More than one aux pid #866 
refactoring
 2019-07-07 19:59:48 -04:00
rusefi 6208f7579d reviving F4 compilation 2019-07-06 21:02:48 -04:00
rusefi 2c515f13a9 user is unable to start with zero fuel - at least showing a warning 
https://rusefi.com/forum/viewtopic.php?p=33761#p33760
 2019-07-06 20:45:47 -04:00
rusefi 52a0ce8c72 refactoring: consistency & removing unused parameter 2019-07-06 20:24:47 -04:00
rusefi 5bdb7f7155 minor refactoring 2019-07-06 20:16:14 -04:00
rusefi 5d2afd2331 refactoring: better file name 2019-07-06 20:15:49 -04:00
rusefi 777eb532dc Refactoring: OS access should be explicit #867 2019-07-03 21:48:04 -04:00
rusefi 2164661274 undoing wrong fix & better fix for #805 
also generator logging improvements
This reverts commit 96270758c9.
 2019-06-30 14:28:47 -04:00
rusefi adae026788 https://rusefi.com/forum/viewtopic.php?f=10&t=442&p=33587#p33584 
better support for pretty noisy trigger (?)
 2019-06-25 20:51:29 -04:00
rusefi c6bcb85a45 fresh ini 2019-06-23 09:25:04 -04:00
rusefi 96270758c9 "Calibrate TPS" broken in TS fix #805 2019-06-17 22:00:34 -04:00
rusefi 0b843819eb TPS Live Documentation 2019-06-17 21:37:11 -04:00
rusefi 5a0d2413f5 removing dead text protocol support 2019-06-16 17:13:11 -04:00
rusefi 8ea5d687aa idle using ETB #783 2019-06-15 13:33:14 -04:00
rusefi bd80315737 bumping configuration version in light of #773 2019-06-14 13:04:04 -04:00
rusefi e309b8266c we need TLE8888 driver #714 2019-06-08 15:25:28 -04:00
rusefi f322d6f753 better status code 2019-06-07 19:14:55 -04:00
rusefi 8456bd3c23 reviving tle8888 configuration 2019-06-05 22:32:30 -04:00
rusefi 2901d9f902 nicer pin names for messages while same short names for engine sniffer 2019-05-15 04:26:41 -04:00
rusefi cbc1aef722 more PROD code into unit test 2019-05-12 20:31:28 -04:00
rusefi deead8f8ff reducing code duplication with unit tests 2019-05-12 20:24:35 -04:00
rusefi 8b74476c1b BUG: phase sensor validation attending - detect missing CAM signal fix #659 2019-05-11 00:21:37 -04:00
rusefi 91c404b353 FEATURE REQ: aux temperature inputs #332 2019-05-09 19:39:21 -04:00
rusefi 2d0d4bccb1 Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778 2019-05-07 21:39:11 -04:00
rusefi 8a90297160 refactoring: better method name 2019-05-07 19:32:08 -04:00
rusefi 7fc699fce2 Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778 
metric progress
 2019-05-07 19:16:01 -04:00
rusefi 2c24571ddb dreams of two ETBs 2019-05-05 12:02:42 -04:00
rusefi e359ddbb25 MC33816 integraion #784 
progress
 2019-05-03 21:54:38 -04:00
rusefi 762feb1b03 console usability: engine sniffer jitter fix #780 2019-05-02 18:42:59 -04:00
rusefi b34bdf5bcb docs 2019-05-02 17:52:48 -04:00
rusefi 40e1995e7f FSIO to allow smart output pins 2019-05-01 22:26:07 -04:00
rusEfi 892be38a03 ETB tiny progress 2019-04-30 19:22:12 -04:00
rusefi ded9b017e1 PID - fix dTime usages fix #776 2019-04-26 00:45:53 -04:00
rusefi ea86d987c8 PID - fix dTime usages #776 2019-04-25 21:31:33 -04:00
rusefi 09fea8b7f9 progress 2019-04-23 23:19:12 -04:00
rusefi fb30089d89 USB and TLE8888 not working for F4 or F767 #764 
this RAM would be needed to run three smart SPI threads
 2019-04-20 17:35:24 -04:00
rusefi 3732eedbf0 The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-04-15 21:09:43 -04:00
rusefi d67f3dc6e1 we need TLE8888 driver #714 2019-04-14 08:20:25 -04:00
rusefi 334b5d1992 steps towards smarter gpio 2019-04-13 12:02:34 -04:00
rusefi 884c54a185 defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi 76d3630588 ETB using tle7209 #746 2019-04-11 23:21:16 -04:00
rusefi c0a8c2e80f The Big Refactoring of 2019: folder structure #723 2019-04-09 23:00:17 -04:00
rusefi 19917361a2 FATAL error loading TS project 
fix #736
 2019-04-09 22:15:55 -04:00
dron0gus 12e07bc3ab Some more include fixes for linux (#738) 
* Some more include fixes for linux

* Pass cross-compile path through CROSS_COMPILE

* Lower-upper case conversion fixes for linux
 2019-04-10 01:12:35 +02:00
rusefi acf1216ab0 rusEfi settings editor is broken for one byte enums fix #709 2019-04-08 11:57:16 -04:00
rusefi dae6638b62 rusEfi settings editor is broken for one byte enums #709 2019-04-08 11:19:07 -04:00
rusefi 9a84db26af release notes 2019-04-07 12:27:59 -04:00
rusefi df62ae6a4b The Big Refactoring of 2019: folder structure #723 2019-04-05 01:41:24 -04:00
rusefi 540e0a2c85 The Big Refactoring of 2019: console vs TS vs CONSOLE_MODE_SWITCH_PIN vs text protocol #725 2019-04-01 11:16:19 -04:00
rusefi 59d33c4cdc The Big Refactoring of 2019: folder structure #723 2019-03-31 17:44:34 -04:00
rusefi 581d3d0c1b The Big Refactoring of 2019: folder structure #723 2019-03-31 17:14:53 -04:00
rusefi c29e6d99c4 The Big Refactoring of 2019: folder structure #723 2019-03-31 16:56:13 -04:00
rusefi e28ce71bb8 unifying_file_naming 2019-03-29 09:11:13 -04:00
rusefi 1f81aa169a we need TLE8888 driver #714 2019-03-25 20:30:36 -04:00
rusefi e7660a9090 overall usability progress 2019-03-12 14:35:49 -04:00
rusEfi 90bf18bcd7 better Electronic Throttle body control #493 2019-03-09 23:31:47 -05:00
rusefi 78c87195c8 ETB_BENCH_ENGINE 2019-02-27 08:55:56 -05:00
rusefi 34aa05cda9 refactoring: reducing code duplication 2019-02-23 12:33:49 -05:00
rusefi d8c0a5cf49 fix #688 2019-02-23 08:52:12 -05:00