Commit Graph

311 Commits

Author SHA1 Message Date
Andrey 3d096b2ac1 totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
Andrey df2b073c49 totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
Andrey e57403618a totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:33:17 -05:00
Matthew Kennedy 5471321363 don't warn if we intentionally skipped this spark (#4961)
* don't warn if we intentionally skipped this spark

* header

* real nb2
2023-01-10 19:07:44 -05:00
Matthew Kennedy 54e711a705 detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
Andrey 4c1f456c6b symmetrical shapes are not rendered right #4956 2023-01-08 22:37:35 -05:00
rusefillc d3e41b311e refactoring 2023-01-08 22:30:57 -05:00
rusefillc cc9da420d3 sweet 4g93 data 2023-01-07 17:31:13 -05:00
Andrey a699e29c02 Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy 56aa0fe367 improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
Andrey ae13e1a000 Mitsubishi 4G93 Trigger issues #4918
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey 0337cb44ac Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey 7c10ac7507 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey bdffec4ce5 let's try again 2023-01-03 08:38:42 -05:00
Andrey eb9c096ab7 a bit of dead code 2023-01-03 07:49:17 -05:00
Matthew Kennedy 2118aaff60 Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 29db8e2474 Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 5576065eb9 default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy e801ffc979 fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi 5c32f75c2c reducing ugly 2022-11-06 21:28:38 -05:00
Andrey 25d292c462 trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc cc7af64ed3 minor trigger refactoring 2022-11-06 00:59:29 -04:00
Andrey ea0a054dfc Nissan defaults 2022-11-02 12:05:51 -04:00
Matthew Kennedy 1cc46a1b83 simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc 9c75704412 triggerImage: todo: support symmetrical crank 2022-10-16 10:33:38 -04:00
rusefillc 5590b55273 triggerImage: todo: support symmetrical crank 2022-10-16 02:59:57 -04:00
rusefillc fc66b45ce4 triggerImage: todo: support symmetrical crank 2022-10-16 02:44:57 -04:00
Matthew Kennedy 14b92612e2 fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy f07c00548b 2jz test (#4638) 2022-10-05 20:48:28 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy 60fc30d34d remove 898 (#4634)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy f2c8a0192c fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 90489edb96 schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy 6f5bed28d9 better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy dbf8a1ea2a #4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey 24cf41c5f7 Honda K cam wheels #3405 2022-09-25 00:26:42 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 178fe15760 more inclusive configuration name 2022-09-24 23:49:41 -04:00
Andrey 4653cde601 K progress 2022-09-24 23:18:57 -04:00
Andrey 63fe1120bd fancy default and reusing constant 2022-09-24 23:01:42 -04:00
Andrey 533d30efd1 fancy 2022-09-24 22:54:58 -04:00
Andrey d497d99a8c K 2022-09-24 15:37:51 -04:00
Andrey e7e9742ba9 refactoring: extract constant 2022-09-24 15:33:01 -04:00
rusefillc c6a2f2657b honda K enum rename 2022-09-23 20:13:14 -04:00
rusefillc 08499c7252 K20 2022-09-23 20:13:14 -04:00
rusefillc 04ac7fcd3b K20 2022-09-23 18:25:24 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00