Matthew Kennedy
d5f9479f28
ObdCode is enum class ( #77 )
...
* change ObdCode to enum class builds firmware
* test builds
* don't need this line at all
* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy
d6534157a0
rename obd_code_e -> ObdCode
2023-04-11 16:32:47 -07:00
Matthew Kennedy
2f85cd60d4
use ECU-calculated blend table axis values
2023-04-02 13:56:42 -07:00
Matthew Kennedy
1bc1e76efa
blend result returns blend parameter value for TS UI
2023-04-02 13:50:34 -07:00
Matthew Kennedy
f090a97b0b
remove specs_s struct, flatten config
2023-03-27 00:58:18 -07:00
rusefillc
2d9298e586
ohhh we already have FO_1_2_3_4_5_6_7_8
2022-12-20 21:23:25 -05:00
rusefillc
f49cae527c
FO_1_2_3_4_5_6_7_8
2022-12-20 21:13:33 -05:00
rusefillc
d951f36794
guards
2022-12-17 14:36:27 -05:00
Matthew Kennedy
7b47e77e58
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
rusefillc
6402e61484
minor trigger refactoring
2022-11-05 22:30:08 -04:00
Matthew Kennedy
acec8f2da3
VE blend tables ( #4640 )
...
* blendy ve too
* ui
* small optimizations
* save kinetis memory
* changelog
2022-10-19 06:42:22 -04:00
Matthew Kennedy
0dfba2a655
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Andrey
b439f27284
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
34f87a3683
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
110c49949d
some dead nonsense
2022-09-14 01:15:26 -04:00
Andrey
d256fd2b01
removing dead parameter
2022-09-14 01:13:57 -04:00
Andrey
b059e9defb
tear down Engine god object #4511
...
just trying different things
2022-09-14 01:09:32 -04:00
Andrey
ab3d92b995
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
54ac7279b1
refactoring: reducing outputChannels copy
2022-09-01 00:13:55 -04:00
Matthew Kennedy
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit 5454b8f509
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
cf51533f45
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
rusefillc
c557b4ec30
Revert "Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150"
...
This reverts commit 086b4885c9
.
2022-05-08 07:10:54 -04:00
rusefillc
086b4885c9
Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150
2022-05-08 07:07:34 -04:00
Andrey
03662e48c4
Move curves out of engineConfiguration in order to reduce RAM usage #4127
2022-05-01 23:43:43 -04:00
Matthew Kennedy
2d033df11b
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
rusefillc
089d7f5cd1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
Matthew Kennedy
5cf2b1bba5
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
Matthew Kennedy
fae8b9ec06
clean up timing table defaults ( #3705 )
...
* less crazy configs
* cleanup
* make that test happy
2021-12-20 08:02:38 -05:00
Andrey
faa29f0dc2
2 byte table axis #3045
...
fixing build
2021-12-20 01:50:23 -05:00
Matthew Kennedy
b2af3637a2
simplify cylinder phasing ( #3650 )
2021-12-05 10:46:35 -05:00
Scott Smith
659cc68be1
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Matthew Kennedy
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
rusefillc
5ddd516860
refactoring - magic constant bad
2021-11-07 00:09:17 -04:00
rusefi
353782ad9c
this warning should be promoted to fatal!
2021-10-26 17:10:53 -04:00
Matthew Kennedy
dab377d15d
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
rusefillc
613ef6fe21
OBD error renames
2021-10-03 01:30:42 -04:00
rusefillc
dc8caa20bc
more firing orders!
2021-09-18 00:18:06 -04:00
Matthew Kennedy
3a8d92f879
Dwell voltage correction ( #3234 )
...
* cfg + impl
* ui
* value_or
* changelog
* fix
2021-09-15 08:07:33 -04:00
rusefillc
f33132af9e
firing order for some 911
2021-08-24 07:31:55 -04:00
rusefillc
76dc085abf
firing order for some 911
2021-08-24 07:28:56 -04:00
Matthew Kennedy
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Andrey
35f631984d
VH41DE (Japaneese Y32 Variant) firing order
2021-07-20 21:16:51 -04:00
Matthew Kennedy
e3849b95d5
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Andrey
cbe407f465
VAG canned tunes
2021-07-08 20:42:35 -04:00
Matthew Kennedy
110322d353
store cylinder count as plain number ( #2915 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* no need to be a typedef
* paste in actual cylinder count
2021-07-07 08:31:05 -04:00
Matthew Kennedy
717d4dd7ac
Unified cyl count macro ( #2914 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* console needs help
2021-07-06 20:14:08 -04:00
Matthew Kennedy
322f69474f
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
Matthew Kennedy
047f62b2b9
remove deprecated getEngineLoadT ( #2676 )
...
* remove
* few more
2021-05-10 08:30:41 -04:00
Matthew Kennedy
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00