Commit Graph

1241 Commits

Author SHA1 Message Date
Matthew Kennedy d5f9479f28
ObdCode is enum class (#77)
* change ObdCode to enum class builds firmware

* test builds

* don't need this line at all

* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy fa41247fde ancient history dead histogram 2023-04-11 17:02:56 -07:00
Matthew Kennedy d6534157a0 rename obd_code_e -> ObdCode 2023-04-11 16:32:47 -07:00
Matthew Kennedy b7fe618db8 s 2023-04-11 13:51:32 -07:00
Matthew Kennedy 323d61d90b sensor checker wasn't checking sensors 2023-04-11 13:47:30 -07:00
Matthew Kennedy 416cfa1a92 happy tests 2023-04-02 02:09:35 -07:00
Matthew Kennedy c682c49d46 register/unregister 2023-04-01 23:17:50 -07:00
Matthew Kennedy 82794403f8 gear detection in to the sensor model 2023-04-01 23:08:06 -07:00
Matthew Kennedy b9d065ae4e more dead stuff 2023-03-31 23:11:01 -07:00
Matthew Kennedy f090a97b0b remove specs_s struct, flatten config 2023-03-27 00:58:18 -07:00
Matthew Kennedy bdeeb82f93 better idle VE table transition 2023-03-27 00:42:56 -07:00
Matthew Kennedy cb0e81b062 support abs+gauge+diff fuel pressure #32 2023-03-25 13:53:16 -07:00
Matthew Kennedy 3d72c297b7 exact miata test 2023-03-17 14:54:50 -07:00
Matthew Kennedy c47d7394c5 convert throttle model to g/s instead of kg/s 2023-03-16 01:19:03 -07:00
Matthew Kennedy d14d442157 throttle model tests 2023-03-13 15:43:39 -07:00
Matthew Kennedy 7ee63df142 Throttle model #63 2023-03-13 13:25:45 -07:00
Matthew Kennedy df03f3c536
Fix afr dropdown, switch AFR to sensor model (#62)
* move presets to ini, like clt/iat

* call deinit

* init lambda using proper sensors

* raw output channel

* init lambda test

* ve blend 1 should use bias table 1, good eye @nmstec
2023-03-09 11:25:30 -08:00
Matthew Kennedy 4a8ff4dcc0 test 2023-03-01 17:27:53 -08:00
Matthew Kennedy 0072e8f33c nobody should use NA6 VAF 2023-02-28 20:04:47 -08:00
Matthew Kennedy a2652d31dc invert vvt in one spot, like trigger 2023-02-28 13:13:29 -08:00
Matthew Kennedy b6e3f105df state sequence api doesn't use triggervalue #55 2023-02-28 02:25:38 -08:00
Matthew Kennedy d7681bf194 no TriggerValue for vvt: #55 2023-02-28 02:11:28 -08:00
Matthew Kennedy 56c5b8d2e9
remove displayLogicLevelsInEngineSniffer (#56)
* configs

* remove displayLogicLevelsInEngineSniffer

* test
2023-02-28 01:57:50 -08:00
Matthew Kennedy cd99553fbf test 2023-02-26 15:52:37 -08:00
Matthew Kennedy 6c2e4f00f6 test 2023-02-25 01:34:23 -08:00
Matthew Kennedy 4cd08fbc4b
table-only map fallback (#46)
* table-only map fallback

* InSequence
2023-02-23 15:05:56 -08:00
Matthew Kennedy 8b5337f0a5 camOffsetAdd 2023-02-23 13:29:03 -08:00
Matthew Kennedy 711e90f3d3
remove old trigger noise detector (#44)
* remove old noiseless decoder layer

* test
2023-02-23 11:27:56 -08:00
Matthew Kennedy 959f14fae6 more dead 2023-02-21 11:54:24 -08:00
Matthew Kennedy bc4d1127bc etb style idle valve 2023-02-20 22:56:26 -08:00
Matthew Kennedy 0e12622371 cdm ion 2023-02-20 22:37:14 -08:00
Matthew Kennedy 666a41e496 hip9011 2023-02-20 22:29:48 -08:00
Matthew Kennedy fd09ad7b4f cj125 2023-02-20 22:21:52 -08:00
Matthew Kennedy 961950dbcc gps 2023-02-20 22:07:21 -08:00
Matthew Kennedy 61c17791b8 joystick, lcd 2023-02-20 21:54:10 -08:00
Andrey 55ac54019d making test stronger 2023-02-20 22:25:24 -05:00
Andrey 149428c8b9 just more test, does not help :( 2023-02-20 20:37:40 -05:00
Andrey 20beb1129b just a rename 2023-02-20 20:37:39 -05:00
Andrey 08f3f2e953 Feb20: 3rd ticket for 4g9x mess #5111
adding lightness
2023-02-20 18:22:51 -05:00
Andrey 0f16637767 minor bugfix 2023-02-18 23:58:06 -05:00
Andrey 11e3cb3d8d TDD for minor bug 2023-02-18 23:14:02 -05:00
rusefi bfcd5953e1 DC is not ETB 2023-02-18 22:39:45 -05:00
Andrey 85e0e3cbce Nick wonders if DC wastegate is still FUBAR #5075 2023-02-17 22:17:09 -05:00
Matthew Kennedy 4b5fa68d13 fix 4g63 vs 9x naming, add cam-only test (#5093) 2023-02-16 23:22:34 -05:00
Nathan Schulte de28fefde4 explicit RedundantSensor redundancy unit tests (#5085) 2023-02-16 07:18:18 -05:00
Matthew Kennedy aaa3ea2d3e remove useETBforIdleControl (#5054)
* remove useETBforIdleControl

* etb integrated

* jni weirdness
2023-02-12 16:49:12 -05:00
Matthew Kennedy 03daac572e more flexible GPPWM (#5032)
* gppwm improvements!

* test

* ui

* autoscale
2023-02-06 08:53:31 -04:00
Matthew Kennedy 34430f251f rewrite neon trigger (#5003)
* rewrite neon trigger

* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Matthew Kennedy dc4cbb9c37 mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
Matthew Kennedy abffa262c2 emit v2 mlg (#4979)
* emit v2 mlg

* missed a spot

* s

* s

* binary log unit test

* sd generator test

* oop

* getcategory

* write zeroes instead of null pointer in case of no category
2023-01-21 07:31:40 +05:30
rusefillc 65b06d1f2f h-bridge wastegate not alive on bench #4965
fixing master
2023-01-18 02:12:34 -05:00
Andrey 3d096b2ac1 totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
Andrey df2b073c49 totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
Andrey e57403618a totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:33:17 -05:00
Matthew Kennedy 5471321363 don't warn if we intentionally skipped this spark (#4961)
* don't warn if we intentionally skipped this spark

* header

* real nb2
2023-01-10 19:07:44 -05:00
Matthew Kennedy 54e711a705 detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
Matthew Kennedy c86f75ec78 Jammed ETB detection (#4873)
* jammed ETB detection

* autoscale

* comment

* cleanup

* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey 4c1f456c6b symmetrical shapes are not rendered right #4956 2023-01-08 22:37:35 -05:00
rusefillc d3e41b311e refactoring 2023-01-08 22:30:57 -05:00
rusefillc cc9da420d3 sweet 4g93 data 2023-01-07 17:31:13 -05:00
Andrey a699e29c02 Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy 56aa0fe367 improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
Andrey ae13e1a000 Mitsubishi 4G93 Trigger issues #4918
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey 0337cb44ac Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey 7c10ac7507 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey bdffec4ce5 let's try again 2023-01-03 08:38:42 -05:00
Andrey eb9c096ab7 a bit of dead code 2023-01-03 07:49:17 -05:00
Andrey 00e8cc4262 test coverage for antilag #4920
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey 36573a3044 test coverage for antilag #4920
bugfix?
2022-12-30 12:21:04 -05:00
Andrey 6a3c7d20e7 test coverage for antilag #4920 2022-12-30 12:17:53 -05:00
Andrey 13c3699415 test coverage for antilag #4920 2022-12-30 12:11:57 -05:00
rusefillc 6ec6b0b82a refactoring: method name 2022-12-27 00:13:13 -05:00
rusefillc 1e04153867 random Frankenso clean-up 2022-12-14 19:29:01 -05:00
Matthew Kennedy 2118aaff60 Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 29db8e2474 Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 016b71babe switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
rusefillc c0daffda1d reduce flash footprint by smarter code generation #4163 2022-12-03 00:51:41 -05:00
Matthew Kennedy ecee1dd02d ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey db8f7c48f3 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey 9641d08d67 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 20:08:19 -05:00
Andrey a6432feae7 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
rusefi 475c177f78 x2 spelling 2022-11-30 17:14:16 -05:00
Andrey 47aac2b46e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Matthew Kennedy 5576065eb9 default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Andrey 4a7a48779d ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 7547edb566 mock invalid & current state of ETB error counter 2022-11-29 20:36:03 -05:00
Andrey b97745496e refactoring: extracting method 2022-11-29 20:11:34 -05:00
Andrey ca63f37d9e ETB duty cycle jitter #4833
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey 8a3727de3e ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 73e309da03 ETB duty cycle jitter #4833 2022-11-29 14:02:44 -05:00
Andrey 82a3074cbd ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey d7cdf75e22 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey a14fb947c2 exp average is pretty cool 2022-11-28 19:22:45 -05:00
Andrey ac12287ab0 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey c5a5d7f6eb ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey e1d3647401 ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc c729b10bbe refactoring: constexpr fuel computer (#4830)
* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc d63f1af40d without ValueProvider3D interface how do we mock? (#4829)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey f32ae379f5 nissan 2022-11-23 23:45:25 -05:00
rusefillc 261222bb04 avoid ctime in GPS UART (#4824)
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00