Matthew Kennedy
d3d2762847
adjust taper behavior ( #3051 )
...
* adjust taper behavior
* check that taper works in running state too
2021-07-24 16:12:07 -04:00
Matthew Kennedy
16dac2e47c
Disable closed loop idle during cranking->running taper ( #2900 )
...
* implement
* dead file?
* implement tests
* new phase
2021-07-06 08:47:06 -04:00
Matthew Kennedy
d69fc86f26
explicitly set mock vss to test ( #2905 )
2021-07-04 17:52:45 -04:00
Matthew Kennedy
3247d4de00
Gate closed loop idle on road speed ( #2901 )
...
* implement
* test
* b
* config
2021-07-04 09:35:12 -04:00
Matthew Kennedy
63524c3f34
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
Matthew Kennedy
0c0957f52a
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
Matthew Kennedy
f21fa3e652
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
Matthew Kennedy
1f3cbd67ad
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
Matthew Kennedy
6fbdb3c2d0
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
Matthew Kennedy
1b607faeba
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
Matthew Kennedy
86d3746453
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
rusefillc
7c38714129
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit f1ee8b43
2020-12-31 12:22:54 -05:00
Matthew Kennedy
f1ee8b431e
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
Matthew Kennedy
560061e251
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
Matthew Kennedy
93cc1e84c3
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
Matthew Kennedy
d3cbed60af
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
rusefillc
2d3ddcde9d
Starter seems to be engaged forever #1965
2020-11-18 22:47:40 -05:00
rusefillc
2af3cdf70e
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
Matthew Kennedy
605269c358
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
David Holdeman
e8e2cf2cfd
DebounceButton A/C switch ( #1782 )
...
* change acSwitch name, add mode
* fix
* remove some adc stuff
* remove some adc stuff
* semicolon stupid
* left behind
* add readpinstate
* wrong var name
* add functions back
* fix name
* bool, not void, plus fix name
* move
* not sure what I broke
* try setMockValue
* namespace
* whoops missed one
* switch values because adc was set up for pullup
* try 5
* comment for now
* comment for now
* uncomment tests, add function to mock, add mock to efiReadPin
* fixes
* for F's sake
* if
* add defy
* pass params
* use ASSERT_TRUE/FALSE
* advance time
* remove ifdef from readPin
* try moving if
* move to separate func
* move extern
* move include
* try engine_test_helper
* am confuse
* move func to else
* include hal
* add efi prod check
* remove include
* try extern
* move include
* semicolon stupid
* move extern again
* include
* move mockPinStates
* size
* add if
* add comment
* clean on instantiation
2020-09-10 22:16:20 -04:00
rusefi
6b2c1d4d59
NA6 progress
2020-07-29 22:48:41 -04:00
rusefi
93f85b0b93
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
rusefi
8bcd46291f
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
rusefi
bd39351055
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
andreika-git
8b84243dae
Gen config refactor 2 ( #1560 )
...
* gen_config refactor, part II
* short board defines
* oops
* comment & undef
* define QUOTE
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
rusefi
21c35874a5
idle_min through FSIO not working as intended #1553
2020-07-01 20:45:37 -04:00
Matthew Kennedy
942403cec2
Fuel/ign correctino on new temp sensors ( #1318 )
...
* corrections
* test
* adv map
* tests
* cleanup
* lcd
* fsio
* unneeded
* more math
* last consumer
* cleanup
* fix kinetis
2020-04-18 18:45:30 -04:00
Matthew Kennedy
83592f0dff
New clt consumers part 1 ( #1301 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
2020-04-15 09:48:17 -04:00
Matthew Kennedy
9a21262cf8
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
Matthew Kennedy
6d8eedf9ca
Split out EtbHardware ( #1168 )
...
* start tear out motor
* fix
* nuke reconfig
* guard for test
* test fixing
* format, condense headers
* fix todos
* undo todo
* format
2020-03-03 17:56:50 -05:00
rusefi
63e3e84e08
happy new year
2020-01-08 00:02:40 -05:00
rusefi
27f617686b
progress towards ETB controller mocking
2019-12-13 13:52:34 -05:00
rusefi
f47a1a16d1
getting rid of boardConfiguration / binary compatible change
2019-12-11 17:48:55 -05:00
rusefi
eb59a41724
extracting pid test to separate file
2019-09-29 14:36:41 -04:00
rusefi
0d35b1ebba
reducing hell in unit tests
2019-09-25 08:40:33 -04:00
rusefi
df64289fd5
ETB target is using integer values fix #945
2019-09-22 18:15:00 -04:00
rusefi
42f085a4a0
ETB target is using integer values #945
...
now we have a unit test! now we can fix the issue :)
2019-09-22 17:58:27 -04:00
rusEfi
b46c5b4960
ETB target is using integer values #945
...
first we will write a unit test
2019-09-22 07:58:03 -04:00
rusefi
13b74d3d4d
unit tests progress
2019-09-20 00:46:35 -04:00
rusefi
cac91ceac8
unit tests progress
2019-09-20 00:34:42 -04:00
rusefi
d83ed085e8
unit tests progress
2019-09-19 22:56:54 -04:00
rusefi
317ec8d752
unit tests progress
2019-09-19 08:05:23 -04:00
rusefi
8ef1fcd344
unit tests progress
2019-09-18 21:48:46 -04:00
rusefi
d576f3ba1f
Delayed A/C compressor switch #922
...
unit tests skeleton
2019-09-12 07:31:13 -04:00
rusefi
6043c93372
WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
...
fancy smansy unit test with some C++11
2019-08-08 21:27:57 -04:00
rusefi
998345ef9e
unit tests should not have global context, including mock values
2019-05-27 15:56:12 -04:00
rusefi
e557a30193
messing with TPS mocking
2019-05-27 14:21:12 -04:00
andreika-git
b7a9cc13bb
Idle timing PID control & TPS-based VE table ( #713 )
...
* Add new config settings for idleTimingPidControl & TPSBasedVeTable
* Add dialogs for idleTimingPidControl settings
* Add dialogs for TPSBasedVeTable settings
* Share the code for getTargetRpmForIdleCorrection() and move it from idle_thread.cpp
* Implement TPSBasedVeTable
* Add PID to advance_map.cpp
* Implement idleTimingPidControl
* Make getAdvanceCorrections() visible to unit-tests
* Unit-tests! Yeah!
2019-03-22 22:55:51 -04:00
rusefi
8303dc7595
refactoring: no logic changes, just nicer variable and method names
2019-03-12 18:54:46 -04:00
rusefi
c60c8ce777
better (?) variable names
2019-02-10 22:47:49 -05:00