Commit Graph

76 Commits

Author SHA1 Message Date
rusefi 66f8d0e8f8 it has been almost two years we cannot be compatible forever 2022-11-13 20:05:04 -05:00
GitHub gen-configs Action cdcc94bb02 Auto-generated configs and docs 2022-11-06 00:28:03 +00:00
Matthew Kennedy 32b170810e duplicate log field names (#4730)
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
GitHub gen-configs Action 6eedad82c1 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 651101e6bc Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
Matthew Kennedy 890a8e0fed implement "ford mode" injector correction (#4686)
* implement "ford mode"

* missed the enum value
2022-10-20 22:25:39 -04:00
Andrey 93032c7c1f tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey e56924310b tear down Engine god object #4511
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc 78b28c8f90 typo 2022-09-03 07:26:49 -04:00
GitHub gen-configs Action 59543fa221 Auto-generated configs and docs 2022-09-02 18:42:52 +00:00
rusefillc 54e05ba0fc moving state into specific class (#4520)
* moving state into specific class

* moving state into specific class
2022-09-02 14:38:03 -04:00
rusefillc 0e27ec6633 another huh (#4517)
* another huh

* why does this not compile
2022-09-02 13:10:21 -04:00
rusefillc f8e37e6af7 I am sure that's not magic (#4516)
* I am sure that's not magic

* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey 074e5c840b Revert "tear down Engine god object #4511"
This reverts commit 3094cc6be7.
2022-09-01 20:44:51 -04:00
Andrey b017ef8031 Revert "tear down Engine god object #4511"
This reverts commit 2d689f5a5a.
2022-09-01 20:44:51 -04:00
Andrey 2d689f5a5a tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 3094cc6be7 tear down Engine god object #4511
just trying different things
2022-09-01 20:15:46 -04:00
Andrey 05e851c138 tear down Engine god object #4511
just trying different things
2022-09-01 19:24:19 -04:00
GitHub gen-configs Action 8785db9762 Auto-generated configs and docs 2022-09-01 23:18:26 +00:00
Andrey c9008214f5 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Andrey d1917a2a62 tear down Engine god object #4511
just trying different things
2022-09-01 19:00:16 -04:00
Andrey 80fa25488a tear down Engine god object #4511
smallest step maybe forward
2022-09-01 13:55:03 -04:00
GitHub gen-configs Action f19c219587 Auto-generated configs and docs 2022-09-01 15:03:34 +00:00
Andrey 436c294770 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
GitHub gen-configs Action bac4f9800f Auto-generated configs and docs 2022-09-01 14:39:52 +00:00
Andrey 09f0a540b6 refactoring: reducing outputChannels copy 2022-09-01 10:30:07 -04:00
Matthew Kennedy d9ca1fb578 set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Matthew Kennedy 14b39b7b0a unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
Matthew Kennedy 2d033df11b more missing autoscale (#4112)
* autoscale m_config->timeConstant

* min/max afr

* more

* dwell voltage

* closed loop fuel

* knock

* map estimate

* applyNonlinearBelowPulse

* fix

* add a test while we're at it for un-covered code

* test fallback MAP since we touched that

* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
GitHub build-firmware Action 783aa1451c Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
Matthew Kennedy 6a46c60d75 disable fuel trim shortly after DFCO (#3847)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* disable closed loop fuel after dfco1

* I can't type

* correct comparison helps

* poke
2022-01-28 21:35:23 -05:00
Matthew Kennedy 60b9ddeb1e vss based dfco (#3845)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* even better than comments are tooltips
2022-01-27 14:05:18 -05:00
Matthew Kennedy 1a0682aa0e dfco checks driver throttle intent (#3832) 2022-01-24 14:26:39 -05:00
Matthew Kennedy 5978df2855 refactor decel fuel cut (#3830)
* refactor dfco

* s

* output channel logs dfco

* slightly cheeky comment
2022-01-23 19:44:41 -05:00
GitHub build-firmware Action e4f828c0a1 Auto-generated configs and docs 2022-01-05 06:49:51 +00:00
GitHub build-firmware Action fd23938b2a Auto-generated configs and docs 2022-01-05 05:09:04 +00:00
rusefillc 2219e55a22 refactoring - enum has more usages now 2021-12-26 14:53:27 -05:00
rusefillc 98423f2046 live data 2021-12-26 13:00:17 -05:00
rusefillc 4deb96fca6 live data 2021-12-26 13:00:17 -05:00
rusefillc c647dde007 docs & refactoring 2021-12-26 12:35:41 -05:00
Andrey d2c46b3310 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
rusefillc c64fb3f595 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
Scott Smith f9f13f0bad Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Scott Smith e8633a8cb4 Move fuel density to a header file so it can be accessed by other components. (#3474) 2021-11-05 22:29:56 -04:00
Matthew Kennedy 4717210859 autoscale fields in generated structs (#3444)
* add to grammar

* parser

* parser

* example consumer

* build config tool

* commit the right jar
2021-11-02 18:59:19 -04:00