5f1aadf638
Epic: Remove FSIO #2928
2021-11-14 10:39:47 -05:00
94320910e9
Epic: Remove FSIO #2928
2021-11-14 07:30:26 -05:00
31848f5bf4
lua pid class ( #3411 )
...
* lua pid
* no luaaa stl
* update luaaa
* finality
* luaaa
* luaaa
* = default
* bad merge
* gitmodules
* lua
* proteus demo script
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 03:18:16 -05:00
baf11a27b9
load lua libs correctly ( #3529 )
...
* fix lua lib loading
* test
2021-11-11 13:44:13 -05:00
93d31c6c9b
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
aec887efc8
Change users of MultiChannelStateSequence to use the API ( #3524 )
...
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
1a299a3221
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
76f9840dc1
MathMin
2021-11-10 19:23:05 -05:00
26749e0384
test TS writes ( #3515 )
...
* test TS writes
* s
* this must be a gcc extension
2021-11-10 07:29:40 -05:00
9b40e68155
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
7367aa5b8a
Compile each project's PCH to a separate file to reduce developer friction. ( #3505 )
...
Having to remove the precompiled header when switching from firmware to simulator to unit_tests and
back again is annoying. Use a directory to store the precompiled header output. Turn off
precompiled header warnings as GCC still complains even if it finds a valid one eventually.
2021-11-08 15:52:58 -05:00
8639b7c7e4
Make getTimeNowNt even faster ( #3504 )
...
The last version is already much better than the original, mostly because it doesn't call
CriticalSectionLocker, which has a ton of overhead due to debug tracking. But this version is
another 4 instructions / 12 bytes shorter. Does as much match in 32-bit land as possible, and
avoids math operations that span 64-bits (i.e. either operate on the lower half or upper half, but
not both). The result is only 3 instructions not including the necessary 4 loads (ptr to now, now,
ptr to upper, upper), 1 store (upper), and 1 return/branch.
2021-11-08 14:24:31 -05:00
2166a5ba16
ETB: do not touch HW pins if function not selected, this way Lua can use DC motor hardware pins directly
2021-11-08 12:44:37 -05:00
3d7bc6d422
refactoring: assigning etbFunctions earlier
2021-11-08 12:39:41 -05:00
fdcce9558e
WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK
2021-11-08 12:27:02 -05:00
49d4dea65e
lua pid class #3411
2021-11-07 09:53:40 -05:00
e3355ab2d3
Remove Miata MX5 NB1 trigger #3488
2021-11-06 20:24:41 -04:00
72cdc52acc
configurable etb maximum ( #3469 )
...
* etb maximum
* update tests and test new behavior
2021-11-05 18:16:19 -04:00
fcac26c032
Allow scaled_channel to have both multiplier and divisor ( #3468 )
...
Disallow scaled_channel for float. I can't think of a reason to allow it, and it gets in the way
of rounding.
Add separate template param to setTable; let the compiler sort out whether assignment can happen
between TElement and VElement without forcing them to be the same at function call time.
2021-11-05 17:34:22 -04:00
818e0057c9
lua curve progress
2021-11-05 16:08:48 -04:00
a2766e5d9b
support autoscale on table axes ( #3452 )
...
* scale map Y axis
* allow different row/col types
* scaled channel detector
* interpolation
* looks like this actually works
* tests, no manual scaling
* comment
2021-11-03 19:53:26 -04:00
52bd7a9cb7
lua interpolate
2021-11-02 23:35:48 -04:00
4717210859
autoscale fields in generated structs ( #3444 )
...
* add to grammar
* parser
* parser
* example consumer
* build config tool
* commit the right jar
2021-11-02 18:59:19 -04:00
1cee83a56c
Knock retard ( #3396 )
...
* output gauge
* knock controller
* don't need that
* inject engine ref
* test knock
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
292120b8dc
better pch usage and gmock constructors ( #3426 )
...
* break out mock constructors
* comment and spacing
* unnecessary compiler options
* happy stepper
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-30 20:31:09 -04:00
3d2e5be370
Override trigger gaps feature #2734
2021-10-30 11:09:10 -04:00
6a504e0755
Revert "lua pid class #3411"
...
This reverts commit 02bbe16170
2021-10-28 23:41:23 -04:00
02bbe16170
lua pid class #3411
2021-10-28 23:35:53 -04:00
23012085c9
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 13:10:38 -04:00
9cd1a2d55a
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 11:40:47 -04:00
e7d66fd242
Lua CAN RX ( #3403 )
...
* wiring
* static
* implementation
* comment
* unit tests happy
* guard
* guard smarter, not harder
* guard smarter not harder
* guard even smarter, not even harder
* don't need that
2021-10-24 08:37:04 -04:00
4259c96809
lua can set sensors ( #3389 )
...
* add sensor unsubscribe
* sensor hook
* test it!
* virtual destructor makes us sad
* ensure deinit
2021-10-22 16:36:29 -04:00
0e6a3e38ed
findSensorTypeByName
2021-10-21 14:33:59 -04:00
c6b37f57b5
findSensorTypeByName
2021-10-20 22:21:42 -04:00
45e0a0403f
very old very dead code
2021-10-20 12:57:07 -04:00
bee1eb2c6b
very old very dead code
2021-10-20 10:38:36 -04:00
c984894cb3
last packet optimization ( #3363 )
...
* last packet optimization
* comment
* test
* missed one
* set tcp mss
2021-10-18 19:59:08 -04:00
49aedb1c74
[DRAFT] IAC H-Bridge Microstepping ( #3213 )
...
* fix for stepperHbridgeHardware
* new config fields for microstepping
* add stepper dir pin mode to the dialog
* refactor stepper hw dialog & add microstepping panel
* microstepper modes enum
* stepperDcInvertedPins needed by Hellen
* add sleep() for stepper and divisor for pause()
* microstepping impl.
* make unit-tests more happy
* small progress
* fix etb-stepper dlg conflict
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 13:57:04 -04:00
99fb5e4204
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
dab377d15d
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
53d20d203e
put MAP in the sensor model ( #3292 )
...
* map averaging in sensor model
* deadly, deadly code!
* mpxh
* Revert "deadly, deadly code!"
This reverts commit 346fe25267966a313145a809792dced84be348cf.
* comments
* sensor types
* last sensor
* channel init
* correct spot
* deinit properly
* simplify
* fix
* mocks
* map init test
* showInfo
* comment
* singleton identity function
* sensor info print
* multiple cylinder averaging buffer
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-04 17:18:08 -04:00
ace0efe39a
overdwell protection #3071 ( #3294 )
2021-10-02 01:17:53 -04:00
ea7187bb25
overdwell protection ( #3220 )
...
* cancel event
* looks like it works...
* some tests are happy
* add enable bit
* undo test changes
* Revert "add enable bit"
This reverts commit 000afadd3fc560867302557afe26f76cd9fc4ed6.
* enable bit in engine
* only turn off for one test
* Revert "undo test changes"
This reverts commit 106db49e291b5a531a94de6ac177c6584d5337f6.
2021-10-02 01:10:24 -04:00
88a19b5aa8
reducing crazy in unit tests
2021-10-02 00:13:15 -04:00
6a72968ec4
reducing crazy in unit tests
2021-10-02 00:00:08 -04:00
ef5859f010
reducing crazy in unit tests
2021-10-01 23:53:22 -04:00
5dbb42b833
reducing crazy in unit tests
2021-10-01 22:33:06 -04:00
8f46b8079e
reducing crazy in unit tests
2021-10-01 22:29:44 -04:00
bbcb82bf0f
Complete fuel cut, maybe by wall wetting? Warning on decel (?) CUSTOM_OBD_SKIPPED_FUEL = 9010 fix #3225
2021-09-27 22:04:03 -04:00
4416b35820
system lua: load a script! ( #3231 )
...
* load script
* test
* needs more rams
* embiggen stack
* init system lua from lua thread
* de-embiggen stack
* system needs a little more
* memory
* om nom nom delicious memory
* how much more memory could it want
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-23 21:45:14 -04:00
f85dc02aaf
Turbo sensor ( #3245 )
...
* outputs rpm
* no msg param necessary
* new sensor type
* happy test
2021-09-20 15:39:41 -04:00
bf1221d16d
Turbo speed sensor implementation #2935 ( #3209 )
...
* Add turbocharger speed converter class
* Add turbocharger speed converter tests
* Add turbocharger speed sensor initialization functions
* Add turbocharger speed sensor to initialization
Co-authored-by: alxrMironov <330OMcorporative>
Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-09-19 20:50:11 -04:00
c84559f542
merc128: engine config defaults #3236
2021-09-18 22:12:22 -04:00
1edf98dce2
merc128: engine config defaults #3236
2021-09-18 21:27:17 -04:00
2944a89e4e
TS channel names for nicer console messages
2021-09-18 15:33:14 -04:00
98c4e71f03
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
0b73150ea4
Lua timer ( #3218 )
...
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* lua timer is happy (#3216 )
* hooks are happy
* don't need that any more
* format
* update lib
* module
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2021-09-03 20:21:39 -04:00
f6e269a3ab
remove old vss implementation ( #3208 )
...
* dead vss
* remove
2021-08-28 01:39:55 -04:00
df5f7552f2
disable closed loop boost below MAP threshold ( #3206 )
...
* boost minimum map
* changelog
2021-08-27 17:54:08 -04:00
7a4a0bb608
add & test remove from linked list ( #3199 )
2021-08-26 23:03:09 +03:00
df48806ec0
start allowing ADC change while running ( #3100 )
...
* allow re-register of the same sensor
* add api to unsubscribe
* do it for tps
* clear the pin
* happy test
* maybe make afr happy for now
* tests build
* happy simulator
* active configuration
* check valid
* we need vbatt now
* manage all pin init in init_sensors.cpp
* don't need that
* cleanup
* thermistors
* do two phase reinit in the right place
* config vs engine
* finally the tests are happy
2021-08-24 16:41:16 -04:00
dd1b7ffa24
Vehicle speed switching to frequency sensor #3106 ( #3148 )
...
* Add vehicle_speed_converter.h with realization.
* Add test_vehicle_speed_converter.cpp with realization.
* Add test_vehicle_speed_converter.cpp to Makefile
* Edit "VehicleSpeedSensor" from function pointer sensor to frequency sensor
* Fix "VehicleSpeedSensor" init function args
* Remove "VehicleSpeedConverter" empty constructor
* Edit vehicle_speed_converter.h code style
* Fix args and engine injection in "VehicleSpeedSensor" initialization procedure
* Remove old "Vehicle Speed" module initialization
* Revert "Remove old "Vehicle Speed" module initialization"
This reverts commit 100b7caa8c615c20eed3d0c23a49824b4e556148.
* Remove old "Vehicle Speed" module initialization pieces
* Revert "Revert "Remove old "Vehicle Speed" module initialization""
This reverts commit f559a726f1f7f5a7acacd1b6517e571743e84327.
* Debug changes
* Revert "Debug changes"
This reverts commit f7e2be1a8a46c6f3f93f14f002b2f2db539da8e2.
* Another debug changes
* More debug changes
* And more debug changes.
* Revert "Another debug changes"
This reverts commit 914fbb1df42c37e4b5ecbb119bb45e7cffdf4064.
* Revert "More debug changes"
This reverts commit 0b2d96d461c3cd9b0f1ae97ed110b8effe6b0cc6.
* Revert "And more debug changes."
This reverts commit 06ae8daded0e6e1c025e4e5058b47283f4adfe92.
* Add "Vehicle Speed" sensor reconfiguration
* Revert "Add "Vehicle Speed" sensor reconfiguration"
This reverts commit a089a6d563dd710004ce1a7da1744b0b4b90c3b1.
* Revert "Revert "Add "Vehicle Speed" sensor reconfiguration""
This reverts commit 7b2bb8af4b3caa547236ca59e4c4bdb3ac1200cc.
* Debug changes
* Another debug changes
* Fix another debug changes
* Another debug changes 2
* Revert "Another debug changes 2"
This reverts commit cfad55141eec125b2f1d35fb95d9f46b54f666b6.
* Revert "Fix another debug changes"
This reverts commit 9bc2c74a3be6fd896827ff48cf4580e7657529c0.
* Revert "Another debug changes"
This reverts commit 4337ed8cad8dff508d093944eb3f75e9a69e4a77.
* Edit class FrequencySensor, make it more RAII
* Debug changes
* Debug changes 2
* Debug changes 3
* Revert "Debug changes 3"
This reverts commit 52a7054c122b5157540fe45a055a84b57478d722.
* Revert "Debug changes 2"
This reverts commit dec79fb913344ccb4b8614910ad62e6c129a243e.
* Revert "Debug changes"
This reverts commit eb08d7a529b55ba397a7dd2c154b76eab42f212b.
* Revert "Edit class FrequencySensor, make it more RAII"
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Citroen Berlingo" engine config.
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Dodge Neon" engine config
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-24 00:55:41 -04:00
e056369f05
actually remove FSIO idle stuff ( #3150 )
...
* debug mode
* pid cleanup
* more dead
* more dead
* wow more dead
* much dead many death wow
2021-08-14 09:48:45 +03:00
d16cb0e153
dead idle FSIO
2021-08-12 18:28:55 -04:00
9d1ce540c4
Begin "vehicleSpeed" refactoring. Module switched to "FunctionalPointerSensor" class. #3106 #3107 #3108 . ( #3132 )
...
* Add new sensor type "VehicleSpeed"
* Add "Vehicle speed" sensor to name list
* Add Vehicle speed sensor initialization with function pointer sensor.
* Add init_vehicle_speed_sensor.cpp to Makefile
* Replace dependencies from "getVehicleSpeed" to OOP-like "Sensor::get()"
* Add warning and TODO to "mock vehicle speed" call
* Replace get & mock "VehicleSpeed" methods in tests
* Remove #warning directive (cause error by current settings)
* Remove stray tab
* Remove explicitly type casting.
* Add "InitVehicleSpeedSensor" function declaration to init.h
* Add "VehicleSpeedSensor" initialization call into "InitNewSensors"
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-12 22:16:51 +03:00
7933f50ef3
skip etb init if no primary sensor ( #3136 )
...
* skip init if no primary sensor
* specific test
2021-08-12 00:45:44 +03:00
8a4831b1dc
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 07:04:18 -04:00
39388c75d8
even more pch ( #3112 )
...
* s
* more
* s
* f7
2021-08-04 19:30:52 -04:00
d5155cfd86
don't "validate instant RPM" ( #3095 )
...
* don't "validate instant RPM"
* test actually tests the right thing
* test mode transition
2021-08-04 08:17:14 +03:00
4e6b61234f
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
33dfb904cc
unit test for vehicle_speed.cpp fix #3081
2021-08-03 19:54:11 -04:00
b6046d60d3
Unit tests for vehicle speed.cpp #3081 ( #3103 )
...
* Add test_vehicle_speed.cpp
* Add test_vehicle_speed.cpp to makefile
* Add tests for vehicle_speed.cpp
* Enable vehicle_speed.cpp testing
* Edit make some constants explicit and format code style
* Revert "Enable vehicle_speed.cpp testing"
This reverts commit bcba5219a1d69fb3375e33c7fcb97abffc190a75.
* Remove verbose variables
* Remove dead code strings
* Fix tests coupling by setMockVehicleSpeed
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-03 19:49:16 -04:00
e62244a623
unit test for vehicle_speed.cpp #3081
2021-08-03 19:48:24 -04:00
0ebc59b80f
perform extra-step-prevention in the stepper driver itself ( #3038 )
...
* perform extra-step-prevention in the stepper driver itself
* isBusy flag
* I am unable to type
* the court of public opinion has decided that greater-equal is correct
* that sets target in steps, not percent
* correct var name
* mock stepper motor
* testable stepper
* build is happy
* helping build
2021-08-02 07:03:57 -04:00
9a3d385ea5
call handleShaftSignal ( #3097 )
2021-08-02 07:02:45 -04:00
4ea56e4122
fix the mess ( #3094 )
...
* test
* s
2021-08-01 23:21:53 -04:00
99085c6776
Unit test for flex sensor.cpp #3091 ( #3093 )
...
* Add test_flex_sensor.cpp
* Add test_flex_sensor.cpp to makefile
* Edit test_flex_sensor.cpp code formatting
* Fix test case name in test_flex_sensor.cpp
* Remove explicitly defined constructor of "FlexSensorForTests" class
* Edit included headers replaced by single one in test_flex_sensor.cpp
* Edit format to make similar to other files.
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-01 22:14:01 -04:00
6eec2a1282
remove some noise from nb2 trigger log ( #3078 )
2021-07-30 08:19:16 -04:00
e3e5e57eac
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
82b30d8f78
cleanup for pch ( #3062 )
...
* cleanup
* d
2021-07-25 20:43:02 -04:00
be7ef805c9
fix nonlinear correction threshold ( #3060 )
...
* s
* macro
* test has to do the inverse
2021-07-25 20:42:26 -04:00
857a5e8572
Clutch switch inverted options do not invert detected pedal position
...
#3545
2021-07-24 19:49:23 -04:00
d3d2762847
adjust taper behavior ( #3051 )
...
* adjust taper behavior
* check that taper works in running state too
2021-07-24 16:12:07 -04:00
bc9f85ff31
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
e8aef0dcd3
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
fbf6ff05be
Nissan VVT trigger decoder #2887
2021-07-21 23:26:40 -04:00
e8bbea21be
Nissan VVT trigger decoder #2887
2021-07-21 23:24:23 -04:00
2a07c3df27
Nissan VVT trigger decoder #2887
2021-07-21 23:08:56 -04:00
5648067489
Nissan VVT trigger decoder #2887
2021-07-21 22:41:37 -04:00
58f01b7ce0
nissan logic cranking
2021-07-21 21:58:00 -04:00
3cbd983c93
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
3237b43d47
simplify quad vvt test ( #3018 )
...
* use single tooth in quad cam test
* mod == remainder
* now the test works without changes
2021-07-21 18:48:05 -04:00
4f692ebe48
test existing implementation ( #3017 )
2021-07-21 17:48:37 -04:00
0fde085a44
remove TS file read ( #3004 )
...
* remove
* more defines
* test
* lots of java
* s
2021-07-21 14:24:53 -04:00
2a4dfd0bf8
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
df522cf60e
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 19:43:17 -04:00
c9360448cc
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
e9ea68e901
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
45d185b09d
lua hooks for CAN tx ( #2967 )
...
* CanTxMessage usable from unit test
* testLuaReturnsNil
* CAN hook and tests
* it helps if parameter names exist
* nameless params
* s
* redefinition of default argument
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 14:06:26 -04:00
85d6d6c70d
trigger signal debug pins - logic level output #2959
...
test driven development is still amazing
2021-07-15 09:29:14 -04:00
5914ea6bd5
trigger signal debug pins - logic level output #2959
2021-07-15 00:34:22 -04:00
b53b23b140
trigger signal debug pins - logic level output #2959
2021-07-14 22:51:08 -04:00
c502239b45
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:47:55 -04:00
47f285c50c
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:03:00 -04:00
36dce560cf
cute example of a bug which only macoc unit test fails to compile
2021-07-13 18:15:22 -04:00
970b315bcf
NB2 hellen-72-rev-d something is off #2958
2021-07-13 15:04:30 -04:00
093b3bda89
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:39:21 -04:00
8afa24e7eb
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:24:47 -04:00
75f3cff924
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 14:07:55 -04:00
bda416fcbb
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 13:27:47 -04:00
94883a651e
it's spelled 'resources' :(
2021-07-13 12:36:50 -04:00
0b4a237897
it's spelled 'resources' :(
2021-07-13 12:35:43 -04:00
63c5315620
NB2 hellen-72-rev-d something is off #2958
2021-07-13 11:57:18 -04:00
ff9c14c239
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
f169fbf615
trailing spark scheduling ( #2932 )
...
* enable bit
* implement trailing sparks
* test trailing spark
* it helps to call the correct function
* add pins
* gobblin ram
2021-07-09 08:37:46 -04:00
130efe0f14
restore testQuadCam #2911
2021-07-08 00:11:54 -04:00
40f823662c
Matt has CUSTOM_ERR_VVT_OUT_OF_RANGE warning #2921
2021-07-07 23:55:49 -04:00
03c6db89f5
injector nonlinearity ( #2916 )
...
* nonlinear polynomial
* make existing tests work again
* test that nonlinearity is called
* s
* fix enum
* ui
* fix and test
* comment
* changeloggy
2021-07-07 23:46:44 -04:00
ba331f4895
knock sensing peak detect ( #2910 )
...
* knock peak detect
* comments
* comment
* initialize
* test
* fix warnings while we're here
* those are functions, not values
* ram
2021-07-06 21:44:59 -04:00
16dac2e47c
Disable closed loop idle during cranking->running taper ( #2900 )
...
* implement
* dead file?
* implement tests
* new phase
2021-07-06 08:47:06 -04:00
bb181ac8fd
Nissan VVT trigger decoder #2887
...
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
416cecc104
Nissan VVT trigger decoder #2887
...
that looks like one bug
2021-07-05 22:50:44 -04:00
7ec3ef4b28
Nissan VVT trigger decoder #2887
...
that's all very strange
2021-07-05 22:17:26 -04:00
59e33b3577
restore testQuadCam #2911
2021-07-05 21:04:09 -04:00
87ecec5a35
restore testQuadCam #2911
2021-07-05 20:56:24 -04:00
bafc376e92
shard unit tests ( #2906 )
...
* scripts
* it found problems!
* off by one
* call bash maybe?
2021-07-04 22:28:31 -04:00
d69fc86f26
explicitly set mock vss to test ( #2905 )
2021-07-04 17:52:45 -04:00
3247d4de00
Gate closed loop idle on road speed ( #2901 )
...
* implement
* test
* b
* config
2021-07-04 09:35:12 -04:00
c0cbe626b6
Nissan VVT trigger decoder fix #2887
...
TDD is amazing we are done here!
2021-07-03 12:43:01 -04:00
e34b04bd46
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
2ad22a262b
Nissan VVT trigger decoder #2887
2021-07-03 11:08:22 -04:00
9ad5ec8044
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
26fdfb1ab6
Nissan VVT trigger decoder #2887
2021-07-03 10:15:41 -04:00
8689adcb95
Nissan VVT trigger decoder #2887
2021-07-03 09:43:54 -04:00
cd4842f2b8
Nissan VVT trigger decoder #2887
2021-07-02 20:28:15 -04:00
2911e128d9
Nissan progress
2021-07-02 19:57:26 -04:00
a7075acbf1
Nissan progress
2021-07-02 19:23:52 -04:00
cb0ec0c78f
Nissan progress
2021-07-02 18:33:32 -04:00
96b2beff97
Nissan progress
2021-07-02 17:32:45 -04:00
7ffe09aa96
Nissan progress
2021-07-02 16:31:10 -04:00
ab24b8e5f3
Nissan progress
2021-07-02 14:56:12 -04:00
9ae1ada582
Stricter miata sync ( #2891 )
...
* strict mazda trigger shape
* this is an even better gap
* sync point moved so things are different now
* fix
* update instantrpm in test
* s
* s
* this is safer
* test
* tests
* instant rpm
* cleanup
2021-07-01 21:29:04 -04:00
20937455a0
Fix pre sync timestamp copy ( #2892 )
...
* fix tests
* fix pre sync copy
* this fixes the issue
2021-07-01 18:58:28 -04:00
024c477be4
test multiple starts ( #2888 )
...
* test
* pi
* typo
* private
* test short gap too
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 17:29:31 -04:00
ebf6083d95
test dc_motor.cpp ( #2890 )
...
* use ipwm where possible
* mock ipwm
* initialize
* test
2021-07-01 09:21:18 -04:00
2cf2db8fb2
fix instant rpm ( #2886 )
...
* fix instant rpm
* this is what it should look like!
* warning
* comment issue link
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 09:19:16 -04:00
77f9c68733
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
d5481707d5
aggressively test rpm calculator ( #2884 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 00:05:24 -04:00
0defaccb15
no fan if stopped engine ( #2822 )
...
* no fan if stopped engine
* config
* use config
* more tests
* merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 08:52:54 -04:00
fe6f123be5
Move AC logic out of FSIO ( #2872 )
...
* new impl
* remove fsio
* inject "is ac active" to fan
* include the correct code
* include
* test
* more AC features
* AC switch vs. actual AC indicators
* include
* duh
2021-06-27 18:51:34 -04:00
84a9a423d2
VW warnings on cranking #2861
2021-06-27 13:01:56 -04:00
43e71c12fa
more minimal version of fix trigger replay #2874
2021-06-27 11:38:42 -04:00
cb9b1a7cbb
crankDivider is asking for a new unit test
2021-06-27 00:51:14 -04:00
c1eda5dec8
VW warnings on cranking #2861
2021-06-26 16:05:43 -04:00
8cfcdad536
VW warnings on cranking #2861
2021-06-26 01:37:55 -04:00
04096e57b8
VW warnings on cranking #2861
2021-06-26 01:31:50 -04:00
ec1c2fd50b
VW warnings on cranking #2861
2021-06-26 00:51:09 -04:00
e2a95d566b
progress
2021-06-26 00:33:28 -04:00
4e79ed0c72
VW warnings on cranking #2861
2021-06-25 22:24:41 -04:00
f262be8c99
Minor change of Miata NA trigger shape #2855 #669 ( #2856 )
...
* Minor change of Miata NA trigger shape #2855 #669
* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
bb5500dbb3
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
2013a496ef
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:02:37 -04:00
af014f9e37
Trigger: warning code on normal engine start up #669
2021-06-25 01:43:15 -04:00
f567c764ab
giving unit tests a chance to use tdcMarkCallback
2021-06-25 01:31:53 -04:00
3efd959da8
better test coverage
2021-06-24 23:38:16 -04:00
13e93f8901
refactoring - better entity names
2021-06-24 23:19:31 -04:00
a0ea828093
docs
2021-06-24 23:12:16 -04:00
0efbbe7344
raw files #669
2021-06-24 22:39:00 -04:00
1269e7f4ea
Minor change of Miata NA trigger shape #2855 #669
2021-06-24 22:21:30 -04:00
c19479fdad
Trigger: warning code on normal engine start up #669
2021-06-24 21:58:40 -04:00
aafb2e7def
misc threading/safety improvements ( #2854 )
...
* allow termination of thread controller
* no gpio if fatal
* stub for test
2021-06-24 20:18:23 -04:00
8ba4b0ce1f
Trigger: warning code on normal engine start up #669
2021-06-23 11:32:06 -04:00
feb56dad72
refactoring
2021-06-23 06:37:32 -04:00
263bdb7eae
global static not good, there shall be only one god object /s
2021-06-23 06:10:27 -04:00
00c7b61387
Trigger: warning code on normal engine start up #669
2021-06-23 05:22:08 -04:00
42f0b0f0f5
one can dream about a well defined framework
2021-06-19 09:56:08 -04:00
837beee828
Trigger: warning code on normal engine start up #669
2021-06-18 22:52:01 -04:00
f1a95123fb
kill engine if no oil pressure ( #2800 )
...
* min oil pressure for crank
* do it time-based
* rename field
* include
* fix existing test
* tests
* fix logic
* more test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-16 17:20:28 -04:00
f15a017402
Etb rev limit ( #2820 )
...
* cfg
* impl
* a test
* don't break the ts channel
* text
2021-06-16 08:44:48 -04:00
63524c3f34
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
322f69474f
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
0c0957f52a
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
41104dcca8
hard coded fan logic ( #2805 )
...
* remove fsio
* hard code impl
* test it
* enable fan with AC
* make commented stuff match
2021-06-11 06:25:12 -04:00
e3bf80b9d7
convert gpiochips to c++ ( #2761 )
...
* core
* basic header
* tests are happy
* tle6240
* tle8888
* 33972
* 33810
* tle8888_req_init
* unused warning
* warning
* unsigned
* 8888 debug
* fix
* don't qualify
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-10 04:11:01 -04:00
de00c7fef7
Bandaid for 2735 ( #2788 )
...
* bandaid
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-02 12:02:52 +03:00
cc0547217c
Cranking defaults ( #2787 )
...
* defaults
* more
* cranking fuel
* cranking timing
* cranking time digits
* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
f21fa3e652
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
1f3cbd67ad
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
6fbdb3c2d0
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
1b607faeba
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
f0c8b3e102
my status
2021-05-31 05:27:51 -04:00
f51dd36622
require redundant pedal ( #2758 )
...
* require redundant pedal
* return false
* I don't typing good
* tests
* tests
2021-05-30 19:19:57 -04:00
0d46d96e46
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 05:22:13 -04:00
e4497358f5
Override trigger gaps feature #2734
2021-05-25 17:19:20 -04:00
9b7c9afb3b
Trigger: warning code on normal engine start up #669
2021-05-24 06:03:58 -04:00
575d2fda85
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:59:08 -04:00
3ab4ee9ea5
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-21 11:07:59 -04:00
68ad12da53
convert a table to scaled_channel ( #2724 )
...
* scaled VE table
* use setTable
* efi::clear
* ratio -> struct
2021-05-20 20:00:32 -04:00
eecfcd9e0e
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-14 10:58:53 -04:00
0c03a1cb4a
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
9307ab6b1e
explicitly test PTC thermistors ( #2681 )
...
* test ptc
* allow hotter for air cooled people
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-10 18:15:09 -04:00
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
77c28c6969
Break out unit tests #2627
2021-05-07 22:14:22 -04:00
ab9d248254
Break out unit tests #2627
2021-05-07 17:45:26 -04:00
37a3de07cf
remove stateChangeCallback from simplepwm ( #2644 )
...
* remove callback parameter from cj125
* remove from ext
* remove stateChangeCallback
* alt doesn't need that
* demorgan
* remove call
* bad cut/paste
* check the actual pin in the test
2021-05-07 09:38:41 -04:00
65a8941286
more Lua hooks ( #2605 )
...
* more hooks
* zero index
* test table hook
* test works
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-29 22:22:04 -04:00
a470c1eec1
lua 5.4 ( #2590 )
...
* thread priority
* build
* makefile prep
* call startup
* lua 5.1
* mk
* 5.3
* mk
* I guess lua does something?
* extract hooks, builds for tests
* a bit of error handling
* guard
* bootloader makefile
* remove lua
* submodule
* submodule update
* builds with submodule
* disabled by default
* h7 chconf
* tweaks
* add a useful hook
* move luaconf
* perf trace lua
* test helpers
* lua unit tests
* include to satiate clang
2021-04-28 22:41:25 -04:00
5f0791f9fb
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
8cfb63455d
Logging remove 3 ( #2568 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
* vvt
* more
* idle
* missed one
* dynoview
* launch
* can
* console IO
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
992c16b4af
logging cleanup 2: sensors, pid, etb, etc ( #2567 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 20:02:32 -04:00
babb43013f
rewrite text logging system ( #2439 )
...
* minor cleanup
* enable mailboxes
* priority
* implement new logger
* more cleaning
* signature
* remove debug
* put the assertion back in
* remove debugging
* spelling
* doy
* tweaks & comments
* cleaning
* size_t
* guard more
* test build now
* needs more ram until we can remove LogginWithSTorage
* hunt for memory
* bootloader
* unused
* stub simulator
* it would help to get the signature right
* geez kinetis only has 64k ram
* more guarding because kinetis
* that's now very legal and very cool
* templatify
* s
* force null terminate
* probably fix
* const
* write a test
* disable sensor chart for now
* hide SC ui
* oh nope that breaks many things
This reverts commit c3c1bb324fb484c3d9cc44b7715c234bc0392e1e.
* missed one
* reset after scheduleLogging
* we can't print out the full message because it contains commas which break parsing
* force terminate long buffers
* let's see how much memory we have to play with
* a lot, is the answer
* real thread name
* shrink this for now before its deleted
* turn that back on
* biiig comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 18:46:47 -04:00
9c1aa580f1
WOW major scheduling drama on NB2 running with Proteus #2533
2021-04-15 19:12:09 -04:00
c3270fb715
helping us trace CUSTOM_FSIO_STACK_SIZE
2021-04-08 15:15:12 -04:00
f34bca916d
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 15:01:12 -04:00
9c26a84be9
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
7782ebd7b4
Ford redundant ETB tps ( #2519 )
...
* ford tps
* configurable maximum
* initialization
* check consistency when in the low range
* print info
* default
* config field
* config parameter
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-05 15:57:03 -04:00
a9e822f790
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
b378fcdb88
engine sniffer into unit tests
2021-04-04 22:48:48 -04:00
112b4d1182
Hip9011 ( #2512 )
...
* hip9011: coexistance with other spi devices
* hip9011: rework so SPI transfer is invoked from thread
also use polling spi exchange to avoid cache problems
* hip9011: move calculations from ADC callback to thread
* hip9011: big cleanup
* hip9011: simplify spi communication
* No need to set knockBandCustom if it is not custom
HIP9011 calculates knockBand from cylinderBore same way
* hip9011: make unit test happy
* hip9011: fix unit test
* hip9011: remove duplicated initialization, reorder
* hip9011: just renames and data type adjustments
* hip9011: rename BAND() to HIP9011_BAND()
* hip9011: move some code from lookup.cpp to logic.cpp
* hip9011: move initEngineNoiseTable to engine_configuration.cpp
* hip9011: move lookup tables to hip9011_logic.c
* hip9011: remove empty files
* hip9011: additional checks
2021-03-30 10:56:25 -04:00
72dac58f9b
fix multi-serial-port insanity ( #2476 )
...
* carve out UART specific
* implement channel
* config cleanup
* use new config
* bootloader
* dead code
* s
* h7 inherits f7
* oops
* ok now it's right
* tests
* cleanup
* call setup
* put that in its own file
* cleanup
* format
* guard
* not needed
* improve guarding
* portable
* allow override of uart mode
* fixes for bootloader
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
204aa33e9a
goodbye ignitionOffset ( #2503 )
...
* remove
* set the timing map to do what the offset used to do
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
ce142907a0
replace print/printMsg with scheduleMsg ( #2497 )
...
* start cleaning
* disabled feature means don't print that it's disabled
* cli
* usages
* printMsg -> scheduleMsg
* this is alllll dead now
* no crlf please
* all hope is lost if you manage to hit this line
* tests
* tests
* ok we did actually need that part
* sim
* d
* kinetis
* it did ifdef, not if
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
4e1d30f86d
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
5e6746c3aa
Implement nonlinear fuel level sender ( #2473 )
...
* table function
* config fields
* sensor type
* switch consumers
* init the sensor
* ui
* 1mv resolution
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-19 08:39:08 -04:00
910f46267f
VVT uses closed loop controller framework ( #2453 )
...
* vvt uses framework
* builds
* rename, update headers
* s
* testable
* write some basic tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-14 19:31:46 -04:00
765895d913
Fuel pressure sensor checks ( #2449 )
...
* test for missing sensor
* test negative pressure delta checking logic
* test new hasSensor logic
2021-03-12 23:32:41 -05:00
3651883bcf
test_timer
2021-03-12 00:43:48 -05:00
9f90387d09
vBatt -> SensorType::vBatt fix #2260
2021-03-11 23:07:18 -05:00
ff5bf3e3c3
error accumulator ( #2434 )
...
* error accumulator
* makefile
2021-03-08 07:40:46 -05:00
89d71e4379
Compute injection duration later in the pipeline ( #2175 )
...
* injector model, test
* new math
* inject fuel based on new math
* tests
* fix
* it should work like this
* format
* update TPS AE even when we're cutting fuel
* comment
* conversion factor
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-03 07:30:56 -05:00
cd548b4db2
hip9011 compilation fix, cosmetic clean-ups ( #2414 )
...
* Board subaru eg33: has HIP9011 knock sensor
* hip9011: lastExecutionCount does not exist any more
* hip9011: extranc commands to header, use logic math for bitfields
2021-02-28 15:42:57 -05:00
350a047ead
cleanup ( #2386 )
2021-02-23 16:57:14 -05:00
12a31e5132
start making tunerstudio more sane: part 2 ( #2381 )
...
* ts cleanup part 1
* move more stuff in to the class
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
321fe48b27
rework FSIO LEelement ( #2374 )
...
* save
* firmware
* test parsing multiple things
* split tests
2021-02-17 23:32:44 -05:00
55facb6613
use DECLARE_ENGINE_PTR for Engine class ( #2365 )
...
* engine cleanup
* do the cleanup
* one last spot
* expand_engine noop for firmware
* simulator
2021-02-16 16:58:54 -05:00
6b848bf896
second bank vvt decoder unit test
2021-02-09 10:16:49 -05:00
8a237fa800
M62T vanos support #2243
2021-02-08 22:41:31 -05:00
8fa1a6530b
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
aea4baecb4
M62T vanos support #2243
2021-02-08 21:07:43 -05:00
1012b61e02
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
2ccb75a064
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
4b8a92ccc9
M62T vanos support #2243
2021-02-08 18:08:26 -05:00
d05edd2a3d
M62T vanos support #2243
2021-02-08 16:16:26 -05:00
3390bcf0ce
refactoring: more structure
2021-02-08 15:59:40 -05:00
11e8a35c15
Trigger pattern request Škoda Favorit fix #2302
2021-02-06 20:53:30 -05:00
8d9db6b5c1
put vbatt in sensor model ( #2261 )
...
* vbatt in sensor model
* sensor name
* vbatt
* s
* oy vei
* a little bit of cleanup
* memory apparently
* cj125 test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 07:55:40 -06:00
11aa253ae9
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
0cc7cb8eb4
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit 1800219e
2021-01-18 18:53:00 -05:00
1800219e44
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
0768eb75da
weird
2021-01-10 20:29:20 -05:00
3daa7d4d9a
Start support for multi-bank closed loop fueling ( #2184 )
...
* cfg
* cell
* N banks
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-10 08:10:49 -05:00
86d3746453
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
f962a7bd64
Gpio cleanup #2 ( #1530 )
...
* pin repository: PIN_USED size in now equal to brain_pin_e enum size
expect special values...
* smart gpios: register gpio chip to given base (no auto-allocation)
* drivers: gpio: core: add gpiochip_unregister()
* drivers: gpio: MC33810 intergation
* smart_gpio.cpp: cleanup ifdef mess, minor cleanups
* gpio: core: additional check for gpio ranges overlaps
* unit test: gpio chip: fixed and extended
2021-01-06 18:29:47 -05:00
56b4d87fcd
generate triggers.txt from parametric test ( #2186 )
...
* add new test
* comment
* remove old
* main cleanup
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
8608df5450
flex fuel AFR interpolation ( #2190 )
...
* config
* implement flex
* secondary fuel default
* test
* test works
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
add0dcd390
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
7c38714129
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit f1ee8b43
2020-12-31 12:22:54 -05:00
83266c904b
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
f1ee8b431e
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
924ca4f3a4
progress to fsio type safety ( #2137 )
...
* rename
* packed type safe fsio value
* comment
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-27 17:22:11 -05:00
5f84cf2a07
limp manager can disable etb ( #2143 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* limp can disable etb
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 21:47:27 -05:00
560061e251
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
b0f7fbf28a
create limp manager ( #2142 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00
93cc1e84c3
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
90cdd2ee84
rename ( #2136 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-25 08:40:54 -05:00
76e19fc97f
fix tach test 2130 ( #2134 )
...
* fix
* comment
2020-12-24 21:20:24 -05:00
297adecbca
Restore testPulsePerRev #2130
2020-12-24 08:17:43 -05:00
fad3b07b8b
Purge e34 config ( #2127 )
...
* remove
* enums
* s
* func test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
85f0621738
Purge rover v8 config ( #2116 )
...
* bye
* goodbye, rover v8
* that snuck in
* use a different config for that test
2020-12-22 10:05:54 -05:00
d3a24c568a
gpio unit tests ( #2099 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* move gpio mocking
* test gpios
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
* test deinit
2020-12-18 17:19:02 -05:00
f5a5a54683
naming consistency
2020-12-18 09:01:18 -05:00
d3cbed60af
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
abf683e775
test ( #2071 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-12 23:40:05 -05:00
719e341eeb
start fuel pump as soon as trigger events happen ( #2038 )
...
* switch pump fsio logic
* value collision
* fuel pump in tests
* mock time since trigger
* test fp
* init pin in test
* fix gpio outputs in tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-10 01:23:24 -05:00
ba1ba1452d
second lambda (x-series CAN only, for now) ( #2048 )
...
* add sensor
* second sensor
* switch sensor name
* gobblin up your memory
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 20:26:23 -05:00
d7c56f78a9
require redundant TPS for ETB ( #2041 )
...
* Require redundant tps for ETB (#2037 )
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
* add a test that fails but should not
* fix the bug
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 06:24:20 -05:00
13ac8fe744
not this line yet?
2020-12-07 01:40:26 -05:00
412e2b1d40
Revert "Revert "Split ETB in to interface + implementation headers ( #2040 )""
...
This reverts commit dae0b606
2020-12-07 01:27:27 -05:00
e38c6d3660
Revert "Require redundant tps for ETB ( #2037 )"
...
This reverts commit c08d0b5e
2020-12-07 01:11:32 -05:00
dae0b606cb
Revert "Split ETB in to interface + implementation headers ( #2040 )"
...
This reverts commit 53cbeedb
2020-12-07 01:11:19 -05:00
53cbeedb99
Split ETB in to interface + implementation headers ( #2040 )
...
* split etb interface
* mocks
* fix master while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
c08d0b5ed8
Require redundant tps for ETB ( #2037 )
...
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:05:06 -05:00
ab8248427c
more ETB test coverage ( #2039 )
...
* test no pedal map
* test open loop
* open loop but not throttle
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:59:18 -05:00
cd2d568b74
maybe fix sensor init checks ( #2034 )
...
* enums
* don't collide
* auto_generated_enums
* check based on new enum val
* maybe this will make generate tool happy
* add a test
* fix test
* fix and add another test
* make clang happier
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:19:57 -05:00
8d6255b1e2
Revert "switch rpm calculator to use timer class ( #2005 )"
...
This reverts most of 622021e799
2020-12-06 18:05:53 -05:00
622021e799
switch rpm calculator to use timer class ( #2005 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
69f754bfbd
don't duplicate sensor error logic ( #2032 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 15:00:30 -05:00
7dad3356e9
add isRedundant ( #2031 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 14:55:06 -05:00
63e328603f
one step back #2017
2020-12-06 08:50:10 -05:00
fbcfb4534a
require TPS values to be different ( #2017 )
...
* require values to be different
* fix not
* oops
* missed another spot
* test negative cases too
* resets
* test no sensor case
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:41:49 -05:00
a806053d52
round rpm instead of truncating ( #2023 )
...
* round rpm instead of truncating
* efiround is expensive
* Revert "efiround is expensive"
This reverts commit e5690f89e1b1988aacf5ced1f024d576465a7cd6.
* round is better than rintf
* testing
* it works now?!
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:11:57 -05:00
8540343d48
unit tests in clang #2012
2020-12-05 00:22:10 -05:00
45205e7da7
Dyno view proposal ( #1999 )
...
* DynoView creation
module implementation and unit_tests
* update acc algo
we only calcualte new acceleration value if speed has changed, not on every callback.
* added acceleration ts_channel
* fixed broken unit tests
* fixed accel sign
* review updates
* Update test_dynoview.cpp
fix unit_tests
* Update engine_controller.cpp
Fix .ram4 unused size
* Update test_dynoview.cpp
2020-12-04 20:28:48 -05:00
b014023560
Launch Control refactoring ( #1992 )
...
* refactor
- called from periodicFastCallback
- removed defines
* Update rusefi.input
removed unused configurations.
added clutch inversion option
* Added new tests
fixed limiting only in case we have launch condition and rpm outside of window
* Update launch_control.cpp
Unintialized config update, now it is working fine with VSS and with clutch as well.
* small fixes
updated after review findings
* Fix breaking engine rev limiter
applyLaunchControlLimiting should not overwrite booleans to false!
* Delay timer in seconds
timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
701f0b2e20
dead engine config
2020-11-26 20:53:44 -05:00
cf1c99b36c
fix etb unit test idle hardware ( #1991 )
...
* move check to etb
* give it a sensor to read
2020-11-26 19:21:42 -05:00
92e36e66b5
fix etb wastegate percent output ( #1988 )
...
* wastegate etb should use percent
* percent_t
* fix test
2020-11-25 21:14:06 -05:00
ae53889d10
Boost tolerance ( #1986 )
...
* tolerate invalid closed loop config when in open loop mode
* fix test
2020-11-25 07:27:24 -05:00
e69d103461
Launch control unit tests update ( #1972 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
* Launch control unit_tests
updated launch control for a better split
VSS mock for unit tests
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
f3c9d67d8b
Starter is engaged on start-up in pull-up configuration #1969
...
usability & test improvement
2020-11-19 17:15:28 -05:00
359a6ddc47
Launch control testable ( #1967 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
2020-11-19 08:15:56 -05:00
dbdfd87c6d
Starter seems to be engaged forever fix #1965
2020-11-18 23:54:30 -05:00
2c4f048e0d
Starter seems to be engaged forever #1965
2020-11-18 23:06:44 -05:00
acb65fe307
Starter seems to be engaged forever #1965
2020-11-18 22:56:05 -05:00
2d3ddcde9d
Starter seems to be engaged forever #1965
2020-11-18 22:47:40 -05:00
a73b2c9298
Starter seems to be engaged forever #1965
2020-11-18 20:53:03 -05:00
ab75be8742
Something something unit test ETB does not work #1966
2020-11-18 20:12:58 -05:00
2af3cdf70e
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
344423e9ab
Starter seems to be engaged forever #1965
2020-11-18 19:34:09 -05:00
80edfe64ce
Fix crc again, for real this time ( #1948 )
...
* re enable
* changelog
* fix
* fix test
* put some tests back
2020-11-15 16:59:02 -05:00
9262c58ea1
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:44:53 -05:00
1eb0f8808f
occasional tunerstudio CRC errors #1943
...
unit test progress
2020-11-15 12:36:07 -05:00
05e7792ad4
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:27:47 -05:00
605269c358
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
0fa06e2e2a
compensate injector flow based on fuel pressure ( #1931 )
...
* injector compensation
* fix
* ui
* testability & comments
* hella testing
* debug channels
* enum value
* auto generated enums
* update comment
* oops too much
* update config fields
* handle failed pressure sensor
* build
* fix
* add some todos for the future
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
14fffa5136
refactoring
2020-11-05 18:10:44 -05:00
789926a61d
convert cranking defaults to mg ( #1921 )
...
* convert cranking defaults to mg
* fix tests
2020-11-03 14:12:26 -05:00
bcabb51222
unused tach field ( #1918 )
2020-10-29 15:26:01 -04:00
b8c2041467
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
6abc80e74c
convert mass -> duration later in the pipeline ( #1906 )
...
* cranking duration to mass
* implement
* units
* patch types
* suppress warning
* fix output channels
* add note about how to set it
2020-10-26 07:23:13 -04:00
5189e0b1d9
fix double deadtime ( #1904 )
...
* move global correction factor to fuel mass
* tests
* the fix
2020-10-25 00:12:05 -04:00
5296de1493
use fuel model ( #1901 )
...
* use fuel model
* spit'n'polish
2020-10-23 20:25:47 -04:00
4d1c331eca
second PID config for wastegate ( #1889 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
* consume
* add cfg field
* ui maybe
* fix
* fix
* add wastegate config test
2020-10-19 08:04:27 -04:00
5337d9f723
Etb wastegate hookup ( #1888 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
2020-10-18 21:57:04 -04:00
2c23085715
Etb function cfg: actually read config ( #1884 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-18 17:26:38 -04:00
54c3d0f15c
HW CI has failed 11 times since Oct 2 #1849
2020-10-16 13:54:12 -04:00
02c47eeec8
write SD header using new Writer class ( #1882 )
...
* write header
* hooray, free memory!
* fix test
* is there really this much free space...?
* no, there is not
2020-10-15 16:00:13 -04:00
94bd5921c5
simplify getTimeNowNt() ( #1876 )
...
* remove old impl
* add cpp wrapper to os_access
* clean up os_access
* remove touchTimeCounter
* new impl
* put comment about lock free impl
* include cpp wrappers for BL
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-10-15 08:57:13 -04:00
abfa17216b
etb function config 1 ( #1881 )
...
* this should all be safe...
* test fix
2020-10-14 22:02:09 -04:00
554304dac3
switch to single precision constants ( #1880 )
...
* adjust builds
* fix test
2020-10-14 20:04:35 -04:00
c5291888d0
buffered writer - progress on #1463 ( #1875 )
...
* add buffered writer
* rename
2020-10-12 15:10:34 -04:00
53c001d541
revering functional part of
...
Etb function cfg, try again #1860
try again from #1831
2020-10-08 17:09:00 -04:00
cca175c6ea
Etb function cfg, try again ( #1860 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-08 14:12:03 -04:00
22a55ce7e6
switch from float to expected<float> ( #1862 )
2020-10-06 22:33:00 -04:00
7b333e60ea
FSIO refactoring ( #1861 )
...
* better fsio tests
* condense operators
* minor parser cleanup too
* comments, too!
2020-10-06 21:54:49 -04:00
060cfbd778
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
540fca8cc9
use expected for event queue next event ( #1859 )
...
* use expected for event queue next event
* minor cleanup
* tests
2020-10-05 13:53:34 -04:00
aee984d0c2
HW CI has failed 11 times since Oct 2 #1849
...
Revert "ETB function config (#1831 )"
This reverts commit fd7dae8a
2020-10-03 22:00:00 -04:00
fd7dae8ab8
ETB function config ( #1831 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-02 20:51:02 -04:00
b79c0fefe5
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
3b9d339db0
unit test for start/stop hardware and pin repository #1811
2020-09-21 12:29:01 -04:00
0b301fb454
unit test for start/stop hardware and pin repository #1811
2020-09-21 08:57:37 -04:00
96d3af18f4
unit test for start/stop hardware and pin repository #1811
2020-09-21 05:02:35 -04:00
4a1b1b6bad
fix closed loop fuel ( #1797 )
...
* fix
* add a test
* signature
2020-09-19 03:44:01 -04:00
85304392dd
two throttles one thread ( #1806 )
...
* two throttles one thread
* look at all this RAM!
2020-09-18 13:47:49 -04:00
36234961c1
logging simplification: switch bare functions to member functions: try the second ( #1794 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
* fix sniffer
2020-09-13 11:49:25 +03:00
ead14bd1ca
Revert "logging simplification: switch bare functions to member functions ( #1788 )"
...
This reverts commit 39280fb2
2020-09-12 04:36:24 -04:00
39280fb2c6
logging simplification: switch bare functions to member functions ( #1788 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
2020-09-12 03:08:11 +03:00
e8e2cf2cfd
DebounceButton A/C switch ( #1782 )
...
* change acSwitch name, add mode
* fix
* remove some adc stuff
* remove some adc stuff
* semicolon stupid
* left behind
* add readpinstate
* wrong var name
* add functions back
* fix name
* bool, not void, plus fix name
* move
* not sure what I broke
* try setMockValue
* namespace
* whoops missed one
* switch values because adc was set up for pullup
* try 5
* comment for now
* comment for now
* uncomment tests, add function to mock, add mock to efiReadPin
* fixes
* for F's sake
* if
* add defy
* pass params
* use ASSERT_TRUE/FALSE
* advance time
* remove ifdef from readPin
* try moving if
* move to separate func
* move extern
* move include
* try engine_test_helper
* am confuse
* move func to else
* include hal
* add efi prod check
* remove include
* try extern
* move include
* semicolon stupid
* move extern again
* include
* move mockPinStates
* size
* add if
* add comment
* clean on instantiation
2020-09-10 22:16:20 -04:00
8079e5f292
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00
eb2bc3201c
Selectable AFR axis override ( #1771 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
* impl
* unhide option
* fix
* tests
2020-09-08 17:15:18 -04:00
8adfef930f
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
a3db817f6e
Move ve logic ( #1762 )
...
* move ve
* fix build
* fix rendering
* duh
* cleaning
* correct scaling
* put some back
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-06 19:06:32 -04:00
fc02c2bdf4
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
c476cd3b95
refactoring
2020-09-03 19:29:15 -04:00
bad69c812e
move lambda in to sensor model ( #1736 )
...
* lambda sens
* fix init
* fix
* a test for good measure
* he's climbin in your windows, snatchin you ram up
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-01 16:22:31 -04:00
286768477c
this does not go as planned :(
2020-08-31 08:02:29 -04:00
81db997be8
this does not go as planned :(
2020-08-31 07:54:45 -04:00
24f12d2993
dead
2020-08-29 09:39:52 -04:00
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
4e333dac1c
VVT support for VAG trigger #883
2020-08-24 02:07:58 -04:00
bdbee0d38b
VVT support for VAG trigger #883
2020-08-24 02:01:50 -04:00
0f9e8bf83e
VVT support for VAG trigger #883
2020-08-24 01:21:42 -04:00
d0705f14ee
Allow negative VVT position feedback #1713
2020-08-23 11:49:46 -04:00
f5036a9f84
Add injector model class ( #1687 )
...
* stub injector model
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-17 05:22:25 -04:00
581fe1808f
tests
2020-08-10 22:11:25 -07:00
4ac3ded498
consume
2020-08-10 21:41:03 -07:00
ae606a6380
trigger and VSS hw integrated testing #1668
2020-08-08 12:03:24 -04:00
0ebe7ba059
TS SD integration #1653
2020-08-06 22:05:26 -04:00
63acb583c3
testHysteresisSelf
2020-08-04 17:59:31 -04:00
ca8083f4d1
these were testing nothing
2020-08-03 12:22:00 -07:00
2572809535
don't rely on periodicFastCallback
2020-07-31 22:09:23 -07:00
1f85c023a8
this test should have never called setTestBug299
2020-07-31 19:08:18 -07:00
7009c82993
Merge remote-tracking branch 'upstream/master' into remove-plain-maf
2020-07-31 14:56:29 -07:00
f502be0d8b
mock airmass
2020-07-31 12:44:22 -07:00
40047327c5
remove getBaseTableFuel test
2020-07-31 12:43:56 -07:00
eabdd9f458
cleanup
2020-07-30 21:20:10 -07:00
6b2c1d4d59
NA6 progress
2020-07-29 22:48:41 -04:00
40c2fb8047
test cleanup
2020-07-28 14:42:02 -07:00
eea3f2cf36
fix tests
2020-07-28 14:27:34 -07:00
dfd646cbf5
Weird VAG: DC motor idle valve not ETB #1637
...
ok, that's the current reality
2020-07-26 12:30:50 -04:00
07df0c78a8
Weird VAG: DC motor idle valve not ETB
...
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
0302be40ed
Weird VAG: DC motor idle valve not ETB #1637
2020-07-26 10:54:51 -04:00
7bf98384bf
add tests for VW mode
2020-07-26 03:11:56 -07:00
0828146ccc
tests & cleanup
2020-07-25 02:00:24 -07:00
07ce0ae1b2
Merge pull request #1634 from mck1117/refactor-inj
...
move injector logic in to its own file
2020-07-24 22:47:39 -04:00
d19e2b2499
refacto
2020-07-24 18:26:24 -07:00
aeb5c8e8d6
improve test
2020-07-23 01:24:02 -07:00
7940b84778
start refactor
2020-07-22 13:11:07 -07:00
2e58d92fdb
Merge pull request #1606 from mck1117/reset-overlap
...
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
c0ea3f19b7
make private
2020-07-20 18:50:48 -07:00
faf9279402
Merge remote-tracking branch 'upstream/master' into export-all-logicdata
2020-07-20 18:48:54 -07:00
b40114f34f
test with fix
2020-07-20 18:47:08 -07:00
572c347ad7
compensate for bug
2020-07-20 13:21:15 -07:00
5c4e22fd16
auto export all logicdata
2020-07-20 13:12:21 -07:00
57de48ad59
impruv
2020-07-20 12:40:23 -07:00
c1a1f384bb
Merge remote-tracking branch 'origin/master'
2020-07-20 14:25:47 -04:00
a6706b7d26
unit test framework improvements for smoother event execution
2020-07-20 14:25:32 -04:00
7d3876148b
Merge pull request #1622 from mck1117/encapsulate-wwae
...
put wall wetting inside InjectionEvent
2020-07-20 14:19:57 -04:00
bac27ea8ea
Merge remote-tracking branch 'upstream/master' into test-1592
2020-07-20 10:54:18 -07:00
117e98b753
unit test framework improvements for smoother event execution
2020-07-20 12:45:26 -04:00
c4885dcc0e
unit test framework improvements for smoother event execution
2020-07-20 11:16:51 -04:00
8282bb127d
test
2020-07-20 03:29:43 -07:00
b38c2e3863
put wall wetting inside
2020-07-20 00:04:05 -07:00
e2c8e97aa0
logicdata into unit tests
2020-07-20 00:36:10 -04:00
e0bf2eb909
fix ( #1620 )
2020-07-19 18:05:31 -04:00
5245cb1978
unit tests: order of tests multispark/sensor tests should not matter #1616
...
TODO
2020-07-19 14:10:55 -04:00
09684963a1
would this work?
2020-07-19 13:59:55 -04:00
9c22ca7202
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:54:47 -04:00
e9c5d5be7e
would this work?
2020-07-19 13:50:43 -04:00
8c520758d6
would this work?
2020-07-19 13:45:42 -04:00
934300465a
would this work?
2020-07-19 13:33:02 -04:00
eaff13ea1f
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:32:17 -04:00
18efd1609b
one step backwards to help build?
2020-07-19 13:26:46 -04:00
5406a60e49
Injectors #1 and #5 stick open #1592
...
starting somewhere
2020-07-19 13:13:25 -04:00
ec29fd9ca0
better folder structure
2020-07-19 12:57:05 -04:00
a79153bbea
correct batch fuel cylinder pairing ( #1595 )
...
* correct batch fuel cylinder pairing
* param
* only change behavior on two wire batch
* Add tests for two wire batch & sequential
* improve testing a little bit
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
93f85b0b93
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
2b32bc8c16
PidIndustrial does not limit iTerm fix #1599
2020-07-11 15:30:40 -04:00
2a45055289
PidIndustrial does not limit iTerm #1599
...
confirming issue with a unit test
2020-07-11 15:19:27 -04:00
8bcd46291f
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
bd39351055
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
8b84243dae
Gen config refactor 2 ( #1560 )
...
* gen_config refactor, part II
* short board defines
* oops
* comment & undef
* define QUOTE
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
21c35874a5
idle_min through FSIO not working as intended #1553
2020-07-01 20:45:37 -04:00
7f3ce36065
1 byte issue in TuneReadWriteTest #1512
2020-06-18 22:51:07 -04:00
aba153b814
simplify cranking corrections ( #1510 )
2020-06-18 08:54:02 -04:00
531f1c63c7
fuel math simplifications ( #1485 )
...
* simplify
* fix
* tweak
* cleaning
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-17 17:15:04 -04:00
546344c78a
nope, unit tests did not just fix themselves
2020-06-17 08:42:37 -04:00
c46a6e5c0e
only setup etb if primary sensor configured instead of proxy ( #1489 )
...
* only setup etb if primary sensor configured instead of proxy
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
160d8d7462
Trigger decoding issues (60-2) #1488
...
unit test refactoring
2020-06-15 00:11:02 -04:00
db29a3523a
Fix gppwm properly ( #1487 )
...
* directly control output in onoff mode
* test fixing
2020-06-11 20:43:26 -04:00
2525a9a22c
Factor out airmass logic ( #1483 )
...
* refactor
* extract more airmass
* rename, fix tests
2020-06-06 07:25:19 -04:00
9ecb0a4e55
refactor ( #1481 )
2020-06-03 21:12:12 -04:00
c95ed26d89
Remove old thermistor implementation ( #1458 )
...
* remove test clt/iat
* remove warning since this code is nearly dead
* remove old therm impl
* tests & live doc
* not quite right
2020-05-28 17:51:33 -04:00
38cb254de3
remove maf2map mode ( #1474 )
...
* remove
* remove fully
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
45e03262d0
Redundant accelerator pedal ( #1470 )
...
* add second boudns
* init logic
* test changes
* reconfigure correctly
* rams
2020-05-23 19:48:32 -04:00
a2313a853c
switch some firmware warnings to errors ( #1465 )
...
* warnings as errors
* throw instead of exit
* test massaging
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
f47f5089ba
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:49:56 -04:00
93a3379fce
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:42:09 -04:00
60bfb2d789
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:38:55 -04:00
ce2beafb5f
Redundant tps ( #1427 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* partial hookup
* fix
* fix
* bad makefile merge
* use second TPS config
* update test
* update test
* sensor names
* set second pin by default
* fix auto cal
* auto cal both sensors
* add reconfigure of secondary sensors
* gobblin' up your ram
* slow down write a little bit
* put split in debug gauge
* s
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
e6e48ce66c
binary logging ( #1443 )
...
* field support
* tests
* makefiles
* test data too
* missing include dir
* write correct thing
* fix one test
* fix test
* omnomnomnom ram
* format
* use defined names
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-17 15:56:37 -04:00
8253f5b931
better VVT progress
2020-05-15 21:33:25 -04:00
2878461d25
VVT_INACTIVE
2020-05-14 23:31:01 -04:00
7a41df6153
Fix 100% duty injection ( #1431 )
...
* skip turn-off for high duty
* mock executor injection
* test
* switch to hard cut
* test no longer relevant
2020-05-14 07:44:32 -04:00
2db29c7824
34-2 3 cam Toyota wheel progress
2020-05-10 18:03:11 -04:00
b6f6d28ed4
removing some unneeded flexibility
2020-05-10 02:06:15 -04:00
bfe3b2c5fb
34-2 3 cam Toyota wheel progress
2020-05-10 01:21:54 -04:00
e4cfc39b68
docs & clean-up
2020-05-10 00:59:32 -04:00
424a86be7b
short term fuel trim: part 2 ( #1405 )
...
* add tooltip
* add other direction to deadband
* add impl
* test partitioning
* makefile
* wrong comment
* fix include
2020-05-07 08:52:32 -04:00
55159cae44
short term fuel trim: part 1 ( #1402 )
...
* add cell
* add stft cell tests
* add bit
* minimally generate
* config defaults
2020-05-06 21:00:40 -04:00
6f3736f246
Rewrite boost control in new closed loop framework ( #1342 )
...
* rewrite boost
* test
* fix build
* tests
* open loop test
* test closed loop
* fix names
* typo
* tests
* mock boost setOutput
* needs more virtual
* fix boost logic
* switch to TPS based open loop
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
573d6d2d55
pull out std air charge math ( #1397 )
2020-05-05 08:01:40 -04:00
9353ef7d51
better state messages
2020-05-01 18:52:06 -04:00
dee2568fd5
Minor ETB improvements ( #1381 )
...
* fix pid reset and pedal failure
* pause control later
* test pauseEtbControl
* update tooltip + field name
* update test
2020-04-28 16:52:40 -04:00
7e067eb0b5
Move ETB control to a thread ( #1374 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* fix dt
* re-resize ram
2020-04-28 07:22:31 -04:00
d84f194ab7
fixing build
2020-04-26 20:40:06 -04:00
738e53442d
General purpose PWM: implementation & tests ( #1366 )
...
* config
* significant digits
* renumber enum, no need for a "none"
* ui
* impl base
* error handle MAP
* init & update
* don't need arg
* don't lie about sensor
* fix test build
* test stub
* initialize
* null check
* fix clamping
* test output
* types & enums
* don't need param
* test getOutput
* fix
* output pin instead of brain pin
* default config
2020-04-26 14:06:28 -04:00
c9ca028c9c
etb CL test ( #1361 )
2020-04-24 17:54:03 -04:00
b1741bdd6e
Improve ETB idle control ( #1319 )
...
* compress idle pos
* fix tests for new behavior
2020-04-20 17:29:03 -04:00
ce08650f65
Inject idle to ETB ( #1335 )
...
* inject idle position
* pointer
* etb idle tests
* extract mocks
* ops
* test negative case too
* don't convert for etb
* guard
2020-04-20 16:26:35 -04:00
3418356b6b
ETB: inject pedal map ( #1334 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
* inject pedal map
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
d17afd3a63
ETB testing: output, position clamping ( #1333 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
bb24782bc2
rewrite etb tests with gmock ( #1330 )
2020-04-19 20:32:41 -04:00
830f03c003
Closed loop controller base & ETB testing ( #1322 )
...
* closed loop controller base
* etb tps test
* closed loop controller tests
* test support
* update gtest
* fix for change
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
f54db83d67
Improve unexpected ( #1323 )
...
* use type instead of value
* fix remaining initializer-list users
* impruv
* last consumer?
* consumer
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 08:37:43 -04:00
363f6d5110
add expected helper class ( #1321 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 01:53:04 -04:00
192a96838f
consistency
2020-04-18 22:46:22 -04:00
942403cec2
Fuel/ign correctino on new temp sensors ( #1318 )
...
* corrections
* test
* adv map
* tests
* cleanup
* lcd
* fsio
* unneeded
* more math
* last consumer
* cleanup
* fix kinetis
2020-04-18 18:45:30 -04:00
2535d123b8
CLT consumer: fsio ( #1302 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
* fsio test help
2020-04-15 16:20:45 -04:00
83592f0dff
New clt consumers part 1 ( #1301 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
2020-04-15 09:48:17 -04:00
3f4518c324
fixing master
2020-04-14 12:55:39 -04:00
afc5f6c99b
fix maf ( #1287 )
2020-04-12 15:52:29 -04:00
3abd181f6f
CLT/IAT/Aux in the new sensor world ( #1269 )
...
* hook up clt
* init test
* probably fix test
* aux temp
* relax checking
* more significant figures
* remove old aux temp
* hand generate
* claim RAM
* move to ccm
* subscribe
* info printing
* warnings
* raise high voltage failure threshold
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-07 16:07:09 -04:00
01c87a87ee
Deadband helper & tests ( #1267 )
...
* deadband
* header
* comment
2020-04-06 09:16:26 -04:00
f161a6990a
fix ( #1268 )
2020-04-06 09:00:26 -04:00
95ef31da67
Goodbye, old TPS ( #1266 )
...
* clear out tps
* boost control
* aux valves
* launch, aux valves
* unused field
2020-04-05 19:33:33 -04:00
44bb09d1a4
yet more tps consumers ( #1258 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
* old tests
* kill dead stuff
* cleanup
* more
* fix
* test
* s
* fix signature
* fix test
* comment
* priming pulse
* remove mock tps
* remove more dead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
43d38a6691
TPS Initialization Testing ( #1264 )
...
* test support
* stub for tests
* plumbing so we can test this
* add test
* comments
2020-04-05 09:10:08 -04:00
606a7fff0d
More TPS consumers: VE lookup ( #1256 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
9a21262cf8
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
d16ff88e30
run ETB on new TPS ( #1248 )
...
* run ETB on new TPS
* why did we include all those...?
* init tps for etb test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
baa2547da1
E30 M3 Tach output solution #907 ( #1203 )
...
* Update tachometer.cpp
Initial implementation of E30 M3 Tach output solution #907 , unit_test plus debugging next
* tacho unit tests
First successfull unit test for tachometer
* RAM adjustment so it would link
* refactoring tacho, broken!
* starting to make some progress...still fails after a few seconds
* Rework with SW PWM
* Update after code review
* unit_test update
* First working unit_test
* Update .gitignore
* Update engine_controller.cpp
* Update engine_controller.cpp
* Update tachometer.h
* Update test_tacho.cpp
Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-04-02 15:20:04 -04:00
cee565f2b1
Add redundant sensor ( #1249 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* casing
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:55:21 -04:00
7e4f4ca97e
Replace hasPedalPositionSensor ( #1245 )
...
* remove
* add Sensor::hasSensor
* consume in etb
* remove unused state
* don't use it there either
* format
* fix up tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
b40d4d588d
code style
2020-04-01 21:32:21 -04:00
8235d8d765
Fully switch acc pedal to new sensors ( #1212 )
...
* proxy sensor
* header
* idle
* can
* settings
* remove old mocking
* remove old impl
* etb
* oops, gotta actually register it
* fix test
* structured bindings ftw!
* driver intent for stepper
* tear out old
* oops too much
2020-04-01 20:21:03 -04:00
cd41449459
Debuggability in the new sensor world ( #1238 )
...
* rename to avoid conflict
* fix efilib
* add sensor printing
* makefile
* that check was already there
* const
* const
* fix tests
* formatting
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-30 18:29:42 -04:00
b7033bbde9
Finally rename injector_central to bench_test ( #1229 )
...
* bench test rename
* rename consumers
* good lord what are all of these externs doing
* fix tests
2020-03-26 08:03:55 -04:00
b7b67a2a7f
Multispark implementation ( #1192 )
...
* multispark prototype
* only multispark if not cut
* typo
* do some reasonableish math
* consume cfg
* todo
* bad merge
* move math out of engine2.cpp
* engine state config
* consume generated
* use new
* hand generate
* doc, debugging
* debug channel names
* don't depend on rpmcalc
* safer, fix math
* tests
* default multispark config
* remove todo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
aa28127211
random code inspired by Ola
2020-03-24 19:50:04 -04:00
fa8036e4b6
fix ( #1202 )
...
* fix test
* shrink memory
2020-03-19 20:02:49 -04:00
0e8acf6514
CLT stops working when using 2-0 custom trigger wheel #1171
2020-03-06 01:31:04 -05:00
6d8eedf9ca
Split out EtbHardware ( #1168 )
...
* start tear out motor
* fix
* nuke reconfig
* guard for test
* test fixing
* format, condense headers
* fix todos
* undo todo
* format
2020-03-03 17:56:50 -05:00
923daaa3a1
ETB: expand automated testing #115
2020-02-22 23:18:02 -05:00
2eec300251
miata vvt trigger decoding is broken #1145
2020-02-14 13:02:27 -05:00
67e6812dbb
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:51:26 -05:00
f69bbba6a4
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:50:50 -05:00
eaf28b161b
miata vvt trigger decoding is broken #1145
2020-02-14 10:49:22 -05:00
rusefillc
Matthew Kennedy
Scott Smith
rusefi
Andreika
rusefillc
alxrMironov
Andrey G
rusefi
shadowm60
David Holdeman
Matthew Kennedy