Commit Graph

538 Commits

Author SHA1 Message Date
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy e801ffc979 fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi 4bc9b25214 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 65f5c00616 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey f7daa5df72 trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey 25d292c462 trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc d23b0b063f minor trigger refactoring 2022-11-06 01:32:59 -04:00
rusefillc 2d96fb3ef6 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc ce55171d8d minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 45deb75979 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
Andrey 72ed388948 minor trigger refactoring 2022-11-05 21:43:12 -04:00
Andrey G cc9b1517ac compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 07c5c2a91e progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc 8b1a1a984c refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
Matthew Kennedy 14b92612e2 fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc a9cf096272 // todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 93b5758736 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 5935c18beb K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey 4653cde601 K progress 2022-09-24 23:18:57 -04:00
Matthew Kennedy 2410b11a66 log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc d423c077a0 moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 1c9cb5b6ba just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc cf53f8b65c tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc 6e3bbd2ca2 dead idea 2022-09-15 14:55:32 -04:00
Andrey dc9504f33c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey d9accf1772 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey aa0cffcfdb deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc 4836c78644 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc b2ad515b0f vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey 3c1cc0b857 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey fdee7db991 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
Andrey 5cb41535d5 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 89b32418a1 Revert "smaller step forward"
This reverts commit 3e105b1599.
2022-09-01 09:10:11 -04:00
Andrey 22f31397b0 Revert "smaller step forward"
This reverts commit deff630653.
2022-09-01 09:10:07 -04:00
Andrey deff630653 smaller step forward 2022-09-01 08:51:13 -04:00
Andrey 3e105b1599 smaller step forward 2022-09-01 08:44:46 -04:00
Andrey 7b50f32b3d smaller step forward 2022-09-01 01:08:51 -04:00