From 2590ebd10b015382761e4a4669ad6737998e817c Mon Sep 17 00:00:00 2001
From: Andre Puschmann <andre@softwareradiosystems.com>
Date: Tue, 15 Jan 2019 15:59:38 +0100
Subject: [PATCH] fix bugs reported by coverity

---
 lib/src/upper/rlc_tm.cc       | 16 +++++++++-------
 srsenb/hdr/phy/prach_worker.h |  2 +-
 srsue/test/mac/mac_test.cc    |  4 +++-
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/lib/src/upper/rlc_tm.cc b/lib/src/upper/rlc_tm.cc
index d279f9ee1..59f90526a 100644
--- a/lib/src/upper/rlc_tm.cc
+++ b/lib/src/upper/rlc_tm.cc
@@ -29,14 +29,16 @@
 
 namespace srslte {
 
-rlc_tm::rlc_tm(uint32_t queue_len) : ul_queue(queue_len)
+rlc_tm::rlc_tm(uint32_t queue_len) :
+  ul_queue(queue_len),
+  tx_enabled(false),
+  log(NULL),
+  pdcp(NULL),
+  rrc(NULL),
+  lcid(0),
+  num_tx_bytes(0),
+  num_rx_bytes(0)
 {
-  log = NULL;
-  pdcp = NULL;
-  rrc = NULL;
-  lcid = 0;
-  num_tx_bytes = 0;
-  num_rx_bytes = 0;
   pool = byte_buffer_pool::get_instance();
 }
 
diff --git a/srsenb/hdr/phy/prach_worker.h b/srsenb/hdr/phy/prach_worker.h
index 45ca75745..551096ce7 100644
--- a/srsenb/hdr/phy/prach_worker.h
+++ b/srsenb/hdr/phy/prach_worker.h
@@ -68,7 +68,7 @@ private:
   const static int sf_buffer_sz = 128*1024;
   class sf_buffer {
   public:
-    sf_buffer() { nof_samples = 0; tti = 0; }
+    sf_buffer() { nof_samples = 0; tti = 0; bzero(samples, sizeof(samples)); }
     void reset() { nof_samples = 0; tti = 0; }
     cf_t samples[sf_buffer_sz];
     uint32_t nof_samples;
diff --git a/srsue/test/mac/mac_test.cc b/srsue/test/mac/mac_test.cc
index 4318c986b..7308831ff 100644
--- a/srsue/test/mac/mac_test.cc
+++ b/srsue/test/mac/mac_test.cc
@@ -280,7 +280,9 @@ public:
     nsegm_dcch = 0; 
     si_window_len = 0; 
     sib2_period = 0; 
-    send_ack = 0; 
+    send_ack = 0;
+    bzero(&bit_msg, sizeof(bit_msg));
+    bzero(&byte_msg, sizeof(byte_msg));
   }
   bool has_data(uint32_t lcid) {
     return get_buffer_state(lcid);