From 3a502ccd137fb746876ef2e05309d2d16b937808 Mon Sep 17 00:00:00 2001
From: Pedro Alvarez <pedro.alvarez@softwareradiosystems.com>
Date: Mon, 15 Apr 2019 15:43:44 +0100
Subject: [PATCH] Removed memset from rlc_status_pdu in test, to avoid compiler
 warnings.

---
 lib/test/upper/rlc_am_control_test.cc | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/lib/test/upper/rlc_am_control_test.cc b/lib/test/upper/rlc_am_control_test.cc
index e8b1721dd..2eb9a3a4c 100644
--- a/lib/test/upper/rlc_am_control_test.cc
+++ b/lib/test/upper/rlc_am_control_test.cc
@@ -32,33 +32,32 @@ uint8_t pdu2[] = {0x00 ,0x22 ,0x00 ,0x40 ,0x0C ,0x01 ,0xC0 ,0x20};
 uint32_t PDU2_LEN = 8;
 
 int main(int argc, char **argv) {
-  srslte::rlc_status_pdu_t s;
+  srslte::rlc_status_pdu_t s1, s2;
   srslte::byte_buffer_t b1,b2;
 
   memcpy(b1.msg, &pdu1[0], PDU1_LEN);
   b1.N_bytes = PDU1_LEN;
-  rlc_am_read_status_pdu(&b1, &s);
-  assert(s.ack_sn == 30);
-  assert(s.N_nack == 0);
-  rlc_am_write_status_pdu(&s, &b2);
+  rlc_am_read_status_pdu(&b1, &s1);
+  assert(s1.ack_sn == 30);
+  assert(s1.N_nack == 0);
+  rlc_am_write_status_pdu(&s1, &b2);
   assert(b2.N_bytes == PDU1_LEN);
   for(uint32_t i=0;i<b2.N_bytes;i++)
     assert(b2.msg[i] == b1.msg[i]);
 
   b1.reset();
   b2.reset();
-  memset(&s, 0, sizeof(srslte::rlc_status_pdu_t));
 
   memcpy(b1.msg, &pdu2[0], PDU2_LEN);
   b1.N_bytes = PDU2_LEN;
-  rlc_am_read_status_pdu(&b1, &s);
-  assert(s.ack_sn == 8);
-  assert(s.N_nack == 4);
-  assert(s.nacks[0].nack_sn == 0);
-  assert(s.nacks[1].nack_sn == 1);
-  assert(s.nacks[2].nack_sn == 3);
-  assert(s.nacks[3].nack_sn == 4);
-  rlc_am_write_status_pdu(&s, &b2);
+  rlc_am_read_status_pdu(&b1, &s2);
+  assert(s2.ack_sn == 8);
+  assert(s2.N_nack == 4);
+  assert(s2.nacks[0].nack_sn == 0);
+  assert(s2.nacks[1].nack_sn == 1);
+  assert(s2.nacks[2].nack_sn == 3);
+  assert(s2.nacks[3].nack_sn == 4);
+  rlc_am_write_status_pdu(&s2, &b2);
   assert(b2.N_bytes == PDU2_LEN);
   for(uint32_t i=0;i<b2.N_bytes;i++)
     assert(b2.msg[i] == b1.msg[i]);