stdout: remove extra value from eNB stats + ...

address PR review
- change "TO DO" into "TODO"
- remove forgotten "printf" for debug

Signed-off-by: Carlo Galiotto <carlo@srs.io>
This commit is contained in:
Carlo Galiotto 2021-10-19 13:33:07 +02:00 committed by Andre Puschmann
parent 4e3564a8a2
commit a4932564d7
4 changed files with 3 additions and 5 deletions

View File

@ -85,7 +85,7 @@ private:
std::atomic<bool> active_state{true};
// TO DO: some counters are kept as members of class ue_nr, while some others (i.e., mcs) are kept in the ue_metrics
// TODO: some counters are kept as members of class ue_nr, while some others (i.e., mcs) are kept in the ue_metrics
// We should make these counters more uniform
uint32_t phr_counter = 0;
uint32_t dl_cqi_valid_counter = 0;

View File

@ -139,9 +139,8 @@ void metrics_stdout::set_metrics_helper(uint32_t num_ue
fmt::print(" {:>5.5}", "n/a");
}
int phr = mac.ues[i].phr;
fmt::print(" {:>3}", int(phr));
if (not isnan(phr)) {
fmt::print(" {:>2}", int(phr));
fmt::print(" {:>2}", phr);
} else {
fmt::print(" {:>2}", 0);
}

View File

@ -81,7 +81,7 @@ void mac_nr::stop()
/// However, get_metrics is called infrequently enough to cause major halts in the L1/L2
void mac_nr::get_metrics(srsenb::mac_metrics_t& metrics)
{
// TO DO: We should comment on the logic we follow to get the metrics. Some of them are retrieved from MAC, some
// TODO: We should comment on the logic we follow to get the metrics. Some of them are retrieved from MAC, some
// others from the scheduler.
get_metrics_nolock(metrics);
sched.get_metrics(metrics);

View File

@ -220,7 +220,6 @@ void ue_nr::metrics_read(mac_ue_metrics_t* metrics_)
auto it = std::find(cc_list.begin(), cc_list.end(), 0);
ue_metrics.cc_idx = std::distance(cc_list.begin(), it);
// printf("RNTI %u: reading and resetting metrics: \n", rnti);
*metrics_ = ue_metrics;
phr_counter = 0;
dl_cqi_valid_counter = 0;