PentHertz
/
srsLTE
mirror of https://github.com/PentHertz/srsLTE.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify if condition in checking the maximum allocated SNs in PDCP

This commit is contained in:
Pedro Alvarez 2021-02-18 15:00:29 +00:00
parent 33808a5cb8
commit c66c96aac7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/src/upper/pdcp_entity_lte.cc
View File

@ -569,12 +569,12 @@ bool pdcp_entity_lte::store_sdu(uint32_t sn, const unique_byte_buffer_t& sdu)
auto fms_it = undelivered_sdus_queue.begin();
uint32_t fms_sn = fms_it->first;
int32_t diff = sn - fms_sn;
if (diff > 0 && (uint32_t)diff > maximum_allocated_sns_window) {
if (diff > (int32_t)maximum_allocated_sns_window) {
// This SN is too large to assign, it may cause HFN de-synchronization.
logger.debug("This SN is too large to assign. Discarding. SN=%d, FMS=%d, diff=%d", sn, fms_sn, diff);
return false;
}
if (diff < 0 && diff < ((-1) * (int32_t)maximum_allocated_sns_window)) {
if (diff < 0 && diff > -((int32_t)maximum_allocated_sns_window)) {
// This SN is too large to assign, it may cause HFN de-synchronization.
logger.debug("This SN is too large to assign. Discarding. SN=%d, FMS=%d, diff=%d", sn, fms_sn, diff);
return false;