Commit Graph

3570 Commits

Author SHA1 Message Date
Pedro Alvarez 1b2c9502e2 lib,pdcp_nr: fix order in which header discard was done in PDCP NR. 2022-05-17 10:29:37 +01:00
Pedro Alvarez 39fbf21174 lib,pdcp_nr: fix order of integrity generation 2022-05-17 10:29:37 +01:00
Pedro Alvarez a148dff0cd gnb,ue,rrc: enable using integrity on DRBs 2022-05-17 10:29:37 +01:00
Robert Falkenberg 02cb2532f8 lib,pdcp_nr: make sure MAC-I is computed on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez c015540f54 lib,pdcp_nr: make sure MAC-I is added on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez 25b8a35d7a lib,pdcp_nr: make sure we don extract MAC-I if integrity is not enabled. Make sure gNB does not enable integrity on DRBs 2022-05-16 16:16:07 +01:00
Codebot e79aa61a9a Merge branch 'next' into agpl_next 2022-05-15 21:14:43 +00:00
Pedro Alvarez ae8191c46d lib,rlc_am_nr: make sure we check that ACK_SN is not larger than TX_NEXT (after we checked we didn't get an ACK out of order) 2022-05-13 10:27:52 +01:00
Pedro Alvarez 97b66dbc4c lib,rlc_am_nr: fixed mal-formed status report in test. 2022-05-13 10:27:52 +01:00
Pedro Alvarez 6d55560256 lib,rlc_am_nr: check if ACK SN is within rx_window. Stop
t-PollRetransmit only if status report is not ignored
2022-05-13 10:27:52 +01:00
Pedro Alvarez c457132570 lib,rlc_am_nr: avoid if that would always be true when checking the
out-of-order ACK. Check ACK_SN instead of stop SN with Tx_Next_Ack
2022-05-13 10:27:52 +01:00
Pedro Alvarez 7c42b09e89 lib,rlc_am_nr: check if rx ACK is smaller than current Tx_Next_Ack 2022-05-13 10:27:52 +01:00
Robert Falkenberg 0c24e9c55f lib,rlc_am_nr: clean retx_queue of ACK'ed SDUs 2022-05-13 06:49:13 +02:00
Robert Falkenberg e20cb2e0c8 lib,rlc_am_nr: empty PDUs shall not increment metrics.num_tx_pdus 2022-05-13 06:49:13 +02:00
Pedro Alvarez 2c5a74340b lib,rlc_um_nr: reduce log level of message 2022-05-12 22:25:11 +01:00
Robert Falkenberg 7b77558fd4 lib,rlc_um_nr: add log message if tx_sdu_queue has no non-null SDU 2022-05-12 22:25:11 +01:00
Pedro Alvarez 6a40fd8411 lib,pdcp_nr: disabe discard timer with RLC UM 2022-05-12 22:25:11 +01:00
Pedro Alvarez 92a6d8ec66 lib,rlc_um_nr: fix issue with discard in RLC UM NR 2022-05-12 22:25:11 +01:00
Pedro Alvarez 68b6facac8 lib,pdcp_nr: log RLC mode in PDCP configuration 2022-05-12 22:25:11 +01:00
Pedro Alvarez 97b32f2fb6 rrc_nr,utils: fix generation of RLC configs from ASN.1 structs created from cfg parser. 2022-05-11 18:19:29 +01:00
Pedro Alvarez 3620308940 lib,pdcp_nr: added options to select re-ordering timer 2022-05-11 12:10:54 +01:00
Pedro Alvarez 1fecae9b5a lib,pdcp_nr: added ifdef to select pdcp_entity_nr 2022-05-11 10:15:58 +01:00
Robert Falkenberg ecc995bd4b lib,rlc_am_nr: merge NACKs across SN overflows 2022-05-10 14:02:39 +02:00
Robert Falkenberg e9156d4ba2 lib,rlc_am_nr: status PDU creation supports NACK range 2022-05-10 14:02:39 +02:00
Pedro Alvarez e01bbb8f79 lib,rlc_am_nr: support also NACK ranges without SO_start/end. Fix for NACK ranges of sizee == 1 2022-05-09 14:03:25 +01:00
Pedro Alvarez 6d8357bee9 lib,rlc_am_nr: deleted error log for unhandled NACK ranges 2022-05-09 14:03:25 +01:00
Pedro Alvarez c386d89577 lib,rlc_am_nr: fix nack ranges with so 2022-05-09 14:03:25 +01:00
Pedro Alvarez 444783e2f2 lib,rlc_am_nr: added handling of nack ranges at RX 2022-05-09 14:03:25 +01:00
Codebot f2dff0b7a0 Merge branch 'next' into agpl_next 2022-05-04 16:21:18 +00:00
Pedro Alvarez 407c44617c lib,rlc_am_nr: fix typo 2022-05-02 20:39:10 +02:00
Pedro Alvarez 840aac7fda lic,rlc_am_nr: removed stop_no_lock(), it is not necessasry 2022-04-29 09:54:49 +01:00
Pedro Alvarez ea532cbf41 lib,rlc_am_nr: added stop() method to RX entity 2022-04-29 09:54:49 +01:00
Pedro Alvarez 2f8fd7a483 lib,rlc_am_nr: add stop() method to TX entity 2022-04-29 09:54:49 +01:00
Codebot 4d2b5b8eda Adding AGPL copyright to new files 2022-04-29 07:28:44 +00:00
Codebot 9211ad7d51 Merge branch 'next' into agpl_next 2022-04-29 07:28:41 +00:00
Robert Falkenberg 828c7ec02d lib,rlc_am_nr: Change log level for already acked (removed) RETX. 2022-04-28 14:55:44 +01:00
Andre Puschmann 70eaec21e2 all: fix uninitialized variables detected by coverity 2022-04-28 15:42:08 +02:00
Pedro Alvarez e023cecd28 lib,rlc_am_nr: lower log level of unsupported NACK ranges from warning to error 2022-04-27 21:30:13 +01:00
Pedro Alvarez 5992303aca lib,rlc_am_nr: make sure we react to polling bit, even if SDU/SDU
segment is a duplicate/overlapping.
2022-04-27 16:27:52 +01:00
Pedro Alvarez 68cc16ad68 lib,rlc_am_nr: fix assert triggered by receiving duplicate segments 2022-04-27 16:27:52 +01:00
Andre Puschmann cbc0b43621 lib,radio,rf: fix printf arguments 2022-04-27 09:28:06 +02:00
Ali_UBUNTU18.04 3fdec57a47 liblte_mme: Added sec_hdr_type check in liblte_mme_pack_deactivate_eps_bearer_context_request_msg 2022-04-27 09:28:06 +02:00
Pedro Alvarez ee06a8893b lib,rlc_am_nr: fix wrong full sdu queue check 2022-04-26 22:01:47 +02:00
Pedro Alvarez 9dbb7acffa lib,rlc_am_nr: ensure early return if there is not enough space for payload plus header 2022-04-26 20:38:46 +02:00
Codebot dd59dfac7d Adding AGPL copyright to new files 2022-04-26 08:28:18 +00:00
Codebot 123f766935 Merge branch 'next' into agpl_next 2022-04-26 08:28:16 +00:00
Pedro Alvarez 0c562336d2 lib,rlc_am_nr: change update of POLL SN to be the currently being
transmitted SDU (if not an RETX)
2022-04-25 15:49:58 +01:00
Pedro Alvarez d7a32a0ea5 lib,rlc_am_nr: sending first SDU segment if t-PollRetransmit expires
instead of full SDU. Adressing test accordingly
2022-04-25 15:49:58 +01:00
Pedro Alvarez 361d3f46e0 lib,rlc_am_nr: starting to fix retx poll expiry test 2022-04-25 15:49:58 +01:00
Pedro Alvarez 42f7094a0e lib,rlc_am_nr: changed order in which the ack of poll SN is checked 2022-04-25 15:49:58 +01:00
Pedro Alvarez 0ee20d7a0c lib,rlc_am_nr: addressing reviewers comments:
* Tweaked logs
 * Addressed a missing modulus in handling a state variable.
 * made restarting t-PollRetransmission look more like the comment.
2022-04-25 15:49:58 +01:00
Pedro Alvarez 0551244d64 lib,rlc_am_nr: make sure has_data returns true when there are retxs. Make sure t-PollRetransmit is not started if it is set to infinity. 2022-04-25 15:49:58 +01:00
Pedro Alvarez 6ff18272e0 lib,rlc_am_nr: added debug_window function 2022-04-25 15:49:58 +01:00
Pedro Alvarez d2d3c4140a lib,rlc_am_nr: make sure that sdu_under_segmentation is set before calculating the polling bit 2022-04-25 15:49:58 +01:00
Pedro Alvarez ffb0c21903 lib,rlc_am_nr: stop poll retransmission if POLL_SN is ACKed/NACKed 2022-04-25 15:49:58 +01:00
Pedro Alvarez 515f2099be lib,rlc_am_nr: added SN to get pdu poll function. Setting POLL_SN now. 2022-04-25 15:49:58 +01:00
Pedro Alvarez f93d699abc lib,rlc_am_nr: retransmit first un-acked SDU when t-Poll_retransmit
expires
2022-04-25 15:49:58 +01:00
Pedro Alvarez b3edced44a lib,rlc_am_nr: added t_poll_retransmit to tx entity 2022-04-25 15:49:58 +01:00
Robert Falkenberg c0546b8634 lib,rlc_am_nr: increase verbosity on invalid ACK 2022-04-25 12:19:37 +02:00
Robert Falkenberg 4028b26274 lib,rlc_am_nr: add info_state() 2022-04-25 12:19:37 +02:00
Robert Falkenberg d66c76b374 lib,rlc_am_nr: consider size of all pending retx in buffer state 2022-04-25 12:00:31 +02:00
Robert Falkenberg ced6cf6e40 lib,rlc_am_nr: consider SDU under segmentation in buffer state 2022-04-25 12:00:31 +02:00
Robert Falkenberg e0acb7b81c lib,rlc_am_nr: update buffer-state-related unit test 2022-04-25 12:00:31 +02:00
Pedro Alvarez 8a27cdf45a lib,rlc_am_nr: fix incorrectly stopping the t-StatusProhibit 2022-04-23 00:00:16 +01:00
Pedro Alvarez 63877ba209 lib,rlc_am_nr: make sure that tx_buffer_queue size is configurable 2022-04-22 22:05:03 +01:00
Andre Puschmann 8505523928 ue,ue_sync: fix CP setting for find and track objects
move setting of CP for find and track objects further down
after the respective objects have been resized and updated
there frame_len, fft_size, etc. members.

Doing this too early cause a segfault with div by zero
because the values were all zero
2022-04-22 14:42:45 +02:00
Andre Puschmann 319a185eba phy_common_test: fix test when compiled with USE_LTE_RATES 2022-04-22 11:55:59 +02:00
Robert Falkenberg ca37eed664 lib,rlc_am_nr: default initialize member in class definition 2022-04-21 06:54:43 +02:00
Robert Falkenberg a2332d10f2 lib,rlc_am_nr_packing: unit test + bugfix for trimming of status PDUs 2022-04-21 06:54:43 +02:00
Robert Falkenberg 872e55a84e lib,rlc_am_nr_packing: reorder functions by importance 2022-04-21 06:54:43 +02:00
Robert Falkenberg d9d3bfde63 lib,rlc_am_nr: remove redundant function calls. 2022-04-21 06:54:43 +02:00
Robert Falkenberg 48dce0aab0 lib,rlc_am_nr: truncate status PDUs if necessary 2022-04-21 06:54:43 +02:00
Robert Falkenberg 489259dc78 lib,rlc_am_nr: extend status PDU struct with self-contained packed size info
This change refactors the rlc_am_nr_status_pdu_t from a simple
container into a class with integrated counter of the packed size.
As this depends on the SN length, the SN length must be passed
via constructor.
2022-04-21 06:54:43 +02:00
Andre Puschmann 68695078f0 phy_common: add basic test for sample rate for different bandwidths 2022-04-20 17:51:36 +02:00
Francisco 6984159c6f asn1: fix amf-ngap-ue-id unpacking overflow bug 2022-04-20 17:16:49 +02:00
Robert Falkenberg fc38d4f4d9 lib,rlc_am_nr: consider offset when packing retx with segmentation 2022-04-20 12:17:52 +02:00
Robert Falkenberg 69231f000f lib,rlc_am_nr: don't enqueue segment retx if already pending for retx. 2022-04-20 12:17:52 +02:00
Robert Falkenberg 62558d94da lib,rlc_am_nr: fix segmented retx of non-contiguous segments 2022-04-20 12:17:52 +02:00
Pedro Alvarez 386b1640a9 gnb,bearer_mapper: hack to keep 5QI information in bearer mapper 2022-04-20 10:24:26 +01:00
Pedro Alvarez 47caa60b45 lib,rlc_am_nr: fix up comment 2022-04-12 14:43:44 +01:00
Pedro Alvarez 2f1cf8ee11 lib,rlc_am_nr: make max retx configurable in AM stress test 2022-04-12 14:43:44 +01:00
Pedro Alvarez 4e2f7cf029 lib,rlc_am_nr: make sure that we RETX the segments if we get a NACK for an SDU that was already segmented 2022-04-12 14:43:44 +01:00
Pedro Alvarez 865dfe87e7 lib,rlc_am_nr: Added assert to check SO_start <= SO_end 2022-04-12 14:43:44 +01:00
Pedro Alvarez 7f7656e200 lib,rlc_am_nr: fix missing modulus 2022-04-12 14:43:44 +01:00
Pedro Alvarez b70e6284e6 lib,rlc_am_nr: added logging info to to handling NACKs 2022-04-12 14:43:44 +01:00
Pedro Alvarez 330513ae57 lib,rlc_am_nr: updating segment info when segmenting RETX 2022-04-12 14:43:44 +01:00
Pedro Alvarez 9d0bbc45b3 lib,rlc_am_nr: added debug window function 2022-04-12 14:43:44 +01:00
Pedro Alvarez 1aa13cee9e lib,rlc_am_nr: cleanup logging of configuration 2022-04-05 10:13:17 +01:00
Robert Falkenberg 1180d0f24d lib,rlc_am_nr: properly remove all fully received SDUs from rx window 2022-03-31 16:05:55 +02:00
Pedro Alvarez 9ecf66f313 lib,rlc_am_nr: make sure that handle control PDU correctly locks the mutex 2022-03-31 11:18:26 +01:00
Robert Falkenberg dd7bd351b3 lib,rlc_am_nr: fix pack/unpack of NACKs in status PDUs 2022-03-31 12:04:43 +02:00
Robert Falkenberg aabd22f493 lib,rlc_am_nr: cosmetic change in assert rx_highest_status 2022-03-30 17:16:21 +02:00
Robert Falkenberg 77ae5182a6 lib,rlc_am_nr: stop/restart reassembly timer for segmented SDUs with gaps 2022-03-30 17:16:21 +02:00
Robert Falkenberg d8cb4ec700 lib,rlc_am_nr: detect gaps in sequence of received SDU segments
This is required for checks such as
"there is at least one missing byte segment [...] before
the last byte of all received segments of this SDU"
2022-03-30 17:16:21 +02:00
Robert Falkenberg 51006bbab8 lib,rlc_am_nr: fix out-of-window assignment of rx_highest_status
Also add reminders for (not yet included) handling of
SDUs with segment gaps, i.e.
"...and there is at least one missing byte segment of the SDU
associated with [...] before the last byte of all received
segments of this SDU"
2022-03-30 17:16:21 +02:00
Robert Falkenberg 1d4f10fe0d lib,rlc_am_nr: fix search start point for update of rx_next 2022-03-30 17:16:21 +02:00
Pedro Alvarez 87a4656307 lib,rlc_am_nr: fix for transmitting invalid NACKs 2022-03-29 13:55:27 +01:00
Ismael Gomez b3497c4a94 srsue,nr: decode SIB1 based on coreset0 configuration in MIB 2022-03-29 14:30:14 +02:00
Ismael Gomez f83557b891 srsue,phy: use common pucch for msg3. Completed table for all pucch_common_idx values 2022-03-29 14:30:14 +02:00
Ismael Gomez be5c3afc51 radio: fix invalid mapping of multiple channels to multiple devices 2022-03-26 23:12:57 +01:00