Commit Graph

2285 Commits

Author SHA1 Message Date
Francisco Paisana bd08a64b5e sched: fix crash for 100 prbs and subband CQI reporting 2021-07-27 19:33:03 +02:00
Francisco Paisana e64fcf6ea6 sched,nr: extend sched nr to support RAR and msg3 DCI packing. 2021-07-27 19:32:48 +02:00
Andre Puschmann 7ab52500e9 enb,mac_nr: add NR sched class and add basic init calls 2021-07-27 18:26:20 +02:00
Andre Puschmann 45c1971249 mac,phy,interface: clean up and add NR interface to LTE stack
* remove obsolte rx_data_ind
* add mac_phy_interface_nr to LTE stack
2021-07-27 18:26:20 +02:00
Francisco Paisana 8e174c96ed sched,nr: provide allocated byte_buffer in DL sched output + changes in RA procedure + added sched nr in default nr_phy_tests 2021-07-27 12:47:31 +02:00
Bedran Karakoc a6226379b4 Introducing NGAP UE context procedures 2021-07-26 19:12:01 +02:00
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 2021-07-26 12:02:14 +02:00
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 2021-07-26 12:02:14 +02:00
Francisco Paisana 12e33483e1 sched,nr: add slot_point to sched nr 2021-07-26 11:52:07 +02:00
Xavier Arteaga 5b31fa72d3 Fix gnb race condition in asynchronous PRACH processing by setting number of threads to 0 2021-07-26 11:50:16 +02:00
Andre Puschmann f9589c9c5d enb,rrc,endc: refactor UE capability enquiry and check
this patch first makes sure that ENDC is only configured if the UE
support it. Second the patch also requests the EUTRA-NR and NR capabilities
if the UE indicated ENDC support in its EUTRA caps.
2021-07-26 11:04:02 +02:00
Xavier Arteaga 97db7f2d34 Added custom frequency in cell parser 2021-07-23 14:31:32 +02:00
David Rupprecht 9172059078 Supply ctor with logger instead of fetching 2021-07-22 14:12:39 +02:00
Ismael Gomez 1a15a65483 Add missing parameters to enb.conf.example 2021-07-22 09:24:14 +02:00
Francisco Paisana 4a2b51bc0d sched,nr: fix sched nr pusch K2 timing 2021-07-21 22:05:38 +02:00
Francisco Paisana 61a73d5187 sched: add missing checks for prachs with tti duration above 1msec 2021-07-21 16:24:04 +02:00
Francisco Paisana b589c0d184 sched,nr: ack/crc info included in nr_phy_test 2021-07-21 15:07:10 +02:00
Francisco Paisana 592d9332ba sched,nr: add logic for allocation of RAR and Msg3 grants 2021-07-21 15:07:10 +02:00
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 2021-07-21 13:37:16 +02:00
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 2021-07-21 10:40:40 +02:00
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 2021-07-21 10:40:40 +02:00
David Rupprecht 880eb6fc14 Added git args 2021-07-20 09:31:38 +02:00
David Rupprecht 4f0f6169f5 Added NGAP Metrics 2021-07-20 09:31:38 +02:00
Francisco Paisana c9a5180a09 sched,nr: integrate NR scheduler in nr_phy_test
The scheduler can be activated via a command line flag
2021-07-19 16:04:46 +02:00
Francisco Paisana 660b66dbe3 sched,nr: add option to run phy nr test with real NR scheduler 2021-07-19 16:04:46 +02:00
Xavier Arteaga b264f8fa1e Fix nr_phy_test TSAN warnings 2021-07-19 12:53:48 +02:00
Andre Puschmann fc8fe032ff rrc_nr,endc: add more fields to NR RRC Reconfig for EN-DC activation
adds a big chunk of new fields to the reconfig packing code,
tested with srsUE
2021-07-19 12:53:09 +02:00
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 2021-07-19 12:27:54 +02:00
Francisco Paisana e6683b7387 sched,nr: simplify scheduler threading architecture to reflect the new cc-based parallelism model 2021-07-16 22:57:55 +02:00
Francisco Paisana 74d0a8adb8 sched: add subband cqi info interface to LTE scheduler 2021-07-16 19:34:10 +02:00
Andre Puschmann 921a04ce65 enb,mac_nr: turn UE object into normal std::unique_ptr 2021-07-16 12:35:12 +02:00
Andre Puschmann b3ab661261 rrc_mobility: change log to info when receiving non-EUTRA meas report 2021-07-16 12:35:12 +02:00
Andre Puschmann 48e42f13a3 mac_nr: only request first 2 SIBs from RRC 2021-07-16 12:35:12 +02:00
Andre Puschmann 8d2e81ad6f enb,mac,nr: add basic UE object skeleton
refactor that also adds a basic UE object to the NR MAC
2021-07-16 12:35:12 +02:00
Francisco Paisana 09c7000201 sched,nr: update nr scheduler to use new mac nr interface types 2021-07-15 21:56:47 +02:00
Francisco Paisana 8a34a3c41a sched,nr: fix compilation issues in centos7 and removed unused variables 2021-07-15 21:56:47 +02:00
Francisco Paisana d9336bcd9e sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY 2021-07-15 21:56:47 +02:00
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 2021-07-15 21:56:47 +02:00
Francisco Paisana 323703c2f3 sched,nr: measure latency of sched nr in test 2021-07-15 21:56:47 +02:00
Francisco Paisana d63ea00a5d sched,nr: use PRBs instead of RBGs as the basic unit for PRB grants in the NR scheduler 2021-07-15 21:56:47 +02:00
Francisco Paisana b81cbd1334 sched,nr: redesign the order available search spaces/coresets are found in the scheduler 2021-07-15 21:56:47 +02:00
Francisco Paisana dd3c9b4d7e sched,nr: utilization of common bwp params structure across multiple sched objects 2021-07-15 21:56:47 +02:00
Francisco Paisana 2db8b8d876 sched,nr: add RAR scheduler inspired in LTE one 2021-07-15 21:56:47 +02:00
Francisco Paisana 4f0b954cde sched,nr: changed scheduler nr api to not require slot_indication function 2021-07-15 21:56:47 +02:00
Francisco Paisana 23afc66a86 sched,nr: implementation of PUCCH HARQ allocation in NR 2021-07-15 21:56:47 +02:00
Francisco Paisana bcc374c2cd implement TDD DL vs UL slot activation 2021-07-15 21:56:47 +02:00
Francisco Paisana f87f898641 sched,nr: extend coreset pdcch allocation to UL 2021-07-15 21:56:47 +02:00
Ismael Gomez 5d034b067e
Add option to rr.conf to select sub-band CQI K value (#3071) 2021-07-15 21:23:35 +02:00
Francisco 357bc10a17 feature - make minimum SNR, under which the RRC is notified with UL KO, configurable 2021-07-15 18:44:51 +02:00
faluco 8708043a5f - Add date to log timestamps.
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
2021-07-15 18:44:51 +02:00
Francisco 67325ab5c1 add pdcch_cqi_offset parameter to enb.conf 2021-07-15 18:44:51 +02:00
Francisco 2a31daca4a enb,configuration: allow to specify enb specific max nof RLC retxs 2021-07-15 15:59:33 +02:00
Pedro Alvarez 132f2aa605 Added assert to make sure SRB id makes sense in apply_rlc_rb_updates 2021-07-14 20:21:07 +02:00
Pedro Alvarez e946cbd5de Tweaked SRB parsing to remove unecessary parenthisis 2021-07-14 20:21:07 +02:00
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 2021-07-14 20:21:07 +02:00
Pedro Alvarez f0a28ebc88 Rename drb.conf to rb.conf to reflect the now configurable SRBs. 2021-07-14 20:21:07 +02:00
Pedro Alvarez 17c09dfd75 Changed enb_cfg_parcer.cc to use SRSRAN_ERROR instead of -1 for error returning. 2021-07-14 20:21:07 +02:00
Pedro Alvarez e19df2aedb Make sure that SRB configuration goes in RR config dedicated message. 2021-07-14 20:21:07 +02:00
Pedro Alvarez 72cf3a1cec Added RLC SRB1 and SRB2 configuration ability.
The configuration was added to drb.conf
2021-07-14 20:21:07 +02:00
Ismael Gomez 1fd9d4300c Move pdu buffer mutex in mac::ue to each carrier buffer map 2021-07-14 18:59:04 +02:00
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
2021-07-14 14:30:58 +02:00
Xavier Arteaga 47747e3148 SRSENB: RRC measurement report for NR are appended 2021-07-14 12:56:39 +02:00
David Rupprecht 59ca11db68 Added missing target_link_libs 2021-07-14 09:41:37 +02:00
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
2021-07-12 19:24:02 +02:00
Xavier Arteaga 96cb25b868 Add arguments to NR PHY test 2021-07-09 22:32:40 +02:00
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 2021-07-08 16:47:07 +02:00
Andre Puschmann 068267992d rnti_pool: add rrc_endc class and extra 1024B to UE memblock size
this should fix #3045

however, this hard-coded size seems pretty unflexible anyway so we might
have to increase/add to it, or find an alternative way to calculate the size?
2021-07-08 15:21:28 +02:00
Andre Puschmann e460739152 rrc_ue: only create and call endc_handler if NR RRC is available 2021-07-06 21:57:44 +02:00
Andre Puschmann 3f81d3e969 enb,rrc_endc: add handler for measurements and UE capabilities 2021-07-06 21:57:44 +02:00
Andre Puschmann 8d443d79e5 enb,rrc: add skeleton code for new RRC internal interface for SgNB addition 2021-07-06 21:57:44 +02:00
Andre Puschmann 8dd7075d12 enb,stack: add NR components for NSA mode
adds the main NR components for RLC, PDCP, MAC and RRC
for NSA operation.
2021-07-06 21:57:44 +02:00
Andre Puschmann ec3465bb98 s1ap: fix compilation of test on 32bit 2021-07-06 12:48:41 +02:00
Andre Puschmann 19996a4059 sched_nr: fix compilation 2021-07-06 10:11:50 +02:00
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 2021-07-05 17:51:27 +02:00
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 2021-07-05 17:51:27 +02:00
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 2021-07-05 17:51:27 +02:00
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 2021-07-05 17:51:27 +02:00
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 2021-07-05 17:51:27 +02:00
David Rupprecht f90e359208 Moved cp to test common 2021-07-02 17:23:06 +02:00
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
2021-07-01 17:39:54 +02:00
Ismael Gomez c0fd64c4e6 Fix data races in srsENB MAC 2021-07-01 17:39:06 +02:00
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 2021-06-30 18:19:20 +01:00
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 2021-06-30 18:19:20 +01:00
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 2021-06-30 18:19:20 +01:00
Francisco Paisana 30802777cf fix,enb: fix enb.conf param description 2021-06-29 20:39:32 +02:00
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 2021-06-29 20:39:32 +02:00
Francisco 4c316aa9ea sched,nr: integrate mac-phy interface types into the scheduler 2021-06-29 14:19:35 +02:00
Francisco 5b3c5ded63 sched,nr: implement NR PDCCH allocation algorithm 2021-06-29 14:19:35 +02:00
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 2021-06-28 00:27:36 +02:00
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 2021-06-28 00:27:36 +02:00
Xavier Arteaga c4e13f70a2 SRSENB: fix NR worker pointer check 2021-06-28 00:27:36 +02:00
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 2021-06-28 00:27:36 +02:00
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 2021-06-28 00:27:36 +02:00
Francisco de05e1e549 sched,nr: fix invalid memory write 2021-06-24 16:22:42 +01:00
Francisco 75153c7c83 sched,nr: implementation of sched sim test class 2021-06-24 16:22:42 +01:00
Francisco f1b3cfc764 sched,nr: implementation of sched NR harq retxs. Refactor of rb grid classes. 2021-06-24 16:22:42 +01:00
Francisco d950433cbd sched,nr: fix time-domain parallelization sched nr test. creation of util class to handle acquisition of boolean resources 2021-06-24 16:22:42 +01:00
Francisco 35a236b1b9 sched,nr: fix sched_nr_test. Resolve data race issues. Created new config structs used across the scheduler. 2021-06-24 16:22:42 +01:00
Francisco 407da794e1 sched,nr: implementation of slot grid class 2021-06-24 16:22:42 +01:00
Francisco 4fa27f3841 sched,nr: implementation of main classes for NR scheduler, and basic test for concurrency 2021-06-24 16:22:42 +01:00
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
2021-06-24 16:52:58 +02:00
Francisco e70b8c2472 sched,bugfix: fix SI scheduler logging 2021-06-24 14:24:00 +01:00
Andre Puschmann 4b069d9b86 enb,mac: fix concurrent access to cell structs
this patch moves the rwlock that protects the UE database outside
to also protect the cell struct.

It also adds a missing write guard when setting the cell
2021-06-23 12:38:19 +02:00
Andre Puschmann ff72c78745 enb,mac: fix indention 2021-06-23 12:38:19 +02:00
David Rupprecht ec19919246 Fix NGAP valgrind test 2021-06-22 20:53:43 +02:00
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 2021-06-22 11:11:54 +01:00
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 2021-06-21 17:35:24 +01:00
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 2021-06-21 18:07:53 +02:00
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 2021-06-21 18:07:53 +02:00
yagoda ce30b7e1ce fixing eMBMS after new ue_db architecture and scheduler changes 2021-06-21 11:20:03 +02:00
Pedro Alvarez 181b903117 Small log fix for RNTI in integrity failure notifications 2021-06-18 23:17:39 +02:00
Ismael Gomez 02ec4dd3d0 Remove unused variable 2021-06-18 23:17:14 +02:00
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 2021-06-18 23:17:14 +02:00
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality
Remove unused logger for now in ngap::ue to pass tests
2021-06-17 13:05:29 +02:00
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 2021-06-16 10:21:13 +01:00
Francisco d5234b5f65 sched,bugfix: avoid using UL SNR average in tpc control loop 2021-06-15 19:12:24 +01:00
Francisco c111b23255 config,enb: change the max sib coderate to 0.3 2021-06-14 18:55:51 +01:00
Francisco 2a009eb340 sched,feature: Enable configuring maximum coderate for SIB allocations 2021-06-14 18:55:51 +01:00
Francisco 6ababf401b feature,sched: allow setting initial DL CQI in enb.conf 2021-06-14 15:55:23 +01:00
Francisco 4cf5a8b25a fix: avoid configuring the phy mbsfn from the rrc, when phy is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco f55e1c5a73 fix,srsenb: start stack before the radio to avoid stack methods to be called when stack is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 2021-06-14 13:18:47 +01:00
Xavier Arteaga 63de691351 SRSENB: Added sleep command description 2021-06-14 09:21:29 +02:00
Xavier Arteaga 4bfe092a24 Added multi-command line in srsenb 2021-06-14 09:21:29 +02:00
Francisco 99960c72fa bugfix,srsenb: extend rrc mobility unit test for intraenb handover 2021-06-10 09:46:01 +01:00
Francisco 69b7a7eb19 bugfix,srsenb: the lcids beloging to SRB1 and SRB2 were not being reactivated correctly during intra-eNB handover 2021-06-10 09:46:01 +01:00
Francisco a0ba2d576d remove unused return variable 2021-06-09 11:12:06 +01:00
Francisco 048d487921 bugfix,gtpu: send end marker via the forwarding tunnel, when the source enb receives ue ctxt release command. Improve GTPU unit testing 2021-06-09 11:12:06 +01:00
Francisco 8cbbebdea2 bugfix,scheduler: make sure UL harq pending data is cleared up when the last retx falls in a measurement gap 2021-06-09 10:52:43 +01:00
Francisco 51c9fc514d refactor,sched: fix log lines related with meas gap collisions 2021-06-09 10:52:43 +01:00
Pedro Alvarez 163976f050 Fix releasing on on RRC and not on S1AP on integrity failure. 2021-06-08 18:52:22 +01:00
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 2021-06-08 18:52:22 +01:00
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
2021-06-08 18:52:22 +01:00
Francisco 5c7ea6f6df bugfix,srsenb,rrc: remove redundant calls to setup PDCP/RLC bearer state during reestablishment 2021-06-08 16:21:57 +01:00
Francisco fd3901e4a2 bugfix,srsenb,rrc: delete old context right away after sending Reestablishment msg.
Following ReestablishmentRequests should use the most recent rnti as old context.
2021-06-08 16:21:57 +01:00
Andre Puschmann f65faba756 sched_harq: fix uninitialized values in HARQ
detected with Valgrind memcheck
2021-06-05 11:04:33 +02:00
Francisco 35cea3d104 enb,optimization: consider mac::ue object in rnti pool memory block size 2021-06-04 21:29:13 +01:00
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 2021-06-04 21:29:13 +01:00
Francisco fd1d73666c bugfix,srsenb,mac: avoid sanity check for UL PDU length if CRC=KO 2021-06-04 20:03:38 +01:00
Francisco 76004a3054 enb,mac,refactor: mac::ue now uses byte_buffer_pool for UL PDUs 2021-06-04 20:03:38 +01:00
Francisco 9e2a7d4592 bugfix,tpc: only cap PUSCH TPC when PHR is negative. I also extended TPC unit test 2021-06-04 17:39:51 +01:00
Francisco bdc4362475 bugfix,tpc: place a cap on TPC due to PHR only when TPC is positive 2021-06-04 17:39:51 +01:00
Francisco 7badfb1c88 bugfix: avoid multiple TPC=0 for a single PHR<0 2021-06-04 17:39:51 +01:00
Francisco e2c37ad513 bugfix: missing early return in TPC derivation 2021-06-04 17:39:51 +01:00
Francisco 75eebd6b5d bugfix,gtpu: close forwarding tunnel during reestablishment due to handover failure 2021-06-04 14:59:12 +01:00
Francisco 597f993706 sched,improvement: filter out Msg3 UL SNR estimates from the TPC control loop 2021-06-04 13:45:10 +01:00
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
2021-06-04 13:23:54 +02:00
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 2021-06-04 11:13:23 +02:00
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
2021-06-03 21:11:47 +02:00
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 2021-06-03 20:45:02 +02:00
Andre Puschmann 80a89ec4bf enb,mac: protect concurrent access to ue_db from different threads
race condition between PHY worker(s) and Stack thread when
accessing ue_db member. RWlock needs to be hold.

partly fixes #2932
2021-06-03 20:43:37 +02:00
faluco 3df72cb6ab Move out a free call in a RT thread when doing lots of rachs. 2021-06-03 20:41:04 +02:00
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 2021-06-03 15:33:38 +01:00
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 2021-06-03 15:33:38 +01:00
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 2021-06-02 20:21:32 +01:00
Ismael Gomez 5cef780789 Radio-link KO notification. Measgap fix 2021-06-02 12:37:36 +02:00
Francisco 92e272ce3e limit minimum UL grant size to accommodate both BSR and RLC headers 2021-06-02 12:37:36 +02:00
Francisco 3b61df4b64 test,sched: update TPC test to reflect changes in SNR estimatioN 2021-06-02 10:08:34 +01:00
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 2021-06-02 10:08:34 +01:00
Francisco 2a2c56391c sched,refactor: Improve DL/UL grant log lines in the scheduler to print CFI as well 2021-06-02 10:08:34 +01:00
Francisco dda52afe61 move rrc unit tests to rrc/ folder 2021-06-02 10:05:49 +01:00
Francisco 47494a668d rrc,bugfix: fix reestablishment crash due to pointer invalidation 2021-06-02 10:05:30 +01:00
Francisco 3f75538660 rrc,feature: Use t301 to set time that the enb waits for the UE RRCConnectionSetupComplete or ReestablishmentComplete 2021-06-02 10:05:30 +01:00
Francisco 0349949cce bugfix, handover: disable inactivity timer during s1 handover in target enb 2021-06-02 10:05:30 +01:00
Francisco 19af55b63d bugfix, handover: Avoid sending UEContextReleaseRequest from Target eNB during S1 Handover due to UL KOs 2021-06-02 10:05:30 +01:00
Andre Puschmann 2c975732dc metrics_stdout: fix race detected by TSAN 2021-06-01 22:44:12 +02:00
Pedro Alvarez c23034e1a7 Make sure the S1AP state is reset after sending a successful/unsuccessful message 2021-06-01 19:16:16 +01:00
Pedro Alvarez 18e2149d68 Sending Initial Context Setup Response after RRC reconfiguration. 2021-06-01 19:16:16 +01:00
Xavier Arteaga 50b7d3937f Added RNTI in SRSENB PDCCH log line 2021-06-01 15:04:24 +02:00
Xavier Arteaga 6de34524e2 Fix SRSENB PHY log line 2021-06-01 08:27:03 +02:00
Xavier Arteaga ce3c808a16 Reviewed SRSENB PHY unused variables and log messages 2021-06-01 08:27:03 +02:00
Francisco f80c591127 sched,bugfix: fix scheduler CA test 2021-05-31 23:59:46 +01:00
Francisco 2cdda3b6db sched,enhancement: allow PUSCH allocations when PHICH falls in measurement Gap by resuming UL HARQ 2021-05-31 23:59:46 +01:00
Andre Puschmann fcba67ca84 enb,rrc: fix logging text 2021-05-28 18:12:16 +02:00
Andre Puschmann 8322887135 enb,rrc: increase RRC PDU queue size to 128 2021-05-28 18:12:16 +02:00
Francisco a8790abd7e fix centos7 tuple compilation issue 2021-05-28 17:21:10 +02:00
Francisco 200006c4b7 bugfix,scheduler: avoid offset to increase decrease unboundedly when mcs is equal to 0 or max_mcs 2021-05-28 17:21:10 +02:00
Francisco 0dafe4dd58 fix coderate derivation in PDCCH based on aggregation level 2021-05-28 17:20:08 +02:00
Francisco a587d20252 allow specification of subset of valid measurement gap offsets in rr.conf 2021-05-28 17:19:30 +02:00
Francisco 0996e50dce bugfix, s1ap: allow source enb to release old UE ctxt in case a connectionRequest arrives with repeated m-TMSI 2021-05-28 17:18:41 +02:00
Francisco 52247a46e5 rrc,refactor - change log level for paging try lock 2021-05-28 12:29:36 +02:00
Francisco 692bd193d5 rrc,improvements - use single subframe-indexed struct to access pending PCCH. The scheduler now doesnt lock checking for pending paging 2021-05-28 12:29:36 +02:00
Francisco 957ca453e9 bugfix,rrc: change mechanism to delete old paging messages to avoid deleting messages not yet sent 2021-05-28 12:29:36 +02:00
Andre Puschmann 66770a57e3 enb_phy_test: fix concurrent access between PHY worker and Stack
PHY and Stack are using a normal std::queue to communicate with each
other. Concurrent access among the threads needs to be protected.
2021-05-26 14:25:38 +02:00
Francisco fe0dc77c03 bugfix, s1ap: fix uninitialized variable access in s1ap_test 2021-05-26 11:35:32 +02:00
Francisco 297a2394b8 bugfix, s1ap: fix failing s1ap_test 2021-05-26 11:35:32 +02:00
Francisco 7076dbfef8 feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs 2021-05-25 21:51:10 +02:00
Francisco 4627ae9802 bugfix, scheduler: effectively disable adaptive mcs when target bler is unspecified 2021-05-25 21:51:10 +02:00
Francisco c75777c618 bugfix, sched: avoid compilation issue due to uninitialized variable access 2021-05-25 21:50:56 +02:00
Francisco 329cf02cd0 bugfix, sched: ensure max_coderate is respected in scheduler 2021-05-25 21:50:56 +02:00
Francisco a8cccd7a10 bugfix, sched: fix aggregation level derivation to avoid L > 3 2021-05-25 21:50:56 +02:00
Francisco dedd9c09a7 feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER 2021-05-25 21:50:56 +02:00
Francisco fb4a363abd fix formatting errors in scheduler 2021-05-24 19:33:27 +02:00
Francisco 1f1665bab7 improve adaptive offset adjustment log lines 2021-05-24 19:33:27 +02:00
Francisco c5029fc266 feature - implement adaptive link adaptation in DL and UL 2021-05-24 19:33:27 +02:00
Francisco 8811b7c9a7 fix handling of CRNTI CE in the RRC. The scheduler should not allocate more grants for the new rnti after this point. 2021-05-24 19:33:16 +02:00
Francisco 59513c0eed fix bearer reactivation in case the RRC session is recovered after max KO 2021-05-24 19:33:16 +02:00
Andre Puschmann fbb151af2d enb,rrc: fix bearer re-activation after max KO
this patch makes sure that if RBs have been deactivated after
max KO on either the DL or the UL, they are reactivated if either
of them is working again.

UL/DL are always activated together, even if just one of them
recovers. The KO counter (or timer), however, is not stopped implicitly.
2021-05-24 19:33:16 +02:00
Francisco 59db527481 fix reestablishment reject logging level 2021-05-24 19:33:16 +02:00
Francisco a17e3b71e7 set minimum snr under which the UL SNR estimate is not updated 2021-05-24 17:25:07 +02:00
Francisco 8df6ed07c6 sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes 2021-05-24 17:25:07 +02:00
Francisco 41bc7e4810 avoid letting repeated s1ap::user_release calls to deem the user as in zombie state. Use timer instead to auto-remove user from s1ap if no response from mme arrives 2021-05-24 17:24:31 +02:00
Francisco e07ef0aa18 avoid releasing ues doing s1 handover before TS1relocoverall expiry 2021-05-24 17:24:31 +02:00
Francisco b093576634 avoid sending UEContextReleaseRequest from Source eNB during S1 Handover. 2021-05-24 17:24:31 +02:00
Francisco f2a56c9139 simplification of multiqueue design.
- the consumer does multi-staged waiting:
  1. spins first across all queues in a RR fashion
  2. each queue access is done with a try_lock.
  3. if the try_lock fails, it increases the number of spins needed
  2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
2021-05-24 17:24:12 +02:00
Francisco 2d6a878826 change interface to create multiqueue queues 2021-05-24 17:24:12 +02:00
Francisco f705735093 optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks 2021-05-24 17:24:12 +02:00
Ismael Gomez 8414b2c2c9 Define iszero in csv_stdout 2021-05-22 16:59:27 +02:00
Ismael Gomez 5a2a435710 Improve srsENB output metrics 2021-05-22 16:59:27 +02:00
yagoda 9501283c1c fixing support for extended Cyclic Prefix
small cosmetic fixes of CP code
2021-05-20 18:16:15 +02:00
yagoda f90f6f0c7e adding MAC 0 padding support 2021-05-20 10:26:50 +02:00
Francisco 52ef23f40e fix sched benchmark test 2021-05-19 13:11:39 +01:00
Francisco a83c0ebe3b increase starting CFI when subframe contains control allocations (e.g. SIB or RAR) when cell bandwidth <= 5 MHz 2021-05-19 13:11:39 +01:00
Francisco 0a1ae0e4ad redesign and fix enb rrc message logs 2021-05-19 12:42:41 +01:00
Francisco 8d30c88330 bugfix - avoid calling rlf release timer handler concurrently 2021-05-19 12:17:40 +01:00
Francisco f0f99c1e4f update sched benchmark, created unit test to cover rbg search algorithms, improved algorithms to search for empty rbgs 2021-05-19 11:43:39 +01:00
Francisco 22f1f2d56c move ngap files into their own folders 2021-05-17 15:32:57 +01:00
Francisco 1488606156 refactor - create s1ap dedicated folder 2021-05-17 15:32:57 +01:00
Francisco 0e0835a805 move scheduler rbg/prb/cce mask and interval types and associated helper functions to a separate file 2021-05-17 14:30:23 +01:00
Francisco 7c0649bc24 delete erab if gtpu tunnel creation failed 2021-05-17 15:17:27 +02:00
Francisco c6d543efdf fix conversions of drb id to erab id in srsenb 2021-05-17 15:17:27 +02:00
Andre Puschmann 167200f5cd rrc_bearer_cfg: replace fixed E-RAB to DRB mapping
also make sure we don't assign LCIDs beyond the possible
number.

possible fix for https://github.com/srsran/srsRAN/issues/658

Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
2021-05-17 15:17:27 +02:00
Francisco fa34aaa16e ensure the DL mask count is reduced enough to fit required bytes 2021-05-14 19:58:03 +01:00
Francisco 4d3ff0d139 implementation of basic search for optimal rbgmask for subband CQI 2021-05-14 19:58:03 +01:00
Francisco f8b6eae2bf use of min DL cqi across all PRBS to compute required DL PRBs 2021-05-14 19:58:03 +01:00
Francisco 8564996eaf fix sched_dl_cqi method to compute cqi-optimal rbgmask 2021-05-14 19:58:03 +01:00
Francisco 485c6ee129 subband CQI feature - add K parameter in sched_interface::ue_cfg_t and update it from RRC 2021-05-14 19:58:03 +01:00
Francisco 84ad6dd8ee Integrated new sched_dl_cqi class in sched_ue_cell
- extend sched_dl_cqi interface to allow getting tti when cqi was last updated
- extend sched_dl_cqi to quickly get average cqi across the whole bandwidth
2021-05-14 19:58:03 +01:00
Francisco 16d05ff042 Remove time exponential averaging of DL cqi
- renaming: sched_cqi -> sched_dl_cqi
- testing: add unit test for sched_dl_cqi wideband cqi mode.
- feature: remove time exponential averaging of dl cqi
2021-05-14 19:58:03 +01:00
Francisco 28c24a89ef sched subband cqi - create method to get cqi-optimal RBG mask 2021-05-14 19:58:03 +01:00
Francisco eeb8ad6571 sched,feature - creation of sched_cqi class to manage the update of CQI in a subband CQI setting 2021-05-14 19:58:03 +01:00
Francisco f25dbea4de fix PCCH assembly in srsenb rrc 2021-05-14 19:57:52 +01:00
Xavier Arteaga af2f37d8ca SRSENB: CFI protection for all CC and fix test 2021-05-13 07:56:08 +02:00
Francisco 96ab16f1c7 s1ap fix - release old rnti (instead of new one) when a new rnti with the same tmsi is found. Furthermore, we now make sure to warn log if the enb is unable to release the old rnti 2021-05-12 18:55:10 +01:00
Francisco 6ed617f429 s1ap, bugfix - check if MME-UE-S1AP-ID has been yet assigned before sending UL NAS Transport. If it hasn't log error and abort. 2021-05-12 16:20:44 +01:00
Francisco 32228389a9 fix latest static analysis warnings in rrc paging 2021-05-11 21:14:47 +01:00
Francisco bfdb0332db remove undefined methods from rrc_ue 2021-05-11 16:54:14 +01:00
Francisco 46cfdaf9e5 Handle case when old rnti gets removed during RRC reestablishment
This is achieved via:
- keep restarting the inactivity timer whenever a ReestablishmentRequest is received
- in case the RRC ReestablishmentComplete is very late and the old rnti was removed anyway,
  abort RRC reestablishment procedure and release new rnti
2021-05-11 16:54:14 +01:00
Andre Puschmann b2825d1280 mac_controller: after maxRetx disable ALL UE bearers
the reasoning here is that the only way to recover
from the maxRetx event is the UE attempting a reestablishment.

No further traffic, neither control nor data is scheduled
until then.
2021-05-10 18:43:37 +02:00
Andre Puschmann b61be7878a enb,rrc: split RLF counter and timer handling for DL/UL/RLC
this patch splits the counter and timer handling for PHY DL, PHY UL,
and RLC errors and makes sure that, for example, a successful DL
does not cancel the UL RLF timer, and vice versa.

They all use the same timeout value which is user-configurable.
2021-05-10 18:43:37 +02:00
David Rupprecht f9c0009d23 Remove setup erabs function 2021-05-10 17:54:38 +02:00
Francisco 0d800eb8f6 stack, multiqueue - bugfix for multiqueue destruction, and addition of unit test 2021-05-10 15:27:21 +01:00
Francisco ef9d1b8c13 stack optimization - reduction of contention in multiqueue class
With the new design, each queue created in the multiqueue object has its own mutex.
Pushing tasks to separate queues will, therefore, not cause contention.
There will be, however, still contention between the popping thread and the pushing threads.
2021-05-10 15:27:21 +01:00
Francisco b54bb35343 use rnti_map_t in scheduler 2021-05-07 10:58:04 +01:00
Francisco 6b84754ede fix rrc and gtpu bearer rnti update during reestablishment. The rnti of UE's rrc_bearer_handler was not being updated 2021-05-07 10:58:04 +01:00
Francisco 1677abce8d create typedef for circular map of rntis. check return of gtpu ue creation 2021-05-07 10:58:04 +01:00
Francisco 9464f36714 make eNB UE release timer after RLF detection configurable 2021-05-07 09:51:59 +01:00
Ismael Gomez 0b91598e36 Move mlockall() to main() in srsUE and srsENB 2021-05-06 23:03:57 +02:00
Francisco 46bd8845ba fix gtpu bearer removal during handover 2021-05-06 18:10:31 +01:00
Francisco 7c2e841eb4 gtpu bugfix - call gtpu rem bearer when erab is removed 2021-05-06 18:10:31 +01:00
Francisco c5396155ad set default gtpu tunnel close timeout to infinity 2021-05-06 18:07:20 +01:00
Francisco 15484e9472 rrc - make t304 configurable via rr.conf 2021-05-06 18:07:20 +01:00
Francisco c6b9c12ba2 gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received 2021-05-06 18:07:20 +01:00
Francisco b619a2b649 application of new cache allocator to deques in scheduler 2021-05-06 18:06:10 +01:00
David Rupprecht c117b563c9 Initial commit for ngap in enb 2021-05-05 13:54:57 +02:00
David Rupprecht 3284143b39 Capture false encoded messages before sending 2021-05-04 21:38:06 +02:00
Francisco 7bee75e126 update description of srsenb --expert.nof_prealloc_ues config parameter, and added a comment in header file explaining the use of such parameter. 2021-05-04 17:52:47 +01:00
Francisco 5818488b27 change enb max_nof_ues config parameter to nof_prealloc_ues 2021-05-04 17:52:47 +01:00
Francisco 9739a9de5f add missing srsenb expert parameter to enb.conf.example 2021-05-04 17:52:47 +01:00
Francisco 04ded030ea srsenb,bugfix - avoid logging error message when UE sends CRNTI MAC CE for old rnti whose context has already been erased. 2021-05-03 21:43:48 +01:00
Francisco d175bb281b avoid error logging during handover if EIA0 has been chosen 2021-05-03 17:58:24 +01:00
Francisco 051530177e feature - support eia0 during S1 Handover 2021-05-03 17:58:24 +01:00
Francisco a43dd68d57 update comment, explaining the reasoning behind setting a lower bound for allocated UL grants 2021-05-03 17:43:41 +01:00
Francisco f7016633d2 sched, fix - avoid tpc commands when target pusch and pucch snr are not specified 2021-05-03 17:43:41 +01:00
Francisco c69631462b sched, fix - limit UL cqi update to PUSCH SNR reports 2021-05-03 17:43:41 +01:00
Francisco d3c51fdad4 limit minimum UL grant size to accommodate both BSR and RLC headers 2021-05-03 17:43:41 +01:00
Francisco cde61a5796 rrc paging - reduce the space taken by paging manager class
Paging messages can only be transmitted in a subset of subframes - {0, 4, 5, 9}
I avoid now creating objects for the subframes that are not part of this subset
2021-05-03 15:58:21 +01:00
Francisco b014cbfe0f rrc paging - removal of redundant mutexes in paging manager class. Now mutexes are indexed by subframe index instead of paging buffer index 2021-05-03 15:58:21 +01:00
Francisco 8487c10956 removal of unused variables 2021-05-03 15:58:21 +01:00
Francisco 01eace2631 rrc paging mechanism improvements
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
2021-05-03 15:58:21 +01:00
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 2021-04-29 10:00:09 +02:00
Francisco 70d6e4d9b3 mac, fix - Verify that mac::ue also exists in the scheduler before attempting to retrieve its metrics 2021-04-28 00:02:06 +01:00
Francisco 6e7d992552 remove UE on S1AP Release Request if MME S1AP UE ID hasn't been assigned yet 2021-04-27 19:14:25 +01:00
Xavier Arteaga 6045998909 enb_phy_test uses default rr configuration 2021-04-27 16:55:51 +02:00
Francisco Paisana d39183419c
Separate TPC PUSCH and PUCCH target SINR (#2740)
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
2021-04-27 10:12:40 +01:00
Francisco 86dac9c823 several coverity high and medium impact fixes 2021-04-27 10:11:03 +01:00
Andre Puschmann 20575d3eec phy,enb: only initialize NR workers if needed
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
2021-04-26 09:43:58 +02:00
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM
mainly fixmes, unused/empty code, etc.
2021-04-25 21:03:53 +02:00
AlaiaL d88760f099 Fixes coverity 366620 2021-04-23 21:22:06 +02:00
AlaiaL beaa1b3e24 Fixes coverity 369569 2021-04-23 21:22:06 +02:00
AlaiaL 82788ca094 Fixed issues from coverity:
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
2021-04-23 21:22:06 +02:00
herlesupreeth 0f06ec0d9c Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.

In order to make use of this feature, use the following parameter in enb.conf

Example:

gtp_advertise_addr = 213.61.141.82
2021-04-23 20:31:36 +02:00
faluco cd1c6732f7 Remove the creation of strings when preparing the contents of a log entry in sched_helpers. 2021-04-22 12:38:14 +02:00
Francisco ff3fc0826b asn1 fixes and improvements
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
2021-04-22 10:21:08 +01:00
Francisco 42e7fc656b s1ap fix - send S1AP UEContextRelease when the UE does a new RRC connection setup with the same TMSI 2021-04-21 16:49:36 +01:00
faluco 69726bc939 Remove two allocs in the prio queues in sched_time_pf. 2021-04-21 15:05:48 +02:00
faluco 7df308c756 Remove two mallocs in the stack:
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
2021-04-21 15:05:48 +02:00
Xavier Arteaga 407903e0d6 SRSUE: refactor carrier setting for accepting a dynamic carrier configuration 2021-04-20 21:50:10 +02:00
Xavier Arteaga 1a4de831e9 Ammended eNb PHY tests 2021-04-20 19:12:46 +01:00
Francisco d1b336101f revert enb phy tests. Check that when nof_carriers==6 the phy fails to start and reports an error. 2021-04-20 19:12:46 +01:00
Francisco 6137e4569b fix srsran_assert definition when asserts are disabled 2021-04-20 14:01:05 +01:00
Francisco 3b78bf3730 bugfix - fix memcheck warnings. move instructions with side effects outside of asserts 2021-04-20 14:01:05 +01:00
David Rupprecht a064e85c54 rename common lte header 2021-04-19 22:23:59 +02:00
David Rupprecht 81ad72b0ff Refactor srb and drb handling 2021-04-19 22:23:59 +02:00
David Rupprecht 6b41ae7e8b Updated PDCP config struct for rat type 2021-04-19 22:23:59 +02:00
Francisco 8ed8b94ca5 in search for contiguous prb interval, skip already scanned prbs 2021-04-19 13:31:20 +01:00
Francisco 22024ac35d implemented bounded_bitset::find_lowest(...) for both reverse and non-reverse bit ordering. Applied this method to UL scheduling search for PRB intervals 2021-04-19 13:31:20 +01:00
David Rupprecht f42d4dbc28 Refactored carrier config 2021-04-19 12:13:37 +02:00
Francisco 52bf973981 s1ap - set cause to transport when gtpu fails to allocate TEID 2021-04-17 13:06:19 +01:00
Francisco 791b8d24ce fix regression in scell activation during intraenb handover 2021-04-16 12:17:41 +01:00