Andre Puschmann
8e44d0504c
radio: fix device mapping for mimo
...
commit #51c6e8d1 introduced a regression in which the 2nd antenna
port was never considered. All MIMO ZMQ based tests therefore failed.
this fixes #1608
2020-08-19 15:39:13 +02:00
Xavier Arteaga
710700d0eb
SRSUE: Fix synch error correction for multiple channels
2020-08-19 15:39:13 +02:00
Andre Puschmann
d5da4bd8b6
radio: fix printf for 32bit
2020-08-19 11:57:04 +02:00
Francisco Paisana
7cd4f45d62
fsm refactor.
...
- avoid triggering directly a subfsm
- improved metafunctions
- other cleanups
2020-08-18 16:07:21 +01:00
Francisco Paisana
5d1343fe75
implemented S1 bearer status transfer
2020-08-18 13:55:17 +01:00
Francisco Paisana
db8af399f8
extended rrc tenb s1 handover test. implemented layer reconfig during s1 handover
2020-08-18 13:55:17 +01:00
Francisco Paisana
7605c7df23
added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack
2020-08-18 13:55:17 +01:00
Francisco Paisana
841b884796
remove extern C flags from common_helper.h
2020-08-18 13:54:23 +01:00
Francisco Paisana
a2b8bc9e0a
check all cpus scaling governor
2020-08-18 13:54:23 +01:00
Francisco Paisana
5be5409f62
scaling governor function moved to common header file
2020-08-18 13:54:23 +01:00
Francisco Paisana
9146e6ddf1
change method name to resize intervals
2020-08-14 15:06:06 +01:00
Francisco Paisana
4457bbda7e
added new asserts to interval interface
2020-08-14 15:06:06 +01:00
Francisco Paisana
8b174ce2f4
changed interval interface to disallow interval::stop < interval::start via an assertion
2020-08-14 15:06:06 +01:00
Francisco Paisana
39b380c8e0
fix compilation issue for gcc version < 5
2020-08-14 15:06:06 +01:00
Francisco Paisana
2f689372dd
added missing header
2020-08-14 15:06:06 +01:00
Francisco Paisana
c1755727d7
changed interval method names, and added comments and assertions
2020-08-14 15:06:06 +01:00
Francisco Paisana
b2dd46ccad
remove extra space in to_string
2020-08-14 15:06:06 +01:00
Francisco Paisana
20b69fb22e
substitution of ul_alloc_t for prb_interval
2020-08-14 15:06:06 +01:00
Francisco Paisana
26f46ea067
add S1 Handover Request handling in target eNB
2020-08-14 14:28:56 +01:00
Francisco Paisana
857cc141c7
fix macro checking for exceptions, added missing includes, fixed bounded bitset methods' noexcept specifiers
2020-08-13 13:13:34 +01:00
Francisco Paisana
cceeff10de
moved expected, bounded_bitset, move_callback to adt folder. created a test for bitset
2020-08-13 13:13:34 +01:00
Francisco Paisana
caf862c99f
moved expected, bounded_bitset, move_callback to adt folder. created a test for bitset
2020-08-13 13:13:34 +01:00
Ismael Gomez
382811e10e
Update S1AP RNTI context when doing Reestablishment ( #1582 )
2020-08-12 23:48:20 +02:00
faluco
1253740da3
- Extracted traits from class to a detail namespace.
2020-08-11 19:47:26 +01:00
faluco
072e84cec8
- Simplified the usage of span now with implicit constructors as it should be.
...
- Added overload for generic containers that have size and data members like vector.
- Removed unnecessary uses of make_span.
2020-08-11 19:47:26 +01:00
faluco
158edd4fe7
Removed init list constructor test.
2020-08-11 19:47:26 +01:00
faluco
eb4b2d4e43
- Added a clarification comment on why to use make_span.
...
- Moved byte_buffer utilities to common.h thus breaking the dependency of ADT to COMMON.
- Fixed compilation failures in tests.
2020-08-11 19:47:26 +01:00
faluco
af8dfcf19c
Extended a bit the span implementation with the following changes:
...
- Documented methods and class.
- Adapted interface to the latest standard: no init list and generic container constructors, new iterator pair ctor.
- Implemented some SFINAE for managing conversions in constructors.
- Re-organised some methods to be grouped by category (modifiers, observers, iterators, ...).
- Added convenience make_span functions.
- Added some more asserts.
- Adapted test to use some syntax that was modified.
2020-08-11 19:47:26 +01:00
Francisco Paisana
76a62909c1
use of span type for universal array views
2020-08-11 19:47:26 +01:00
Francisco Paisana
a9d882c1f1
fix task_scheduler_test. Fix potential reference invalidation in task_scheduler internal tasks data structure
2020-08-11 17:16:06 +01:00
Francisco Paisana
9d877e55b3
add test for when scope exit lambda is an lvalue
2020-08-10 17:23:43 +01:00
faluco
9e2a116e11
- Fix a missing template parameter in the constructor.
...
- Decay the type to the template.
- Switched member order to improve memory layout.
2020-08-10 17:23:43 +01:00
Francisco Paisana
0f67bee556
creation of a scope exit standalone file. Created a new folder ADT. Added test for scope exit.
2020-08-10 17:23:43 +01:00
Andre Puschmann
cb2d7f4c16
rf_uhd_generic: add explicit ctor and dtor
...
clang 6 complained about a missing virtual dtor and thus
failed compilation. this patch adds both, an explicit ctor and dtor.
2020-08-10 10:42:54 +02:00
Andre Puschmann
498af989bf
rf_uhd: add missing endl to UHD log macros
2020-08-06 22:42:48 +02:00
Xavier Arteaga
46ab07123d
UHD: fix compatibility with 3.9.7 LTS
2020-08-06 22:42:48 +02:00
Andre Puschmann
5867668c0c
rf_uhd_rfnoc: fix compilation for UHD before 3.15
...
the enable_rx_timestamps() for the radio_ctrl object has only been
introduced in Nov 2019 for UHD 3.15 and therefore needs
to be excluded when compiling for 3.14 and below.
Note: According to the original UHD commit in
67dbaa41f2 (diff-60a9387c0fc8406fd5b39fa995dd8c14)
it looks like the Rx timestamps are disabled by default
for UHD versions before 3.15
This commit fixes #1602
2020-08-05 13:05:29 +02:00
Xavier Arteaga
0cd61145ca
RFNOC: added optional FPGA FIFO
2020-07-31 13:11:10 +02:00
Xavier Arteaga
237de07ab3
UHD: disable AD936x based device reset
2020-07-31 13:11:10 +02:00
Xavier Arteaga
ff8925b6ec
UHD: use same timeout policy than previous release
2020-07-31 13:11:10 +02:00
Xavier Arteaga
ac76a398fe
UHD: Minor stability improvement
2020-07-31 13:11:10 +02:00
Xavier Arteaga
d2abaaf719
UHD: add initial test for AD936x based devices during initialization
2020-07-31 13:11:10 +02:00
Xavier Arteaga
f80c779d88
RFNOC: added DUC/DDC internal loopback option and test
2020-07-31 13:11:10 +02:00
Xavier Arteaga
dcf05f7a53
UHD: Improved RFNOC
2020-07-31 13:11:10 +02:00
Xavier Arteaga
38d9545e99
UHD: API improvement
2020-07-31 13:11:10 +02:00
Xavier Arteaga
405e0c8195
UHD: Check if tree exist before requesting access
2020-07-31 13:11:10 +02:00
Xavier Arteaga
5d43fc903e
UHD: fix SPP equal 0
2020-07-31 13:11:10 +02:00
Xavier Arteaga
774c0926a6
UHD: added device args for log level, spp and return if timeout
2020-07-31 13:11:10 +02:00
Xavier Arteaga
88a1ab12c5
UHD: Generic detects if it a AD9361, USB based device and resets if LIBUSB_TRANSFER_ERROR is detected
2020-07-31 13:11:10 +02:00
Xavier Arteaga
04a661d239
UHD: RFNOC class detects custom DDC and DUC
2020-07-31 13:11:10 +02:00
Xavier Arteaga
180fb42dc3
UHD: minor aesthetic corrections
2020-07-31 13:11:10 +02:00
Xavier Arteaga
0f24d510ac
UHD: Fix RFNOC DDC frequency calculator
2020-07-31 13:11:10 +02:00
Xavier Arteaga
ebf995c621
UHD: better RFNOC detection and configuration
2020-07-31 13:11:10 +02:00
Xavier Arteaga
0e360b3953
UHD: RFNOC Dynamic re-configuration
2020-07-31 13:11:10 +02:00
Xavier Arteaga
d9cb51d261
UHD: Added custom DDC/DUC support
...
UHD: Aesthetic corrections
UHD: minor aesthetic changes
2020-07-31 13:11:10 +02:00
Xavier Arteaga
e4a794fdbd
UHD: Initial RFNOC implementation
...
UHD: Fix RFNOC for multiple carriers
2020-07-31 13:11:10 +02:00
faluco
cfd3f51931
Import of srslog into srsepc and srsenb. ( #1574 )
...
* - Import of srslog into srsepc and srsenb.
* - Removed logger_file and logger_stdout files.
2020-07-30 19:17:23 +02:00
Xavier Arteaga
21e9a3958f
Minor changes
2020-07-28 09:31:34 +02:00
Xavier Arteaga
2271aec6b2
Radio: remove trace
2020-07-28 09:31:34 +02:00
Xavier Arteaga
a5fefbfdd3
Radio: fix possible overflow
2020-07-28 09:31:34 +02:00
Xavier Arteaga
51c6e8d1a6
Radio: channel map includes device mapping, unmapped Rx uses dummy buffers
2020-07-28 09:31:34 +02:00
Xavier Arteaga
74fde5597f
PDSCH_UE: added synchronization error to console
2020-07-28 09:31:34 +02:00
Xavier Arteaga
edda1f730a
srsLTE: Placeholder Band correction
2020-07-28 09:31:34 +02:00
Xavier Arteaga
d8eaa99132
Radio: do not use more radios than necessary
2020-07-28 09:31:34 +02:00
Xavier Arteaga
5258f27490
Fix start-of_burst for PRACH Test USRP
2020-07-28 09:31:34 +02:00
Ismael Gomez
dda91b14f7
Remove duplicate add_rnti() function since already done in set_config
2020-07-27 17:58:06 +02:00
Xavier Arteaga
fda1d040e7
SRSENB: implement PUSCH threshold for UCI bits
2020-07-27 16:44:15 +02:00
faluco
efdff8ba4c
Import srslog into srsue ( #1556 )
...
- Import the srslog project into srslte.
- Ported srsue app to use the new logging framework.
- Implemented a wrapper that dispatches log entries to srslog.
- Renamed an existing log test to be more specific to avoid name clashes.
2020-07-22 16:04:18 +02:00
Andre Puschmann
d441486f76
fading: fix heap buffer overflow in fading sim
...
at the when applying the fading channel we copied the state back
to our buffer. Since we are offsetting the read buffer
by X samples, we need to make sure that we don't read after then
(len-X) samples of the temporary memory buffer
2020-07-21 21:42:22 +02:00
Andre Puschmann
1199a79851
fix Scell sync for large cells
...
the PSS detection needs more temporary buffer than a full subframe.
we therefore need to allocate and initialize the sync object with
larger maximum size to support Scell search of large cells, e.g.
20 MHz
this fixes issue #1538
2020-07-21 18:35:53 +02:00
Ismael Gomez
f380f46a10
Revert "Remove unnecessary zero memory ( #1564 )"
...
This reverts commit f662aeaff3
.
2020-07-21 16:24:06 +02:00
Andre Puschmann
9550bd3ef8
rlc: revisit interface for MAC and RRC
...
* add locked and unlocked version of has_data() since one is
called from stack and one from PHY threads
* add comments in each interface section as to why locking
is required or not
* remove RLC rwlock when not required
* move calls only used by RRC to RRC section
2020-07-21 11:56:43 +02:00
Andre Puschmann
7f98cb9b62
pdcp: log discard timer duration in init()
...
to log the configured discard timer length
2020-07-21 11:56:43 +02:00
Andre Puschmann
a578ff1975
pdcp: fix typo
2020-07-21 11:56:43 +02:00
Francisco Paisana
58c4bcf288
reduce mcs for UL grants carrying UCI
2020-07-21 10:51:11 +01:00
Ismael Gomez
f662aeaff3
Remove unnecessary zero memory ( #1564 )
...
* RF drivers to allow nullptr buffers in send/recv
* Remove zeromem from radio
* remove unused buffers
2020-07-20 19:11:56 +02:00
Andre Puschmann
dc67d28709
nas: do not generate NAS encryption key if also is set to NULL
...
its more a cosmetic change to clean the logs. this makes
sure that a zero key is logged when NULL encryption is selected.
2020-07-20 10:58:10 +02:00
Ismael Gomez
1eaf7efab0
Fix UL adaptive retx rv index
2020-07-15 18:24:23 +02:00
Xavier Arteaga
5cf2089a8c
srsLTE: increased SRS test TA us threshold
2020-07-15 07:34:14 +02:00
Xavier Arteaga
794f969e1a
srsLTE: fix TA calculation
2020-07-15 07:34:14 +02:00
Xavier Arteaga
729986f259
srsLTE: Added PUCCH format 3 valid correlation
2020-07-15 07:34:14 +02:00
Xavier Arteaga
0192130742
SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index
...
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
2020-07-15 07:34:14 +02:00
Andre Puschmann
c8b4ba885b
rename rlc_tx_queue to byte_buffer_queue
...
this data structure will be used by the PDCP layer as well.
2020-07-14 18:18:32 +02:00
Francisco Paisana
36fc88d2e2
fsm log macros, and utility methods to convert event callbacks to move tasks
2020-07-14 13:33:50 +01:00
Francisco Paisana
9c5471b094
more ergonomic event callback
2020-07-14 13:33:50 +01:00
Francisco Paisana
d48a45976e
moved cell selection/search complete event signalling out of phy_controller
2020-07-14 13:33:50 +01:00
Francisco Paisana
489969722e
implemented phy controller FSM to perform cell selection & search. The controller also tracks the phy sync state
2020-07-14 13:33:50 +01:00
Andre Puschmann
6fb01d61a7
rlc: change remaining occurances of "SN: " to "SN="
...
streamline all RLC AM and UM for better log analysis
2020-07-14 09:47:53 +02:00
Xavier Arteaga
137d250d66
srsLTE: fix ZMQ decimation pointer
2020-07-13 19:15:25 +02:00
Andre Puschmann
a7911f0dab
pdcp,rlc: refactor SDU queueing policy
...
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.
When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.
To avoid this, this patch makes the following changes:
* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
* a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
* all writes into queues need to be non-blocking
* if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
* this case should be avoided with the monitoring mechanism
2020-07-13 17:05:28 +02:00
Andre Puschmann
7a66a00e15
block_queue: add method to check if given queue is full
2020-07-13 17:05:28 +02:00
Xavier Arteaga
f39abe0094
SRSENB: fix MAC pending PHY config
2020-07-13 15:27:46 +02:00
Francisco Paisana
5e06430455
removal of stack handler interface
2020-07-13 11:19:25 +01:00
Francisco Paisana
7c364070ee
creation of task scheduler interface for classes/functions running outside the main control thread
2020-07-13 11:19:25 +01:00
Francisco Paisana
039977aeb5
renamed interfaces
2020-07-13 11:19:25 +01:00
Francisco Paisana
1a9c04bf2f
use of task scheduler handle in pdcp
2020-07-13 11:19:25 +01:00
Francisco Paisana
e9f34c7613
using task scheduler in enb stack
2020-07-13 11:19:25 +01:00
Francisco Paisana
4f5e65781f
created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks
2020-07-13 11:19:25 +01:00
Pedro Alvarez
89b6e0f714
Send paging message to all cells.
2020-07-10 10:14:08 +01:00
Francisco Paisana
fe8f8be62d
apply separate cqi configurations to scells
2020-07-09 18:56:01 +02:00
Andre Puschmann
d5f0ad9f35
pdcp: fix typo
2020-07-09 16:13:16 +02:00
Andre Puschmann
2749c870e3
rlc_am: refactor control test
...
* move both tests into own functions and call those in main()
* use common test header and macros
2020-07-08 10:09:06 +02:00
Andre Puschmann
035c369a43
mac_pdu: fix check of remaining length when adding new subheader to MAC PDU
...
when adding a new subheader to a MAC PDU we should only add the subheader
if at least 2 bytes are left in the PDU. Even a 1 Byte MAC Control Element requires
another byte to pack the subheader.
This fixes #1424 in which a 3 B MAC opportunity is provided in the UL. After
adding the Short BSR, we tried to add another MAC subheader. Adding the subheader
succeeded even though no space is left to add a single byte. With this patch,
adding the subheader fails and the generates MAC PDU is correct.
2020-07-08 10:08:26 +02:00
Andre Puschmann
58e255cb63
pdu_test: add unit test to verify correct packing of 3B PDU with Short BSR
2020-07-08 10:08:26 +02:00
Andre Puschmann
5589816690
pdu_test: fix PCAP output
...
API now requires to pass CC index
2020-07-08 10:08:26 +02:00
Andre Puschmann
f6d3467884
ringbuffer: fix timeout calculation for timed read
...
with ZMQ RF, we've seen the radio returning -1 and traced
the issue down to the ringbuffer.
in fact, pthread_cond_timedwait() returned 22 (EINVAL) indicating
a wrong timeout value. The issue was likely an overflow
in the timespec parameter. This patch checks for the return
value of pthread_cond_timedwait() and also calculates the
nanosecond wrap around for the timespec
2020-07-07 23:04:05 +02:00
Andre Puschmann
aed38a6028
rf_zmq: increase default ZMQ timeout to 2s
...
amarisoft flags an RF error and exits after not receiving samples
for the radio. Running with ZMQ in the RFCI, the UE sometimes needs more
time to start up due to slow processing and no fftw wisdom file and
then Amarisoft eNB times out. This gives the whole process a little
bit more time. Should we still find it too short we may increase
it further.
2020-07-07 23:04:05 +02:00
Andre Puschmann
b3e92883d4
rlc_um: reduce log level when provided space is not enough to build PDU
...
this is not a warning case as it can always happen. reduce level to info therefore.
2020-07-07 18:01:39 +02:00
Andre Puschmann
95f5093432
rlc_am: hold lock while handling new PDUs
...
This lock was removed in 1cbf7eac
because it was considered unneeded.
However, as can be seen in issue #1503 , we need to protect the access
to rx_window, for example.
Issue #1503 shows a stack trace where a PHY worker generates a status PDU.
While holding the mutex to access rx_window, the stack thread on the
other hand, happily accesses the rx_window member without acquiring
the lock. This commit protects all handle_*() functions in write_pdu().
This reverts commit 1cbf7eac04
.
2020-07-07 10:41:14 +02:00
Francisco Paisana
e550bf726d
updated fsm to allow enter methods to receive event that caused them
2020-07-06 14:25:03 +01:00
Andre Puschmann
6f5da19312
pdcp: similar to tx, also reduce log for Rx
...
instead of logging PDU received from below, and SDU that is forwarded
to above, only log the PDU in rx in info mode.
The next layer will do the same and log the PDU received (which is the SDU coming from here)
so there is now loss of information in the logs.
2020-07-05 16:56:06 +02:00
Andre Puschmann
6654453e22
pdcp: reduce amount of log messages during tx
...
drop logging encrypted PDU seperately. Instead, only log formatted
PDCP PDU before passing to lower layers
2020-07-05 16:56:06 +02:00
Xavier Arteaga
6f03ce7e11
srsLTE: minor radio fix
2020-07-03 10:48:20 +02:00
Xavier Arteaga
67543a73bb
Radio: fix erroneous offset
2020-07-03 10:48:20 +02:00
Xavier Arteaga
8966db31d8
srsLTE: Radio benchmark plots all ports
2020-07-03 10:48:20 +02:00
Andre Puschmann
ff96336f91
rlc_um: fix reestablishment for sending UM entity
...
we've reset the rx state variables during reestablishment but not
the tx state variable.
2020-07-02 17:52:55 +02:00
Francisco Paisana
84f34bc736
changed to a label filtering approach for ctest
2020-07-02 15:56:59 +01:00
Francisco Paisana
ebb8f18000
set some extra tests with the prefix "long_"
2020-07-02 15:56:59 +01:00
Francisco Paisana
c6323478d2
remove unecessary sleeps in mac test, and add long_ prefix in long tests
2020-07-02 15:56:59 +01:00
Andre Puschmann
eb56efe9f5
rlc_am_lte: turn error message into warning and print state variables
...
the issue doesn't cause any unrecoverable situation so its not
appropiate to use the error level
2020-06-30 14:25:56 +02:00
Francisco Paisana
cb7f620254
created separate class to manage bearers buffers/status reports in the scheduler
2020-06-29 17:31:07 +01:00
Andre Puschmann
a3d7d4517c
rlc_um: add dedicated unit test for the PDU packing bug
...
Here is the test output with the fix disabled:
13:47:42.679774 [RLC_UM_1] [D] MAC opportunity - 14 bytes
13:47:42.679784 [RLC_UM_1] [D] pdu_space=14, head_len=2
13:47:42.679790 [RLC_UM_1] [D] adding new SDU segment - 10 bytes of 10 remaining
13:47:42.679834 [RLC_UM_1] [D] Complete SDU scheduled for tx. Stack latency: 0 us
13:47:42.679909 [RLC_UM_1] [D] pdu_space=4, head_len=2
13:47:42.679922 [RLC_UM_1] [D] adding new SDU segment - 0 bytes of 10 remaining
13:47:42.679928 [RLC_UM_1] [I] Tx PDU SN=0 (14 B)
13:47:42.679974 [RLC_UM_1] [D] vt_us = 1
The test checks the correct packing and of the two PDUs at the end.
2020-06-26 17:58:36 +02:00
Andre Puschmann
df50dd7d3c
rlc: extend RLC metrics
...
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
2020-06-26 17:58:36 +02:00
Andre Puschmann
48db31c5cf
rlc_stress_test: fix random PDU dropping
...
the rand() was sometimes giving NaN so this case needs to be handled
and the PDU not dropped to have real zero drop-rate
2020-06-26 17:58:36 +02:00
Andre Puschmann
82f811ed52
rlc_am: change return value when writing SDU
...
return false when SDU couldn't be added to SDU tx queue so
to count dropped SDUs in base
2020-06-26 17:58:36 +02:00
Andre Puschmann
3cef20607e
rlc_am: fix bug in returning zero len bytes
2020-06-26 17:58:36 +02:00
Andre Puschmann
86025cf390
rlc_um: fix PDU packing when newly added SDU segment was too large
...
during the PDU packing it could happen that a new SDU segment
was added but the resulting larger header was so big that not even
a single byte of the new PDU could be added. because this
corner case wasn't handled correctly an invalid PDU was transmitted.
the solution is to revert the addition of the new SDU.
2020-06-26 17:58:36 +02:00
Andre Puschmann
fc3cd24177
rlc_um: fix counting of lost PDUs
...
* change try_push() return value to indicate whether the addition
of the SDU to the tx queue was successful or not
* count lost PDUs
2020-06-26 17:58:36 +02:00
Andre Puschmann
96726a03e0
rlc_stress_test: fix PCAP support
...
expose actual RLC configuration to PCAP object
2020-06-26 17:58:36 +02:00
Andre Puschmann
1c7bfde404
rlc_stress_test: fix compilation with PCAP enabled
2020-06-26 17:58:36 +02:00
Ismael Gomez
493b7ea2da
Remove SNR threshold based link failure detection
2020-06-25 22:57:31 +02:00
Ismael Gomez
874e614970
Increase PUCCH detection threshold to avoid false alarms
2020-06-25 22:57:31 +02:00
Francisco Paisana
2de702f50e
disable carrier aggregation when ue release is below 10 or category is below 5
2020-06-25 21:13:11 +01:00
Francisco Paisana
9855749e9a
remove comments
2020-06-24 23:28:53 +01:00
Francisco Paisana
eee195c828
remote commented lines and added comments
2020-06-24 23:28:53 +01:00
Francisco Paisana
8ea059d578
fix pnf messages and shutdown
2020-06-24 23:28:53 +01:00
Francisco Paisana
e555e50a90
fix pnf packing for MIB messages
2020-06-24 23:28:53 +01:00
Francisco Paisana
e3e9bbcd62
fix PNF PDU size cutting
2020-06-24 23:28:53 +01:00
Francisco Paisana
a0606669e2
fix ue nr gw initialization
2020-06-24 23:28:53 +01:00
Francisco Paisana
e6418b4b39
fix variable naming
2020-06-24 23:28:53 +01:00
Francisco Paisana
1d07258458
created pnf bridge executable
2020-06-24 23:28:53 +01:00
Francisco Paisana
fddcbc9879
fix vnf-ue stack interface
2020-06-24 23:28:53 +01:00
Andre Puschmann
ad1b9d4d9b
rlc_um: improve warning message to better differentiate them
2020-06-23 10:56:27 +02:00
Francisco Paisana
d7138b7752
fix nr activation guards
2020-06-19 13:33:16 +01:00
Ismael Gomez
29e126a583
Add per-channel TX gain ( #1450 )
...
* Change type of rf_set_gain() to avoid unambiguous return with negative gains
* Add per-channel TX gain
2020-06-19 11:00:12 +02:00
Francisco Paisana
52c6c6aafd
add ifdef guards for NR code
2020-06-18 23:37:26 +01:00
Francisco Paisana
0938c447f7
fix compilation error
2020-06-18 23:37:26 +01:00
Francisco Paisana
b68ef69ab4
fix comments and other minor issues
2020-06-18 23:37:26 +01:00
Francisco Paisana
468389997e
fix header sn check
2020-06-18 23:37:26 +01:00
Francisco Paisana
0259d31b13
fix lack of final in pdcp virtual methods
2020-06-18 23:37:26 +01:00
Francisco Paisana
eb69683dc3
fix lack of final in virtual methods
2020-06-18 23:37:26 +01:00
Francisco Paisana
42969ad992
add tb size as argument to gnb
2020-06-18 23:37:26 +01:00
Francisco Paisana
2f8dad03cc
add rlc nr locking
2020-06-18 23:37:26 +01:00
Francisco Paisana
f0874b780b
add radio_base/null classes
2020-06-18 23:37:26 +01:00
Francisco Paisana
64e8f5e3ed
update license year
2020-06-18 12:41:54 +01:00
Pedro Alvarez
9c1a7d2cf1
Removed get_bearer_status in PDCP. Renamed get_state/set_state to
...
get_bearer_state/set_bearer_state.
2020-06-18 12:13:57 +01:00
Pedro Alvarez
208a539499
Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn
...
variables.
2020-06-18 12:13:57 +01:00
Pedro Alvarez
08578a7331
Switched to use a struct to hold the PDCP entity state variables. Deleted some unecessary setters.
2020-06-18 12:13:57 +01:00
Pedro Alvarez
66d4f320e5
Added intereface to set PDCP state after reestablishment.
2020-06-18 12:13:57 +01:00
Pedro Alvarez
33567d81db
Added interface to get internal PDCP state.
2020-06-18 12:13:57 +01:00
Pedro Alvarez
4093e75237
Starting to add getters and setters of the state in PDCP lte entity.
2020-06-18 12:13:57 +01:00
Xavier Arteaga
0e415260e9
SRSUE: scell_sync vector changed to map
2020-06-18 09:51:51 +02:00
Xavier Arteaga
e0e8405285
SRSUE: initial scell sync
...
SRSUE: SCell Synch feedbacks delay
SRSUE: Implemented SCell Radio offset correction
2020-06-18 09:51:51 +02:00
Xavier Arteaga
5c0bb000ca
UE DL does not complain if no grant is not found
2020-06-18 09:51:51 +02:00
Xavier Arteaga
8a774136de
Radio: return error if a RF instance fails to open
2020-06-16 11:00:51 +02:00
Xavier Arteaga
f04cf2090a
Integrates number of samples in radio buffer
...
Fix minor issue
Radio: Fix minor bug and add unit test
2020-06-16 11:00:51 +02:00
Xavier Arteaga
de230826b9
Added string helper for removing spaces and parsing list
...
Fix
Fix string parser
2020-06-16 11:00:51 +02:00
Xavier Arteaga
89b24b54e5
Refactored radio class for acommodating multiple RF devices
2020-06-16 11:00:51 +02:00
Andre Puschmann
1f73e6ae69
multiqueue: add option to create queue with non-default capacity
...
this allows to create a queue that has a non-default capacity
currently this is 8192, but the value might now be suitable in some
cases like for TTI sync events
2020-06-12 21:37:10 +02:00
Francisco Paisana
3c2e3dbdbf
added latest mac nr updates
2020-06-11 15:50:36 +01:00
Francisco Paisana
cc52edf820
added latest pnf/vnf api updates
2020-06-11 15:50:36 +01:00
Francisco Paisana
27e5d98ef9
added vnf phy nr
2020-06-11 15:50:36 +01:00
Francisco Paisana
b05ce2fe57
added pnf_dummy test
2020-06-11 15:50:36 +01:00
Francisco Paisana
8a022fb35b
fix noexcept declaration issue in gcc4.8
2020-06-11 14:25:21 +02:00
Francisco Paisana
6509399ed3
fix for move-only events
2020-06-11 10:37:35 +01:00
Francisco Paisana
12dda03bb8
add ability for fsms to self-trigger
2020-06-11 10:37:35 +01:00
Andre Puschmann
9f98bb3f54
disable prach_test_usrp compilation if no RF is selected
2020-06-11 11:07:06 +02:00
Francisco Paisana
d859c33035
added check for UCI collision during DL scheduling for CA
2020-06-10 22:22:41 +01:00
Ismael Gomez
60b5fb9a74
Refactor variable name
2020-06-10 21:30:39 +02:00
Xavier Arteaga
0e5704731e
Removed UHD unrelated changes
2020-06-10 11:44:44 +02:00
Xavier Arteaga
258f7a180c
Improved PRACH test USRP
2020-06-10 11:44:44 +02:00
Xavier Arteaga
cd463d1b87
UHD: Initial C++ porting
...
UHD: cmakefix
x3
2020-06-10 11:44:44 +02:00
Andre Puschmann
8512c10286
create simple helper method to log command line arguments
2020-06-09 20:55:38 +02:00
Xavier Arteaga
039f2164a6
Initial Sounding Reference Signals implementation
2020-06-08 09:33:51 +02:00
Francisco Paisana
613003ac53
add srsenb::rrc class
2020-06-05 15:10:11 +01:00
Ismael Gomez
84b84eaad6
Move search_in_common variable
2020-06-03 17:23:42 +02:00
Ismael Gomez
9b634b8d2a
Search DCI in UE space before common to avoid DCI size ambiguity. Fixes #1398
2020-06-03 17:23:42 +02:00
Francisco Paisana
c6dde24476
avoid blocking when new procedure is launched from within proc::then call
2020-06-02 22:42:53 +01:00
Pedro Alvarez
960c0e97cd
Added handling of RRC re-establishment to srsENB.
...
* Added the appropriate code for handling and sending the
re-establishment procedure messages to rrc_ue.c/.h.
* Triggered RRC reconfiguration after the reception of RRC
re-establishment complete
* Refreshed K_eNB at the reception of re-establishment
request
* Changed the mapping of TEIDs to RNTIs in the GTP-U layer,
as the RNTI might change with reestablishment.
2020-06-02 11:19:17 +01:00
Daniel Willmann
0e99e2f6eb
srsue: Refactor definition to live in its own .cc file
2020-06-02 10:05:38 +02:00
Francisco Paisana
452c043370
created a global map of lcids to srbs/drbs for NR
2020-05-29 14:11:23 +01:00
Andre Puschmann
9fd327fcac
soapy: use SoapySDRDevice_enumerateStrArgs to create Soapy args object
...
this allows to use Soapy device parameter when creating the device
2020-05-28 14:17:20 +02:00
Andre Puschmann
ff508a2c6b
npdsch_ue: add rf_dev param and make remove samp rate check
...
the remove of the samp rate check was needed on the PlutoSDR
because the result would not be the exact value that was
asked for
2020-05-28 14:17:20 +02:00
David Rupprecht
61b69a0dab
security: refactor code, fix race in eia1
...
* state funktion for eia1 (mitigate race condition)
* Extra file for snow3g
* just use mbedtls aes
* ref specification
* adding const keyword to security functions
2020-05-28 14:02:14 +02:00
faluco
617cad58ab
Fix identation of arrays.
2020-05-28 11:27:15 +02:00
faluco
cf5b321fb5
Replace magic numbers with macro constants.
...
Adjust comments to refer to these macros.
2020-05-28 11:27:15 +02:00
faluco
ac3b7ed54c
Move static array inside function as it is only used in there.
2020-05-28 11:27:15 +02:00
faluco
9484db8a90
Added header comments to srslte_sfidx_tdd_nof_X family of functions.
...
Fixed a comment referring to an older TS release.
Remove elses after returns.
2020-05-28 11:27:15 +02:00
faluco
8c59606d6f
Add comment header to srslte_sfidx_tdd_type.
...
Remove else after return.
2020-05-28 11:27:15 +02:00
faluco
7354f49fe5
Added explanatory comments to TDD phy structs and enums.
2020-05-28 11:27:15 +02:00
Xavier Arteaga
9f5aef30e6
SRSENB: fix DL ACK decoding
2020-05-28 10:29:51 +02:00
Francisco Paisana
026628a84f
use of reestablishment method to reset the RLC bearers during handover
2020-05-26 14:46:41 +01:00
Francisco Paisana
edba7f57e4
corrected mac_nr_pdu includes
2020-05-26 10:02:08 +01:00
Ismael Gomez
270c7ce9dc
Separate PHY interface to add rnti and pregenerate sequences. Calculate the sequences on the reception of ConnectionSetup instead of PRACH
2020-05-25 13:12:19 +02:00
Francisco Paisana
d7c7bb382a
fix license year
2020-05-25 11:48:16 +01:00
Francisco Paisana
2da8c923b1
removed commented code and fixed interfaces
2020-05-25 11:48:16 +01:00
Francisco Paisana
b4b5cd7cd6
added nr gnb and ue interfaces
2020-05-25 11:48:16 +01:00
Ismael Gomez
a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) ( #1361 )
2020-05-22 11:20:33 +02:00
Francisco Paisana
8e9da9d12e
avoid creating unused static variable to avoid linking issues
2020-05-21 16:45:16 +01:00
Andre Puschmann
1eaa99530f
rlc_am: tiny refactor of rlc_amd_pdu_header_t
...
mainly turning header into proper class and adding default init value
2020-05-21 10:33:55 +02:00
Andre Puschmann
8756d14660
enb_interface: add default initialize to zero
2020-05-21 10:32:31 +02:00
Francisco Paisana
c87197dd4e
fix deadlock in multiqueue reset method.
2020-05-20 11:04:16 +01:00
Xavier Arteaga
20db13abc7
SRSUE: fix condition number calculation
2020-05-19 22:31:56 +02:00
Xavier Arteaga
9d5c2d70df
SRSENB: Fix PHY reconfiguration for HO
...
Minimal aesthetic change
2020-05-19 16:38:55 +02:00
Pedro Alvarez
6ce33c3812
Small compilation fixes for GCC 10.1
2020-05-18 18:08:45 +01:00
Francisco Paisana
e8aff22e1b
using new rrc obj id util methods in handover code
2020-05-14 20:51:16 +01:00
Francisco Paisana
f43985b6cd
small updates for testing handover and configuring the rrc
2020-05-13 21:02:53 +01:00
Francisco Paisana
598bad1f0e
changed rrc ue cfg files names
2020-05-13 12:39:58 +01:00
Francisco Paisana
d43448e8a1
created security cfg handling class for rrc ue and refactor bearer_list handling
2020-05-12 17:28:11 +01:00
Francisco Paisana
ca0db7fffe
created generic methods to apply toaddmodlist and removelists.
2020-05-12 14:17:57 +01:00
Francisco Paisana
c65c081b51
created separate files to handle rrc bearers
2020-05-12 14:17:57 +01:00
Francisco Paisana
65abcd2903
use true_type to represent success
2020-05-11 16:08:20 +01:00
Francisco Paisana
791d84e639
created error_type and cleaned up expected
2020-05-11 16:08:20 +01:00
Francisco Paisana
9a7f48b6a5
fix gcc4.8 compilation issue
2020-05-11 16:08:20 +01:00
Francisco Paisana
975d004224
fix compilation error
2020-05-11 16:08:20 +01:00
Francisco Paisana
0f49cb7357
abort if bad access
2020-05-11 16:08:20 +01:00
Francisco Paisana
a2b76a4a5f
use references rather than pointers
2020-05-11 16:08:20 +01:00
Francisco Paisana
a88bffa5d5
created expected type and respective test
2020-05-11 16:08:20 +01:00
Andre Puschmann
bdd97ca25f
pdsch_enodeb: remove check in while-loop
...
this check is always true since the false case is caught
before and the application is closed()
2020-05-11 14:49:56 +02:00
Fabian Eckermann
447b989aad
fix parsing of zmq arguments
...
Use the return value of parse_string function to determine whether a parameter was found.
I experienced issues when the rx_type was set, but the rx_format was not. This led to "Unsupported sample format pub" as the tmp variable is still set to the value of the rx_type.
2020-05-09 12:23:07 +02:00
Ismael Gomez
847366bcdb
Don't set high master clock rate for 75 PRB
2020-05-08 22:10:28 +02:00
faluco
3fa5926cd5
Fix SIMD neg operation which was inverted.
...
Re-enable -Werror.
2020-05-08 21:17:05 +02:00
faluco
4fb290ea27
Remove ifdefs now that this SIMD op is supported.
2020-05-08 21:17:05 +02:00
faluco
c39ea2f583
Adjust possible type mismatch.
2020-05-08 21:17:05 +02:00
Andre Puschmann
189685b6f5
demod_soft: fix clang warning in demod NEON code
...
Try to bring back compilation.
Disable temporarily Werror.
Re-enable two simd functions.
2020-05-08 21:17:05 +02:00
Andre Puschmann
f67524707d
neon: add srslte_simd_b_neg()
...
clang complained about an uinit var that is returned and it turned
out that we don't even implement that function in NEON.
I've found a nice MIT-licensed header that was easy to integrate.
2020-05-08 21:17:05 +02:00
Andre Puschmann
53ab53ee77
ue_sync: fix tracking in GNSS_SYNC mode
...
this fixes the subframe-accurate rx in tracking mode.
previously we've only alligned to the next subframe start in find and
when there was a single overflow we've lost the track.
this patch calculates the offset in samples to the actual start of the
subframe (full ms of the receive timestamp) vs. the actual
receive timestamp and uses the value as the "next_rf_sample_offset"
to realign on the next receive
2020-05-08 14:33:12 +02:00
Andre Puschmann
14143f8560
pssch_ue: fix memory leaks and operation with RF
...
- add missing free's for ofdm and chest objects
- fix sf_idx setting
- add getchar() when plotting from file to observe output
2020-05-08 14:33:12 +02:00
Andre Puschmann
ca3b76df6e
chest_sl: fix some possible array access at negative index
2020-05-08 14:15:10 +02:00
Francisco Paisana
cf9d31ea64
fix coverity warning for useless call
2020-05-08 14:14:25 +02:00
Andre Puschmann
28c98280d7
ue_dl_nbiot: convert macro to access SF contents into member var
...
also use srslte_vec_cf_cp() helper functions
2020-05-07 19:53:10 +02:00
Andre Puschmann
9648e47eb6
ue_cell_search_nbiot: fix potential out-of-bounds access
...
we've used a macro that can return -1 as access index
for an array. this has now been converted in a member
that is initialized and checked during init
2020-05-07 19:53:10 +02:00
Andre Puschmann
d64fa19321
ue_dl_nbiot: check sf_idx before accessing buffer
...
this fixes a potential out-of-bounds access
2020-05-07 19:53:10 +02:00
Andre Puschmann
ba4c2f10f0
fix potential out-of-bounds access in static look-up-tables
...
check index before accessing lut
2020-05-07 19:53:10 +02:00
Andre Puschmann
52799192ab
pssch_ue: fix uninit var
2020-05-07 19:53:10 +02:00
Andre Puschmann
7aeddfd186
fix potential error where return value -1 is used for loop termination
2020-05-07 19:53:10 +02:00
faluco
340ec61e8e
Code review.
2020-05-07 18:53:40 +02:00
faluco
e28d9bb473
Fix for 1492950.
2020-05-07 18:53:40 +02:00
faluco
6fdceadc4e
Fix for 1480100.
2020-05-07 18:53:40 +02:00
faluco
7bec101831
Small refactor to eliminate a function that causes undefined behaviour.
2020-05-07 18:52:01 +02:00
Andre Puschmann
a0665b721e
prach: fix illegal mem access when wrong configs are passed
...
this fixes Coverity issue 1480095
2020-05-07 13:25:02 +02:00
Xavier Arteaga
282cda7155
Fix Radio segfault
2020-05-07 13:09:46 +02:00
Xavier Arteaga
f69aad3aac
Clean up channel class
2020-05-07 13:09:46 +02:00
faluco
d9529a3a8f
Fix for 1480071.
2020-05-07 10:12:29 +02:00
faluco
0ba9164ae2
Fix for 1480055.
2020-05-07 10:12:29 +02:00
Andre Puschmann
8185b7c793
ue_dl: fix potential out-of-bounds access when decoding DCIs
...
fixes Coverity issue 1480088 where srslte_ue_dl_find_dl_dci() expects
an array of struct srslte_dci_dl_t but is only given one element.
srslte_ue_dl_find_and_decode() itself only uses the first decoded
message but find_dl_dci() may still decode more than that
2020-05-07 10:11:21 +02:00
faluco
9efa24bfa9
More warning fixes.
2020-05-07 10:10:24 +02:00
faluco
d3cb5dcffd
Start fixing clang 10.0.0 warnings.
...
Disable -Werror temporarily.
2020-05-07 10:10:24 +02:00
faluco
74dae2c287
- Small refactor to make math operations without implicit casts.
2020-05-07 10:10:24 +02:00
faluco
d7433a551b
Initialize TDD matrix with shorter symbols using macros. While there move another matrix next to where it is used.
2020-05-07 10:10:24 +02:00
faluco
7ff251f112
- Fixed warnings caught by Clang 9.0.0
2020-05-07 10:10:24 +02:00
Francisco Paisana
2204cab4c8
old gcc version cannot support the detected pattern. Removing it
2020-05-05 19:42:34 +01:00
Francisco Paisana
e3d0b1c89e
format missing fsm table
2020-05-05 19:42:34 +01:00
Francisco Paisana
f4d19a6d44
added fsm table formmatting comments
2020-05-05 19:42:34 +01:00
Francisco Paisana
3ef8c67d67
enter/exit are now inside the state class. No need for friend classes anymore
2020-05-05 19:42:34 +01:00
Francisco Paisana
2641c6ef08
resolve template type derivation in clang
2020-05-05 19:42:34 +01:00
Francisco Paisana
9b48130ae1
use of transition table to support guards in fsms
2020-05-05 19:42:34 +01:00
Francisco Paisana
04e192eb0f
redesign fsm to use transition table
2020-05-05 19:42:34 +01:00
Andre Puschmann
49a375ce1a
arch_select: fix compilation for clang 3
...
In clang 3's C headers, the bit_SSE4_2 and bit_AVX2 macros
aren't defined/supported. So we can only use them if
they exist.
2020-05-05 19:04:14 +01:00
Andre Puschmann
99c3975f83
remove CMake option to disable glibc header for IPv6
...
we've added this to allow building for older glibc
version that cause issues with redefining some structs.
this patch removes the flag and auto-detects it using the glibc version
2020-05-05 19:04:14 +01:00
Francisco Paisana
fbd889ad4d
fix formatting issues in asn1
2020-05-05 18:33:52 +01:00
Francisco Paisana
e79fc9bf08
fixed generation of ie containers of one single ie object
2020-05-05 13:10:41 +01:00
Andre Puschmann
e3e3848210
cell_search_nbiot: show DL frequency in MHz
2020-05-04 17:52:21 +02:00
Andre Puschmann
f5d55847c2
nbiot: add r14 parameter to NPDSCH eNB and file test and make it the default
...
also add skip SIB2 option to UE example
2020-05-04 17:52:21 +02:00
Andre Puschmann
92fb6a94f4
npdsch: use r14 bcch sequence when encoding SIB
2020-05-04 17:52:21 +02:00
Andre Puschmann
2c6a95c1d5
nbiot_sync: fix potential segfault during sync when time gap is too big
2020-05-04 17:52:21 +02:00
yagoda
3f99e40159
-changing rlc so that mrb is never removed when going to idle
...
-adding metric counting to eMBMS MAC so that the count is not lost during eMBMS subframes
2020-05-04 17:50:57 +02:00
Francisco Paisana
e5533e4bcd
gcc 4.8.5 does not have std::max_align_t
2020-05-04 14:59:25 +01:00
Xavier Arteaga
d94078d543
Minor changes
...
Fix UE sequence generation
minor change
2020-05-01 21:07:33 +02:00
Ismael Gomez
8c82203c74
Removed unused pregenerate option
2020-05-01 21:05:00 +02:00
Xavier Arteaga
2d39c7261c
renamed vector copy prefix from to
2020-04-30 13:43:17 +02:00
Andre Puschmann
9d529ba0d5
fix compilation on arm, add missing declaration and headers
2020-04-30 13:37:49 +02:00
Xavier Arteaga
2569a94deb
Radio Tx handles more overlap/gap cases
2020-04-30 09:51:19 +02:00
Andre Puschmann
cd26f6988c
temporarily disbale rf_zmq_test test due to hanging on exit on some platforms
2020-04-30 09:48:12 +02:00
Xavier Arteaga
e15c49c5a5
Fix EVM hard-decision performance
2020-04-29 21:11:30 +02:00
Andre Puschmann
f4f7210c56
pssch_ue: LGTM fixes
2020-04-29 18:56:46 +02:00
Andre Puschmann
68a1868c33
npdsch_{ue,enodeb}: few more LGTM fixes
2020-04-29 18:56:46 +02:00
Andre Puschmann
6a764ae87c
psbch: change memcpy() to srs_vec alternative
2020-04-29 15:31:29 +02:00
Francisco Paisana
615bd54fd5
fix uninit var
2020-04-29 11:17:00 +02:00
Francisco Paisana
f8c6f55cac
fix uninit var usages and signed bit manipulations
2020-04-29 11:17:00 +02:00
Francisco Paisana
de4d58d8fe
fix coverity scan issues in master
2020-04-29 11:17:00 +02:00
Ismael Gomez
c0054140e9
Configure properly PUCCH CS mode for CA in ConnectionReconfiguration. Allocate n_pucch_cs resource and cqi/sr at rrc::ue constructor
2020-04-29 10:11:43 +01:00
Xavier Arteaga
928439b94c
DL Wiener: optimized with inlining
2020-04-28 17:26:01 +02:00
Xavier Arteaga
9d0a3268e8
Added DL channel estimator algorithm options
2020-04-28 17:26:01 +02:00
Xavier Arteaga
355b2ed7e1
Wiener: fixed more issues
2020-04-28 17:26:01 +02:00
Xavier Arteaga
9b9389ead5
DL Wiener: bug fixed and verified
2020-04-28 17:26:01 +02:00
Xavier Arteaga
4b6691a630
DL Wiener: Fixed phy common header missing
2020-04-28 17:26:01 +02:00
Xavier Arteaga
3ab5f3a7e8
Initial wiener filter integradion in DL channel estimator
2020-04-28 17:26:01 +02:00
Xavier Arteaga
5199aaa94e
DL Wiener: Fixed minor header issues, format and optimization
2020-04-28 17:26:01 +02:00
Xavier Arteaga
6248ab43e3
Minor optimization in SIMD dot product kernel
2020-04-28 17:26:01 +02:00