Commit Graph

8162 Commits

Author SHA1 Message Date
Francisco 86dac9c823 several coverity high and medium impact fixes 2021-04-27 10:11:03 +01:00
Xavier Arteaga 9a4fcb605b Reviewed UHD Tx FSM 2021-04-27 09:52:41 +02:00
Xavier Arteaga 3413f29cc8 Fix channel interpolator for 4 ports 2021-04-27 09:50:33 +02:00
Andre Puschmann 03e1277b0b rf_soapy_imp: fix lowercase to detect Lime 2021-04-26 21:39:04 +02:00
Andre Puschmann a083b0da2a proc_ra: only log warning if RAR wasn't received in window
lead to some failing tests with RF where PRACH wasn't received
correctly. recovery machanism will retransmit PRACH.
2021-04-26 10:08:48 +02:00
Andre Puschmann 20575d3eec phy,enb: only initialize NR workers if needed
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
2021-04-26 09:43:58 +02:00
Andre Puschmann b569e81299 rf_soapy_imp: fix LTE sample rate info check
only print if Lime is substring in dev args, so don't print with blade
2021-04-26 09:43:58 +02:00
Andre Puschmann f76cd5ef83 backward: fix compile error on aarch64 2021-04-26 09:43:58 +02:00
Andre Puschmann 0826b86cec srsue: remove NR DL freq and ARFCN option
not required anymore as all NR carrier tuning is done
through RRC signaling
2021-04-25 21:05:23 +02:00
Andre Puschmann 4dd17aee45 rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
2021-04-25 21:05:23 +02:00
Andre Puschmann 6e79ae67aa ldpc/polar: add casts to avoid possible variable overflow before assignment 2021-04-25 21:03:53 +02:00
Andre Puschmann 92d4e6e746 adt/common: remove const from return type
reported by LGTM https://lgtm.com/projects/g/srsLTE/srsLTE/rev/pr-9ae46cae260b6b8137b34b9423bf1477bd6b5c42
2021-04-25 21:03:53 +02:00
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM
mainly fixmes, unused/empty code, etc.
2021-04-25 21:03:53 +02:00
AlaiaL 5fd4f421e9 Fixes coverity 366610 2021-04-23 21:22:06 +02:00
AlaiaL d88760f099 Fixes coverity 366620 2021-04-23 21:22:06 +02:00
AlaiaL beaa1b3e24 Fixes coverity 369569 2021-04-23 21:22:06 +02:00
AlaiaL 0535473895 Fixes coverity 369570 2021-04-23 21:22:06 +02:00
AlaiaL 6332490cae Fixes coverity 369581 2021-04-23 21:22:06 +02:00
AlaiaL 58ce75d3b4 Fixes coverity 369617 2021-04-23 21:22:06 +02:00
AlaiaL 385b12a33a Fixes coverity 369620 2021-04-23 21:22:06 +02:00
AlaiaL 23f0bd4d4f Fixed coverity 369716 2021-04-23 21:22:06 +02:00
AlaiaL 862784ee46 Fixed coverity 369719 2021-04-23 21:22:06 +02:00
AlaiaL 82788ca094 Fixed issues from coverity:
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
2021-04-23 21:22:06 +02:00
herlesupreeth 0f06ec0d9c Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.

In order to make use of this feature, use the following parameter in enb.conf

Example:

gtp_advertise_addr = 213.61.141.82
2021-04-23 20:31:36 +02:00
herlesupreeth aff9091ad3 Make use of RF device passed as argument 2021-04-23 20:31:36 +02:00
herlesupreeth 00a7d3a4cd Add option to provide RF device to use for cell search 2021-04-23 20:31:36 +02:00
Jan a786d1dda0 Update security algorithms in epc.conf
Added EEA3 and EIA3, since they were missing from the description completely.
I also included EIA0 with a remark, since my understanding is that the epc supports it, but most UEs reject it because it must only be used for unauthenticated emergency calls.
2021-04-23 20:31:36 +02:00
Matan Perelman 7ee52dc676 srsUE: Add option to filter N_id_2 / PSS to configuration 2021-04-23 20:31:36 +02:00
Matan Perelman ee997a4e4e NAS: Add configuration for full and short network names. 2021-04-23 20:31:36 +02:00
David Rupprecht 102a943171 Fixed naming srsLTE to srsRAN 2021-04-23 14:25:02 +02:00
David Rupprecht fd451e8be3 Configure Short PDCP NR SN support 2021-04-23 12:49:53 +02:00
Andre Puschmann 7817f12f1f phy_common: reduce log level to info when UL grant is tried to activate twice
in accordance with discussion in #2717 we reduce the log level to info
to avoid failing tests due to that event
2021-04-23 10:28:10 +02:00
faluco 1ccb62af3d Apply srsLTE formatting rules to srsLog. They were previously formatted with different rules when the project lived in the external rapo. 2021-04-22 16:35:23 +02:00
Xavier Arteaga 873f375ecc Make NR DCI test more exhaustive and fix issues 2021-04-22 14:16:46 +02:00
Xavier Arteaga ab6a5ef17a Added NR DCI conversion to string for formats 1_0 and 1_1 2021-04-22 14:16:46 +02:00
Xavier Arteaga bccfa8d875 Added NR DCI packing/unpacking format 1_1 2021-04-22 14:16:46 +02:00
Xavier Arteaga 11b9990224 Added NR DCI packing/unpacking format 0_1 2021-04-22 14:16:46 +02:00
faluco cd1c6732f7 Remove the creation of strings when preparing the contents of a log entry in sched_helpers. 2021-04-22 12:38:14 +02:00
faluco 0afd59a5a0 Replace a string with a const char * in the rlc to_string. 2021-04-22 12:38:14 +02:00
Francisco 289559af82 asn1 fix - fix choice access correct type assert 2021-04-22 10:21:08 +01:00
Francisco ff3fc0826b asn1 fixes and improvements
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
2021-04-22 10:21:08 +01:00
David Rupprecht 98914dab6a Allow pdcp lte entity to use 18 bit SN 2021-04-22 09:55:34 +02:00
Francisco 42e7fc656b s1ap fix - send S1AP UEContextRelease when the UE does a new RRC connection setup with the same TMSI 2021-04-21 16:49:36 +01:00
Francisco 23203b73ae fix - avoid recompiling srsue rrc files twice 2021-04-21 16:22:59 +01:00
faluco 69726bc939 Remove two allocs in the prio queues in sched_time_pf. 2021-04-21 15:05:48 +02:00
faluco 7df308c756 Remove two mallocs in the stack:
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
2021-04-21 15:05:48 +02:00
Andre Puschmann e3b77fd82a rrc_nr: set timeout for NR cell measurement to 250ms
the low timout of 10ms was:
1) causing too frequent measurement reports
2) causes a MO ping test to fail where the ICMP request
was sent on the LTE carrier but never got a reply because
the MCG addition was inbetween
2021-04-21 12:50:43 +02:00
Andre Puschmann 2c156f0007 proc_ra: add further state checks when getting harq_retx signalled
that makes sure to only restart contres timer if we are actually
in the contention resolution state.
2021-04-21 12:36:32 +02:00
Andre Puschmann 607ba7c262 mac_test: fix RAR test for Msg3 retx
with hi=1 the eNB signals a successul Msg3 reception.
To request a retx, which is the case in the MAC test,
it needs to signal a hi=0
2021-04-21 12:36:32 +02:00
Xavier Arteaga 7246ce0cea Fix MSG3 false retransmission
this fixes #2694 by considering hi=1 value and not treating
this as a Msg3 retx
2021-04-21 12:36:32 +02:00