Commit Graph

1934 Commits

Author SHA1 Message Date
Andre Puschmann b0bfc7956d use const& in metrics interface 2020-01-14 20:52:09 +01:00
Xavier Arteaga bca5d1a95a srsLTE: extend viterbi test 2020-01-13 16:20:31 +01:00
Francisco Paisana 182a721329 fix some integer printf potential warnings 2020-01-07 21:33:31 +01:00
Xavier Arteaga 8a666ee455 srsLTE: Increase UHD default sampling rate. Enables warning if USB2 is used. 2020-01-07 11:16:37 +01:00
Andre Puschmann be4ba504bd fix another bunch of uninit memory in tests, and one in srsENB 2020-01-07 11:12:34 +01:00
Andre Puschmann 0554064bf0 refactor NPBCH init, fix memset with zero length 2020-01-07 11:12:34 +01:00
Andre Puschmann 0394d21dd2 fix uninit memory in chest sl test when not test is executed 2020-01-07 11:12:34 +01:00
Andre Puschmann 06afe74bef add virtual dtor in sched_interface base class 2019-12-30 22:15:31 +01:00
Andre Puschmann 6ec573987a remove default value for 'blocking' param from pdcp::write_sdu()
there were two defaults and one was shadowing the other. This
commit removes both defaults and uses blocking-mode for RRC
calls to PDCP in the UE. The eNB write_sdu() uses the non-blocking
mode by default. We have to review the eNB's RRC perhaps and use blocking
there too and non-blocking only for data plane
2019-12-29 23:45:37 +01:00
Andre Puschmann 1155adf007 fixing printfs in asn1_utils 2019-12-29 23:37:49 +01:00
Andre Puschmann 0bd493b567 call byte_buffer cleanup in two enb tests and fix typo 2019-12-26 22:06:34 +01:00
Andre Puschmann c54fa568be fixing typo in CMake for PHY DL test 2019-12-24 10:51:48 +01:00
Andre Puschmann 03512547f5 add test for Sidelink channel estimator 2019-12-23 23:08:32 +01:00
Xavier Arteaga 0912701cb0 srsLTE: sidelink minor corrections 2019-12-23 23:08:32 +01:00
Andre Puschmann 7de51c8236 refactor Sidelink PSBCH and DMRS code 2019-12-23 23:08:32 +01:00
Xavier Arteaga 36b2102de8 SRSUE: avoid testing ue_phy_test 2019-12-23 22:57:37 +01:00
Xavier Arteaga 307c27dc30 srsLTE: ZMQ renamed struct field 2019-12-23 22:57:37 +01:00
Xavier Arteaga 2d98f92823 srsLTE: upgraded ZMQ for supporting frequency selection 2019-12-23 22:57:37 +01:00
Xavier Arteaga 11eafa8ab4 srsLTE: FFTW wisdom gets loaded and saved by default 2019-12-23 22:57:37 +01:00
Xavier Arteaga 892ece8cdd srsLTE: reduce number of SF for rf_zmq_test 2019-12-23 22:57:37 +01:00
Xavier Arteaga c92dce71b7 srsLTE: AGC only uses boundaries for requesting gain to Radio 2019-12-23 22:57:37 +01:00
Xavier Arteaga 097f492430 srsLTE: fix ZMQ RF module gain 2019-12-23 22:57:37 +01:00
Andre Puschmann 9e1b8bc95e disabling certain PHY DL tests that aren't working on ARM due to Turbo issues 2019-12-20 18:54:41 +01:00
Pedro Alvarez 6d4303cd94 Added option to force 32bit compilation (useful for debug). Fixed various warnings when compiling in a 32 bit arch. 2019-12-20 17:33:55 +01:00
Xavier Arteaga a96a7fe20a Removed srsue_phy from thread_test 2019-12-19 13:01:05 +01:00
Xavier Arteaga 089a5e21dc Label test that memcheck is excessively long 2019-12-19 13:01:05 +01:00
Xavier Arteaga b1c4cd7189 srsLTE: removed timout in tti semaphore 2019-12-19 13:01:05 +01:00
Xavier Arteaga 6bef91a788 srsLTE: TTI sempahore wait for all resuses wait code. 2019-12-19 13:01:05 +01:00
Xavier Arteaga ad46fc006f srsLTE: Fix thread memory leak. Moved test. Fix CLang warnings. 2019-12-19 13:01:05 +01:00
Xavier Arteaga a7e92c384e srsLTE: applied minor comments in tti semaphore 2019-12-19 13:01:05 +01:00
Xavier Arteaga 447ede327c srsLTE: removed unused argument 2019-12-19 13:01:05 +01:00
Xavier Arteaga 384c420c7c SRSUE: fix phy workers concurrency issue 2019-12-19 13:01:05 +01:00
Xavier Arteaga 173defd676 srsLTE: Execute load and save FFTW wisdom automatically 2019-12-19 13:01:05 +01:00
Xavier Arteaga 9c51af491a SRSUE: phy default arguments are set in constructor 2019-12-19 13:01:05 +01:00
Andre Puschmann 75672324b9 fix RRC connection reconfig for new bearer
this fixes the packing of a RRC connection reconfig after creating
a new ERAB

it also adds a PDCP config factory based on the received request
2019-12-18 15:27:42 +01:00
Andre Puschmann 41be303f27 fixing NAS PCAP ctor 2019-12-18 13:27:48 +01:00
Tiago Ferreira Alves 3fed21ce3e PSSS and SSSS implementation 2019-12-18 11:27:10 +01:00
Andre Puschmann 476f970ee1 replace FIXME with TODO 2019-12-18 11:25:56 +01:00
Andre Puschmann 0d1c8021f9 fix radio_multi interface if radio vector is still empty 2019-12-18 11:25:36 +01:00
Andre Puschmann 4f5e991480 fix typo in RLC AM 2019-12-16 17:16:15 +01:00
Pedro Alvarez c5979f59eb Clang format UE, eNB and lib (#850)
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
2019-12-16 16:04:22 +01:00
Andre Puschmann 2ed2e35aa7 fixing two size_t printfs 2019-12-16 14:06:26 +01:00
Vasil Velichkov 87a0a25c18 M2AP: Align 8 bits in liblte_m2ap_unpack_protocolie_singlecontainer
Alignment with more then 8 bits is unusual for APER encoding.

It seems clangs uses different packing for the LIBLTE_BIT_MSG_STRUCT
struct then gcc and puts more bytes between N_bits and header.

typedef struct {
  uint32 N_bits;
  uint8  header[LIBLTE_MSG_HEADER_OFFSET];
  uint8  msg[LIBLTE_MAX_MSG_SIZE_BITS];
} LIBLTE_BIT_MSG_STRUCT __attribute__((aligned(8)));

Fixes a failure in srslte_asn1_m2ap_test when compiled with clang
272: Test command: lib/test/asn1/srslte_asn1_m2ap_test
272: Test timeout computed to be: 1500
272: 03:47:13.189195 [M2AP] [I] M2 Setup Request original message
272:              0000: 00 05 00 37 00 00 03 00 0d 00 08 00 00 f1 10 00
272:              0010: 1a 2d 00 00 0e 40 0a 03 80 65 6e 62 31 61 32 64
272:              0020: 30 00 0f 00 16 00 00 10 00 11 00 00 f1 10 1a 2d
272:              0030: 00 10 27 10 01 02 00 01 02 00 02
272: [m2_setup_request_test][Line 95]: FAIL at (plmn_id[0] & 0x0F) == 0 && (plmn_id[0] & 0xF0) >> 4 == 0 && (plmn_id[1] & 0x0F) == 1
1/1 Test #272: srslte_asn1_m2ap_test ............***Failed    0.00 sec
2019-12-16 14:06:26 +01:00
Vasil Velichkov 72f04a31b6 Fix typo in -Wno-parentheses
This fixes the following clang's warning

warning: unknown warning option '-Wno-parantheses'; did you mean
      '-Wno-parentheses'? [-Wunknown-warning-option]
2019-12-16 14:06:26 +01:00
Andre Puschmann 42080e59f1 remove std::move when returning freshly created unique_ptr 2019-12-16 14:06:26 +01:00
Andre Puschmann c7ee887170 add factory function for creating PDCP config 2019-12-16 14:06:26 +01:00
Francisco Paisana 5b4c42ac77 pass argument by pointer to avoid gcc4.8 issue 2019-12-16 14:06:26 +01:00
Vasil Velichkov ef9d16a3cf PHY: Initialize pucch3_w_n_oc_5 using precomputed constants when compiled with clang
Fixes the following clang-7's error

srsLTE/lib/src/phy/phch/pucch.c:307:9: error: initializer element is not a compile-time constant
    {1, cexpf(I * 2 * M_PI / 5), cexpf(I * 4 * M_PI / 5), cexpf(I * 6 * M_PI / 5), cexpf(I * 8 * M_PI / 5)},
        ^~~~~~~~~~~~~~~~~~~~~~~

Add SRSLTE_PUCCH_FORMAT_3 in the pucch_test
2019-12-16 14:06:26 +01:00
Vasil Velichkov a44671fc77 PHY: Manually unroll loops that use _mm_extract_epi(8/16)
clang does not unroll those loops even though it supports the
-funroll-loops command line option, adding various #pragma unroll
options also does not help.

The unroll is needed to make the second argument a constant integer.

Enable the SSE/AVX turbo rate matching when compiling in debug mode.

srsLTE/lib/src/phy/fec/rm_turbo.c:590:33: error: argument to '__builtin_ia32_vec_ext_v16qi' must be a constant integer
          int8_t x  = (int8_t)  _mm_extract_epi8(xVal,   j+8);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib64/clang/7.0.1/include/smmintrin.h:1048:23: note: expanded from macro '_mm_extract_epi8'
  (int)(unsigned char)__builtin_ia32_vec_ext_v16qi((__v16qi)(__m128i)(X), \
                      ^
srsLTE/lib/src/phy/fec/rm_turbo.c:591:35: error: argument to '__builtin_ia32_vec_ext_v8hi' must be a constant integer
          uint16_t l = (uint16_t) _mm_extract_epi16(lutVal2, j);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib64/clang/7.0.1/include/emmintrin.h:4273:24: note: expanded from macro '_mm_extract_epi16'
  (int)(unsigned short)__builtin_ia32_vec_ext_v8hi((__v8hi)(__m128i)(a), \
2019-12-16 14:06:26 +01:00
Vasil Velichkov af2b4ecc79 Use -Wno-unused-but-set-variable only if supported
This fixes the following clang's warning

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean
      '-Wno-unused-const-variable'? [-Wunknown-warning-option]
2019-12-16 14:06:26 +01:00