PentHertz
/
srsLTE
mirror of https://github.com/PentHertz/srsLTE.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,386 Commits 3 Branches 23 Tags 67 MiB
Commit Graph

3921 Commits

Author SHA1 Message Date
Andre Puschmann 44baea6666 mac_nr: add UL HARQ 
this patch adds a basic UL HARQ entity for NR.

The patch also updates some interfaces between MAC/RA/HARQ,
i.e. get_temp_crnti().

It also adds a Msg3 unit test.
 2021-04-14 13:40:31 +02:00
Andre Puschmann b7146c41b2 nr: add NDI for PUSCH grant to sch cfg struct 2021-04-14 13:40:31 +02:00
faluco a474a0f293 SRSLOG: Avoid calling unordered_map::emplace if element already exists since it will allocate even if the insertion is not going to take place. 2021-04-14 12:41:35 +02:00
Xavier Arteaga 80f5c82b53 Fix formatter test 2021-04-14 08:16:44 +02:00
Xavier Arteaga 7823bfc28c Fix append NR to loggers for NR components 2021-04-14 08:16:44 +02:00
Francisco c2a99a8112 handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB 2021-04-13 21:23:13 +01:00
faluco daad20c9d4 Disable copy and move operations for dyn_node_pool. 2021-04-13 17:36:39 +02:00
faluco a2f6e13138 Add a tag to the string memory pool in fmt to discriminate between pool vs heap allocated buffers. Heap allocated buffers are used as a fallback mechanism when the buffer runs out of space. 2021-04-13 17:36:39 +02:00
faluco 0465f6badd Implement a pool in FMT to avoid allocating heap memory when passing a char* to the backend, usually when formatting a %s argument. 
Previously since a char* can have any length, this was managed by FMT by converting it into a std::string.
Now we store it into a configurable size node that can store a fixed size string, otherwise it falls back to std::string.
 2021-04-13 17:36:39 +02:00
Xavier Arteaga 2f453b43ba Initial NR PHY interface 2021-04-13 16:02:53 +02:00
Francisco d2c404b166 handover - setup s1ap cause in case of handover failure at the target enb 2021-04-13 09:30:40 +01:00
Francisco 49bd895e29 s1ap - handle invalid or repeated erab ids in s1ap erab release command 2021-04-12 22:07:26 +01:00
Francisco 7842e3bff3 s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass 2021-04-12 22:07:26 +01:00
Francisco 985846e3bd s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids. 2021-04-12 22:07:26 +01:00
David Rupprecht 5a3a2a6d6f Added functions for adding phr and tag config 2021-04-12 20:50:30 +02:00
Andre Puschmann 48537f3fe7 pdcp,rlc: increase number of PDCP SDUs for notification from RLC 
the current value of 256 limits the number of PDCP SDUs that can be
notified from RLC. The limit is quickly hit when too many SDUs
are in flight. This can cause unwanted log entries and weird PDCP
behaviour.

the patch increases the value to 1024, which still can be too few if
many smaller SDUs are traveling.

The patch also set the log level to warning to quicker spot
misconfigs in logs.

Fixes #2616
 2021-04-12 20:09:20 +02:00
Xavier Arteaga 2f8ea05132 SRSUE: Add periodic CQI R10 parsing 2021-04-12 20:08:22 +02:00
Andre Puschmann c9da21c9bb mac_nr: add error handling when unpacking SCH MAC PDU 
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
 2021-04-12 18:26:31 +02:00
Xavier Arteaga e989e62c52 Fix NR PDCCH DMRS test 2021-04-12 17:05:53 +02:00
Xavier Arteaga b8a9a7fc70 Review soft demodulator zero check 2021-04-12 17:05:53 +02:00
Xavier Arteaga dd26c6a90e Added more comments for better understanding in NR PDCCH DMRS 2021-04-12 17:05:53 +02:00
Xavier Arteaga 17a3c76540 Fix NR TDD pattern configuration 2021-04-12 17:05:53 +02:00
Xavier Arteaga c84e73541d Offset FFT window for UE DL NR 2021-04-12 17:05:53 +02:00
Xavier Arteaga f799ab6f94 Fix NR UL RV selection 2021-04-12 17:05:53 +02:00
Xavier Arteaga 42dcff45b2 Improve PDCCH NR detection 2021-04-12 17:05:53 +02:00
Xavier Arteaga 1a6e5cdee5 Demodulator sets LLR to zero for 0.0 symbols 2021-04-12 17:05:53 +02:00
Xavier Arteaga 3889f1369f Added partial NR time resource mapping tables 2021-04-12 17:05:53 +02:00
Xavier Arteaga de187d4c88 Fix copy-past issue in srsran_vec_apply_cfo_simd 2021-04-12 17:05:53 +02:00
Xavier Arteaga 2e3c00aa97 NR PDSCH zeroes RE around the DC. Added delay and CFO emulation to phy_dl_nr_test 2021-04-12 17:05:53 +02:00
Xavier Arteaga 667cc0b552 NR PDSCH/PUSCH DMRS estimation precompensates Synch error and CFO before interpolation 2021-04-12 17:05:53 +02:00
Francisco 685c971dc2 fix recursive call to get rb name 2021-04-12 13:21:43 +01:00
Francisco f7a8b8bf94 separate drb srb ids into separate enum types 2021-04-12 13:21:43 +01:00
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 2021-04-12 13:21:43 +01:00
Francisco 437db3af03 forbid allocations when dispatching task to thread pool 2021-04-10 15:03:38 +01:00
Andre Puschmann b991b07167 rlc: add length check for RLC PDU generation 
makes sure that RLC doesn't generate a PDU larger than
the provided grant size
 2021-04-10 14:01:43 +02:00
Andre Puschmann 8024bf7820 mux_nr: improve logging when building UL MAC PDU 2021-04-09 20:40:22 +02:00
Andre Puschmann 9950278a12 nr,mac_sch_pdu,mux: fix packing of MAC subPDUs with 16bit L field 
the created RLC PDU was too large to fit inside the MAC grant
because only the header room for the short L field was used.

The patch determines the correct size before passing the opportunity to RLC.

It also improves logging in error case by using the MAC logger instead of
stderr/stdout when error occurs.
 2021-04-09 20:12:03 +02:00
Francisco ff8a43f6b0 avoid allocation of dl_sched_list and ul_sched_t by converting a std::vector to bounded_vector 2021-04-09 15:38:07 +01:00
Francisco f1c67f5b2b pool - avoid concurrent batch allocations in background threads 2021-04-09 12:54:22 +01:00
Francisco 75e9700de0 rlc - usage of memory pool to allocate RLC bearers 2021-04-09 12:54:22 +01:00
Francisco 71f1f1b556 enb - log warning when rnti-specific memory block is full 2021-04-09 12:54:22 +01:00
Francisco a890a22ccd enb - rnti memory pool now fallbacks to new/delete if rnti-specific memory block is full 2021-04-09 12:54:22 +01:00
Francisco a780a6a7b6 fix obj pool interface 2021-04-09 12:54:22 +01:00
Francisco 60d5c6df7b implementation of memory pool with individual memory blocks per UE that get accessed via their rnti 2021-04-09 12:54:22 +01:00
Andre Puschmann db496df1e6 mac_nr: add support for periodic BSR reporting 
building on the previous refactor this patch now adds support
for peridoic BSR reporting (using short BSR). It furthermore does
the following changes:

* add BSR packing
* add proc_bsr_nr unit test
* move mac_nr test code into test folder under src (needs to be done with other test code too)
 2021-04-09 12:28:05 +02:00
Andre Puschmann 6dd8c21073 mac_sch_pdu_nr: add unpacking of TA CE in DL-SCH 
also add basic test to verify correct unpacking
 2021-04-09 09:49:14 +02:00
Francisco dc763b5045 rlc am - fix bugs in buffered_pdcp_pdu_list 
The count and container elements were not being correctly updated in the events
of SN overwrite, clear(), clear_pdcp_sdu(sn) of sn that doesnt exist
 2021-04-08 20:11:15 +01:00
Francisco ebbb74e639 rlc am - use of circular_map container in RLC AM window 
The window elements are not being correctly cleaned up when clear() is called
or when overwritten by newer SN. Furthermore, the window count member is not being
correctly updated when the insertion of a newer SN overwrites the previous one.

I used the circular_map container to avoid this sort of bugs
 2021-04-08 20:11:15 +01:00
David Rupprecht 82c9636156 Refactor pdcp ctor seperate the configure function 2021-04-08 19:08:17 +02:00
David Rupprecht 56e947bf27 Added functionality for releasing a NR bearer 2021-04-08 17:37:36 +02:00
David Rupprecht cc6d8128ad Added gw interface if it is running 2021-04-08 17:37:36 +02:00
David Rupprecht 7a481c40ab Added mac prach nr proc error handling 2021-04-08 17:37:36 +02:00
David Rupprecht f9ea02b6bf Added functions for rrc reestablishing procedure if nr reconfig failes 2021-04-08 17:37:36 +02:00
Xavier Arteaga 58a9ef6e7f Minor NR PHY tweaks and aesthetic 2021-04-08 11:39:55 +02:00
Xavier Arteaga 991c6e7016 Refactored NR HARQ-ACK feedback enqueue 2021-04-08 11:39:55 +02:00
Xavier Arteaga bd11b66b6c Fix unitialised NR PHY arguments 2021-04-08 11:39:55 +02:00
Xavier Arteaga 22239b29c5 Disable smoothing filter for NR PDCCH DMRS 2021-04-08 11:39:55 +02:00
Xavier Arteaga 9f54c6ae6d Fix NR PUCCH info string and memory leak 2021-04-08 11:39:55 +02:00
Francisco b7d4a72ea1 adt - fix circular map clear() and erase(it) functions 2021-04-07 22:26:42 +01:00
Andre Puschmann 0fdcea2924 rlc_am: count every segment retx as a full retx for this SN 
previously we were only counting retx if we retx the start of a segment.
this could lead to unwanted behaviour, i.e., not counting retx
correctly and thus not triggering the maxretx attempt, if the receive
always sends NACKs with a SO_start.

The RLC spec is not clear on how this should be handled correctly but
IMHO using an integer number of retx is reasonable, even for segments
that might be retransmitted more often.

The alternative of using a fractional retx counter that may be increamented
proportional to the segment size that is retx is another alternative
but considered too complex to implement (and test correctly).
 2021-04-07 22:18:22 +02:00
Andre Puschmann c74661ae95 rlc_am: add log message when received NACK SN is already on retx queue 2021-04-07 22:18:22 +02:00
Francisco d02cc51e33 use mutex or atomic in running flag to signal the interruption of a thread 2021-04-07 16:11:31 +01:00
Xavier Arteaga 49731ab5a1 Initial NR-DCI refactor 
Added NR DCI 1_1 size

Several DCI NR fixes
 2021-04-07 16:57:12 +02:00
Xavier Arteaga 01990c2e1d SRSUE: Add PHY-MAC SR related interfaces 2021-04-07 14:16:46 +02:00
Xavier Arteaga 64acf03158 Fix sch_nr_test 2021-04-07 13:56:06 +02:00
Xavier Arteaga 1dcd75a6c7 Ignore CRC for RV!=0 in phy_dl_nr_test 2021-04-07 13:56:06 +02:00
Xavier Arteaga 3504bfcf5a Fix NR-SCH test 2021-04-07 13:56:06 +02:00
Xavier Arteaga 39e97cbcf4 Fix unbounded memory access 2021-04-07 13:56:06 +02:00
Xavier Arteaga 29c6adad93 Avoid unused LDPC memory in AVX2 decoder 2021-04-07 13:56:06 +02:00
Xavier Arteaga 392a8cc1b6 Fix LDPC RM number of useful iterations 2021-04-07 13:56:06 +02:00
Xavier Arteaga 3568f633c3 Use LDPC RM number of useful LLR and rename functions 2021-04-07 13:56:06 +02:00
Xavier Arteaga ecd2c1cdcc Improved LDPC decoded performance and other NR aesthetical changes 2021-04-07 13:56:06 +02:00
Francisco cdf72248f3 Reimplement batch-based background object/memory pool 
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
  The object pool cannot use intrusive free list because it would overwrite the object
  memory
 2021-04-07 12:02:22 +01:00
Francisco 62a6d9a8dc fix background memory pool destruction 2021-04-07 12:02:22 +01:00
Francisco b004c2024d integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class 2021-04-07 12:02:22 +01:00
Francisco 460d7a8f4f fix memory pool test - placed the pool state into a shared_ptr so that the callbacks still have a valid handle when the pool is destroyed 2021-04-07 12:02:22 +01:00
Francisco 9bec13731a adt unit test - fix memory pool test 2021-04-07 12:02:22 +01:00
Francisco ec3cd9ffea adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists 2021-04-07 12:02:22 +01:00
Francisco d1c5b000dc adt - creation of pre-initialized object pool, that leverages the background memory pool allocator 2021-04-07 12:02:22 +01:00
Ismael Gomez 3daba090f6 Fixed compilation of turbo decoder in ARM 2021-04-06 18:42:26 +02:00
Francisco 2fc2280c3b adt pool - replace uint8_t* for void* to represent memory blocks 2021-04-02 17:40:50 +01:00
Francisco a79ca92020 refactor type storage and pool tests 2021-04-02 17:40:50 +01:00
Francisco 2723993740 fix network utils test 2021-04-02 11:42:50 +01:00
Francisco 046633674a refactor - removal of stack-gtpu interface, and use of socket manager interface instead 2021-04-02 11:42:50 +01:00
Francisco c24e382c19 Refactor of socket manager class 
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
 2021-04-02 11:42:50 +01:00
Francisco 4aac7ac238 use global rx multisocket handler, and remove stack-s1ap interface 2021-04-02 11:42:50 +01:00
Francisco 39de2efa69 multisocket handler - use blocking socket remove method 2021-04-02 11:42:50 +01:00
Francisco bf96d897ee network utils refactor - renaming of socket handle to unique socket and cleanup of its methods 2021-04-02 11:42:50 +01:00
Pedro Alvarez 8194b5ec73 Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout. 2021-04-01 13:21:43 +01:00
dr 968c261bec Reordered lock to avoid deadlock in mac pcap thread 2021-04-01 10:58:56 +01:00
Francisco 23ae9967cf replaced present+value for optional field in s1ap mme_ue_s1ap_id context field 2021-04-01 10:24:34 +01:00
Francisco c3482b45e1 s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME 2021-04-01 10:24:34 +01:00
Francisco ced757a11b adt - add optional construct that closely emulates std::optional<T> 2021-03-31 19:14:11 +01:00
faluco 54fab314c0 Enhance RRC eNB events: 
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.

Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
 2021-03-31 19:37:49 +02:00
Andre Puschmann d135ae4d29 proc_bsr: initial BSR procedure for NR 
* refactor some common methods to mac_common.cc
* add common mux_base class
* move UL PDU generation to mux class
* add logical channel registration to MAC, MUX, BSR
* add initial proc BSR
* add basic MAC NR test
* rework MAC interfaces
 2021-03-30 13:46:12 +02:00
Francisco d04a19f8bc refactor - increase code reuse in adt files 2021-03-29 22:11:25 +01:00
Francisco 5eccfad05b gtpu - added comments, updated expected construct, handled in rrc the case a gtpu teid fails to allocate 2021-03-29 10:20:55 +01:00
Francisco ab2bd9a2d2 gtpu refactor - handle dl path state activation internally in gtpu tunnel manager class 2021-03-29 10:20:55 +01:00
Francisco cfd24f6a0e gtpu - leverage byte_buffer_pool to store buffered sdus in gtpu 2021-03-29 10:20:55 +01:00
Francisco c201eb7708 use of more space efficient sorted vector structure for lcid tunnels of a rnti 2021-03-29 10:20:55 +01:00
Francisco eba0edea4a creation of static id obj pool class. Application of this class to gtpu tunnels container to avoid allocations 2021-03-29 10:20:55 +01:00
Francisco 60cd7e6cfe adt - improved concurrent fixed memory pool policy to send buffers from thread cache to central cache 2021-03-27 12:21:08 +00:00
Francisco eb38ff43ab fixed size buffer pool bugfix - deleted threads now return the cached memory blocks to the pool shared memory block container 2021-03-27 12:21:08 +00:00
Francisco be771e5c23 performance - use of new concurrent fixed size pool for byte_buffer pool 2021-03-27 12:21:08 +00:00
Francisco e1523692c2 implementation of concurrent fixed size pool that leverages thread local caches to avoid mutexing 2021-03-27 12:21:08 +00:00
David Rupprecht b944528a4f Install srslog to system folder 2021-03-26 16:16:28 +01:00
faluco e2c7809abb - Introduce a new tracer scoped object that only records if the event duration exceeds the programmed threshold. 2021-03-26 10:31:26 +01:00
Andre Puschmann bde7b49ca3 ue,mac_nr: add basic SR procedure 
the current implementation support only one SR config
and doesn't support the prohibit timer
 2021-03-26 09:53:03 +01:00
Xavier Arteaga 6219500148 Added NR-RRC RACH parsing 2021-03-26 09:45:10 +01:00
faluco 3c1a97f450 - Use fprintf in the srsran_assert context incase the assert is being triggered by srslog producing a circular loop. 
- Switch to use a dynamic circular buffer for the log backend queue.
 2021-03-25 19:00:06 +01:00
faluco 4b5e15cd70 - Fixed missing return statements in base_circular_buffer::try_push. 
- Fixed array index calculation in base_circular_buffer::clear.
- Removed redundant explicit in srslog::backend_worker.
 2021-03-25 19:00:06 +01:00
faluco b06ef3f390 Switch the queue of the log backend to use a circular buffer. 2021-03-25 19:00:06 +01:00
David Rupprecht 8c86d2084d Adding NR phy config RRC parsing 
Added error handling

Reworked flattening error handling
 2021-03-25 11:34:53 +01:00
Andre Puschmann 6eedd70275 rlc_stress_test: add RLC UM NR 12bit stresstest 2021-03-25 08:06:49 +01:00
Andre Puschmann 48c106ae64 rlc_um_nr: fix packing/unpacking of PDUs with 12bit SN 
* fix SN extraction/writing
* fix packed header size calculation
* fix segmentation logic and take variable header lenght into account
 2021-03-25 08:06:49 +01:00
Andre Puschmann f992350d2d rlc_um_nr_pdu_test: add testcases for 12bit SN length packing/unpacking 2021-03-25 08:06:49 +01:00
AlaiaL 1cc2cc4e7f Fixed typo 2021-03-24 12:01:12 +01:00
AlaiaL fd3c2b855e - Renamed log to logger. 
- Added a log entry in the metrics when skipping a measurement due to
time constrains
 2021-03-24 12:01:12 +01:00
AlaiaL bbaebd1274 Added a warning in the log when the cpu metrics are not registered due 
to the number cpu cores is greater than supported.
 2021-03-24 12:01:12 +01:00
AlaiaL c9d1c77e8c - Deleted the magic number of maximum supported cores, now it is a 
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
 2021-03-24 12:01:12 +01:00
AlaiaL 6cd9bba641 Added the cpu metrics to the system metrics. 2021-03-24 12:01:12 +01:00
Xavier Arteaga 5bdf2c93b3 Initial NR PDSCH CSI-RS RE skip and other changes 2021-03-24 09:06:26 +01:00
Pedro Alvarez 5bc55ec48c Changed discard_if to appyly_if in circular_buffer.h. 
This was done so it would work when circular buffer holds other things
that are not unique_pointers. Queue and pop_func had to be made public
to be able to call the pop_func when an SDU is discarded.
 2021-03-24 00:57:58 +00:00
Andre Puschmann 1b1cfa40c9 rlc_am_lte: add some more sanity checks around retx of PDUs 
this patch doesn't change any functionality but adds a bit
of further error checking around the handling of status PDUs
and the retx of PDUs
 2021-03-23 23:36:53 +01:00
Francisco 6d9709fe54 adt - make circular buffer work with types without default ctor 2021-03-23 17:28:35 +00:00
Francisco ef5329bec0 adt - extend circular map unit test to test the container with move-only types 2021-03-23 17:28:35 +00:00
Xavier Arteaga 7704c09ce2 Fix typos 2021-03-23 15:11:46 +01:00
faluco e8395c7474 - Implement a pool to store dyn arg store objects in srslog to avoid allocations when passing arguments to the backend. 
- Use string views inside the log formatters to avoid allocations.
- Avoid a std::string when using fmt::vsprintf, instead favour fmt::vprintf.
 2021-03-23 14:55:34 +01:00
Andre Puschmann 1a0891df51 all: check return value of make_byte_buffer() and handle them safely 2021-03-23 14:31:15 +01:00
Francisco 46d46e70ff add documentation for srsran_assert and srsran_expect macros 2021-03-23 10:49:28 +00:00
Francisco dd336c53ea changed srsran_warning to srsran_expect. Applied new macro to rlc am 2021-03-23 10:49:28 +00:00
Francisco b5692037a2 created macros for assertions and warnings. The assert macro prints the whole callstack on crash. The warning macro can just log a warning or call an assertion fail depending on the cmake flag STOP_ON_WARNING 2021-03-23 10:49:28 +00:00
Andre Puschmann 9d8d897d3e mac_pcap_base: log warning when PDUs can't be added to write queue 2021-03-23 10:17:03 +01:00
Andre Puschmann 26e7964694 mac_pcap_base: increase PDU queue size to 512 2021-03-23 10:17:03 +01:00
Pedro Alvarez d91119baf6
RLC discard (#2515) 
* Added ability to discard to dyn_block_queue

* Change way of keeping track of SDUs

* Check nullptr in poping callback. Starting to check for nullptr in RLC read_pdu.

* Adding RLC discard tests

* Clearing PDCP info when RLC discard happens

* Read SDUs until they are no longer nullptr

* Changed discard_if to use template argument
 2021-03-22 16:51:32 +00:00
Francisco 0d5038dd34 fix wrong lib linking in cmaker 2021-03-22 14:58:25 +00:00
Francisco 88f5add1fb adt - fix circular map erase function and added extra asserts 2021-03-22 14:58:25 +00:00
Francisco 5d676199ab adt bugfix - fix copy/move ctor of circular map 2021-03-22 14:58:25 +00:00
Francisco 4869b14de3 application of new circular map to mac::ue_db 2021-03-22 14:58:25 +00:00
Francisco 98d0637ded adt addition - implemented reusable circular map 2021-03-22 14:58:25 +00:00
Codebot 4523ee6087 rename srsLTE to srsRAN 2021-03-21 21:47:01 +01:00
David Rupprecht ad3a3af490 Adding more info into pcap test 2021-03-19 17:55:13 +01:00
Francisco 977c194cbc gtpu,bugfix - handle the case when gtpu fails to allocate buffer for end marker. Also, added a timer that when expired, it autoremoves the GTPU handover tunnel 2021-03-19 13:43:21 +00:00
Pedro Alvarez dde8157bf1 Make sure that S1 Setup request is restarted regardless of which error made the procedure fail. 2021-03-19 10:48:45 +00:00
Xavier Arteaga 2782d96170 SRSUE: compute speed from TA commands 2021-03-19 11:47:09 +01:00
Andre Puschmann 47654af717 pdcp_entity_lte: fix printf formatter for size_t 
we've seen a heap-buffer overflow in fmt because printf wasn't using
the right formtter for size_t, which should be %zu

this patch fixes it for the PDCP LTE entity but we might have it elsewhere too

[1m[31m==7595==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000e6f1fc at pc 0x562273a45289 bp 0x7f35567641f0 sp 0x7f35567641e0
[1m[0m[1m[34mREAD of size 4 at 0x629000e6f1fc thread T12 (STACK)[1m[0m
    0 0x562273a45288 in fmt::v7::basic_format_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> > fmt::v7::detail::make_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9dc288)
    1 0x562273a3aa86 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::emplace_arg<unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9d1a86)
    2 0x562273a308e7 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::push_back<unsigned int>(unsigned int const&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/bundled/fmt/core.h:1548
    3 0x562274361541 in void srslog::log_channel::operator()<unsigned int&, unsigned int&, unsigned long>(char const*, unsigned int&, unsigned int&, unsigned long&&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/log_channel.h:101
    4 0x56227430d9e7 in srslte::pdcp_entity_lte::update_rx_counts_queue(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/upper/pdcp_entity_lte.cc:451
 2021-03-18 22:56:58 +01:00
Francisco fb48f4484c sched refactor - removal or cleanup of unused sched methods 2021-03-18 17:04:45 +00:00
Andre Puschmann 2cfc657fbb rlc_am_lte: refactor logging when PDCP SDUs are enqueued 
the patch refactor the logging when a new PDCP SDU is enqueued for
transmission at RLC.

If the SN is already present, only a warning is logged. From the RLC
perspective operation continues and the SDU will be transmitted.

The patch also changes the order of logs. When the SN cannot be inserted
inside the queue of undelivered SDUs, only one message is logged.
 2021-03-18 15:27:49 +01:00
faluco 358c4de0bd Fix a valgrind issue in a unit test in log_channel_test where the buffer was not being null terminated. 2021-03-18 10:29:54 +01:00
faluco eb27efd867 Modify the policy of the buffered sink to flush its contents continuously instead of doing it once. 2021-03-18 10:28:58 +01:00
Francisco 0d91802495 sched optimization - swap c-arrays for bounded_vector in sched_interface to reduce time performing bzero/memcpy in the scheduler 2021-03-17 19:54:44 +00:00
Xavier Arteaga 5f954ab379 Fix UHD compilation 2021-03-17 08:53:40 +01:00
Xavier Arteaga a8b5b8efa1 UHD: stability improvements 2021-03-17 08:53:40 +01:00
Xavier Arteaga f9689ec956 Added PUSCH CFO estimation 2021-03-17 08:53:40 +01:00
Francisco 47f1175502 [sched, feature enhancement] - allow variable nof prbs allocated per SIB / Paging message 2021-03-16 19:27:25 +00:00
Andre Puschmann 3e07767f28 rlc_stress_test: set maxRetx for AM to 32 by default 
since the tests are random we sometimes hit the maxRetx threshold
with 8 retx allowed that made the unit test fail.

increase threshold to lower the likelihood for this to happen.
 2021-03-16 15:47:38 +01:00
Xavier Arteaga f3c0360842 Applied aesthetical changes 2021-03-16 11:36:11 +01:00
Xavier Arteaga d9780e1f13 Fix duplicated NR-DCI in different search spaces and CORESET and other aesthetic modification 2021-03-16 11:36:11 +01:00
Xavier Arteaga 6fa33c890d Simultaneous HARQ-ACK, SR and CSI in NR-PUCCH 2021-03-16 11:36:11 +01:00
Xavier Arteaga 1463b11bad Fix compilation 2021-03-16 11:36:11 +01:00
Xavier Arteaga be8e8cbe3e Fix radio decimation Rx stream stall 2021-03-16 11:36:11 +01:00
Xavier Arteaga 1153555ae1 SRSUE: Added UE specific cell space 2021-03-16 11:36:11 +01:00
Xavier Arteaga 10af89fcdd NR-PDCCH aesthetic changes 2021-03-16 11:36:11 +01:00
Xavier Arteaga fb1a0b6bce SRSUE: added NR-PDCCH information 2021-03-16 11:36:11 +01:00
Xavier Arteaga d3cfb00211 SRSUE: Added TDD DL/UL slot detection 2021-03-16 11:36:11 +01:00
Xavier Arteaga f3bf0c1c68 Wrap slot index in modulus macro 2021-03-16 11:36:11 +01:00
Xavier Arteaga 4bab0b53b7 SRSUE: fix slot index overflow 2021-03-16 11:36:11 +01:00
Xavier Arteaga 6f6c20e194 SRSUE: Added procedure for multiplexing UCI in NR-PUSCH 2021-03-16 11:36:11 +01:00
faluco e43f555fc0 - Provide a fast path for logging pre-formatted strings that are small and fit in 64 bytes without any allocations. 
- Use this new feature in the tracer.
 2021-03-16 11:20:01 +01:00
Francisco 2e18827259 avoid accessing C-array via &[0] for initialized buffer 2021-03-14 14:27:34 +00:00
Francisco 80104c7e65 adt, bugfix - fix assert when accessing bounded_vector::data() member 2021-03-14 14:27:34 +00:00
David Rupprecht be46806495 PCAP: Enable carrier ID TAG 2021-03-13 19:19:19 +01:00
Francisco ca7fe1349e remove unnecessary sfinae from bounded_vector. Use bounded_vector for UE cc buffers. Set ue cc used buffers remove_pdu method to private 2021-03-12 19:10:15 +00:00
Francisco d27e0be609 created special class to manage mac::ue currently allocated rx UL buffers. This class avoids mallocs 2021-03-12 19:10:15 +00:00
Ismael Gomez 7b33c48fe7 Use static queue in pdu_queue 2021-03-12 19:10:15 +00:00
Pedro Alvarez f02694dd3e PDCP status report: Fix issue in keeping track of Rx'ed COUNTs after eNB reestablishment. Fixed issue in logic that limits the size of the rx_counts info vector. 2021-03-12 13:47:20 +00:00
Pedro Alvarez d2ef541957 Changed the structure to store rx_counts info to std::vector, to reduce 
memory allocations.
Update the rx_count_info queue if the queue size is too large.
 2021-03-12 13:47:20 +00:00
Pedro Alvarez 3f79cd6281 Changed generation of status report to use rx_counts instead of 
undeliverd_sdus_queue. Added a queue to store information about
rx_counts received.
Added unit test for when the SNs wrap-around in status report genaration
 2021-03-12 13:47:20 +00:00
Francisco 6159cb3817 add assert to ensure a valid ptr is passed to memory pool deallocator 2021-03-12 01:33:44 +00:00
Francisco 20928651c7 created batch allocator that leverages background worker pool 2021-03-12 01:33:44 +00:00
Francisco 3e9f93eb8a refactor - remove old log_filter and logmap libraries from the codebase 2021-03-11 20:10:54 +00:00
Francisco 3b491ab06b optimize .count() method of bounded_bitset to leverage popcount special instructions. Confirmed to work for gcc in -msse4 flag is passed. 2021-03-11 15:18:16 +00:00
Francisco 7dcb703d06 adt lib,bugfix - fix bounded_bitset resize to clear bits outside of mask correctly 2021-03-11 15:18:16 +00:00
Francisco d1483dc0f8 sched,bugfix - fix bitmask formatting. fix msg3 adaptive retx pdcch allocation 2021-03-10 22:42:39 +00:00
faluco 173dcdd421 - Import latest srslog version. 
- Remove string allocs in some log lines in radio.cc.

Add new tracing buffer capcity options into srsenb and srsue.

Add missing file.
 2021-03-10 16:27:33 +01:00
faluco c7542daf43 Remove rlc traces and add new ones into tti run functions both in the enb and ue. 2021-03-10 11:59:09 +01:00
faluco 82db6544fb Add instrumentation points to rlc_am_lte::rlc_am_lte_tx::handle_control_pdu using srslog. 2021-03-10 11:59:09 +01:00
Ismael Gomez 8e9d28e7e0 Change wait_for interface for wait_until in circular_buffer 2021-03-10 09:51:35 +01:00
Andre Puschmann 16de8668e0 rlc_am_lte: convert mutexes to std::mutex 
replace all pthread_mutex with std::mutex and use lock_guard and unique_lock (where needed)
 2021-03-09 21:56:33 +01:00
Andre Puschmann 20cbc48f90 rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure 
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
 2021-03-09 21:56:33 +01:00
Francisco ee77343f26 fix compilation issue for centos7 2021-03-09 16:23:08 +00:00
Francisco 20e341d0a1 mac,bugfix - fixed formatting of MAC and scheduler user-defined types 2021-03-09 16:23:08 +00:00
Francisco f72cd4151c rlc am,bugfix - fixed formatting of RLC AM header and status pdu 2021-03-09 16:23:08 +00:00
Francisco 4c1067bcf6 bitset - fix compilation issue for centos7 2021-03-09 16:23:08 +00:00
Francisco 0f9d73012f use srslte::move_callback instead of std::function in timers to avoid allocations 2021-03-09 16:23:08 +00:00
Francisco 5a1bf28fe1 optimization - minimization of number of std::string allocations for logging 2021-03-09 16:23:08 +00:00
Francisco 1ffc4cef86 rlc am,optimization - change helper log methods to avoid mallocs 2021-03-09 16:23:08 +00:00
Francisco d77b6e1d9c sched,optimization,refactor - use of custom formatter that avoids mallocs for getting bitmasks strings in hex and binary formats 2021-03-09 16:23:08 +00:00
Xavier Arteaga a03c78a777 Fix NR-PUSCH defect 2021-03-09 17:05:08 +01:00
Xavier Arteaga 05f4d6af71 Fix and validated UCI multiplex in NR-PUSCH 2021-03-09 17:05:08 +01:00
Xavier Arteaga 2b9bd1173e More NR-PUSCH UCI bit multiplexing 2021-03-09 17:05:08 +01:00
Xavier Arteaga 289fff9c22 Removed carrier set in UCI NR module 2021-03-09 17:05:08 +01:00
Xavier Arteaga 97435b085e Added CSI part1 and 1/2 bit HARQ-ACK multiplexing on PUSCH 2021-03-09 17:05:08 +01:00
Xavier Arteaga dc2542901a Verified HARQ-ACK in PUSCH 2021-03-09 17:05:08 +01:00
Xavier Arteaga 9dffad87f2 Initial UCI bits multiplexing in PUSCH 2021-03-09 17:05:08 +01:00
Xavier Arteaga f4e9d00ea8 Initial HARQ-ACK multiplex in PUSCH 2021-03-09 17:05:08 +01:00
Xavier Arteaga 7b588eafec Minor aesthet change 2021-03-09 17:05:08 +01:00
Andre Puschmann ace8764568 rlc_am_lte: add missing unlock when building status PDU fails 2021-03-08 15:19:07 +01:00
Francisco 0b6293c676 adt lib additions - add the ability to perform timedwait for popping from a blocking queue 2021-03-08 14:49:14 +01:00
Francisco f0ed1e06a8 documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path 2021-03-08 14:49:14 +01:00
Francisco d1236fd62f stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb 2021-03-08 14:49:14 +01:00
Francisco 28ef5833a2 fix compilation issue for centos7 2021-03-08 14:49:14 +01:00
Francisco 0ba93d274f converted byte_buffer_queue to use new circular buffer-based queue to avoid mallocs 2021-03-08 14:49:14 +01:00
Francisco 822e26b63f implemented circular buffer-based queue 2021-03-08 14:49:14 +01:00
Francisco fb278a8b21 Fallback to default R8 TBS tables for format 1A DCI 
Co-authored-by: xavierarteaga <xavier.arteaga@softwareradiosystems.com>
 2021-03-06 21:27:52 +01:00
Andre Puschmann 83f24fbf77 rlc_am_test: fix max_retx test 
the test should only check the correct signaling of the maxretx
to the upper layer.
 2021-03-06 20:55:08 +01:00
Andre Puschmann ceacf8508d rlc_am_lte: fix handling of maxretx 
this patch fixes the actions/handling after RLC detected
maxRetx reached for a given SN.

According to the TS, RLC should only inform upper layers and
not try to recover from the event itself.

As a consequence, we won't manipulate the Tx or Rx window.
As a result of this, we might retransmit a SN more than
the specified amount of times.

It's the task of RRC to reestablish the bearer to recover
from that.
 2021-03-06 20:55:08 +01:00
Francisco fb04fdbe69 sched,bugfix - fix mcs/tbs computation for 256-QAM. 2021-03-06 20:49:05 +01:00
Andre Puschmann 9f627911df rlc_am_{control}_test: extend status PDU test 2021-03-05 19:46:00 +01:00
Andre Puschmann 6a4bf65fd8 rlc_am_lte: extend check for valid status PDU 
check for all NACKed SNs are smaller than ACK_SN
 2021-03-05 19:46:00 +01:00
Andre Puschmann fa23be4d6d rlc_stress_test: fix SDU generation 
the PDCP SN was used to fill the SDU with data. But since
the max value isn't devisable by 256 it didn't always increment
correctly. Use a normal byte now that wraps correctly.
 2021-03-05 19:46:00 +01:00
Andre Puschmann 62b2327178 rlc_am_lte: fix header reconstruction 
* optimize processing of status PDU (SN is removed from window immediately)
* fix maxRetx signaling for segments
* make tx_window_t a template class, rename and use for rx_window as well
 2021-03-05 15:47:30 +01:00
Andre Puschmann 5e345df439 rlc_stress_test: make pedantic operation the default 
among cleaning up the the stress test, it does:
* remove optional pedantic flag and make it the default to catch resegmentation issues
* use random SDU and MAC grant size the default
* use factory functions to create RLC configs (make maxretx configurable)
* remove reestablishment and print error when maxRetx is triggered
* fix NR PCAP usage and removes PCAP ifdef
 2021-03-05 15:47:30 +01:00
Andre Puschmann 1a59f2d5ba rlc_am_test: extend header reconstruction test 
this patch adds various new test cases generated from
rlc_stress_test to test header reconstruction.
 2021-03-05 15:47:30 +01:00
faluco dc6a2e5160 Implement a log spy to check if a certain message has been logged. 2021-03-05 15:47:30 +01:00
Francisco 9eeddcec5f disabled prach vs pucch collision detection temporarily until enb cfg files are updated in the rfci 2021-03-05 14:59:44 +01:00
Francisco 102cb196e1 Addition of enb cfg option to choose between PUCCH with multiplexing and without. Change default prach offset to 4. 
- The new prach offset of 4 accounts for the size of the PUCCH-ACK region with 100 prbs
 2021-03-05 14:59:44 +01:00
Francisco 39aea96c69 fix sched tests UL HARQs. Set common pucch cfg in the sched tests 2021-03-05 14:59:44 +01:00
Andre Puschmann 99df71a914 rf_zmq: make error message when port bind failed more verbose 2021-03-05 10:36:11 +01:00
Francisco 9748c0be84 simplified tbs/mcs computation in scheduler 2021-03-04 23:40:35 +01:00
Pedro Alvarez 9c67a029b5 Trying to make calculation of offset in status report more readable 2021-03-04 11:22:53 +01:00
Pedro Alvarez 7b23a83306 Fixup tests to consider wrap-around in status report 2021-03-04 11:22:53 +01:00
Pedro Alvarez c4e9516561 Fix issue when LMS wraps-around and FMS doesn't in PDCP status report. Fix incorrect update of FMS on clear_sdu. Adding unit test to LMS wrap-around. 2021-03-04 11:22:53 +01:00
Pedro Alvarez 0d020a7f07 Disable sending and handling status report on SRBs 2021-03-04 11:22:53 +01:00
Xavier Arteaga 81cc8de2b7 Protect NAS unbounded message read 2021-03-03 23:06:47 +01:00
David Rupprecht aef6805d03 Added pcap net feature to eNodeB 2021-03-03 09:50:15 +01:00
David Rupprecht 9e72d89fa1 MAC PCAP move run thread in base class 2021-03-03 09:50:15 +01:00
David Rupprecht 894e4d3501 Added mac pcap network class that dumps the packets to a udp network sink 2021-03-03 09:50:15 +01:00
David Rupprecht a58f0642cb created pcap base class for main handling 2021-03-03 09:50:15 +01:00
David Rupprecht da658ed2d4 Changable UE ID for enodeb 2021-03-03 09:50:15 +01:00
David Rupprecht 5a95cbdfae Disable rat assignment in pcap class 2021-03-03 09:50:15 +01:00
David Rupprecht 24bea9a860 Refactored functions for pcap udp packing and write lte mac pcap with udp frame 2021-03-03 09:50:15 +01:00
David Rupprecht bb3e87302d Added new pcap enable option and mac nr 2021-03-03 09:50:15 +01:00
AlaiaL 390a4c0f76 [metrics] Changing variable types. 
Adjusting the license.
 2021-03-02 22:17:13 +01:00
AlaiaL 723c56051e [metrics] Changed the extension from cpp to cc. 
- Fix date of CMakeLists.txt.
- Initialization of the used variables in the cpu usage calculation.
 2021-03-02 22:17:13 +01:00
AlaiaL 41cf15f5ad [metrics] Adjusted function names and documentation 2021-03-02 22:17:13 +01:00
AlaiaL d518a625cc [metrics] Added the system metrics to the csv 2021-03-02 22:17:13 +01:00
AlaiaL 0ba7cd7df9 [metrics] Added system metrics to the enb's stdout 2021-03-02 22:17:13 +01:00
AlaiaL 3a86c210f9 [metrics] Added the system metrics to the ue stdout 2021-03-02 22:17:13 +01:00
Francisco 290f39d805 fix crnti mac ce handling in the rrc in normal (no handover) case 2021-03-02 17:14:17 +01:00
Xavier Arteaga 0346564241 Fix NR-PUCCH encoding 2021-03-02 15:40:40 +01:00
Xavier Arteaga 784f4be72e SRSUE: NR CSI report fixes 2021-03-02 15:40:40 +01:00
Xavier Arteaga 4679e9f871 Initial NR CSI reports 2021-03-02 15:40:40 +01:00
Francisco 202c4d7566 remove uses of method .clear() of stack timers 2021-03-02 11:25:38 +01:00
Francisco be7e78da53 limit allocation of PDCP SDU+Timer buffer to DRB+RLC AM cases 2021-03-02 11:25:38 +01:00
Pedro Alvarez 8dfa87c377 Disable undelivered SDU queue for SRBs. 2021-03-02 11:25:38 +01:00
Francisco a3cb21d378 move undelivered_pdcp_sdus class methods to .cc file. Fixed the forwarding of pending PDCP SNs during S1 handover 2021-03-02 11:25:38 +01:00
Francisco 17fa79f24c couple the pdcp discard timers and sdu buffer management into same subclass. Add asserts to ensure there is no ambiguity in the PDCP SN assignment and buffering. Extend the discard timer and pdcp sdu buffering to SN lengths above 12 2021-03-02 11:25:38 +01:00
Pedro Alvarez 4723dd0aa9 Converted undelivered sdus queue in the PDCP to use a vector. 
This was done to improve the performance of the notify_delivery().
 2021-03-02 11:25:38 +01:00
Francisco a72a659fdf fix timers interface to avoid accessing to a timer after its release. fix gtpu tunnel activation during s1 handover 2021-03-01 23:20:07 +01:00
Xavier Arteaga 6c9ff3ac92 Fix packed sequence genration for non multiples of 8 2021-03-01 15:30:33 +01:00
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 2021-03-01 15:30:33 +01:00
Xavier Arteaga 93752fb2c4 Fix LDPC compilation for GCC 10 2021-03-01 13:26:05 +01:00
Xavier Arteaga 576a923a4c Added i8 zero vector 2021-03-01 13:26:05 +01:00
Pedro Alvarez 4011714664 Fix errors in RLC stress tests due to PDCP SN wrap-around 2021-03-01 10:20:17 +00:00
Francisco 1cd3576134 fix gcc compilation issue 2021-02-26 16:44:57 +01:00
Francisco 5ea2e8f45d remove more srslte.h includes from upper layers 2021-02-26 16:44:57 +01:00
Francisco 4b09507c19 remove srslte.h includes from upper layers 2021-02-26 16:44:57 +01:00
Francisco 766018f2b4 fix gcc compilation issue 2021-02-26 16:44:57 +01:00
Francisco b329e25bbb move ue phy interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco 13d805ef56 move ue rrc interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco b1706b9197 move ue nas interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco 186285ffd3 move ue usim interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
David Rupprecht 8f49b92760 Using PDCP entity lte instead of nr for nr bearer 2021-02-26 15:13:41 +01:00
Pedro Alvarez c0b5edf6db
Make sure discard timers are initialized, even when timeout is infinite. (#2400) 2021-02-26 10:36:04 +00:00
Francisco 6e64933335 handle the scenario when the network thread fails to allocate a byte buffer 2021-02-25 15:56:40 +01:00
Francisco f610a7b83d Change background worker pool to become a global variable 
Allocate rrc::ue objects in batches in the background worker pool
 2021-02-25 15:56:40 +01:00
Xavier Arteaga 11cffdcbec Minor comment 2021-02-25 09:04:04 +01:00
Xavier Arteaga 126fc09b7d SRSUE: Added initial SR procedure for NR 2021-02-25 09:04:04 +01:00
Andre Puschmann 822abc763e rlc_am_lte: when max retx is reached, remove SN from tx window 
this fixes an issue when the RLC bearer isn't reset from RRC.
In this case, the RLC would retransmit the same PDU over and over
again despite the max retx counter being reached.
 2021-02-24 21:57:56 +01:00
Andre Puschmann c0a1b0efa3 rlc_am_test: add TC to check RLC AM drops PDU if max retx have been reached 2021-02-24 21:57:56 +01:00
Francisco 0b6b62324f convert rlc am retx_queue to circular buffer 2021-02-24 21:19:15 +01:00
Andre Puschmann 9c4146442a mac,phy: refactor NR MAC/PHY UL data passing interface 
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.

* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
 2021-02-24 20:28:43 +01:00
David Rupprecht fc9d5befda Remove header test case 2021-02-24 20:23:54 +01:00
Andre Puschmann 5e93a6f5bd rlc_um_nr_pdu_test: add 12bit SN unpack test 2021-02-24 20:23:54 +01:00
Andre Puschmann 06e7f169c6 rlc_um_nr: fix unpacking of 12bit UM PDU 2021-02-24 20:23:54 +01:00
Pedro Alvarez 976b5c12c1
Releasing the UE when max retransmissions are reached in the RLC. (#2385) 2021-02-24 16:45:40 +00:00
Francisco 138685399e remove allocations from rlc_am_tx::handle_control_pdu 2021-02-24 12:06:34 +01:00
David Rupprecht cc0c091a39 pcap checksum to null for decoding if checksum check is enabled 2021-02-23 17:02:23 +01:00
Xavier Arteaga 6ba9f8fd41 SRSUE: Remove UL hard-coded phase and more PUSCH logging info 2021-02-23 17:02:23 +01:00
David Rupprecht 1fcd006a7c fixed segfaulting 2021-02-23 17:02:23 +01:00
Xavier Arteaga b768002a93 SRSUE Added RAR unpacking and other fixes 2021-02-23 17:02:23 +01:00
David Rupprecht 82a8dcc77a Change interface to unique_byte_buffer 
logging message for msg3 preparing
 2021-02-23 17:02:23 +01:00
Xavier Arteaga 760ad3a746 SRSUE: Interface stack and PHY for NR-RA procedure 2021-02-23 17:02:23 +01:00
Francisco 9a6512f4e8 fix RLC AM undelivered PDCN SNs reset bug 2021-02-22 22:56:19 +01:00
Francisco 1ede82bb30 use circular array for buffered PDCP SNs in RLC AM to limit memory allocations 2021-02-22 22:56:19 +01:00
Francisco 2a65bf9636 fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case 2021-02-22 22:56:19 +01:00
Francisco bad2302e31 avoid the use of two arrays for managing buffered pdcp sns in RLC AM 2021-02-22 22:56:19 +01:00
Francisco 299634b319 use of vector to store undelivered PDCP SNs in RLC AM 2021-02-22 22:56:19 +01:00
David Rupprecht 0f1586dd2d Deleted all HAVE_5GNR in CC and h files 
CMakeList and travis yaml
 2021-02-22 21:16:04 +01:00
Xavier Arteaga c2c05d1e8f Initialise to zeros NR PHY configuration by default 2021-02-22 20:41:28 +01:00
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368) 
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
 2021-02-22 10:36:14 +00:00
Francisco 2f75abcc7a fix failing rlc am test 2021-02-21 21:24:24 +01:00
Francisco 1d185fb152 use macro for rlc tx window size. refactor tx window clearing 2021-02-21 21:24:24 +01:00
Francisco abe4f4c7eb use tx_window to store the map of rlc sn to pdcp sns 2021-02-21 21:24:24 +01:00
Francisco f86eb84876 conversion of RLC AM tx window from std::map to array 2021-02-21 21:24:24 +01:00
Francisco 1660fc81a0 fix comment regarding PDCP SN value for status report 2021-02-21 12:50:32 +01:00
Francisco 047dd2a56d use function helper for discard timer lookup and stopping in the PDCP 2021-02-21 12:50:32 +01:00
Francisco c6fa011eec fix pdcp discard timer list creation 2021-02-21 12:50:32 +01:00
Francisco 82bb0a7d81 implementation of pdcp discard timers using a vector for efficiency 2021-02-21 12:50:32 +01:00
Andre Puschmann 40d7934267 rlc: call PDCP notify without holding Tx lock 
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
 2021-02-21 11:03:44 +01:00
Francisco 93b1450e03 fix enb crash during close down of enb and epc 2021-02-20 16:00:31 +01:00
Francisco Paisana cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map (#2363) 
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
 2021-02-20 15:08:00 +01:00
Pedro Alvarez d947a0bccf Used the used SN to insert into the discard timer instead of the TX_COUNT 2021-02-19 20:15:39 +00:00
Pedro Alvarez 3f2fe4e5f6 Disable PDCP discard timer when using RLC UM. 2021-02-19 20:15:39 +00:00
Xavier Arteaga b8b27709b9 Radio: implement resampling buffer protection 2021-02-19 17:23:59 +01:00
Pedro Alvarez 24d5b9071c Fix issue with status report test config 2021-02-19 13:30:48 +00:00
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 2021-02-19 13:30:48 +00:00
Pedro Alvarez 6a6bffcf5c Changed log of discarding SN due limit to info level 2021-02-19 12:07:15 +00:00
Pedro Alvarez c66c96aac7 Simplify if condition in checking the maximum allocated SNs in PDCP 2021-02-19 12:07:15 +00:00
Pedro Alvarez 33808a5cb8 Making sure that SNs don't wrap-around in PDCP with RLC AM. 2021-02-19 12:07:15 +00:00
Ismael Gomez 543e84d873 Fix compilation error in PPC 2021-02-19 13:00:39 +01:00
faluco 613d397d0a - Dump the PDCP metrics into the JSON file. 
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
 2021-02-19 09:54:41 +01:00
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 2021-02-19 09:54:41 +01:00
faluco b750647cd8 - Remove the cause field in the rrc disconnect event. 
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
 2021-02-19 09:54:41 +01:00
faluco 7b9dab3a73 Rename cc_idx variable to enb_cc_idx for specific upper layer events. 2021-02-19 09:54:41 +01:00
faluco a4605883f0 Implement second revision of the events and metrics document. 2021-02-19 09:54:41 +01:00
Pedro Alvarez 0e828aeb4b Remove unecessary mutex. PDCP metrics are accessed from the stack thread. 2021-02-19 02:55:17 +00:00
Pedro Alvarez c39905744c Fix metrics of TX PDUs and TX_PDU bytes in PDCP 2021-02-19 02:55:17 +00:00
Pedro Alvarez 451c305790 Add mutex to isolate metrics_hub thread from the stack thread when 
getting the metrics from the PDCP
 2021-02-19 02:55:17 +00:00
Pedro Alvarez 0c240a80aa Fix up PDCP metrics to calculate the buffered bytes when get_metrics is 
called.
 2021-02-19 02:55:17 +00:00
Xavier Arteaga 70a55ebf1e Fix ZMQ sleep time 2021-02-18 18:59:30 +01:00
Pedro Alvarez 46cd29e0ac Temporarly disable sending status report and retrasnsmissions on reestablishment in PDCP 2021-02-18 14:51:29 +00:00
Pedro Alvarez df501d1500 Clear underlivered SDUs info map for SRBs on reestablishment 2021-02-18 14:51:29 +00:00
Pedro Alvarez d705fa2106 Tentative fix for errors due to status report already present in RLC info queue 2021-02-18 14:51:29 +00:00
Pedro Alvarez ba5367bc56 Change order which reestablish is called in eNB 
Make sure that RLC info queue is reset when reestablish happens
 2021-02-18 14:51:29 +00:00
David Rupprecht a7949e69c8 configure and start ra proc 
Fix crash due to missing init
 2021-02-18 14:34:15 +01:00
David Rupprecht 876858b44c Added mac nr prach common config convert function with test case 2021-02-18 14:34:15 +01:00
David Rupprecht b19cbdde23 Added test case for testing the decoding of cell group config 2021-02-18 14:34:15 +01:00
David Rupprecht a3be380e3b workaround to mitigate the linking error 2021-02-18 14:34:15 +01:00
Andre Puschmann e0495d1da8 zmq: fix parsing of log_trx_timeout 
add temp var for this param. the bug cause log_trx_timeout
to have the value of the previously parsed fail_on_disconnect
 2021-02-17 21:06:28 +01:00
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 2021-02-17 18:40:12 +00:00
Pedro Alvarez 8873b7c42f Added computation for the metrics 2021-02-17 18:40:12 +00:00
Pedro Alvarez d34aba8065 Added interfaces to get metrics from PDCP entities. 2021-02-17 18:40:12 +00:00
Pedro Alvarez eb2f5b978f Starting to add metrics to lib/upper/pdcp.cc 2021-02-17 18:40:12 +00:00
Pedro Alvarez dd6a292d79 Added structure to hold PDCP metrics 2021-02-17 18:40:12 +00:00
Pedro Alvarez 3eab97340b Fix issue in getting PDCP discard timer from configs 2021-02-17 17:53:03 +00:00
Xavier Arteaga bdef411855 SRSUE: Aesthetic changes 2021-02-17 16:34:00 +01:00
Xavier Arteaga 96a47fb93a Add NR RRC interface types 2021-02-17 16:34:00 +01:00
Xavier Arteaga 784a33583b SRSUE: Initial NR MAC-PHY interfaces 
SRSUE Fix compilation

SRSUE: temporary fixes LTE/NR PHY/Stack interface problem

fix

fix
 2021-02-17 16:34:00 +01:00
Francisco 6a178693a8 handle rrc configs with pdcp with sn=15 or 18 bits 2021-02-17 11:03:52 +01:00
Francisco faf2adde90 set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn 2021-02-17 11:03:52 +01:00
Pedro Alvarez e2d2951b00 Added some extra logging for the PDCP get_buffered_pdus and notification reception. 2021-02-17 11:03:52 +01:00
Pedro Alvarez 963dff34af Added retransmissions to the UE's PDCP on re-establishment. 2021-02-17 11:03:52 +01:00
Xavier Arteaga 8ac6d7382f Fix PRACH sequence generation 2021-02-17 10:34:34 +01:00
Xavier Arteaga 2fd618a295 Avoid FFTW re-planning if no DFT change is required 2021-02-17 10:34:34 +01:00
Xavier Arteaga 596c8f52a9 PRACH set config avoids modulo operation 2021-02-17 10:34:34 +01:00
Xavier Arteaga 1e073b8b67 PRACH: avoid general cexp for sequence generation using LUT 2021-02-17 10:34:34 +01:00
Andre Puschmann c1a1c92e1b zmq: optionally log rx/tx timout from ZMQ ringbuffers to stderr 
this patch adds two new config flags to the ZMQ driver that allows to:
* configure the default ZMQ trx timeout in ms
* turn on error logging if the timeout occurs

Use with, e.g.:
device_args = log_trx_timeout=true,trx_timeout_ms=3333
 2021-02-16 20:38:19 +01:00
Xavier Arteaga 984c4a4748 Changed license header 2021-02-16 15:57:58 +01:00
Pedro Alvarez e0542a4651 Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC. 2021-02-16 13:21:50 +00:00
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 2021-02-16 13:21:50 +00:00
Pedro Alvarez 89a23cec7e Added statusReportRequired to the PDCP entity config. 2021-02-16 13:21:50 +00:00
David Rupprecht 24123313bf Added MAC NR RA procedure with a minimal test case 2021-02-16 09:42:09 +01:00
Xavier Arteaga 3d3c80262c Modified Error messages 2021-02-16 09:12:47 +01:00
Xavier Arteaga d9805f7ba7 Added AVX512 LDPC 2021-02-16 09:12:47 +01:00
Pedro Alvarez 2ed8dceddf Use TX_COUNT in RLC AM stress test. Avoids issue with re-using SNs within the test 2021-02-15 19:37:49 +00:00
Xavier Arteaga 2e39e103f8 Minor NR related corrections 2021-02-15 12:54:17 +01:00
Xavier Arteaga 24cfed6489 Fix scrambling sequence for PUCCH format2 2021-02-15 12:54:17 +01:00
Xavier Arteaga 5f70526ac5 Minor NR-PUCCH related fixes 2021-02-15 12:54:17 +01:00
Xavier Arteaga 9faa2d5fcd SRSUE: Automatic DL-HARQ Reset for every TTI and Generate PUCCH baseband signal 2021-02-15 12:54:17 +01:00
Xavier Arteaga 2d9e964147 Fix RA RNTI grant count 2021-02-15 12:54:17 +01:00
Xavier Arteaga d807ccc3dd SRSUE: Initial NR-PUCCH HARQ feedback 2021-02-15 12:54:17 +01:00
Xavier Arteaga ff5fbbf0a0 Added vector sprint for bit 2021-02-15 12:54:17 +01:00
Xavier Arteaga 818f3ea7c7 Initial NR-PDSCH HARQ-ACK/NACK procedure 2021-02-15 12:54:17 +01:00
Xavier Arteaga 18db846c6c Remove NR hard-coded phase offsets 2021-02-15 12:54:17 +01:00
Xavier Arteaga 44df2288b9 Corrected typos 2021-02-15 12:54:17 +01:00
Pedro Alvarez f89b644902 Added function to get control pdu type to the PDCP base class. Shorten logger name in PDCP Status report test. 2021-02-15 11:44:57 +00:00
Pedro Alvarez 90113419c2 Added memset(0) to PDCP status report bitmap before starting to fill it in. 2021-02-15 11:44:57 +00:00
Pedro Alvarez 9bc08af880 - Added ability to the PDCP LTE entity to send PDCP Status report. 
- Added handling of PDCP status report to the PDCP LTE entity.
- Added test to the generation and handling of PDCP status report.
 2021-02-15 11:44:57 +00:00
Francisco Paisana 4152e43bab fix gtpu packing when extension header is enabled 2021-02-15 10:49:54 +01:00
Francisco Paisana c40ad81a90 cleanup s1ap methods. remove hard coded erab list in s1ap handover required message. 2021-02-15 10:49:54 +01:00
Francisco Paisana 5e48327eca fix valgrind memcheck warnings in rlc_am_test 2021-02-13 11:04:27 +01:00
Francisco dc4283c572 added cmake functions as helpers to set labels in ctests 2021-02-12 20:27:31 +01:00
Francisco add156c3fe update phy lib cmake test labels 2021-02-12 20:27:31 +01:00
Francisco 23459dee28 Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files. 2021-02-12 16:36:50 +01:00
Francisco 43e57df00b breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h 2021-02-12 16:36:50 +01:00
Pedro Alvarez dd6d6f731d Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed. 2021-02-12 11:57:36 +00:00
Pedro Alvarez 492ea2a5a8 Addressing reviewers comments to #2290. 
Removing unecessary \n for logs and changed log of PDCP info queue
 capacity to debug to avoid log spam.
Changed log level for unhandled S1AP messages from error to warning
 in EPC to avoid failing tests because of error message.
Changed usage of allocate_unique_buffer to make_unique_buffer()
 2021-02-11 15:49:00 +00:00
Pedro Alvarez fcaaf72187 Starting to add discard functionality to PDCP LTE entity. 
This includes:
  - Adding a queue (implemented with std::map) for undelivered PDUs.
    This queue uses the SN used for TX as the key.
  - Added discard timer that is started upon reception of the SDU. Upon
    expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
  - Added the mechanisms to the notify_delivery to remove PDUs from the
    undelivered queue when the PDU is ACK'ed.
  - Added test case for both timer expiry and acknowledgment.
  - Fix up the getter for buffered SDUs to return the undelivered SDUs
  - Changed default PDCP discard timer, so AM has a discard timer by
    default.
 2021-02-11 15:49:00 +00:00
faluco 5c8923123a Misc compilation fixes from the fapi repo. 2021-02-11 15:38:50 +01:00
faluco 57f66febfc Ported the RLC classes to srslog in the lib dir. 2021-02-11 14:37:27 +01:00
faluco f424f2e113 - Upgraded PDCP classes in lib to use srslog. 
- Update tests to new changes.
 2021-02-11 14:37:27 +01:00
faluco 6359a2d948 - Upgrade the gtpu class in lib dir to srslog. 
- Propagate old log elimination through all the dependencies of gtpu.
 2021-02-11 14:37:27 +01:00
faluco 62fcf04083 Ported the all radio classes to use srslog. 2021-02-11 14:23:14 +01:00
Francisco c2dfe615e7 fixed alignment of LIBLTE_BYTE_MSG_STRUCT to reflect the one of byte_buffer. Add bzero in liblte packers 2021-02-11 13:09:06 +00:00
Francisco 4188b5146e fix uninitialized memory access in gtpu_test and liblte_mme unpacking 2021-02-11 13:09:06 +00:00