From 3c1fa2816f1e32c1ca263b0c480a75c0fc40b3c0 Mon Sep 17 00:00:00 2001
From: Fabio Utzig <utzig@utzig.org>
Date: Sat, 9 Apr 2016 13:55:23 +0000
Subject: [PATCH] [AVR] Fix timer usage for ATmega128

git-svn-id: svn://svn.code.sf.net/p/chibios/svn/branches/stable_16.1.x@9262 35acf78f-673a-0410-8e92-d51de3d6d3f4
---
 os/hal/ports/AVR/st_lld.c | 51 +++++++++++++++++++++++++++++----------
 os/hal/ports/AVR/st_lld.h | 16 +++++++++---
 2 files changed, 50 insertions(+), 17 deletions(-)

diff --git a/os/hal/ports/AVR/st_lld.c b/os/hal/ports/AVR/st_lld.c
index 97b35ba9b..ea470cb07 100644
--- a/os/hal/ports/AVR/st_lld.c
+++ b/os/hal/ports/AVR/st_lld.c
@@ -62,20 +62,45 @@
 
 /* Find the most suitable prescaler setting for the desired OSAL_ST_FREQUENCY */
 #if ((F_CPU / OSAL_ST_FREQUENCY) <= AVR_TIMER_COUNTER_MAX)
+
   #define AVR_TIMER_PRESCALER 1
-  #define AVR_TIMER_PRESCALER_BITS (0<<CS02)|(0<<CS01)|(1<<CS00); /* CLK      */
+  #define AVR_TIMER_PRESCALER_BITS ((0<<CS02)|(0<<CS01)|(1<<CS00)) /* CLK      */
+
 #elif ((F_CPU / OSAL_ST_FREQUENCY / 8) <= AVR_TIMER_COUNTER_MAX)
+
   #define AVR_TIMER_PRESCALER 8
-  #define AVR_TIMER_PRESCALER_BITS (0<<CS02)|(1<<CS01)|(0<<CS00); /* CLK/8    */
+  #define AVR_TIMER_PRESCALER_BITS ((0<<CS02)|(1<<CS01)|(0<<CS00)) /* CLK/8    */
+
 #elif ((F_CPU / OSAL_ST_FREQUENCY / 64) <= AVR_TIMER_COUNTER_MAX)
+
   #define AVR_TIMER_PRESCALER 64
-  #define AVR_TIMER_PRESCALER_BITS (0<<CS02)|(1<<CS01)|(1<<CS00); /* CLK/64   */
+
+  #ifdef __AVR_ATmega128__
+    #define AVR_TIMER_PRESCALER_BITS ((1<<CS02)|(0<<CS01)|(0<<CS00)) /* CLK/64   */
+  #else
+    #define AVR_TIMER_PRESCALER_BITS ((0<<CS02)|(1<<CS01)|(1<<CS00)) /* CLK/64   */
+  #endif
+
 #elif ((F_CPU / OSAL_ST_FREQUENCY / 256) <= AVR_TIMER_COUNTER_MAX)
+
   #define AVR_TIMER_PRESCALER 256
-  #define AVR_TIMER_PRESCALER_BITS (1<<CS02)|(0<<CS01)|(0<<CS00); /* CLK/256  */
+
+  #ifdef __AVR_ATmega128__
+    #define AVR_TIMER_PRESCALER_BITS ((1<<CS02)|(1<<CS01)|(0<<CS00)) /* CLK/256  */
+  #else
+    #define AVR_TIMER_PRESCALER_BITS ((1<<CS02)|(0<<CS01)|(0<<CS00)) /* CLK/256  */
+  #endif
+
 #elif ((F_CPU / OSAL_ST_FREQUENCY / 1024) <= AVR_TIMER_COUNTER_MAX)
+
   #define AVR_TIMER_PRESCALER 1024
-  #define AVR_TIMER_PRESCALER_BITS (1<<CS02)|(0<<CS01)|(1<<CS00); /* CLK/1024 */
+
+  #ifdef __AVR_ATmega128__
+    #define AVR_TIMER_PRESCALER_BITS (1<<CS02)|(1<<CS01)|(1<<CS00); /* CLK/1024 */
+  #else
+    #define AVR_TIMER_PRESCALER_BITS (1<<CS02)|(0<<CS01)|(1<<CS00); /* CLK/1024 */
+  #endif
+
 #else
   #error "Frequency too low for timer, please set OSAL_ST_FREQUENCY to a higher value"
 #endif
@@ -165,16 +190,16 @@ void st_lld_init(void) {
    */
 
   /* CTC mode, no clock source */
-  TCCR1A  = 0;
-  TCCR1B  = _BV(WGM12);
+  TCCR1A     = 0;
+  TCCR1B     = _BV(WGM12);
 
   /* start disabled */
-  TCCR1C  = 0;
-  OCR1A   = 0;
-  TCNT1   = 0;
-  TIFR1   = _BV(OCF1A);                                  /* Reset pending.   */
-  TIMSK1  = 0;
-  TCCR1B  = PRESCALER;
+  TCCR1C     = 0;
+  OCR1A      = 0;
+  TCNT1      = 0;
+  TIFR_REG   = _BV(OCF1A);                                  /* Reset pending.   */
+  TIMSK_REG  = 0;
+  TCCR1B     = PRESCALER;
 
 #endif /* OSAL_ST_MODE == OSAL_ST_MODE_FREERUNNING */
 
diff --git a/os/hal/ports/AVR/st_lld.h b/os/hal/ports/AVR/st_lld.h
index 871d5ca4a..a68144fa2 100644
--- a/os/hal/ports/AVR/st_lld.h
+++ b/os/hal/ports/AVR/st_lld.h
@@ -68,6 +68,14 @@ extern "C" {
 }
 #endif
 
+#ifdef __AVR_ATmega128__
+#define TIFR_REG TIFR
+#define TIMSK_REG TIMSK
+#else
+#define TIFR_REG TIFR1
+#define TIMSK_REG TIMSK1
+#endif
+
 /*===========================================================================*/
 /* Driver inline functions.                                                  */
 /*===========================================================================*/
@@ -98,10 +106,10 @@ static inline void st_lld_start_alarm(systime_t time) {
   OCR1A = (uint16_t) time;
 
   /* Reset pending. */
-  TIFR1 = _BV(OCF1A);
+  TIFR_REG = _BV(OCF1A);
 
   /* enable interrupt */
-  TIMSK1 = _BV(OCIE1A);
+  TIMSK_REG = _BV(OCIE1A);
 }
 
 /**
@@ -111,7 +119,7 @@ static inline void st_lld_start_alarm(systime_t time) {
  */
 static inline void st_lld_stop_alarm(void) {
 
-  TIMSK1 = 0;
+  TIMSK_REG = 0;
 }
 
 /**
@@ -149,7 +157,7 @@ static inline systime_t st_lld_get_alarm(void) {
  */
 static inline bool st_lld_is_alarm_active(void) {
 
-  return (bool) ((TIMSK1 & _BV(OCIE1A)) != 0);
+  return (bool) ((TIMSK_REG & _BV(OCIE1A)) != 0);
 }
 
 #endif /* _ST_LLD_H_ */