diff --git a/os/hal/lib/complex/serial_nor/devices/micron_n25q/hal_flash_device.c b/os/hal/lib/complex/serial_nor/devices/micron_n25q/hal_flash_device.c index 1b5d81f83..f314c54cc 100644 --- a/os/hal/lib/complex/serial_nor/devices/micron_n25q/hal_flash_device.c +++ b/os/hal/lib/complex/serial_nor/devices/micron_n25q/hal_flash_device.c @@ -270,8 +270,8 @@ static void n25q_reset_memory(SNORDriver *devp) { #else /* 2x N25Q_CMD_RESET_ENABLE command.*/ static const wspi_command_t cmd_reset_enable_2 = { - .cfg = WSPI_CFG_CMD(N25Q_CMD_RESET_ENABLE) | - WSPI_CFG_CMD_MODE_TWO_LINES, + .cmd = N25Q_CMD_RESET_ENABLE, + .cfg = WSPI_CFG_CMD_MODE_TWO_LINES, .addr = 0, .alt = 0, .dummy = 0 @@ -279,8 +279,8 @@ static void n25q_reset_memory(SNORDriver *devp) { /* 2x N25Q_CMD_RESET_MEMORY command.*/ static const wspi_command_t cmd_reset_memory_2 = { - .cfg = WSPI_CFG_CMD(N25Q_CMD_RESET_MEMORY) | - WSPI_CFG_CMD_MODE_TWO_LINES, + .cmd = N25Q_CMD_RESET_MEMORY, + .cfg = WSPI_CFG_CMD_MODE_TWO_LINES, .addr = 0, .alt = 0, .dummy = 0 diff --git a/os/hal/lib/complex/serial_nor/hal_serial_nor.h b/os/hal/lib/complex/serial_nor/hal_serial_nor.h index cca029775..7e5afaa57 100644 --- a/os/hal/lib/complex/serial_nor/hal_serial_nor.h +++ b/os/hal/lib/complex/serial_nor/hal_serial_nor.h @@ -156,8 +156,10 @@ typedef struct { #ifdef __cplusplus extern "C" { #endif +#if SNOR_SHARED_BUS == TRUE void bus_acquire(BUSDriver *busp, const BUSConfig *config); void bus_release(BUSDriver *busp); +#endif void bus_cmd(BUSDriver *busp, uint32_t cmd); void bus_cmd_send(BUSDriver *busp, uint32_t cmd, size_t n, const uint8_t *p); void bus_cmd_receive(BUSDriver *busp, diff --git a/readme.txt b/readme.txt index 811cae3fa..759ffaded 100644 --- a/readme.txt +++ b/readme.txt @@ -82,6 +82,7 @@ - NEW: Improved boost settings for STM32G4. - NEW: Files mcuconf.h for STM32F746, F767, L432, L452, L476, L496 received the missing setting STM32_WSPI_QUADSPI1_PRESCALER_VALUE. +- FIX: Fixed problem with N25Q driver (bug #1173). - FIX: Fixed missing constant in ADuCM36x hal_lld.c (bug #1166). - FIX: Fixed invalid STM32 TIM21/TIM22 debug freeze setting (bug #1164). - FIX: Fixed I2S-related definitions missing in STM32F3xx registry (bug #1162).