andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make stacks smaller (#1055) 

* remove factually incorrect comment

* shrinky stacky

* shuffle comments
This commit is contained in:
Matthew Kennedy 2019-12-13 13:47:26 -08:00 committed by rusefi
parent aa1b7e2c6b
commit 003c1c17f0
4 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
firmware/config/boards/kinetis/chconf.h
View File

@ -44,12 +44,11 @@
* *
*/ */
#define PORT_IDLE_THREAD_STACK_SIZE 64/*768*//*1024*/ #define PORT_IDLE_THREAD_STACK_SIZE 32
// rusEfi main processing happens on IRQ so PORT_INT_REQUIRED_STACK has to be pretty large. // See global_shared.h notes about stack requirements
// see also a strange comment about PORT_INT_REQUIRED_STACK in global_shared.h
// see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks // see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks
#define PORT_INT_REQUIRED_STACK 512/*768*/ #define PORT_INT_REQUIRED_STACK 128
#define CHPRINTF_USE_FLOAT TRUE #define CHPRINTF_USE_FLOAT TRUE

9
firmware/config/stm32f4ems/chconf.h
View File

@ -41,12 +41,11 @@
* *
*/ */
#define PORT_IDLE_THREAD_STACK_SIZE 1024 #define PORT_IDLE_THREAD_STACK_SIZE 32
// rusEfi main processing happens on IRQ so PORT_INT_REQUIRED_STACK has to be pretty large. // See global_shared.h notes about stack requirements
// see also a strange comment about PORT_INT_REQUIRED_STACK in global_shared.h
// see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks // see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks
#define PORT_INT_REQUIRED_STACK 768 #define PORT_INT_REQUIRED_STACK 128
#define CHPRINTF_USE_FLOAT TRUE #define CHPRINTF_USE_FLOAT TRUE
@ -605,7 +604,7 @@
* tickless mode. * tickless mode.
*/ */
#if !defined(CH_DBG_THREADS_PROFILING) #if !defined(CH_DBG_THREADS_PROFILING)
#define CH_DBG_THREADS_PROFILING FALSE #define CH_DBG_THREADS_PROFILING TRUE
#endif #endif
/** @} */ /** @} */

7
firmware/config/stm32f7ems/chconf.h
View File

@ -41,12 +41,11 @@
* *
*/ */
#define PORT_IDLE_THREAD_STACK_SIZE 1024 #define PORT_IDLE_THREAD_STACK_SIZE 32
// rusEfi main processing happens on IRQ so PORT_INT_REQUIRED_STACK has to be pretty large. // See global_shared.h notes about stack requirements
// see also a strange comment about PORT_INT_REQUIRED_STACK in global_shared.h
// see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks // see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks
#define PORT_INT_REQUIRED_STACK 768 #define PORT_INT_REQUIRED_STACK 128
#define CHPRINTF_USE_FLOAT TRUE #define CHPRINTF_USE_FLOAT TRUE

10
firmware/controllers/global_shared.h
View File

@ -14,10 +14,12 @@
* The following obscurantism is a hack to reduce stack usage, maybe even a questionable performance * The following obscurantism is a hack to reduce stack usage, maybe even a questionable performance
* optimization. * optimization.
* *
* rusEfi main processing happens on IRQ so PORT_INT_REQUIRED_STACK has to be pretty large. Problem * Of note is that interrupts are NOT serviced on the stack of the thread that was running when the
* is that PORT_INT_REQUIRED_STACK is included within each user thread stack, thus this large stack multiplies * interrupt occurred. The only thing that happens on that thread's stack is that its registers are
* and this consumes a lot of valueable RAM. While forcing the compiler to inline helps to some degree, * pushed (by hardware) when an interrupt occurs, just before swapping the stack pointer out for the
* it would be even better not to waste stack on passing the parameter. * main stack (currently 0x400=1024 bytes), where the ISR actually runs.
*
* see also http://www.chibios.org/dokuwiki/doku.php?id=chibios:kb:stacks
* *
* In the firmware we are using 'extern *Engine' - in the firmware Engine is a signleton * In the firmware we are using 'extern *Engine' - in the firmware Engine is a signleton
* *