From 0b852e4a81901738b7e5f46c4e87241504bf4525 Mon Sep 17 00:00:00 2001 From: pchmura4 Date: Sun, 22 Oct 2023 18:21:28 +0200 Subject: [PATCH] Changed the way AC idle RPM bump is handled --- firmware/controllers/actuators/idle_thread.cpp | 2 +- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/firmware/controllers/actuators/idle_thread.cpp b/firmware/controllers/actuators/idle_thread.cpp index 2379ef8355..a81412e465 100644 --- a/firmware/controllers/actuators/idle_thread.cpp +++ b/firmware/controllers/actuators/idle_thread.cpp @@ -32,7 +32,7 @@ int IdleController::getTargetRpm(float clt) { // alternator duty cycle has a similar logic targetRpmAcBump = engine->module().unmock().acButtonState ? engineConfiguration->acIdleRpmBump : 0; - auto target = targetRpmByClt + targetRpmAcBump; + auto target = (targetRpmByClt < targetRpmAcBump) ? targetRpmAcBump : targetRpmByClt; idleTarget = target; return target; } diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 47fdc44f71..2e6751185c 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1060,7 +1060,7 @@ bit tempBooleanForVerySpecialLogic float turboSpeedSensorMultiplier;;"mult", 1, 0, 0, 7000, 3 Gpio[CAM_INPUTS_COUNT iterate] camInputsDebug; - int16_t acIdleRpmBump;Extra idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 1000, 0 + int16_t acIdleRpmBump;Idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 2000, 0 int16_t warningPeriod;set warningPeriod X;"seconds", 1, 0, 0, 60, 0 diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 0d1ede9c86..327d5acaad 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -3504,7 +3504,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ field = "Max CLT", maxAcClt field = "Max TPS", maxAcTps field = "A/C Idle adder", acIdleExtraOffset - field = "A/C RPM adder", acIdleRpmBump + field = "A/C Idle RPM", acIdleRpmBump dialog = acSettings, "", border panel = acSettingsWest, West