From 124493efebf492026c3b76d2b1743d6a563c9c87 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Mon, 23 Jan 2023 08:16:30 -0500 Subject: [PATCH] Default binary should have more relaxed pinout: serial fix #4998 we can now simplify code a bit --- firmware/config/engines/vw_b6.cpp | 1 - firmware/console/binary/tunerstudio_io_serial_ports.cpp | 5 +---- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 1 - 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/firmware/config/engines/vw_b6.cpp b/firmware/config/engines/vw_b6.cpp index 572f6e583b..1b18a0e8aa 100644 --- a/firmware/config/engines/vw_b6.cpp +++ b/firmware/config/engines/vw_b6.cpp @@ -276,7 +276,6 @@ void setMreVwPassatB6() { coolantControl->pin = MRE_LS_2; // "7 - Lowside 1" //engineConfiguration->hpfpValvePin = MRE_LS_1; - engineConfiguration->disablePrimaryUart = true; engineConfiguration->hpfpValvePin = Gpio::B10; // AUX J13 diff --git a/firmware/console/binary/tunerstudio_io_serial_ports.cpp b/firmware/console/binary/tunerstudio_io_serial_ports.cpp index a269d17178..0edc7e5ab6 100644 --- a/firmware/console/binary/tunerstudio_io_serial_ports.cpp +++ b/firmware/console/binary/tunerstudio_io_serial_ports.cpp @@ -86,10 +86,7 @@ class SerialTsChannel; void startSerialChannels() { #if defined(TS_PRIMARY_UxART_PORT) - // todo: invert setting one day? - if (!engineConfiguration->disablePrimaryUart) { - primaryChannelThread.start(); - } + primaryChannelThread.start(); #endif #if defined(TS_SECONDARY_UxART_PORT) diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 94b097e36a..7515669bac 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1010,7 +1010,7 @@ end_struct uint16_t tps2SecondaryMin;;"ADC", 1, 0, 0, 1000, 0 uint16_t tps2SecondaryMax;;"ADC", 1, 0, 0, 1000, 0 - bit disablePrimaryUart + bit unusedBitDisablePrimaryUart bit fuelClosedLoopCorrectionEnabled;Enables lambda sensor closed loop feedback for fuelling. bit isVerboseIAC;Print details into rusEFI console\nenable verbose_idle bit boardUseTachPullUp,"12v","5v" diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 70e656fcb3..adcbbbd274 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -4291,7 +4291,6 @@ dialog = tcuControls, "Transmission Settings" field = "Tune read/write password", tuneHidingKey, { yesUnderstandLocking == 1 } field = verboseQuad, verboseQuad field = useEeprom, useEeprom - field = "disablePrimaryUart", disablePrimaryUart field = "#System hacks" field = "vvtBooleanForVerySpecialCases", vvtBooleanForVerySpecialCases field = tempBooleanForVerySpecialLogic, tempBooleanForVerySpecialLogic