Starter is engaged on start-up in pull-up configuration #1969

2020-11-26 16:58:02 -05:00 · 2020-11-26 16:58:02 -05:00 · 21acca2f47
parent b75ab76f1f
commit 21acca2f47
1 changed files with 3 additions and 0 deletions
--- a/firmware/config/engines/rover_v8.cpp
+++ b/firmware/config/engines/rover_v8.cpp
@ -55,7 +55,10 @@ void setRoverv8(DECLARE_CONFIG_PARAMETER_SIGNATURE) {

 	// set ignition_mode 2
 	engineConfiguration->ignitionMode = IM_WASTED_SPARK;
+	/*
+	 * this configuration is used on HW CI - in HW CI 'inverted' would rightfully fail unless there is pull-up
 	engineConfiguration->ignitionPinMode = OM_INVERTED;
+*/

    // set_ignition_channels
    engineConfiguration->ignitionPins[0] = GPIOE_8; // Frankenstein: low side - out #x (?)