diff --git a/firmware/config/engines/bmw_e34.cpp b/firmware/config/engines/bmw_e34.cpp index 00b3aeaac3..ef12236e51 100644 --- a/firmware/config/engines/bmw_e34.cpp +++ b/firmware/config/engines/bmw_e34.cpp @@ -97,7 +97,11 @@ void setBmwE34(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->malfunctionIndicatorPin = GPIO_UNASSIGNED; +/* + * this configuration is used on HW CI - in HW CI 'inverted' would rightfully fail unless there is pull-up engineConfiguration->injectionPinMode = OM_INVERTED; + */ + engineConfiguration->injectionPins[0] = GPIOB_8; // #1 engineConfiguration->injectionPins[1] = GPIOE_2; // #2 engineConfiguration->injectionPins[2] = GPIOE_3; // #3 @@ -105,7 +109,10 @@ void setBmwE34(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->injectionPins[4] = GPIOE_5; // #5 engineConfiguration->injectionPins[5] = GPIOE_6; // #6 + /* + * this configuration is used on HW CI - in HW CI 'inverted' would rightfully fail unless there is pull-up engineConfiguration->ignitionPinMode = OM_INVERTED; +*/ engineConfiguration->ignitionPins[0] = GPIOB_5; // #1 engineConfiguration->ignitionPins[2] = GPIOB_6; // #3 diff --git a/firmware/controllers/system/efi_gpio.cpp b/firmware/controllers/system/efi_gpio.cpp index 52a7f6c5fe..ddfd173f73 100644 --- a/firmware/controllers/system/efi_gpio.cpp +++ b/firmware/controllers/system/efi_gpio.cpp @@ -551,7 +551,7 @@ void OutputPin::initPin(const char *msg, brain_pin_e brainPin, const pin_output_ actualValue = !actualValue; } if (actualValue) { - firmwareError(OBD_PCM_Processor_Fault, "startup pin state %s %d %d", hwPortname(brainPin), actualValue, *outputMode); + firmwareError(OBD_PCM_Processor_Fault, "%s: startup pin state %s value=%d mode=%s", msg, hwPortname(brainPin), actualValue, getPin_output_mode_e(*outputMode)); } } }