andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

only:unused-variable is a nice error message to have #5683

This commit is contained in:
Andrey 2023-11-02 15:27:56 -04:00
parent 114ae8e0bf
commit 3af8d69ad9
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
firmware/controllers/system/efi_gpio.cpp
View File

@ -560,6 +560,7 @@ void OutputPin::resetToggleStats() {
extern bool qcDirectPinControlMode; extern bool qcDirectPinControlMode;
void OutputPin::setValue(const char *msg, int logicValue, bool isForce) { void OutputPin::setValue(const char *msg, int logicValue, bool isForce) {
UNUSED(msg);
if ((qcDirectPinControlMode || getOutputOnTheBenchTest() == this) && !isForce) { if ((qcDirectPinControlMode || getOutputOnTheBenchTest() == this) && !isForce) {
return; return;
} }
@ -730,17 +731,17 @@ void OutputPin::initPin(const char *msg, brain_pin_e p_brainPin, pin_output_mode
#if EFI_GPIO_HARDWARE && EFI_PROD_CODE #if EFI_GPIO_HARDWARE && EFI_PROD_CODE
efiSetPadMode(msg, brainPin, l_mode); efiSetPadMode(msg, brainPin, l_mode);
if (brain_pin_is_onchip(brainPin)) { if (brain_pin_is_onchip(brainPin)) {
int actualValue = palReadPad(port, pin);
// we had enough drama with pin configuration in board.h and else that we shall self-check
// todo: handle OM_OPENDRAIN and OM_OPENDRAIN_INVERTED as well // todo: handle OM_OPENDRAIN and OM_OPENDRAIN_INVERTED as well
if (outputMode == OM_DEFAULT || outputMode == OM_INVERTED) { if (outputMode == OM_DEFAULT || outputMode == OM_INVERTED) {
const int logicalValue = #ifndef DISABLE_PIN_STATE_VALIDATION
int actualValue = palReadPad(port, pin);
// we had enough drama with pin configuration in board.h and else that we shall self-check
const int logicalValue =
(outputMode == OM_INVERTED) (outputMode == OM_INVERTED)
? !actualValue ? !actualValue
: actualValue; : actualValue;
#ifndef DISABLE_PIN_STATE_VALIDATION
// if the pin was set to logical 1, then set an error and disable the pin so that things don't catch fire // if the pin was set to logical 1, then set an error and disable the pin so that things don't catch fire
if (logicalValue) { if (logicalValue) {
criticalError("HARDWARE VALIDATION FAILED %s: unexpected startup pin state %s actual value=%d logical value=%d mode=%s", msg, hwPortname(brainPin), actualValue, logicalValue, getPin_output_mode_e(outputMode)); criticalError("HARDWARE VALIDATION FAILED %s: unexpected startup pin state %s actual value=%d logical value=%d mode=%s", msg, hwPortname(brainPin), actualValue, logicalValue, getPin_output_mode_e(outputMode));