From 3b2ba21946fd5139f0a1fc7d45cf39324eea6e1d Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Tue, 17 Sep 2024 22:16:05 -0400 Subject: [PATCH] jam detection tooltips #6925 only:uaefi --- firmware/integration/rusefi_config.txt | 6 +++--- unit_tests/tests/actuators/test_etb.cpp | 2 +- unit_tests/tests/test_limp.cpp | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index ad0b5a9621..8c20a0b53c 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -459,7 +459,7 @@ uint16_t engineSnifferRpmThreshold;Engine sniffer would be disabled above this r switch_input_pin_e torqueReductionTriggerPin;Pin that activates the reduction/cut for shifting. Sometimes shared with the Launch Control pin int8_t launchFuelAdderPercent;;"%", 1, 0, 0, 100, 0 - uint8_t autoscale etbJamTimeout;Time required to detect a stuck throttle.;"sec", 0.02, 0, 0, 5, 2 + uint8_t autoscale etbJamTimeout;Time after which the throttle is considered jammed.;"sec", 0.02, 0, 0, 5, 2 output_pin_e tachOutputPin; pin_output_mode_e tachOutputPinMode; @@ -1513,7 +1513,7 @@ tChargeMode_e tChargeMode; uint16_t autoscale fordInjectorSmallPulseBreakPoint;;"mg", 0.001, 0, 0, 65, 3 - uint8_t etbJamDetectThreshold;;"%", 1, 0, 0, 50, 0 + uint8_t etbJamDetectThreshold;Threshold in ETB error (target vs. actual) above which the jam timer is started. If the timer reaches the time specified in the jam detection timeout period, the throttle is considered jammed, and engine operation limited.;"%", 1, 0, 0, 50, 0 ! Someday there will be a 6th option for BMW S55 that uses a separate shaft just for HPFP #define hpfp_cam_e_enum "NONE", "Intake 1", "Exhaust 1", "Intake 2", "Exhaust 2" @@ -1573,7 +1573,7 @@ pwm_freq_t tcu_32_solenoid_freq output_pin_e acrPin2; -float etbMinimumPosition;;"%", 1, 0, 0.01, 100, 2 +uint8_t autoscale etbMinimumPosition;Set a minimum allowed target position to avoid slamming/driving against the hard mechanical stop in the throttle.;"%", 0.1, 0, 0, 10, 1 uint16_t tuneHidingKey;;"", 1, 0, 0, 20000, 0 diff --git a/unit_tests/tests/actuators/test_etb.cpp b/unit_tests/tests/actuators/test_etb.cpp index 1c9a943ff2..e74044a9fa 100644 --- a/unit_tests/tests/actuators/test_etb.cpp +++ b/unit_tests/tests/actuators/test_etb.cpp @@ -776,7 +776,7 @@ TEST(etb, jamDetection) { Sensor::setMockValue(SensorType::AcceleratorPedal, 0.0f, true); // Limit of 5%, 1 second - engineConfiguration->jamDetectThreshold = 5; + engineConfiguration->etbJamDetectThreshold = 5; engineConfiguration->etbJamTimeout = 1; EtbController etb; diff --git a/unit_tests/tests/test_limp.cpp b/unit_tests/tests/test_limp.cpp index b98f302b78..ddde83963f 100644 --- a/unit_tests/tests/test_limp.cpp +++ b/unit_tests/tests/test_limp.cpp @@ -4,6 +4,7 @@ #include "limp_manager.h" TEST(limp, testFatalError) { + EngineTestHelper eth(engine_type_e::TEST_ENGINE); LimpManager dut; // Everything should work by default