andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't start boost pwm unnecessarily (#3767) 

* don't start boost pwm unnecessarily

* test
This commit is contained in:
Matthew Kennedy 2022-01-11 17:47:50 -08:00 committed by GitHub
parent eb023376dc
commit 3e56bacef9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
firmware/controllers/actuators/boost_control.cpp
View File

@ -133,6 +133,11 @@ expected<percent_t> BoostController::getClosedLoop(float target, float manifoldP
void BoostController::setOutput(expected<float> output) { void BoostController::setOutput(expected<float> output) {
percent_t percent = output.value_or(engineConfiguration->boostControlSafeDutyCycle); percent_t percent = output.value_or(engineConfiguration->boostControlSafeDutyCycle);
if (!engineConfiguration->isBoostControlEnabled) {
// If not enabled, force 0% output
percent = 0;
}
#if EFI_TUNER_STUDIO #if EFI_TUNER_STUDIO
engine->outputChannels.boostControllerOutput = percent; engine->outputChannels.boostControllerOutput = percent;
#endif /* EFI_TUNER_STUDIO */ #endif /* EFI_TUNER_STUDIO */
@ -190,7 +195,7 @@ void setDefaultBoostParameters() {
void startBoostPin() { void startBoostPin() {
#if !EFI_UNIT_TEST #if !EFI_UNIT_TEST
// Only init if a pin is set, no need to start PWM without a pin // Only init if a pin is set, no need to start PWM without a pin
if (!isBrainPinValid(engineConfiguration->boostControlPin)) { if (!engineConfiguration->isBoostControlEnabled || !isBrainPinValid(engineConfiguration->boostControlPin)) {
return; return;
} }
@ -200,7 +205,7 @@ void startBoostPin() {
&engine->executor, &engine->executor,
&enginePins.boostPin, &enginePins.boostPin,
engineConfiguration->boostPwmFrequency, engineConfiguration->boostPwmFrequency,
0.5f 0
); );
#endif /* EFI_UNIT_TEST */ #endif /* EFI_UNIT_TEST */
} }

2
unit_tests/tests/test_boost.cpp
View File

@ -109,6 +109,8 @@ TEST(BoostControl, ClosedLoop) {
TEST(BoostControl, SetOutput) { TEST(BoostControl, SetOutput) {
EngineTestHelper eth(TEST_ENGINE); EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isBoostControlEnabled = true;
StrictMock<MockPwm> pwm; StrictMock<MockPwm> pwm;
StrictMock<MockEtb> etb; StrictMock<MockEtb> etb;
BoostController bc; BoostController bc;