From 4574aacccec5e1475c6e9c35b0ff22bb7bec9026 Mon Sep 17 00:00:00 2001 From: rusefi Date: Tue, 8 Oct 2019 03:14:21 -0400 Subject: [PATCH] I got carried away, but DEAD CODE?! --- .../controllers/algo/accel_enrichment.cpp | 1 - firmware/controllers/algo/algo.cpp | 1 - firmware/controllers/algo/event_registry.h | 3 ++- firmware/controllers/engine_controller.cpp | 1 - firmware/controllers/engine_controller.h | 1 - firmware/controllers/injector_central.cpp | 1 - firmware/controllers/injector_central.h | 1 - firmware/controllers/map_averaging.cpp | 1 - .../scheduling/signal_executor.cpp | 25 ------------------- .../controllers/scheduling/signal_executor.h | 19 -------------- .../scheduling/signal_executor_sleep.cpp | 1 - .../trigger/main_trigger_callback.cpp | 1 - .../trigger/trigger_emulator_algo.cpp | 1 + firmware/development/wave_analyzer.cpp | 1 - unit_tests/global_execution_queue.cpp | 1 - unit_tests/tests/test_signal_executor.cpp | 1 - 16 files changed, 3 insertions(+), 57 deletions(-) delete mode 100644 firmware/controllers/scheduling/signal_executor.cpp delete mode 100644 firmware/controllers/scheduling/signal_executor.h diff --git a/firmware/controllers/algo/accel_enrichment.cpp b/firmware/controllers/algo/accel_enrichment.cpp index dceae51330..d7adfb4259 100644 --- a/firmware/controllers/algo/accel_enrichment.cpp +++ b/firmware/controllers/algo/accel_enrichment.cpp @@ -27,7 +27,6 @@ #include "accel_enrichment.h" #include "allsensors.h" #include "engine_math.h" -#include "signal_executor.h" #if EFI_TUNER_STUDIO #include "tunerstudio_configuration.h" extern TunerStudioOutputChannels tsOutputChannels; diff --git a/firmware/controllers/algo/algo.cpp b/firmware/controllers/algo/algo.cpp index 5499562d74..8acc176909 100644 --- a/firmware/controllers/algo/algo.cpp +++ b/firmware/controllers/algo/algo.cpp @@ -25,7 +25,6 @@ #include "advance_map.h" #include "fuel_math.h" #include "settings.h" -#include "signal_executor.h" #include "speed_density.h" #include "fsio_impl.h" diff --git a/firmware/controllers/algo/event_registry.h b/firmware/controllers/algo/event_registry.h index 0653cec7d3..bf8640f167 100644 --- a/firmware/controllers/algo/event_registry.h +++ b/firmware/controllers/algo/event_registry.h @@ -8,7 +8,8 @@ #pragma once #include "global.h" -#include "signal_executor.h" +#include "efi_gpio.h" +#include "scheduler.h" #include "fl_stack.h" #include "trigger_structure.h" diff --git a/firmware/controllers/engine_controller.cpp b/firmware/controllers/engine_controller.cpp index c797354288..f0ef263f22 100644 --- a/firmware/controllers/engine_controller.cpp +++ b/firmware/controllers/engine_controller.cpp @@ -33,7 +33,6 @@ #include "fsio_impl.h" #include "idle_thread.h" #include "rpm_calculator.h" -#include "signal_executor.h" #include "main_trigger_callback.h" #include "io_pins.h" #include "flash_main.h" diff --git a/firmware/controllers/engine_controller.h b/firmware/controllers/engine_controller.h index 8f21f1ca31..2b0e402e25 100644 --- a/firmware/controllers/engine_controller.h +++ b/firmware/controllers/engine_controller.h @@ -9,7 +9,6 @@ #pragma once #include "global.h" -#include "signal_executor.h" #include "engine_configuration.h" #include "engine.h" diff --git a/firmware/controllers/injector_central.cpp b/firmware/controllers/injector_central.cpp index 335ebb29e9..5d5545238c 100644 --- a/firmware/controllers/injector_central.cpp +++ b/firmware/controllers/injector_central.cpp @@ -28,7 +28,6 @@ #include "injector_central.h" #include "io_pins.h" -#include "signal_executor.h" #include "main_trigger_callback.h" #include "engine_configuration.h" #include "pin_repository.h" diff --git a/firmware/controllers/injector_central.h b/firmware/controllers/injector_central.h index 516272dcd6..ce05e66694 100644 --- a/firmware/controllers/injector_central.h +++ b/firmware/controllers/injector_central.h @@ -11,7 +11,6 @@ #ifndef INJECTOR_CENTRAL_H_ #define INJECTOR_CENTRAL_H_ -#include "signal_executor.h" #include "engine.h" void fanBench(void); diff --git a/firmware/controllers/map_averaging.cpp b/firmware/controllers/map_averaging.cpp index 89e19a1646..cc781f6e30 100644 --- a/firmware/controllers/map_averaging.cpp +++ b/firmware/controllers/map_averaging.cpp @@ -34,7 +34,6 @@ #include "allsensors.h" #include "engine_configuration.h" #include "interpolation.h" -#include "signal_executor.h" #include "engine.h" #include "engine_math.h" diff --git a/firmware/controllers/scheduling/signal_executor.cpp b/firmware/controllers/scheduling/signal_executor.cpp deleted file mode 100644 index e072869806..0000000000 --- a/firmware/controllers/scheduling/signal_executor.cpp +++ /dev/null @@ -1,25 +0,0 @@ -/** - * @file signal_executor.cpp - * - * todo: we should split this file into two: - * one for pure scheduling and another one for signal output which would - * use the scheduling - * - * @date Dec 4, 2013 - * @author Andrey Belomutskiy, (c) 2012-2018 - * - * This file is part of rusEfi - see http://rusefi.com - * - * rusEfi is free software; you can redistribute it and/or modify it under the terms of - * the GNU General Public License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * rusEfi is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without - * even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along with this program. - * If not, see . - */ - - diff --git a/firmware/controllers/scheduling/signal_executor.h b/firmware/controllers/scheduling/signal_executor.h deleted file mode 100644 index 7679c42a3a..0000000000 --- a/firmware/controllers/scheduling/signal_executor.h +++ /dev/null @@ -1,19 +0,0 @@ -/** - * @file signal_executor.h - * @brief Asynchronous output signal header - * - * @date Feb 10, 2013 - * @author Andrey Belomutskiy, (c) 2012-2017 - */ - -#pragma once - -#include "global.h" -#include "scheduler.h" -#include "efi_gpio.h" - -#if EFI_SIGNAL_EXECUTOR_SLEEP -#include "signal_executor_sleep.h" -#endif /* EFI_SIGNAL_EXECUTOR_SLEEP */ - - diff --git a/firmware/controllers/scheduling/signal_executor_sleep.cpp b/firmware/controllers/scheduling/signal_executor_sleep.cpp index 7b1dce415e..be5af50a9c 100644 --- a/firmware/controllers/scheduling/signal_executor_sleep.cpp +++ b/firmware/controllers/scheduling/signal_executor_sleep.cpp @@ -24,7 +24,6 @@ #include "global.h" #include "scheduler.h" -#include "signal_executor.h" #include "main_trigger_callback.h" #if EFI_SIMULATOR diff --git a/firmware/controllers/trigger/main_trigger_callback.cpp b/firmware/controllers/trigger/main_trigger_callback.cpp index dfc1e36ea7..6ee0c4daa7 100644 --- a/firmware/controllers/trigger/main_trigger_callback.cpp +++ b/firmware/controllers/trigger/main_trigger_callback.cpp @@ -35,7 +35,6 @@ #include "trigger_central.h" #include "spark_logic.h" #include "rpm_calculator.h" -#include "signal_executor.h" #include "engine_configuration.h" #include "interpolation.h" #include "advance_map.h" diff --git a/firmware/controllers/trigger/trigger_emulator_algo.cpp b/firmware/controllers/trigger/trigger_emulator_algo.cpp index 2766ac4b28..c1d99c845a 100644 --- a/firmware/controllers/trigger/trigger_emulator_algo.cpp +++ b/firmware/controllers/trigger/trigger_emulator_algo.cpp @@ -14,6 +14,7 @@ * @author Andrey Belomutskiy, (c) 2012-2018 */ #include "global.h" +#include "efi_gpio.h" #include "efi_wave.h" int getPreviousIndex(const int currentIndex, const int size) { diff --git a/firmware/development/wave_analyzer.cpp b/firmware/development/wave_analyzer.cpp index e375234541..9227fe2b64 100644 --- a/firmware/development/wave_analyzer.cpp +++ b/firmware/development/wave_analyzer.cpp @@ -18,7 +18,6 @@ #include "data_buffer.h" #include "pin_repository.h" #include "allsensors.h" -#include "signal_executor.h" #include "engine_configuration.h" #include "trigger_central.h" #include "os_util.h" diff --git a/unit_tests/global_execution_queue.cpp b/unit_tests/global_execution_queue.cpp index ea4cb084cc..4048bb00aa 100644 --- a/unit_tests/global_execution_queue.cpp +++ b/unit_tests/global_execution_queue.cpp @@ -5,7 +5,6 @@ * @author Andrey Belomutskiy, (c) 2012-2018 */ -#include "signal_executor.h" #include "global_execution_queue.h" bool_t debugSignalExecutor = false; diff --git a/unit_tests/tests/test_signal_executor.cpp b/unit_tests/tests/test_signal_executor.cpp index 21f30b2351..f40e49b051 100644 --- a/unit_tests/tests/test_signal_executor.cpp +++ b/unit_tests/tests/test_signal_executor.cpp @@ -8,7 +8,6 @@ #include "global.h" #include -#include "signal_executor.h" #include "test_signal_executor.h" #include "io_pins.h" #include "event_queue.h"